mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-10-27 23:27:09 +09:00
Ivan Starkov
8e5d0a2186
## Description ref #548 Add shared links with builder/viewer permissions. `editor` permission is now disabled as we don't know a simple way to allow editing images and text only cc @TrySound would need your opinion on this. createTrpcRemixProxy now wraps input in `JSON.stringify` and unwraps before the TRPC call. Otherwise, all params are FormData string entries and may cause errors. createTrpcRemixProxy useQuery/useMutation now returns Remix useFetcher state parameter. **`patch` auth call added, we must do any Auth mutate operations in a single call, otherwise if some call failed we are in troubles.** Example on token relation update. Remove viewer relation. Add editor relation. <- If the call failed here user just loses all permissions. In case of patch both operations are completed in a single transaction - (delete+insert) ## Steps for reproduction Having migrations works locally only with `isFeatureEnabled("share2")` flag. Click the share button then add/rename/update/copy share links. The previous Share button is removed. **TODO In Next PR:** Different UI for builder and viewer links i.e. [this](https://github.com/webstudio-is/webstudio-designer/issues/548#issuecomment-1406947059). ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - [ ] hi @TrySound , I need you to do - detailed review (read every line) ## Before requesting a review - [x] made a self-review - [x] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [x] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-designer/blob/main/apps/designer/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `designer/env-check.js` if mandatory
265 B
265 B
Webstudio Project
Project related functionalities. This was temporarily placed here to reuse between other packages, but we need to split this into separate packages and probably remove this package entirely or keep it only for "project" specific functionality.