mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-10-28 07:37:36 +09:00
## Description how it works https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2317121292 - attack example https://p-845e975a-4e84-4186-b312-431f3a6f99ea-dot-main.development.webstudio.is/ - attack fixed https://p-845e975a-4e84-4186-b312-431f3a6f99ea-dot-csrf.staging.webstudio.is/ corresponding PR #4060 (Add postMessage token to secure against Canvas script execution) Additionally csp on iframe (see comments) destination checks - to prevent including loaders/pages into iframes <img width="1015" alt="image" src="https://github.com/user-attachments/assets/2d8c6840-e195-424e-942f-8b8d05203e18"> ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
58 lines
1.5 KiB
TypeScript
58 lines
1.5 KiB
TypeScript
import { createCookie } from "@remix-run/node";
|
|
import { compareUrls } from "~/shared/router-utils";
|
|
|
|
// https://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/Cookies#name
|
|
export const returnToCookie = createCookie("__Host-_returnTo", {
|
|
path: "/",
|
|
httpOnly: true,
|
|
sameSite: "lax",
|
|
// Set the expiration to 5 minutes as it is unnecessary to retain the cookie for a longer duration.
|
|
maxAge: 60 * 5,
|
|
secure: true,
|
|
});
|
|
|
|
export const returnToPath = async (
|
|
request: Request
|
|
): Promise<string | null> => {
|
|
const returnTo = await returnToCookie.parse(request.headers.get("Cookie"));
|
|
|
|
if (returnTo === null || typeof returnTo === "string") {
|
|
return returnTo;
|
|
}
|
|
return null;
|
|
};
|
|
|
|
export const isRedirectResponse = (response: Response) => {
|
|
return (
|
|
response.status >= 300 &&
|
|
response.status < 400 &&
|
|
response.headers.get("Location") !== null
|
|
);
|
|
};
|
|
|
|
export const clearReturnToCookie = async (
|
|
request: Request,
|
|
response: Response
|
|
) => {
|
|
const returnTo = await returnToPath(request);
|
|
|
|
if (returnTo === null) {
|
|
return response;
|
|
}
|
|
|
|
if (false === isRedirectResponse(response)) {
|
|
return response;
|
|
}
|
|
|
|
if (false === compareUrls(returnTo, response.headers.get("Location")!)) {
|
|
return response;
|
|
}
|
|
|
|
const resultResponse = new Response(response.body, response);
|
|
resultResponse.headers.append(
|
|
"Set-Cookie",
|
|
await returnToCookie.serialize(null, { maxAge: -1 })
|
|
);
|
|
return resultResponse;
|
|
};
|