webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 05:26:24 +09:00

Files

T

Oleg Isonen b1c0ac6a14 fix: when cutting in text editing mode, it should not cut the instance (#3881 )

Fixes https://github.com/webstudio-is/webstudio/issues/3880

## Description

Also cutting or inserting instances without copy permissions should be
not allowed.

Problem was in detecting cut content editable:
```
  if (selection?.type === "Range" || selection?.type === "Caret") {
```

## Steps for reproduction

1. create multiline text inside paragraph
2. select some lines, cmd/ctrl+x to cut
3. expected: should only cut the text
4. currently: cuts the instnace

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file

2024-08-05 15:19:53 +02:00