mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 22:14:29 +09:00
Ivan Starkov
4138a56982
## Description ### NEXT PR, TODO, Image Manager accept issue https://github.com/webstudio-is/webstudio/blob/ab997532c239fcd0329ec017e748729c437200c4/apps/builder/app/builder/shared/image-manager/image-manager.tsx#L102 ### Current PR - [x] Image component can show mp4 files as an image https://video-upload-mn4t9.wstd.work/ https://p-f218c6e2-e776-467d-a97f-00fbaaf98f5a-dot-video.staging.webstudio.is/ - [x] Animations with uploaded images For animation to work "Animation Group" should have at least 1 animation with ranges set. https://video-animation-lw2i6.wstd.work/ https://p-610b2f8d-c4fe-4138-aa40-1339a958fc2e-dot-video.staging.webstudio.is/ Not tested but should work with following video files (only mp4 was tested) ``` [".mp4", "video/mp4"], [".webm", "video/webm"], [".mpg", "video/mpeg"], [".mpeg", "video/mpeg"], [".mov", "video/quicktime"], ``` ### How it works Add Animation Group Add 1 animation and set ranges Add Video Animation Set Source property at Video Animation/Video to uploaded video ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file