webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 14:03:33 +09:00

Files

T

Ivan Starkov 7f114f4b69 fix: Allow reset optional items (#4759 )

## Description

Allow resetting optional items in the following cases:
1. The item has a value and undefined defaultValue
2. The item has a value, defaultValue is not undefined and is not equal
to value

- [x] - Fix placeholder is not shown

## Todo Next PR 
Remove empty prop check
https://github.com/webstudio-is/webstudio/blob/42af9210934f0c5c8fb1f1943bd66cd086c85032/packages/sdk-components-react/src/head-meta.tsx#L27
Switch on undefined.

## Steps for reproduction

Case 1. 

- [x] - HeadSlot/HeadLink

Select value, reset value

<img width="252" alt="image"
src="https://github.com/user-attachments/assets/1944c6f0-32c5-4dc5-aa3e-f2b8cf1593a7"
/>

Case 2. 

- [x] - Youtube Component
Unselect 
<img width="244" alt="image"
src="https://github.com/user-attachments/assets/a55e9105-1c4b-4439-8f2b-f1af05a15964"
/>

Reset to default.


## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file

2025-01-19 12:42:43 +03:00

app

fix: Allow reset optional items (#4759 )

2025-01-19 12:42:43 +03:00

docs

feat: Rename Site to Project because we are not just building a site builder (#2718 )

2023-12-30 10:40:09 +01:00

public

fix: robots.txt to allow login and nothing else (#4110 )

2024-09-13 10:33:51 -07:00

.env

refactor: hardcode asset and upload path in builder (#4579 )