webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-07 12:33:36 +09:00

Files

T

Oleg Isonen ca33d421a2 Instance name bugs (#1200 )

## Description

1. Don't set the label when id didn't change
2. workaround stale defaultValue in TextField

## Steps for reproduction

1. change instance name
2. select a different instance (see previous instance name is still in
the text field)
3. select an different instance or different tab - instance name from
previous instance went into a the currently selected instance

4. expect xyz

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2023-03-08 22:10:22 +01:00