webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 14:03:33 +09:00

Files

T

Ivan Starkov a82825bfe8 Make Image value not an Array (#1148 )

## Description

ref #877

As a part of above I'm changing 
```
export const ImageValue = z.object({
  type: z.literal("image"),
  value: z.array(z.object({ type: z.literal("asset"), value: ImageAsset })),
});
```
to 
```
export const ImageValue = z.object({
  type: z.literal("image"),
  value: z.object({ type: z.literal("asset"), value: ImageAsset }),
});
```
In favour of using in next PRs 

```
const ArrayValue = z.object({
  type: z.literal("array"),
  value: z.array(z.union([UnitValue, KeywordValue, UnparsedValue, ImageValue])),
});
```

For now, to not break compatibility with existing code I'm not
converting to an array immediately.
Just style types simplification.

'array' type is not now supported on db level, parse/serialize will not
work. Will be done in following PRs





## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2023-03-01 12:54:44 +04:00

.storybook

Unify Storybook config (#585 )

2022-12-17 21:50:59 +01:00

src

Make Image value not an Array (#1148 )

2023-03-01 12:54:44 +04:00

jest.config.js

Migrate packages to native ESM (#493 )

2022-11-23 10:12:58 +03:00

LICENSE

initial css engine

2022-11-10 19:55:38 +01:00

package.json

Bump versions (#1127 )

2023-02-25 10:46:22 +01:00

README.md

rename designer to builder

2023-02-14 11:15:24 +01:00

tsconfig.json

Resolve tsconfig package (#643 )

2022-12-16 13:09:33 +03:00

README.md

CSS Engine

This package is designed to render effectively CSS in the format produced by Webstudio Builder. It is using CSS variables for all dynamic parts and can render at runtime as for usage on Live Canvas in the Builder as well as for extracting a fully static style sheet for production.