webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-10 06:24:35 +09:00

Files

T

Oleg Isonen 0eaa57caae Scroll navigator into view when selecting instances on canvas/navigator (#1162 )

Closes https://github.com/webstudio-is/webstudio-builder/issues/1157


## Description

When selecting in navigator - scroll into view on canvas and vice-versa

## Steps for reproduction

1. insert lots of elements to make navigator and canvas scroll
2. click in navigator last and first - see canvas scrolling
3. same as 2 but for canvas

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview
- [ ] hi @rpominov , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2023-03-01 22:00:52 +01:00