0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-10 06:24:35 +09:00

Files

T

Oleg Isonen e07cb22d29 fix: Remove default favicon from exports (#6310 )

## Summary

Remove the default Webstudio `/favicon.ico` from dynamic export
templates and their generated fixtures. Exported sites now rely only on
the configured favicon referenced by the generated `<link rel="icon">`;
projects without one naturally return 404 for `/favicon.ico`.

## Implementation

- Delete the root favicon from the legacy/default and React Router base
templates.
- Remove the derived favicon from Docker, Cloudflare, Netlify, Vercel,
and feature fixtures.
- Add regression coverage for legacy dynamic, React Router dynamic, and
SSG exports.
- Preserve and verify configured favicon link generation in every mode.

## Todo

- [x] Remove the default favicon from export template sources.
- [x] Regenerate the affected fixture outputs.
- [x] Add fail/pass regression coverage.
- [x] Run CLI tests, typecheck, lint, and formatting checks.
- [x] Review documentation impact; no documentation changes are needed.

## Verification

- `pnpm --filter webstudio exec vitest run src/prebuild.test.ts` — 69
tests passed.
- `pnpm --filter webstudio typecheck` — passed.
- `pnpm exec oxlint --deny-warnings packages/cli/src/prebuild.test.ts` —
passed.
- `pnpm exec oxfmt --check packages/cli/src/prebuild.test.ts` — passed.
- Regression test failed for the two affected templates before the fix
and passes for all three export modes after it.
- All six affected fixture builds completed with the repository React
preload. The full `pnpm fixtures` command could not pass its initial
link phase in this fresh worktree because the local CLI loaded JSX
without a React global.

Closes #5218

2026-09-02 11:45:06 +02:00