webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-07 04:23:40 +09:00

Files

T

Oleg Isonen 918da3fb86 fix: Use empty alt attribute by default (#3001 )

https://discord.com/channels/955905230107738152/1217108594735190066

## Description

Images should either have an alt text or be decorative. By adding an
empty alt by default, they are becoming decorative by default which
seems logical, because if you can't explain what's in the picture to
assistive tools, then they should be ignoring that picture

https://www.w3.org/WAI/tutorials/images/decorative/

## Steps for reproduction

1. by default see alt is empty (<img alt> is the same as. <img alt="">)
2. when set by the user its applied

## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2024-03-12 16:36:09 +01:00

image-dev.stories.tsx

feat: Rename Site to Project because we are not just building a site builder (#2718 )

2023-12-30 10:40:09 +01:00

image-loaders.ts

feat: support social image url (#2845 )

2024-01-30 23:39:40 +07:00

image-optimize.test.ts

fix: Use empty alt attribute by default (#3001 )

2024-03-12 16:36:09 +01:00

image-optimize.ts

fix: Use empty alt attribute by default (#3001 )