mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-06 20:13:35 +09:00
Ivan Starkov
d8994140ba
## Description ## First Part Here is only new local resource `/$resources/sitemap.xml` support It can't be implemented as route for now as we have 2 issues: 1. Cloudflare does not allow server fetches from same domain 2. Remix does not have fetch like sveltekit allowing to bypass real http roundtrip when fetching local resources The idea is to write/use it like any route in case of anything of above will be solved. Most PR Size is generated new fixture page. Move SiteData into the resource. Here is example of rendering this resource using html. Project to play: https://sitemap.staging.webstudio.is/builder/cab934af-8615-411a-99c1-5822a98eac74 Published site: https://sitemap-saas-t6j12.wstd.work/ <img width="785" alt="image" src="https://github.com/webstudio-is/webstudio/assets/5077042/b62af518-37bb-4daa-9f57-9145b4c77364"> ## Next steps: - Add `origin` to the system, or even better add `system.hostUrl` with origin, hostname etc - Add xml element and hardcoded sitemap.xml page ## Steps for reproduction 1. click button 4. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory