mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-07 12:33:36 +09:00
Ivan Starkov
81b60abbb9
## Description When the mouse leaves Tooltip.Content and moves over an iframe, the Radix Tooltip stays open. This happens because Radix's internal grace area relies on the pointermove event, which isn't triggered over iframes. The current workaround is to set pointer-events: none on the canvas when the tooltip is open. Here are: - [x] Tooltip component sets `--canvas-pointer-events` on the documentElement if any tooltip is open - [x] Iframe uses `--canvas-pointer-events` - [x] `isCanvasPointerEventsEnabledStore` in order to use above css variable - [x] Color picker hack fully removed. Now just intercepts `open` state change, as it's dialog and canvas is not interactive when it's open already so it's safe to disable pointer-events too. ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory