admin/Cactiplugin_monitor
1
0 Fork 0
mirror of https://github.com/Cacti/plugin_monitor.git synced 2026-10-23 03:26:42 +09:00
Code Issues Packages Projects Releases Wiki Activity
809 Commits 2 Branches 8 Tags
develop
Commit Graph
56 Commits
Author SHA1 Message Date
Thomas VincentandTheWitness 11fa109548 refactor: safe PHP 7.4 modernization (#212) 
* refactor: add strict typing and clean up standalone infra

* refactor: safe PHP 7.4 modernization (arrays, null coalescing)

* fix: restore corrupted function calls from refactor tool

Revert bulk array()->[] rewrite damage affecting:
- is_array, in_array, xml2array
- call_user_func_array, filter_var_array
- Function declarations with _array suffix

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: restore corrupted syntax from refactor tool

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: remove duplicate declare(strict_types) statements

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix(security): escape request reuse in monitor views

* fix:Run php-cs-fixit to resolve workflows

* fix: Remove strict types for now

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
 2026-07-09 09:20:25 -04:00
Sean ManciniCopilotTheWitness
 		501622a676 Refactor codebase for PSR12 compliance and modernization (#202) 
* PSR12 - First run

Rename functions to match PSR12 requirements

* PSR12 run 1

- Change tabs to spaces
- add consts

* reduce cognetive complexity scores based on PSR12 and sonar scans

* Split poller_monitor  with helper file

* update docblocks

* code reorginization

Breaking up  some of the large files

* modernize js

Replaced legacy var with const/let.
Switched loose checks to strict (===, !==, strict typeof checks).
Added default param: applyFilter(action = '').
Used template literals for URL/query string assembly.
Converted many callbacks to arrow functions and shorthand methods.
Removed one duplicate object key in saveFilter payload (trim was defined twice with same value).
Kept existing flow, DOM selectors, action names, and endpoints unchanged.

* Update monitor.js

Applied the Sonar-requested cleanups in monitor.js:

* remove unused variables

* remove unused variables

* Update copilot-instructions.md

* PSR12 formatting

* Update db_functions.php

* refactor functions

Refactor rending function and Ajax call functions
Lowe cognetive complexity
prepare for easier testing

* Add missing docblocks

* Apply typing

* remove checks for min php version

* correct installation errors after PSR12

* try iinstall fix one more time

* .

* Update monitor_controller.php

* Update monitor_controller.php

* Update monitor_render.php

* fix typing errors

* apply php cs-fixer updates

* missed 2 commits

* Update js/monitor.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update js/monitor.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update copilot-instructions.md

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-03-07 11:55:27 -05:00
Sean ManciniCopilotTheWitness
 		d9d25655da CI workflow and CS fixer updates (#198) 
* add CI workflow and AI instructions

* Apply csfixer updates

* Update .github/agents/mysql-mariadb.agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/agents/mysql-mariadb.agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update .github/agents/triage_agent.md.agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-02-14 20:04:33 -05:00
TheWitness 89a2a485ad Update copyrights to 2026 (#199) 2026-02-14 15:56:15 -05:00
TheWitness c9ea6ecd34 QA: Update Copyrights to 2025 2025-06-16 09:20:41 -04:00
Petr Macek 7dd0e3fc32 extend email subject (#187) 
* extend email subject

* update
 2025-05-12 09:12:03 -04:00
MSSandTheWitness e3aab2860c Add a feature to send the reboot email as one email to all recipients (#180) 
* Add a feature (send one email to all recipients in case of device reboot)

Add a feature (send one email to all recipients in case of device reboot)

* Add a feature (send one email to all recipients in case of device reboot)

Add a feature (send one email to all recipients in case of device reboot)

* Update poller_monitor.php

* Update setup.php

---------

Co-authored-by: TheWitness <thewitness@cacti.net>
 2024-06-17 15:09:40 -04:00
mohabuhtig 3242615ed9 Update poller_monitor.php (#179) 
$versionn should read $version
 2024-06-10 12:33:52 -04:00
TheWitness cae4012523 QA: Updating Copyrights to 2024 2024-03-16 04:57:13 +05:30
Petr Macek 17d4b7d58d fix 171 - php error incorrect variable type (#172) 2024-02-01 07:22:43 -05:00
TheWitness 81b669f813 Fixing #122 - Only monitor for hosts with Monitor flagged 2023-04-11 22:02:38 -04:00
TheWitness 49bdc531b2 QA: Monitor throwing errors in Cacti develop branch 2023-04-11 20:19:57 -04:00
TheWitness 6268c05b91 QA: Cacti 1.3.x compatibility 2023-04-08 16:42:32 -04:00
TheWitness da9ae0122f Fixing #157 - Email Processing 
Monitor plugin error message in cacti log
 2023-02-23 11:17:02 -05:00
netniV f0b6bf5e54 Update copyright for 2023 2023-01-04 22:15:22 +00:00
TheWitness aa124f1cda QA: Be consistent on precision 2022-07-06 17:00:51 -04:00
TheWitness ce822e5b9b Fixing Issue #340 - Spelling 
Fix "Notification" Spelling Error
 2021-02-23 07:42:08 -05:00
TheWitness 9fd4264f21 Correct SQL Errors with Monitor polling 2020-12-12 16:26:18 -05:00
TheWitness 6176b53620 Correct copyright, and don't send email if there is not one 2020-09-13 14:31:06 -04:00
netniV a84634d1d6 SQL Errors when removing hosts that no longer exist (#124) 
Closes #124
 2020-08-15 08:57:12 +00:00
TheWitness 6bb241c228 Minor update for email address 2020-03-28 11:51:38 -04:00
netniV 0b7787045b Notification history is not being updated 
Closes #125
 2020-02-14 10:21:48 +00:00
cigamit 7eea9578d8 issue: Add more checks for removed Device conditions 2020-02-08 13:09:10 -06:00
netniV 0834c29d56 When sending emails, monitor reports config variable not found 
Closes #123
 2019-11-14 21:35:38 +00:00
netniV 97cf730cfd Make compatible with 1.3.x 2019-09-28 12:14:13 +00:00
cigamit 1e959d7a93 Resolving Issue #109 
Reboot history being removed incorrectly for removed devices
 2019-06-30 10:58:44 -05:00
Jimmy Conner b350e3781f Correct column name in SQL Query 2019-06-06 18:03:26 -05:00
cigamit 8dbc777ad6 Resolving Issue #93 
* Device reboot notification should avoid new devices.
* Also log monitor stats in the settings table
 2019-03-05 06:16:59 -06:00
cigamit 9f764a5b24 Resolving Issue #80 
Text based emails.
 2019-02-20 20:46:46 -06:00
cigamit b2793f0758 Resolving Issues #80 
* Don';t include CSS in text email.
* Make two calls more consistent.
 2019-02-19 08:00:57 -06:00
cigamit e3ae496ddc Resolving Issue #80 
Allow for the support of text based email
 2019-02-18 22:10:45 -06:00
cigamit 8336774254 Resolving Issues #81, #84 
Two fixes, some i18n and format changes, and an easter egg
 2019-02-17 12:18:33 -06:00
netniV 38cc4ed3af Also remove the reboot history 2019-02-15 17:31:03 +00:00
netniV 40adcdf7a4 Resolving issue #83 2019-02-15 13:40:42 +00:00
cigamit a13f9891d5 Revert "Removing reference to reports API" 
This reverts commit c5e8713834.
 2018-08-30 06:29:29 -05:00
Jimmy Conner c5e8713834 Removing reference to reports API 2018-08-30 06:58:38 -05:00
netniV 6ee4382675 Issue #66: Correct missing variable warnings when sending emails 2018-05-11 19:08:01 +00:00
netniV 1c0f813e8c Correct 'form' to 'from' for #48 2018-03-31 10:06:42 +01:00
netniV 2000448bbd Fix minor issue with #48 2018-03-30 20:36:04 +01:00
netniV db15ad1347 Issue #48: Reboot notifications did not properly use Monitor sender settings 2018-03-30 20:33:16 +01:00
netniV af95d8b3b1 Fix Monitor Notify List and provide Thold override 
Fixes issue where monitor_list was not being used as a notificationlist.
Adds option to allow only monitor_list to be used rather than thresholds alerts lists
 2018-03-16 09:58:28 +00:00
netniV f2634d5d87 Allow setting of From Name and Email address 2018-03-01 22:31:40 +00:00
Thomas Paine 373a9d6074 Update poller_monitor.php 2017-11-29 13:54:09 -06:00
cigamit c01c1d59da Resolving Issue #36 
Fixing last of the translation issues
Also update cacti.pot for translators
 2017-09-13 18:58:56 -05:00
cigamit fb25757d3a Resolving Issue #23 
Notify admins on a syste m reboot detection
 2017-08-14 20:08:49 -05:00
cigamit 96f443d7e7 Use cacti builtin function for version 2017-05-15 00:30:08 -05:00
cigamit cfdd9300b0 Help and Version Audit 2017-02-09 19:53:29 -06:00
cigamit 038084b045 Correcting spelling and grammar issues 2017-01-12 19:36:32 -06:00
cigamit af473560ee Correcting spelling and grammar issues 2017-01-12 19:04:33 -06:00
cigamit 17ea5c3850 Resolving Issue #9 2017-01-07 08:29:46 -06:00