* ci: pin fixtures and install locked shared test dependencies
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
* docs(changelog): list CI hardening as a dev entry
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
* ci: check out the Cacti branch head instead of a pinned commit
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
---------
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
getMonitorSound() used __DIR__ . '/sounds/' after the controller moved to includes/, so the sound file was never found and the audio element was never printed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Monitor: flex grouping cards to full width, order Tree cards by device count
* Monitor: drop inaccurate Site/Template ordering comparison from changelog
* CI: install the declared thold dependency so Monitor can install under Cacti's new install-failure reporting
* Monitor: remove the filter-status/criticality footer and prompt from the board
* Monitor: give the busiest grouping cards (span 3-4) a full row so their tiles span the page
* Monitor: changelog for full-width busy cards and footer removal
* Monitor: drop Site grouping header, tighten tile uptime spacing, add List column tips
* Monitor: add clickable List-view thold/servcheck/ping/criticality pills with filter toggles
* Monitor: unit tests for new filter branches and thold/servcheck count helpers
* Monitor: selectable status pill, fallback/empty pills, hide absent plugin columns, tile sizing, dialog UX
* Monitor: center and keep clickable the tile hostname, remove 'Names only' view option (backend retained)
* Monitor: multi-select Events filter + Events column (additive), Status becomes scope-only Show
* Monitor: apply the Events multi-select on dropdown close (and on change for native selects)
* Add All criticality, Device Template multi-select, servcheck scope
- Add an "All" option to the Criticality filter. Its value (-1) matches the
default and the pill "clear to default" action, which previously set the
select to a non-existent option and submitted crit=null, tripping
validate_store_request_vars.
- Convert the Device Template filter to a checkbox multi-select (like Events)
and actually apply it: renderWhereJoin now adds
h.host_template_id IN (...) for the template grouping (0 = Non-Templated).
Previously the template selection was never applied, so all hosts returned.
- Persist the template selection as a user setting and serialize the
multi-value for request/save payloads.
- Add a "Devices without Service Checks" scope to the Show filter, shown only
when the servcheck plugin is installed and permitted.
- Tests + regenerated .pot.
* Update template escaping assertions for the multiselect markup
* Cover empty-template branch in renderWhereJoin
* Left-align Actions glyph and harden Device Detail Panels dialog layout
- Left-align the List-view Actions column header and fa-layer-group glyph.
- Stack the detail panels as plain blocks and force the jQuery UI dialog
content box to always fill the dialog width, so the panels can no longer
collapse into a narrow right-hand strip.
* Size the detail dialog to its content instead of forcing overflow
The #monitorPanelDialog overflow override (higher specificity than the
theme's .ui-dialog .ui-dialog-content) turned the content into a fixed-height
scroll box that fought the theme's overflow:visible and squashed the panels.
Use height:auto (capped by maxHeight) and stop overriding overflow so the
dialog sizes to its content and the theme governs scrolling.
* Anchor the detail dialog 300px from the top instead of centering
* Make the detail panels dialog non-modal
* Move Notes out of the List view into the detail dialog
The Notes column consumed a lot of horizontal space in List view. Drop it
from the table and surface the notes in the Host Information panel of the
Device Detail Panels dialog instead (shown only when the device has notes).
* Add device-edit action icon and Devices filter button (realm-gated)
List view: add a pen-square action icon linking to host.php?action=edit for
users with the host.php (device edit) realm, beside the detail-panels icon.
Filter bar: add a Devices button (right of Acknowledge) that opens the Cacti
Devices page, shown only to users with the same realm. Also move the detail
dialog anchor from top+300 to top+150.
* Anchor the detail dialog at top+80
* List view: replace Hostname column with a Graphs action glyph
Remove the Hostname column and add an orange fas fa-chart-line Graphs glyph
(.monitorGraph, matching HMIB's colour) to the Actions column, linking to the
device's graphs where the hostname hyperlink used to point.
* List columns + filter layout refinements
- List columns reordered to Description, Location, Site, ID; add a Location
column; Averages, Length in Status, Last Fail are now the last three
columns, all right-aligned.
- rfilter Search now also matches the device location.
- Filter: move the Events multiselect to the second row (right of Search) and
the Rows dropdown to the second row (left of Refresh); rename that dropdown
from Devices to Rows.
- Add a renderWhereJoin test for the description/location rfilter search.
* Monitor: realm-gate service-check scope/column, persist events+template, legacy status reset, failed_svc independent, defer list counts, pill keyboard a11y, PHPDoc/changelog fixes
* Monitor: flow large grouping cards across page, add Tree grouping cards, fix down-group header contrast
- Large grouping cards now span multiple grid columns (data-span) so a device template with many devices flows across the page instead of forming one tall, narrow column that scrolls off screen; grid switched to auto-fill + dense flow for predictable spanning.
- Tree grouping now renders as card panels (one per tree, plus a Non-Tree card) consistent with the Site and Device Template groupings, instead of the legacy section layout.
- Grouping card title colours are now !important so Cacti core device-status classes can't override them and leave unreadable text on a coloured header (e.g. a down device template).
* Monitor: address review - cap card spans responsively, size tree trim length from rendered hosts, persist tree card order
- CSS: establish the grouping grid as a query container and cap each card's span to the tracks actually available (container queries) so wide cards never force an implicit track / horizontal overflow on narrow layouts.
- renderTree cards: derive the default-view trim length from the hosts actually rendered (tree + Non-Tree), matching the Site/Template paths, instead of a tree-only measure that could trim against unrelated devices or collapse to 0.
- saveCardOrder: allow the tree grouping and preserve string group ids (tree_<id>/nontree) via a safe character allowlist instead of casting to int, so tree card drags persist.
- Share the Non-Tree label through a helper so the string multiset is unchanged.
* Monitor: harden saveCardOrder id typing and card render formatting
- Cast preg_replace result to string for strict typing.
- Avoid mixing list destructuring with aligned assignments in the tree card builder.
Weblate