Changed the keyname to EventsSortingState

.gitignore

@@ -9,7 +9,6 @@
 */*/obj/
 */obj/
 .scss-lint-config.yml_
-ActiveSync/ActiveSync.SOGo
 Documentation/*.docbook
 Documentation/*.pdf
 SoObjects/SOGo/SOGo.framework/
@@ -21,10 +20,12 @@ UI/WebServerResources/bower_components/
 UI/WebServerResources/css/
 UI/WebServerResources/css/styles.css
 UI/WebServerResources/css/styles.css.map
-UI/WebServerResources/js/*.js
-UI/WebServerResources/js/*.js.map
-UI/WebServerResources/js/vendor/*.js
-UI/WebServerResources/js/vendor/*.js.map
+UI/WebServerResources/js/Common.js*
+UI/WebServerResources/js/Contacts.js*
+UI/WebServerResources/js/Mailer.js*
+UI/WebServerResources/js/Preferences.js*
+UI/WebServerResources/js/Scheduler.js*
+UI/WebServerResources/js/vendor/
 UI/WebServerResources/node_modules/
 UI/WebServerResources/scss/.sass-cache/
 config.make

.tx/config

@@ -15,23 +15,18 @@ trans.es_ES = UI/MailerUI/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/MailerUI/Basque.lproj/Localizable.strings
 trans.fi = UI/MailerUI/Finnish.lproj/Localizable.strings
 trans.fr = UI/MailerUI/French.lproj/Localizable.strings
-trans.hr_HR = UI/MailerUI/Croatian.lproj/Localizable.strings
 trans.hu = UI/MailerUI/Hungarian.lproj/Localizable.strings
 trans.is = UI/MailerUI/Icelandic.lproj/Localizable.strings
 trans.it = UI/MailerUI/Italian.lproj/Localizable.strings
-trans.lt = UI/MailerUI/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/MailerUI/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/MailerUI/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/MailerUI/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/MailerUI/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/MailerUI/Polish.lproj/Localizable.strings
-trans.pt = UI/MailerUI/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/MailerUI/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/MailerUI/Russian.lproj/Localizable.strings
 trans.sk = UI/MailerUI/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/MailerUI/Slovenian.lproj/Localizable.strings
 trans.sv = UI/MailerUI/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/MailerUI/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/MailerUI/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/MailerUI/ChineseTaiwan.lproj/Localizable.strings
 
@@ -49,23 +44,18 @@ trans.es_ES = UI/PreferencesUI/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/PreferencesUI/Basque.lproj/Localizable.strings
 trans.fi = UI/PreferencesUI/Finnish.lproj/Localizable.strings
 trans.fr = UI/PreferencesUI/French.lproj/Localizable.strings
-trans.hr_HR = UI/PreferencesUI/Croatian.lproj/Localizable.strings
 trans.hu = UI/PreferencesUI/Hungarian.lproj/Localizable.strings
 trans.is = UI/PreferencesUI/Icelandic.lproj/Localizable.strings
 trans.it = UI/PreferencesUI/Italian.lproj/Localizable.strings
-trans.lt = UI/PreferencesUI/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/PreferencesUI/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/PreferencesUI/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/PreferencesUI/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/PreferencesUI/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/PreferencesUI/Polish.lproj/Localizable.strings
-trans.pt = UI/PreferencesUI/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/PreferencesUI/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/PreferencesUI/Russian.lproj/Localizable.strings
 trans.sk = UI/PreferencesUI/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/PreferencesUI/Slovenian.lproj/Localizable.strings
 trans.sv = UI/PreferencesUI/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/PreferencesUI/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/PreferencesUI/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/PreferencesUI/ChineseTaiwan.lproj/Localizable.strings
 
@@ -83,23 +73,18 @@ trans.es_ES = UI/Scheduler/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/Scheduler/Basque.lproj/Localizable.strings
 trans.fi = UI/Scheduler/Finnish.lproj/Localizable.strings
 trans.fr = UI/Scheduler/French.lproj/Localizable.strings
-trans.hr_HR = UI/Scheduler/Croatian.lproj/Localizable.strings
 trans.hu = UI/Scheduler/Hungarian.lproj/Localizable.strings
 trans.is = UI/Scheduler/Icelandic.lproj/Localizable.strings
 trans.it = UI/Scheduler/Italian.lproj/Localizable.strings
-trans.lt = UI/Scheduler/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/Scheduler/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/Scheduler/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/Scheduler/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/Scheduler/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/Scheduler/Polish.lproj/Localizable.strings
-trans.pt = UI/Scheduler/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/Scheduler/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/Scheduler/Russian.lproj/Localizable.strings
 trans.sk = UI/Scheduler/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/Scheduler/Slovenian.lproj/Localizable.strings
 trans.sv = UI/Scheduler/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/Scheduler/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/Scheduler/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/Scheduler/ChineseTaiwan.lproj/Localizable.strings
 
@@ -117,23 +102,18 @@ trans.es_ES = UI/Contacts/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/Contacts/Basque.lproj/Localizable.strings
 trans.fi = UI/Contacts/Finnish.lproj/Localizable.strings
 trans.fr = UI/Contacts/French.lproj/Localizable.strings
-trans.hr_HR = UI/Contacts/Croatian.lproj/Localizable.strings
 trans.hu = UI/Contacts/Hungarian.lproj/Localizable.strings
 trans.is = UI/Contacts/Icelandic.lproj/Localizable.strings
 trans.it = UI/Contacts/Italian.lproj/Localizable.strings
-trans.lt = UI/Contacts/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/Contacts/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/Contacts/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/Contacts/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/Contacts/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/Contacts/Polish.lproj/Localizable.strings
-trans.pt = UI/Contacts/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/Contacts/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/Contacts/Russian.lproj/Localizable.strings
 trans.sk = UI/Contacts/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/Contacts/Slovenian.lproj/Localizable.strings
 trans.sv = UI/Contacts/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/Contacts/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/Contacts/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/Contacts/ChineseTaiwan.lproj/Localizable.strings
 
@@ -151,23 +131,18 @@ trans.es_ES = UI/MainUI/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/MainUI/Basque.lproj/Localizable.strings
 trans.fi = UI/MainUI/Finnish.lproj/Localizable.strings
 trans.fr = UI/MainUI/French.lproj/Localizable.strings
-trans.hr_HR = UI/MainUI/Croatian.lproj/Localizable.strings
 trans.hu = UI/MainUI/Hungarian.lproj/Localizable.strings
 trans.is = UI/MainUI/Icelandic.lproj/Localizable.strings
 trans.it = UI/MainUI/Italian.lproj/Localizable.strings
-trans.lt = UI/MainUI/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/MainUI/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/MainUI/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/MainUI/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/MainUI/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/MainUI/Polish.lproj/Localizable.strings
-trans.pt = UI/MainUI/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/MainUI/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/MainUI/Russian.lproj/Localizable.strings
 trans.sk = UI/MainUI/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/MainUI/Slovenian.lproj/Localizable.strings
 trans.sv = UI/MainUI/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/MainUI/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/MainUI/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/MainUI/ChineseTaiwan.lproj/Localizable.strings
 
@@ -185,23 +160,18 @@ trans.es_ES = UI/Common/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/Common/Basque.lproj/Localizable.strings
 trans.fi = UI/Common/Finnish.lproj/Localizable.strings
 trans.fr = UI/Common/French.lproj/Localizable.strings
-trans.hr_HR = UI/Common/Croatian.lproj/Localizable.strings
 trans.hu = UI/Common/Hungarian.lproj/Localizable.strings
 trans.is = UI/Common/Icelandic.lproj/Localizable.strings
 trans.it = UI/Common/Italian.lproj/Localizable.strings
-trans.lt = UI/Common/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/Common/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/Common/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/Common/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/Common/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/Common/Polish.lproj/Localizable.strings
-trans.pt = UI/Common/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/Common/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/Common/Russian.lproj/Localizable.strings
 trans.sk = UI/Common/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/Common/Slovenian.lproj/Localizable.strings
 trans.sv = UI/Common/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/Common/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/Common/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/Common/ChineseTaiwan.lproj/Localizable.strings
 
@@ -219,23 +189,18 @@ trans.es_ES = UI/AdministrationUI/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/AdministrationUI/Basque.lproj/Localizable.strings
 trans.fi = UI/AdministrationUI/Finnish.lproj/Localizable.strings
 trans.fr = UI/AdministrationUI/French.lproj/Localizable.strings
-trans.hr_HR = UI/AdministrationUI/Croatian.lproj/Localizable.strings
 trans.hu = UI/AdministrationUI/Hungarian.lproj/Localizable.strings
 trans.is = UI/AdministrationUI/Icelandic.lproj/Localizable.strings
 trans.it = UI/AdministrationUI/Italian.lproj/Localizable.strings
-trans.lt = UI/AdministrationUI/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/AdministrationUI/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/AdministrationUI/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/AdministrationUI/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/AdministrationUI/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/AdministrationUI/Polish.lproj/Localizable.strings
-trans.pt = UI/AdministrationUI/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/AdministrationUI/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/AdministrationUI/Russian.lproj/Localizable.strings
 trans.sk = UI/AdministrationUI/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/AdministrationUI/Slovenian.lproj/Localizable.strings
 trans.sv = UI/AdministrationUI/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/AdministrationUI/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/AdministrationUI/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/AdministrationUI/ChineseTaiwan.lproj/Localizable.strings
 
@@ -253,23 +218,18 @@ trans.es_ES = SoObjects/Appointments/SpanishSpain.lproj/Localizable.strings
 trans.eu = SoObjects/Appointments/Basque.lproj/Localizable.strings
 trans.fi = SoObjects/Appointments/Finnish.lproj/Localizable.strings
 trans.fr = SoObjects/Appointments/French.lproj/Localizable.strings
-trans.hr_HR = SoObjects/Appointments/Croatian.lproj/Localizable.strings
 trans.hu = SoObjects/Appointments/Hungarian.lproj/Localizable.strings
 trans.is = SoObjects/Appointments/Icelandic.lproj/Localizable.strings
 trans.it = SoObjects/Appointments/Italian.lproj/Localizable.strings
-trans.lt = SoObjects/Appointments/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = SoObjects/Appointments/Macedonian.lproj/Localizable.strings
 trans.nb_NO = SoObjects/Appointments/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = SoObjects/Appointments/Dutch.lproj/Localizable.strings
 trans.nn_NO = SoObjects/Appointments/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = SoObjects/Appointments/Polish.lproj/Localizable.strings
-trans.pt = SoObjects/Appointments/Portuguese.lproj/Localizable.strings
 trans.pt_BR = SoObjects/Appointments/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = SoObjects/Appointments/Russian.lproj/Localizable.strings
 trans.sk = SoObjects/Appointments/Slovak.lproj/Localizable.strings
 trans.sl_SI = SoObjects/Appointments/Slovenian.lproj/Localizable.strings
 trans.sv = SoObjects/Appointments/Swedish.lproj/Localizable.strings
-trans.tr_TR = SoObjects/Appointments/TurkishTurkey.lproj/Localizable.strings
 trans.uk = SoObjects/Appointments/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = SoObjects/Appointments/ChineseTaiwan.lproj/Localizable.strings
 
@@ -287,23 +247,18 @@ trans.es_ES = SoObjects/Contacts/SpanishSpain.lproj/Localizable.strings
 trans.eu = SoObjects/Contacts/Basque.lproj/Localizable.strings
 trans.fi = SoObjects/Contacts/Finnish.lproj/Localizable.strings
 trans.fr = SoObjects/Contacts/French.lproj/Localizable.strings
-trans.hr_HR = SoObjects/Contacts/Croatian.lproj/Localizable.strings
 trans.hu = SoObjects/Contacts/Hungarian.lproj/Localizable.strings
 trans.is = SoObjects/Contacts/Icelandic.lproj/Localizable.strings
 trans.it = SoObjects/Contacts/Italian.lproj/Localizable.strings
-trans.lt = SoObjects/Contacts/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = SoObjects/Contacts/Macedonian.lproj/Localizable.strings
 trans.nb_NO = SoObjects/Contacts/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = SoObjects/Contacts/Dutch.lproj/Localizable.strings
 trans.nn_NO = SoObjects/Contacts/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = SoObjects/Contacts/Polish.lproj/Localizable.strings
-trans.pt = SoObjects/Contacts/Portuguese.lproj/Localizable.strings
 trans.pt_BR = SoObjects/Contacts/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = SoObjects/Contacts/Russian.lproj/Localizable.strings
 trans.sk = SoObjects/Contacts/Slovak.lproj/Localizable.strings
 trans.sl_SI = SoObjects/Contacts/Slovenian.lproj/Localizable.strings
 trans.sv = SoObjects/Contacts/Swedish.lproj/Localizable.strings
-trans.tr_TR = SoObjects/Contacts/TurkishTurkey.lproj/Localizable.strings
 trans.uk = SoObjects/Contacts/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = SoObjects/Contacts/ChineseTaiwan.lproj/Localizable.strings
 
@@ -321,23 +276,18 @@ trans.es_ES = SoObjects/Mailer/SpanishSpain.lproj/Localizable.strings
 trans.eu = SoObjects/Mailer/Basque.lproj/Localizable.strings
 trans.fi = SoObjects/Mailer/Finnish.lproj/Localizable.strings
 trans.fr = SoObjects/Mailer/French.lproj/Localizable.strings
-trans.hr_HR = SoObjects/Mailer/Croatian.lproj/Localizable.strings
 trans.hu = SoObjects/Mailer/Hungarian.lproj/Localizable.strings
 trans.is = SoObjects/Mailer/Icelandic.lproj/Localizable.strings
 trans.it = SoObjects/Mailer/Italian.lproj/Localizable.strings
-trans.lt = SoObjects/Mailer/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = SoObjects/Mailer/Macedonian.lproj/Localizable.strings
 trans.nb_NO = SoObjects/Mailer/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = SoObjects/Mailer/Dutch.lproj/Localizable.strings
 trans.nn_NO = SoObjects/Mailer/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = SoObjects/Mailer/Polish.lproj/Localizable.strings
-trans.pt = SoObjects/Mailer/Portuguese.lproj/Localizable.strings
 trans.pt_BR = SoObjects/Mailer/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = SoObjects/Mailer/Russian.lproj/Localizable.strings
 trans.sk = SoObjects/Mailer/Slovak.lproj/Localizable.strings
 trans.sl_SI = SoObjects/Mailer/Slovenian.lproj/Localizable.strings
 trans.sv = SoObjects/Mailer/Swedish.lproj/Localizable.strings
-trans.tr_TR = SoObjects/Mailer/TurkishTurkey.lproj/Localizable.strings
 trans.uk = SoObjects/Mailer/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = SoObjects/Mailer/ChineseTaiwan.lproj/Localizable.strings
 
@@ -355,22 +305,17 @@ trans.es_ES = UI/MailPartViewers/SpanishSpain.lproj/Localizable.strings
 trans.eu = UI/MailPartViewers/Basque.lproj/Localizable.strings
 trans.fi = UI/MailPartViewers/Finnish.lproj/Localizable.strings
 trans.fr = UI/MailPartViewers/French.lproj/Localizable.strings
-trans.hr_HR = UI/MailPartViewers/Croatian.lproj/Localizable.strings
 trans.hu = UI/MailPartViewers/Hungarian.lproj/Localizable.strings
 trans.is = UI/MailPartViewers/Icelandic.lproj/Localizable.strings
 trans.it = UI/MailPartViewers/Italian.lproj/Localizable.strings
-trans.lt = UI/MailPartViewers/Lithuanian.lproj/Localizable.strings
-trans.mk_MK = UI/MailPartViewers/Macedonian.lproj/Localizable.strings
 trans.nb_NO = UI/MailPartViewers/NorwegianBokmal.lproj/Localizable.strings
 trans.nl = UI/MailPartViewers/Dutch.lproj/Localizable.strings
 trans.nn_NO = UI/MailPartViewers/NorwegianNynorsk.lproj/Localizable.strings
 trans.pl = UI/MailPartViewers/Polish.lproj/Localizable.strings
-trans.pt = UI/MailPartViewers/Portuguese.lproj/Localizable.strings
 trans.pt_BR = UI/MailPartViewers/BrazilianPortuguese.lproj/Localizable.strings
 trans.ru = UI/MailPartViewers/Russian.lproj/Localizable.strings
 trans.sk = UI/MailPartViewers/Slovak.lproj/Localizable.strings
 trans.sl_SI = UI/MailPartViewers/Slovenian.lproj/Localizable.strings
 trans.sv = UI/MailPartViewers/Swedish.lproj/Localizable.strings
-trans.tr_TR = UI/MailPartViewers/TurkishTurkey.lproj/Localizable.strings
 trans.uk = UI/MailPartViewers/Ukrainian.lproj/Localizable.strings
 trans.zh_TW = UI/MailPartViewers/ChineseTaiwan.lproj/Localizable.strings

ActiveSync/GNUmakefile.preamble

@@ -1,4 +1 @@
-ifeq ($(HAS_LIBRARY_ssl),yes)
-ADDITIONAL_CPPFLAGS += -DHAVE_OPENSSL=1
-BUNDLE_LIBS += -lcrypto
-endif
+# compilation settings

ActiveSync/NGDOMElement+ActiveSync.h

@@ -31,6 +31,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #define __NGDOMELEMENTACTIVESYNC_H__
 
 #import <DOM/DOMElement.h>
+#import <DOM/DOMProtocols.h>
 
 @class NSDictionary;
 

ActiveSync/NGDOMElement+ActiveSync.m

@@ -101,7 +101,7 @@ static NSArray *asElementArray = nil;
   int i, count;
   
   if (!asElementArray)
-    asElementArray = [[NSArray alloc] initWithObjects: @"Attendee", @"Category", @"Exception", nil];
+    asElementArray = [[NSArray alloc] initWithObjects: @"Attendee", @"Category", nil];
 
   data = [NSMutableDictionary dictionary];
 

ActiveSync/NGMimeMessage+ActiveSync.m

@@ -30,6 +30,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import "NGMimeMessage+ActiveSync.h"
 
 #import <Foundation/NSArray.h>
+#import <Foundation/NSEnumerator.h>
+#import <Foundation/NSString.h>
 
 #import <NGMail/NGMailAddress.h>
 #import <NGMail/NGMailAddressParser.h>

ActiveSync/NGVCard+ActiveSync.m

@@ -29,12 +29,16 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 #import "NGVCard+ActiveSync.h"
 
+#import <Foundation/NSArray.h>
 #import <Foundation/NSCalendarDate.h>
 #import <Foundation/NSDictionary.h>
+#import <Foundation/NSString.h>
 #import <Foundation/NSTimeZone.h>
 
 #import <NGExtensions/NSString+misc.h>
 
+#import <NGCards/CardElement.h>
+
 #import <Contacts/NGVCard+SOGo.h>
 
 #import <SOGo/NSString+Utilities.h>
@@ -42,49 +46,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "NSDate+ActiveSync.h"
 #include "NSString+ActiveSync.h"
 
-#import <NGObjWeb/WOContext+SoObjects.h>
-
-#import <SOGo/SOGoUser.h>
-#import <SOGo/SOGoUserDefaults.h>
-
 @implementation NGVCard (ActiveSync)
 
-//
-// This function is called for each elements which can be ghosted according to specs. 
-// https://msdn.microsoft.com/en-us/library/gg650908%28v=exchg.80%29.aspx
-//
-- (BOOL) _isGhosted: (NSString *) element
-           inContext: (WOContext *) context
-{
-  NSArray *supportedElements;
-
-  supportedElements = [context objectForKey: @"SupportedElements"];
-
-  // If the client does not include a Supported element in the initial Sync command request for
-  // a folder, then all of the elements that can be ghosted are considered not ghosted.
-  if (!supportedElements)
-    return NO;
-
-  // If the client includes an empty Supported element in the initial Sync command request for 
-  // a folder, then all elements that can be ghosted are considered ghosted.
-  if (![supportedElements count])
-    return YES;
-
-  // If the client includes a Supported element that contains child elements in the initial 
-  // Sync command request for a folder, then each child element of that Supported element is 
-  // considered not ghosted. All elements that can be ghosted that are not included as child 
-  // elements of the Supported element are considered ghosted. 
-  if (!([supportedElements indexOfObject: element] == NSNotFound))
-    return YES;
-
-  return NO;
-}
-
 - (NSString *) activeSyncRepresentationInContext: (WOContext *) context
 {
   NSArray *emails, *addresses, *categories, *elements;
   CardElement *n, *homeAdr, *workAdr;
-  NSMutableString *s, *a;
+  NSMutableString *s;
   NSString *url;
   id o;
 
@@ -95,7 +63,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   
   if ((o = [n flattenedValueAtIndex: 0 forKey: @""]))
     [s appendFormat: @"<LastName xmlns=\"Contacts:\">%@</LastName>", [o activeSyncRepresentationInContext: context]];
-
+  
   if ((o = [n flattenedValueAtIndex: 1 forKey: @""]))
     [s appendFormat: @"<FirstName xmlns=\"Contacts:\">%@</FirstName>", [o activeSyncRepresentationInContext: context]];
   
@@ -178,22 +146,16 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   if ([addresses count])
     {
       homeAdr = [addresses objectAtIndex: 0];
-      a = [NSMutableString string];
       
       if ((o = [homeAdr flattenedValueAtIndex: 2  forKey: @""]))
-        [a appendString: o];
-
-      if ((o = [homeAdr flattenedValueAtIndex: 1  forKey: @""]) && [o length])
-        [a appendFormat: @"\n%@", o];
+        [s appendFormat: @"<HomeStreet xmlns=\"Contacts:\">%@</HomeStreet>", [o activeSyncRepresentationInContext: context]];
       
-      [s appendFormat: @"<HomeStreet xmlns=\"Contacts:\">%@</HomeStreet>", [a activeSyncRepresentationInContext: context]];
-
       if ((o = [homeAdr flattenedValueAtIndex: 3  forKey: @""]))
         [s appendFormat: @"<HomeCity xmlns=\"Contacts:\">%@</HomeCity>", [o activeSyncRepresentationInContext: context]];
       
       if ((o = [homeAdr flattenedValueAtIndex: 4  forKey: @""]))
         [s appendFormat: @"<HomeState xmlns=\"Contacts:\">%@</HomeState>", [o activeSyncRepresentationInContext: context]];
-
+      
       if ((o = [homeAdr flattenedValueAtIndex: 5  forKey: @""]))
         [s appendFormat: @"<HomePostalCode xmlns=\"Contacts:\">%@</HomePostalCode>", [o activeSyncRepresentationInContext: context]];
       
@@ -209,15 +171,9 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   if ([addresses count])
     {
       workAdr = [addresses objectAtIndex: 0];
-      a = [NSMutableString string];
       
       if ((o = [workAdr flattenedValueAtIndex: 2  forKey: @""]))
-        [a appendString: o];
-
-      if ((o = [workAdr flattenedValueAtIndex: 1  forKey: @""]) && [o length])
-        [a appendFormat: @"\n%@", o];
-
-      [s appendFormat: @"<BusinessStreet xmlns=\"Contacts:\">%@</BusinessStreet>", [a activeSyncRepresentationInContext: context]];
+        [s appendFormat: @"<BusinessStreet xmlns=\"Contacts:\">%@</BusinessStreet>", [o activeSyncRepresentationInContext: context]];
       
       if ((o = [workAdr flattenedValueAtIndex: 3  forKey: @""]))
         [s appendFormat: @"<BusinessCity xmlns=\"Contacts:\">%@</BusinessCity>", [o activeSyncRepresentationInContext: context]];
@@ -234,13 +190,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
   // Other, less important fields
   if ((o = [self birthday]))
-    {
-      [s appendFormat: @"<Birthday xmlns=\"Contacts:\">%@</Birthday>",
-         [[o dateByAddingYears: 0 months: 0 days: 0
-                         hours: -12 minutes: 0
-                       seconds: 0]
-              activeSyncRepresentationInContext: context]];
-    }
+    [s appendFormat: @"<Birthday xmlns=\"Contacts:\">%@</Birthday>", [o activeSyncRepresentationInContext: context]];
 
   if ((o = [self note]))
     {
@@ -267,7 +217,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
                     inContext: (WOContext *) context
 {
   CardElement *element;
-  NSMutableArray *addressLines;
   id o;
   
   // Contact's note
@@ -277,8 +226,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   // Categories
   if ((o = [theValues objectForKey: @"Categories"]) && [o length])
     [self setCategories: o];
-  else
-    [[self children] removeObjectsInArray: [self childrenWithTag: @"Categories"]];
 
   // Birthday
   if ((o = [theValues objectForKey: @"Birthday"]))
@@ -286,11 +233,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       o = [o calendarDate];
       [self setBday: [o descriptionWithCalendarFormat: @"%Y-%m-%d" timeZone: nil locale: nil]];
     }
-  else if (![self _isGhosted: @"Birthday" inContext: context])
-    {
-      [self setBday: @""];
-    }
-
 
   //
   // Business address information
@@ -302,48 +244,18 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   // BusinessCountry
   //
   element = [self elementWithTag: @"adr" ofType: @"work"];
-
-  if ((o = [theValues objectForKey: @"BusinessStreet"]) || ![self _isGhosted: @"BusinessStreet" inContext: context])
-    {
-      addressLines = [NSMutableArray arrayWithArray: [o componentsSeparatedByString: @"\n"]];
-
-      [element setSingleValue: @""
-                      atIndex: 1 forKey: @""];
-      [element setSingleValue: [addressLines count] ? [addressLines objectAtIndex: 0] : @""
-                      atIndex: 2 forKey: @""];
-
-      // Extended address line. If there are more than 2 address lines we add them to the extended address line.
-      if ([addressLines count] > 1)
-        {
-          [addressLines removeObjectAtIndex: 0];
-          [element setSingleValue: [addressLines componentsJoinedByString: @" "]
-                          atIndex: 1 forKey: @""];
-        }
-     }
-
-  if ((o = [theValues objectForKey: @"BusinessCity"]) || ![self _isGhosted: @"BusinessCity" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"BusinessCity"]
-                      atIndex: 3 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"BusinessState"]) || ![self _isGhosted: @"BusinessState" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"BusinessState"]
-                      atIndex: 4 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"BusinessPostalCode"]) || ![self _isGhosted: @"BusinessPostalCode" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"BusinessPostalCode"]
-                      atIndex: 5 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"BusinessCountry"]) || ![self _isGhosted: @"BusinessCountry" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"BusinessCountry"]
-                      atIndex: 6 forKey: @""];
-    }
+  [element setSingleValue: @""
+                  atIndex: 1 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"BusinessStreet"]
+                  atIndex: 2 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"BusinessCity"]
+                  atIndex: 3 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"BusinessState"]
+                  atIndex: 4 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"BusinessPostalCode"]
+                  atIndex: 5 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"BusinessCountry"]
+                  atIndex: 6 forKey: @""];
 
   //
   // Home address information
@@ -355,69 +267,35 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   // HomeCountry
   //
   element = [self elementWithTag: @"adr" ofType: @"home"];
-
-  if ((o = [theValues objectForKey: @"HomeStreet"]) || ![self _isGhosted: @"HomeStreet" inContext: context])
-    {
-      addressLines = [NSMutableArray arrayWithArray: [o componentsSeparatedByString: @"\n"]];
-
-      [element setSingleValue: @""
-                      atIndex: 1 forKey: @""];
-      [element setSingleValue: [addressLines count] ? [addressLines objectAtIndex: 0] : @""
-                      atIndex: 2 forKey: @""];
-
-      // Extended address line. If there are more then 2 address lines we add them to the extended address line.
-      if ([addressLines count] > 1)
-        {
-          [addressLines removeObjectAtIndex: 0];
-          [element setSingleValue: [addressLines componentsJoinedByString: @" "]
-                          atIndex: 1 forKey: @""];
-        }
-    }
-
-  if ((o = [theValues objectForKey: @"HomeCity"]) || ![self _isGhosted: @"HomeCity" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"HomeCity"]
-                      atIndex: 3 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"HomeState"]) || ![self _isGhosted: @"HomeState" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"HomeState"]
-                      atIndex: 4 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"HomePostalCode"]) || ![self _isGhosted: @"HomePostalCode" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"HomePostalCode"]
-                      atIndex: 5 forKey: @""];
-    }
-
-  if ((o = [theValues objectForKey: @"HomeCountry"]) || ![self _isGhosted: @"HomeCountry" inContext: context])
-    {
-      [element setSingleValue: [theValues objectForKey: @"HomeCountry"]
-                      atIndex: 6 forKey: @""];
-    }
+  [element setSingleValue: @""
+                  atIndex: 1 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"HomeStreet"]
+                  atIndex: 2 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"HomeCity"]
+                  atIndex: 3 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"HomeState"]
+                  atIndex: 4 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"HomePostalCode"]
+                  atIndex: 5 forKey: @""];
+  [element setSingleValue: [theValues objectForKey: @"HomeCountry"]
+                  atIndex: 6 forKey: @""];
 
   // Company's name
   if ((o = [theValues objectForKey: @"CompanyName"]))
     [self setOrg: o  units: nil];
-  else if (![self _isGhosted: @"CompanyName" inContext: context])
-    [self setOrg: @""  units: nil];
   
   // Department
   if ((o = [theValues objectForKey: @"Department"]))
     [self setOrg: nil  units: [NSArray arrayWithObjects:o,nil]];
-  else if (![self _isGhosted: @"Department" inContext: context])
-    [self setOrg: nil  units: [NSArray arrayWithObjects:@"",nil]];
   
   // Email addresses
-  if ((o = [theValues objectForKey: @"Email1Address"]) || ![self _isGhosted: @"Email1Address" inContext: context])
+  if ((o = [theValues objectForKey: @"Email1Address"]))
     {
       element = [self elementWithTag: @"email" ofType: @"work"];
       [element setSingleValue: [o pureEMailAddress] forKey: @""];
     }
   
-  if ((o = [theValues objectForKey: @"Email2Address"]) || ![self _isGhosted: @"Email2Address" inContext: context])
+  if ((o = [theValues objectForKey: @"Email2Address"]))
     {
       element = [self elementWithTag: @"email" ofType: @"home"];
       [element setSingleValue: [o pureEMailAddress] forKey: @""];
@@ -425,7 +303,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   
   // SOGo currently only supports 2 email addresses ... but AS clients might send 3
   // FIXME: revise this when the GUI revamp is done in SOGo
-  if ((o = [theValues objectForKey: @"Email3Address"]) || ![self _isGhosted: @"Email3Address" inContext: context])
+  if ((o = [theValues objectForKey: @"Email3Address"]))
     {
       element = [self elementWithTag: @"email" ofType: @"three"];
       [element setSingleValue: [o pureEMailAddress] forKey: @""];
@@ -435,62 +313,45 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   // MiddleName
   // Suffix   (II)
   // Title    (Mr.)
-  if ((o = [theValues objectForKey: @"FileAs"]) || ![self _isGhosted: @"FileAs" inContext: context])
-    [self setFn: [theValues objectForKey: @"FileAs"]];
+  [self setFn: [theValues objectForKey: @"FileAs"]];
 
   [self setNWithFamily: [theValues objectForKey: @"LastName"]
                  given: [theValues objectForKey: @"FirstName"]
             additional: nil prefixes: nil suffixes: nil];
   
   // IM information
-  if ((o = [theValues objectForKey: @"IMAddress"]) || ![self _isGhosted: @"IMAddress" inContext: context])
-    [[self uniqueChildWithTag: @"x-aim"]
-      setSingleValue: [theValues objectForKey: @"IMAddress"]
-              forKey: @""];
+  [[self uniqueChildWithTag: @"x-aim"]
+    setSingleValue: [theValues objectForKey: @"IMAddress"]
+            forKey: @""];
 
   //
   // Phone numbrrs
   //
-  if ((o = [theValues objectForKey: @"BusinessPhoneNumber"]) || ![self _isGhosted: @"BusinessPhoneNumber" inContext: context])
-    {
-      element = [self elementWithTag: @"tel" ofType: @"work"];
-      [element setSingleValue: [theValues objectForKey: @"BusinessPhoneNumber"]  forKey: @""];
-    }
+  element = [self elementWithTag: @"tel" ofType: @"work"];
+  [element setSingleValue: [theValues objectForKey: @"BusinessPhoneNumber"]  forKey: @""];
 
-  if ((o = [theValues objectForKey: @"HomePhoneNumber"]) || ![self _isGhosted: @"HomePhoneNumber" inContext: context])
-    {
-      element = [self elementWithTag: @"tel" ofType: @"home"];
-      [element setSingleValue: [theValues objectForKey: @"HomePhoneNumber"]  forKey: @""];
-    }
+  element = [self elementWithTag: @"tel" ofType: @"home"];
+  [element setSingleValue: [theValues objectForKey: @"HomePhoneNumber"]  forKey: @""];
 
-  if ((o = [theValues objectForKey: @"MobilePhoneNumber"]) || ![self _isGhosted: @"MobilePhoneNumber" inContext: context])
-    {
-      element = [self elementWithTag: @"tel" ofType: @"cell"];
-      [element setSingleValue: [theValues objectForKey: @"MobilePhoneNumber"]  forKey: @""];
-    }
+  element = [self elementWithTag: @"tel" ofType: @"cell"];
+  [element setSingleValue: [theValues objectForKey: @"MobilePhoneNumber"]  forKey: @""];
 
-  if ((o = [theValues objectForKey: @"BusinessFaxNumber"]) || ![self _isGhosted: @"BusinessFaxNumber" inContext: context])
-    {
-      element = [self elementWithTag: @"tel" ofType: @"fax"];
-      [element setSingleValue: [theValues objectForKey: @"BusinessFaxNumber"]  forKey: @""];
-    }
+  element = [self elementWithTag: @"tel" ofType: @"fax"];
+  [element setSingleValue: [theValues objectForKey: @"BusinessFaxNumber"]  forKey: @""];
 
-  if ((o = [theValues objectForKey: @"PagerNumber"]) || ![self _isGhosted: @"PagerNumber" inContext: context])
-    {
-      element = [self elementWithTag: @"tel" ofType: @"pager"];
-      [element setSingleValue: [theValues objectForKey: @"PagerNumber"]  forKey: @""];
-    }
+  element = [self elementWithTag: @"tel" ofType: @"pager"];
+  [element setSingleValue: [theValues objectForKey: @"PagerNumber"]  forKey: @""];
   
   // Job's title
-  if ((o = [theValues objectForKey: @"JobTitle"]) || ![self _isGhosted: @"JobTitle" inContext: context])
+  if ((o = [theValues objectForKey: @"JobTitle"]))
     [self setTitle: o];
   
   // WebPage (work)
-  if ((o = [theValues objectForKey: @"WebPage"]) || ![self _isGhosted: @"WebPage" inContext: context])
+  if ((o = [theValues objectForKey: @"WebPage"]))
     [[self elementWithTag: @"url" ofType: @"work"]
           setSingleValue: o  forKey: @""];
   
-  if ((o = [theValues objectForKey: @"NickName"]) || ![self _isGhosted: @"NickName" inContext: context])
+  if ((o = [theValues objectForKey: @"NickName"]))
     [self setNickname: o];
 
   if ((o = [theValues objectForKey: @"Picture"]))

ActiveSync/NSCalendarDate+ActiveSync.m

@@ -30,6 +30,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import "NSCalendarDate+ActiveSync.h"
 
 #import <Foundation/NSString.h>
+#import <Foundation/NSTimeZone.h>
 
 #define ONE_DAY 86400
 

ActiveSync/NSData+ActiveSync.m

@@ -30,6 +30,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import "NSData+ActiveSync.h"
 
 #import <Foundation/NSProcessInfo.h>
+#import <Foundation/NSString.h>
 
 #import <SOGo/SOGoSystemDefaults.h>
 
@@ -37,6 +38,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import <NGExtensions/NSObject+Logs.h>
 
 #include <wbxml/wbxml.h>
+#include <wbxml/wbxml_conv.h>
+#include <wbxml/wbxml_errors.h>
 
 #define WBXMLDEBUG 0
 

ActiveSync/NSString+ActiveSync.h

@@ -31,6 +31,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #define __NSSTRINGACTIVESYNC_H__
 
 #import <Foundation/NSString.h>
+
 #include "SOGoActiveSyncConstants.h"
 
 @class NSCalendarDate;

ActiveSync/NSString+ActiveSync.m

@@ -31,6 +31,9 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <Foundation/NSArray.h>
 #include <Foundation/NSCalendarDate.h>
+#include <Foundation/NSData.h>
+#include <Foundation/NSDate.h>
+#include <Foundation/NSTimeZone.h>
 
 #include <SOGo/NSString+Utilities.h>
 #include <SOGo/NSData+Crypto.h>
@@ -43,6 +46,99 @@ static NSArray *easCommandParameters = nil;
 
 @implementation NSString (ActiveSync)
 
+//
+// This is a copy from NSString+XMLEscaping.m from SOPE.
+// The difference here is that we use wchar_t instead of unichar.
+// This is needed to get the rigth numeric character reference.
+// e.g. SMILING FACE WITH OPEN MOUTH
+//      ok: wchar_t -> &#128515;   wrong:  unichar -> &#55357; &#56835;
+//
+// We avoir naming it like the one in SOPE since if the ActiveSync
+// bundle is loaded, it'll overwrite the one provided by SOPE.
+//
+- (NSString *) _stringByEscapingXMLStringUsingCharacters {
+  register unsigned i, len, j;
+  register wchar_t *buf;
+  const wchar_t *chars;
+  unsigned escapeCount;
+
+  if ([self length] == 0) return @"";
+
+  NSData *data = [self dataUsingEncoding:NSUTF32StringEncoding];
+  chars = [data bytes];
+  len = [data length]/4;
+
+  /* check for characters to escape ... */
+  for (i = 0, escapeCount = 0; i < len; i++) {
+    switch (chars[i]) {
+      case '&': case '"': case '<': case '>': case '\r':
+        escapeCount++;
+        break;
+      default:
+        if (chars[i] > 127)
+          escapeCount++;
+        break;
+    }
+  }
+  if (escapeCount == 0 ) {
+    /* nothing to escape ... */
+    return [[self copy] autorelease];
+  }
+
+  buf = calloc((len + 5) + (escapeCount * 16), sizeof(wchar_t));
+  for (i = 0, j = 0; i < len; i++) {
+    switch (chars[i]) {
+      /* escape special chars */
+      case '\r':
+        buf[j] = '&'; j++; buf[j] = '#'; j++; buf[j] = '1'; j++;
+        buf[j] = '3'; j++; buf[j] = ';'; j++;
+        break;
+      case '&':
+        buf[j] = '&'; j++; buf[j] = 'a'; j++; buf[j] = 'm'; j++;
+        buf[j] = 'p'; j++; buf[j] = ';'; j++;
+        break;
+      case '"':
+        buf[j] = '&'; j++; buf[j] = 'q'; j++; buf[j] = 'u'; j++;
+        buf[j] = 'o'; j++; buf[j] = 't'; j++; buf[j] = ';'; j++;
+        break;
+      case '<':
+        buf[j] = '&'; j++; buf[j] = 'l'; j++; buf[j] = 't'; j++;
+        buf[j] = ';'; j++;
+        break;
+      case '>':
+        buf[j] = '&'; j++; buf[j] = 'g'; j++; buf[j] = 't'; j++;
+        buf[j] = ';'; j++;
+        break;
+
+      default:
+        /* escape big chars */
+        if (chars[i] > 127) {
+          unsigned char nbuf[32];
+          unsigned int k;
+
+          sprintf((char *)nbuf, "&#%i;", (int)chars[i]);
+          for (k = 0; nbuf[k] != '\0'; k++) {
+            buf[j] = nbuf[k];
+            j++;
+          }
+        }
+        else if (chars[i] == 0x9 || chars[i] == 0xA || chars[i] == 0xD || chars[i] >= 0x20) { // ignore any unsupported control character
+          /* nothing to escape */
+          buf[j] = chars[i];
+          j++;
+        }
+        break;
+    }
+  }
+  
+  self = [[NSString alloc] initWithBytesNoCopy: buf
+                                        length: (j*sizeof(wchar_t))
+                                      encoding: NSUTF32StringEncoding
+                                  freeWhenDone: YES];
+
+  return [self autorelease];
+}
+
 - (NSString *) sanitizedServerIdWithType: (SOGoMicrosoftActiveSyncFolderType) folderType
 {
   if (folderType == ActiveSyncEventFolder)
@@ -62,7 +158,7 @@ static NSArray *easCommandParameters = nil;
 
 - (NSString *) activeSyncRepresentationInContext: (WOContext *) context
 {
-  return [self safeStringByEscapingXMLString: YES];
+  return [self _stringByEscapingXMLStringUsingCharacters];
 }
 
 - (int) activeSyncFolderType

ActiveSync/SOGoActiveSyncDispatcher+Sync.h

@@ -33,6 +33,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import "SOGoActiveSyncDispatcher.h"
 
 #import <DOM/DOMElement.h>
+#import <DOM/DOMProtocols.h>
 
 @class WOResponse;
 

ActiveSync/SOGoActiveSyncDispatcher.h

@@ -1,6 +1,6 @@
 /*
 
-Copyright (c) 2014-2015, Inverse inc.
+Copyright (c) 2014, Inverse inc.
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without
@@ -27,31 +27,19 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 */
-
 #import <Foundation/NSObject.h>
 
 #include "SOGoActiveSyncConstants.h"
 
-@class NSCalendarDate;
 @class NSException;
-@class NSMutableDictionary;
 @class NSURL;
-@class NSNumber;
-
-static volatile BOOL easShouldTerminate = NO;
 
 @interface SOGoActiveSyncDispatcher : NSObject
 {
   NSURL *folderTableURL;
-  NSDictionary *imapFolderGUIDS;
   id context;
-
-  NSNumber *syncRequest;
-  BOOL debugOn;
 }
 
-- (NSMutableDictionary *) globalMetadataForDevice;
-
 - (id) collectionFromId: (NSString *) theCollectionId
                    type: (SOGoMicrosoftActiveSyncFolderType) theFolderType;
 
@@ -64,6 +52,5 @@ static volatile BOOL easShouldTerminate = NO;
 
 - (NSURL *) folderTableURL;
 - (void) ensureFolderTableExists;
-- (BOOL) easShouldTerminate;
 
 @end

ActiveSync/SOGoMailObject+ActiveSync.m

@@ -29,19 +29,20 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 #include "SOGoMailObject+ActiveSync.h"
 
+#import <Foundation/NSArray.h>
 #import <Foundation/NSCalendarDate.h>
 #import <Foundation/NSDictionary.h>
 #import <Foundation/NSException.h>
 #import <Foundation/NSString.h>
-#import <Foundation/NSCharacterSet.h>
 
 #import <NGCards/iCalCalendar.h>
 #import <NGCards/iCalDateTime.h>
 #import <NGCards/iCalEvent.h>
+#import <NGCards/iCalPerson.h>
+#import <NGCards/iCalTimeZone.h>
 
 #import <NGExtensions/NGBase64Coding.h>
 #import <NGExtensions/NGQuotedPrintableCoding.h>
-
 #import <NGExtensions/NSString+misc.h>
 #import <NGExtensions/NSString+Encoding.h>
 #import <NGImap4/NGImap4Envelope.h>
@@ -49,7 +50,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import <NGImap4/NSString+Imap4.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
 #import <NGObjWeb/WOApplication.h>
-#import <NGObjWeb/WORequest.h>
 
 #import <NGMime/NGMimeBodyPart.h>
 #import <NGMime/NGMimeFileData.h>
@@ -59,6 +59,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import <NGMail/NGMimeMessage.h>
 #import <NGMail/NGMimeMessageGenerator.h>
 
+#import <Mailer/SOGoMailLabel.h>
+
 #import <SOGo/SOGoUserDefaults.h>
 
 #include "iCalTimeZone+ActiveSync.h"
@@ -68,16 +70,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <Appointments/iCalEntityObject+SOGo.h>
 #include <Appointments/iCalPerson+SOGo.h>
-#include <Mailer/SOGoMailBodyPart.h>
 #include <Mailer/NSString+Mail.h>
-
+#include <Mailer/SOGoMailBodyPart.h>
 #include <SOGo/SOGoUser.h>
 #include <SOGo/NSString+Utilities.h>
 
 #import <Appointments/SOGoAptMailNotification.h>
 
-
-
 unsigned char strToChar(char a, char b) {
     char encoder[3] = {'\0','\0','\0'};
     encoder[0] = a;
@@ -424,7 +423,7 @@ struct GlobalObjectId {
           mimeType = [NGMimeType mimeType: [[thePart contentType] type]
                                   subType: [[thePart contentType] subType]
                                parameters: [NSDictionary dictionaryWithObject: @"utf-8"  forKey: @"charset"]];
-          [(NGMimeBodyPart *)thePart setHeader: mimeType  forKey: @"content-type"];
+          [thePart setHeader: mimeType  forKey: @"content-type"];
           
           fdata = [[NGMimeFileData alloc] initWithBytes: [body bytes]
                                                  length: [body length]];
@@ -473,131 +472,18 @@ struct GlobalObjectId {
   return d;
 }
 
-//
-//
-//
-- (BOOL) _sanitinizeNeeded: (NSArray *) theParts
-{
-  NSString *encoding, *charset;
-  int i;
-
-  for (i = 0; i < [theParts count]; i++)
-    {
-      encoding = [[theParts objectAtIndex: i ] objectForKey: @"encoding"];
-      charset = [[[theParts objectAtIndex: i ] objectForKey: @"parameterList"] objectForKey: @"charset"];
-      if (encoding && ([encoding caseInsensitiveCompare: @"7bit"] == NSOrderedSame || [encoding caseInsensitiveCompare: @"8bit"] == NSOrderedSame) &&
-          charset  && ![charset caseInsensitiveCompare: @"utf-8"] == NSOrderedSame
-                   && ![charset caseInsensitiveCompare: @"us-ascii"] == NSOrderedSame)
-        {
-          return YES;
-        }
-
-      if ([self _sanitinizeNeeded: [[theParts objectAtIndex: i ] objectForKey: @"parts"]])
-          return YES;
-   }
-
-   return NO;
-}
-
-
-- (BOOL) _isSigned: (NSDictionary *) thePart
-{
-  NSMutableDictionary *currentPart;
-  NSArray *subparts;
-  NSString *type, *subtype;
-  NSUInteger i;
-
-  type = [[thePart objectForKey: @"type"] lowercaseString];
-  subtype = [[thePart objectForKey: @"subtype"] lowercaseString];
-
-  if ([type isEqualToString: @"multipart"])
-    {
-      if ([subtype isEqualToString: @"signed"])
-        return YES;
-
-      subparts = [thePart objectForKey: @"parts"];
-      for (i = 0; i < [subparts count]; i++)
-        {
-          currentPart = [subparts objectAtIndex: i];
-          if ([self _isSigned: currentPart])
-            return YES;
-        }
-    }
-
-  return NO;
-}
-
-- (BOOL) _isSmimeEncrypted: (NSDictionary *) thePart
-{
-  NSMutableDictionary *currentPart;
-  NSArray *subparts;
-  NSString *type, *subtype;
-  NSUInteger i;
-
-  type = [[thePart objectForKey: @"type"] lowercaseString];
-  subtype = [[thePart objectForKey: @"subtype"] lowercaseString];
-
-  if ([type isEqualToString: @"multipart"])
-    {
-      subparts = [thePart objectForKey: @"parts"];
-      for (i = 0; i < [subparts count]; i++)
-        {
-          currentPart = [subparts objectAtIndex: i];
-          if ([self _isSmimeEncrypted: currentPart])
-            return YES;
-        }
-    }
-  else if ([type isEqualToString: @"application"] && ([subtype isEqualToString: @"pkcs7-mime"] ||
-           [subtype isEqualToString: @"x-pkcs7-mime"]))
-    return YES;
-
-  return NO;
-}
-
-- (BOOL) _isPGP: (NSDictionary *) thePart
-{
-  NSMutableDictionary *currentPart;
-  NSArray *subparts;
-  NSString *type, *subtype, *protocol;
-  NSUInteger i;
-
-  type = [[thePart objectForKey: @"type"] lowercaseString];
-  subtype = [[thePart objectForKey: @"subtype"] lowercaseString];
-  protocol = [[[thePart objectForKey: @"parameterList"] objectForKey: @"protocol"] lowercaseString];
-
-  if ([type isEqualToString: @"multipart"])
-    {
-      if (([protocol isEqualToString: @"application/pgp-signature"] || [protocol isEqualToString: @"application/pgp-encrypted"]))
-        return YES;
-
-      subparts = [thePart objectForKey: @"parts"];
-      for (i = 0; i < [subparts count]; i++)
-        {
-          currentPart = [subparts objectAtIndex: i];
-          if ([self _isPGP: currentPart])
-            return YES;
-        }
-    }
-  else if ([type isEqualToString: @"application"] && [subtype isEqualToString: @"pgp-encrypted"])
-    return YES;
-
-  return NO;
-}
-
 //
 //
 //
 - (NSData *) _preferredBodyDataUsingType: (int) theType
-                              mimeSupport: (int) theMimeSupport
                               nativeType: (int *) theNativeType
 {
   NSString *type, *subtype, *encoding;
   NSData *d;
-  BOOL isSMIME, sanitinizeNeeded;
   
   type = [[[self bodyStructure] valueForKey: @"type"] lowercaseString];
   subtype = [[[self bodyStructure] valueForKey: @"subtype"] lowercaseString];
-  isSMIME = NO;
+
   d = nil;
   
   // We determine the native type
@@ -608,16 +494,8 @@ struct GlobalObjectId {
   else if ([type isEqualToString: @"multipart"])
     *theNativeType = 4;
 
-  if (([self _isSigned: [self bodyStructure]] ||
-       [self _isSmimeEncrypted: [self bodyStructure]] ||
-       [self _isPGP: [self bodyStructure]]) && theMimeSupport > 0)
-    {
-      *theNativeType = 4;
-      isSMIME = YES;
-    }
-
   // We get the right part based on the preference
-  if ((theType == 1 || theType == 2) && !isSMIME)
+  if (theType == 1 || theType == 2)
     {
       if ([type isEqualToString: @"text"] && ![subtype isEqualToString: @"calendar"])
         {
@@ -658,12 +536,12 @@ struct GlobalObjectId {
           d = [self _preferredBodyDataInMultipartUsingType: theType nativeTypeFound: theNativeType];
         }
     }
-  else if (theType == 4 || isSMIME)
+  else if (theType == 4)
     {
-      // We sanitize the content if the content-transfer-encoding is 8bit and charset is not utf-8 or us-ascii.
-      sanitinizeNeeded = [self _sanitinizeNeeded: [NSArray arrayWithObject: [self bodyStructure]]];
-
-      if (sanitinizeNeeded && !isSMIME)
+      // We sanitize the content *ONLY* for Outlook clients and if the content-transfer-encoding is 8bit. Outlook has strange issues
+      // with quoted-printable/base64 encoded text parts. It just doesn't decode them.
+      encoding = [[self lookupInfoForBodyPart: @""] objectForKey: @"encoding"];
+      if ([[context objectForKey: @"DeviceType"] isEqualToString: @"WindowsOutlook15"] || ([encoding caseInsensitiveCompare: @"8bit"] == NSOrderedSame))
         d = [self _sanitizedMIMEMessage];
       else
         d = [self content];
@@ -694,35 +572,6 @@ struct GlobalObjectId {
 }
 
 
-- (NSString *) _truncateContent: (NSString *) theContent
-                          limit: (int) theLimit
-                      truncated: (int *) wasTruncated
-{
-  if ([theContent length] > theLimit)
-    {
-      int i, len;
-
-      theContent = [theContent substringToIndex: theLimit];
-      *wasTruncated = 1;
-
-      // We search for the first "space" character starting from the
-      // end and we truncate the string once more. We do this to avoid
-      // truncating the content in the middle of a XML entity
-      len = theLimit-1;
-
-      for (i = len; i >= 0; i--)
-        {
-          if (isspace([theContent characterAtIndex: i]))
-            break;
-        }
-
-      return [theContent substringToIndex: i];
-    }
-
-  *wasTruncated = 0;
-  return theContent;
-}
-
 //
 //
 //
@@ -782,7 +631,7 @@ struct GlobalObjectId {
                   iCalCalendar *calendar;
                   NSData *calendarData;
                   
-                  calendarData = [bodyPart fetchBLOBWithPeek: YES];
+                  calendarData = [bodyPart fetchBLOB];
                   calendar = nil;
 
                   NS_DURING
@@ -807,17 +656,16 @@ struct GlobalObjectId {
 {
   NSData *d, *globalObjId;
   NSArray *attachmentKeys;
-  iCalCalendar *calendar;
-  NSString *p;
   NSMutableString *s;
-  id value;
-      
-  int preferredBodyType, mimeSupport, mimeTruncation, nativeBodyType;
-  uint32_t v;
 
-  preferredBodyType = [[context objectForKey: @"BodyPreferenceType"] intValue];
-  mimeSupport = [[context objectForKey: @"MIMESupport"] intValue];
-  mimeTruncation = [[context objectForKey: @"MIMETruncation"] intValue];
+  uint32_t v;
+  NSString *p;
+  
+  id value;
+
+  iCalCalendar *calendar;
+      
+  int preferredBodyType, nativeBodyType;
 
   s = [NSMutableString string];
 
@@ -1014,13 +862,7 @@ struct GlobalObjectId {
   else
     {
       // MesssageClass and ContentClass
-      if ([self _isSigned: [self bodyStructure]])
-        [s appendFormat: @"<MessageClass xmlns=\"Email:\">%@</MessageClass>", @"IPM.Note.SMIME.MultipartSigned"];
-      else if ([self _isSmimeEncrypted: [self bodyStructure]])
-        [s appendFormat: @"<MessageClass xmlns=\"Email:\">%@</MessageClass>", @"IPM.Note.SMIME"];
-      else
-        [s appendFormat: @"<MessageClass xmlns=\"Email:\">%@</MessageClass>", @"IPM.Note"];
-
+      [s appendFormat: @"<MessageClass xmlns=\"Email:\">%@</MessageClass>", @"IPM.Note"];
       [s appendFormat: @"<ContentClass xmlns=\"Email:\">%@</ContentClass>", @"urn:content-classes:message"];
     }
 
@@ -1034,8 +876,10 @@ struct GlobalObjectId {
   [s appendFormat: @"<InternetCPID xmlns=\"Email:\">%@</InternetCPID>", @"65001"];
           
   // Body - namespace 17
+  preferredBodyType = [[context objectForKey: @"BodyPreferenceType"] intValue];
+
   nativeBodyType = 1;
-  d = [self _preferredBodyDataUsingType: preferredBodyType  mimeSupport: mimeSupport  nativeType: &nativeBodyType];
+  d = [self _preferredBodyDataUsingType: preferredBodyType  nativeType: &nativeBodyType];
 
   if (calendar && !d)
     {
@@ -1124,50 +968,9 @@ struct GlobalObjectId {
       AUTORELEASE(content);
       
       content = [content activeSyncRepresentationInContext: context];
-      len = [content length];
       truncated = 0;
 
-      // We handle MIMETruncation
-      switch (mimeTruncation)
-        {
-        case 0:
-          {
-            content = @"";
-            len = 0; truncated = 1;
-          }
-          break;
-        case 1:
-          content = [self _truncateContent: content  limit: 4096  truncated: &truncated];
-          len = [content length];
-          break;
-        case 2:
-          content = [self _truncateContent: content  limit: 5120  truncated: &truncated];
-          len = [content length];
-          break;
-        case 3:
-          content = [self _truncateContent: content  limit: 7168  truncated: &truncated];
-          len = [content length];
-          break;
-        case 4:
-          content = [self _truncateContent: content  limit: 10240  truncated: &truncated];
-          len = [content length];
-          break;
-        case 5:
-          content = [self _truncateContent: content  limit: 20480  truncated: &truncated];
-          len = [content length];
-          break;
-        case 6:
-          content = [self _truncateContent: content  limit: 51200  truncated: &truncated];
-          len = [content length];
-          break;
-        case 7:
-          content = [self _truncateContent: content  limit: 102400  truncated: &truncated];
-          len = [content length];
-          break;
-        case 8:
-        default:
-          truncated = 0;
-        }
+      len = [content length];
 
       if ([[[context request] headerForKey: @"MS-ASProtocolVersion"] isEqualToString: @"2.5"])
         {
@@ -1175,32 +978,30 @@ struct GlobalObjectId {
           [s appendFormat: @"<BodyTruncated xmlns=\"Email:\">%d</BodyTruncated>", truncated];
         }
       else
-        {
+       {
           [s appendString: @"<Body xmlns=\"AirSyncBase:\">"];
 
-          // Set the correct type if client requested text/html but we got text/plain.
-          // For s/mime mails type is always 4 if mimeSupport is 1 or 2.
+          // Set the correct type if client requested text/html but we got text/plain
           if (preferredBodyType == 2 && nativeBodyType == 1)
              [s appendString: @"<Type>1</Type>"];
-          else if (([self _isSigned: [self bodyStructure]] ||
-                    [self _isSmimeEncrypted: [self bodyStructure]] ||
-                    [self _isPGP: [self bodyStructure]]) && mimeSupport > 0)
-             [s appendString: @"<Type>4</Type>"];
           else
              [s appendFormat: @"<Type>%d</Type>", preferredBodyType];
 
           [s appendFormat: @"<Truncated>%d</Truncated>", truncated];
           [s appendFormat: @"<Preview></Preview>"];
-          [s appendFormat: @"<Data>%@</Data>", content];
-          [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>", len];
+
+          if (!truncated)
+            {
+              [s appendFormat: @"<Data>%@</Data>", content];
+              [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>", len];
+            }
           [s appendString: @"</Body>"];
        }
     }
-
+  
   // Attachments -namespace 16
   attachmentKeys = [self fetchFileAttachmentKeys];
-
-  if ([attachmentKeys count] && !([self _isSigned: [self bodyStructure]]))
+  if ([attachmentKeys count])
     {
       int i;
 
@@ -1270,21 +1071,15 @@ struct GlobalObjectId {
   if ([[[context request] headerForKey: @"MS-ASProtocolVersion"] isEqualToString: @"14.0"] ||
       [[[context request] headerForKey: @"MS-ASProtocolVersion"] isEqualToString: @"14.1"])
     {
-      id value;
       NSString *reference;
 
-      value = [[self mailHeaders] objectForKey: @"references"];
-
-      if ([value isKindOfClass: [NSArray class]])
-         reference = [[[value objectAtIndex: 0] componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceCharacterSet]] objectAtIndex: 0];
-      else
-         reference = [[value componentsSeparatedByCharactersInSet:[NSCharacterSet whitespaceCharacterSet]] objectAtIndex: 0];
+      reference = [[[[self mailHeaders] objectForKey: @"references"] componentsSeparatedByString: @" "] objectAtIndex: 0];
 
       if ([reference length] > 0)
         [s appendFormat: @"<ConversationId xmlns=\"Email2:\">%@</ConversationId>", [[reference dataUsingEncoding: NSUTF8StringEncoding] activeSyncRepresentationInContext: context]];
-      else if ([[self inReplyTo] length] > 0)
+      else if ([self inReplyTo])
         [s appendFormat: @"<ConversationId xmlns=\"Email2:\">%@</ConversationId>", [[[self inReplyTo] dataUsingEncoding: NSUTF8StringEncoding] activeSyncRepresentationInContext: context]];
-      else if ([[self messageId] length] > 0)
+      else if ([self messageId])
         [s appendFormat: @"<ConversationId xmlns=\"Email2:\">%@</ConversationId>", [[[self messageId] dataUsingEncoding: NSUTF8StringEncoding] activeSyncRepresentationInContext: context]];
     }
 

ActiveSync/SOGoSyncCacheObject.h

@@ -37,7 +37,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 @interface SOGoSyncCacheObject : NSObject
 {
-  @public
   id _uid;
   id _sequence;
 }

ActiveSync/SOGoSyncCacheObject.m

@@ -32,17 +32,9 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #import <Foundation/NSNull.h>
 #import <Foundation/NSString.h>
-#import <Foundation/NSValue.h>
-
-static Class NSNullK;
 
 @implementation SOGoSyncCacheObject
 
-+ (void) initialize
-{
-  NSNullK = [NSNull class];
-}
-
 - (id) init
 {
   if ((self = [super init]))
@@ -54,14 +46,14 @@ static Class NSNullK;
   return self;
 }
 
-+ (id) syncCacheObjectWithUID: (id) theUID  sequence:  (id) theSequence
++ (id) syncCacheObjectWithUID: (id) theUID  sequence:  (id) theSequence;
 {
   id o;
 
   o = [[self alloc] init];
-
-  [o setUID: [NSNumber numberWithInt: [theUID intValue]]];
-  [o setSequence: ([theSequence isKindOfClass: NSNullK] ? theSequence : [NSNumber numberWithInt: [theSequence intValue]])];
+ 
+  [o setUID: theUID];
+  [o setSequence: theSequence];
   
   return [o autorelease];
 }
@@ -75,7 +67,7 @@ static Class NSNullK;
 
 - (id) uid
 {
-  return [_uid description];
+  return _uid;
 }
 
 - (void) setUID: (id) theUID
@@ -85,7 +77,7 @@ static Class NSNullK;
 
 - (id) sequence
 {
-  return ([_sequence isKindOfClass: NSNullK] ? _sequence : [_sequence description]);
+  return _sequence;
 }
 
 - (void) setSequence: (id) theSequence
@@ -96,7 +88,7 @@ static Class NSNullK;
 
 - (NSComparisonResult) compareUID: (SOGoSyncCacheObject *) theSyncCacheObject
 {
-  return [self->_uid compare: theSyncCacheObject->_uid];
+  return [[self uid] compare: [theSyncCacheObject uid]];
 }
 
 //
@@ -105,21 +97,21 @@ static Class NSNullK;
 //
 - (NSComparisonResult) compareSequence: (SOGoSyncCacheObject *) theSyncCacheObject
 {
-  if ([self->_sequence isEqual: [NSNull null]] &&
-      [theSyncCacheObject->_sequence isEqual: [NSNull null]])
+  if ([[self sequence] isEqual: [NSNull null]] &&
+      [[theSyncCacheObject sequence] isEqual: [NSNull null]])
     return [self compareUID: theSyncCacheObject];
   
-  if (![self->_sequence isEqual: [NSNull null]] && [theSyncCacheObject->_sequence isEqual: [NSNull null]])
+  if (![[self sequence] isEqual: [NSNull null]] && [[theSyncCacheObject sequence] isEqual: [NSNull null]])
     return NSOrderedDescending;
   
-  if ([self->_sequence isEqual: [NSNull null]] && ![theSyncCacheObject->_sequence isEqual: [NSNull null]])
+  if ([[self sequence] isEqual: [NSNull null]] && ![[theSyncCacheObject sequence] isEqual: [NSNull null]])
     return NSOrderedAscending;
   
   // Must check this here, to avoid comparing NSNull objects
-  if ([self->_sequence compare: theSyncCacheObject->_sequence] == NSOrderedSame)
+  if ([[self sequence] compare: [theSyncCacheObject sequence]] == NSOrderedSame)
     return [self compareUID: theSyncCacheObject];
   
-  return [self->_sequence compare: theSyncCacheObject->_sequence];
+  return [[self sequence] compare: [theSyncCacheObject sequence]];
 }
 
 - (NSString *) description
@@ -128,4 +120,3 @@ static Class NSNullK;
 }
 
 @end
-

ActiveSync/SoObjectWebDAVDispatcher+ActiveSync.m

@@ -27,11 +27,9 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 */
-
 #import <NGObjWeb/SoObjectWebDAVDispatcher.h>
 
 #include <NGObjWeb/SoObject+SoDAV.h>
-
 #include <NGObjWeb/WEClientCapabilities.h>
 #include <NGObjWeb/WOContext.h>
 #include <NGObjWeb/WORequest.h>
@@ -39,7 +37,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #import <Foundation/NSArray.h>
 
-
 @interface SoObjectWebDAVDispatcher (ActiveSync)
 
 - (id)_callObjectMethod:(NSString *)_method inContext:(WOContext *)_ctx;

ActiveSync/iCalAlarm+ActiveSync.m

@@ -30,9 +30,12 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #import "iCalAlarm+ActiveSync.h"
 
 #import <Foundation/NSDictionary.h>
-#import <NGExtensions/NSCalendarDate+misc.h>
+#import <Foundation/NSString.h>
+
 #import <NGExtensions/NSString+misc.h>
+#import <NGObjWeb/WOContext.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
+
 #import <NGCards/iCalAlarm.h>
 #import <NGCards/iCalEvent.h>
 #import <NGCards/iCalTrigger.h>
@@ -55,7 +58,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       
       // don't send negative reminder - not supported
       if (delta > 0)
-        [s appendFormat: @"<Reminder xmlns=\"Calendar:\">%d</Reminder>", (int)delta];
+        [s appendFormat: @"<Reminder xmlns=\"Calendar:\">%d</Reminder>", delta];
     }
   
   return s;

ActiveSync/iCalEvent+ActiveSync.h

@@ -41,9 +41,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 - (NSString *) activeSyncRepresentationInContext: (WOContext *) context;
 - (void) takeActiveSyncValues: (NSDictionary *) theValues
                     inContext: (WOContext *) context;
-- (void) changeParticipationStatus: (NSDictionary *) theValues
-                         inContext: (WOContext *) context
-                         component: (id) component;
+
 @end
 
 #endif

ActiveSync/iCalEvent+ActiveSync.m

@@ -30,27 +30,26 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #import "iCalEvent+ActiveSync.h"
 
+#import <Foundation/NSArray.h>
+#import <Foundation/NSCalendarDate.h>
+#import <Foundation/NSDate.h>
 #import <Foundation/NSDictionary.h>
+#import <Foundation/NSString.h>
 #import <Foundation/NSTimeZone.h>
 
 #import <NGExtensions/NSString+misc.h>
-#import <NGExtensions/NSCalendarDate+misc.h>
-#import <NGExtensions/NSObject+Logs.h>
+#import <NGObjWeb/WOContext.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
+#import <NGObjWeb/WORequest.h>
 
 #import <NGCards/iCalCalendar.h>
 #import <NGCards/iCalDateTime.h>
 #import <NGCards/iCalPerson.h>
-#import <NGCards/NSCalendarDate+NGCards.h>
-#import <NGCards/NSString+NGCards.h>
 
 #import <SOGo/SOGoUser.h>
 #import <SOGo/SOGoUserDefaults.h>
-#import <SOGo/WORequest+SOGo.h>
 
 #import <Appointments/iCalEntityObject+SOGo.h>
-#import <Appointments/iCalRepeatableEntityObject+SOGo.h>
-#import <Appointments/SOGoAppointmentObject.h>
 
 #include "iCalAlarm+ActiveSync.h"
 #include "iCalRecurrenceRule+ActiveSync.h"
@@ -99,13 +98,10 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   else if ([self created])
     [s appendFormat: @"<DTStamp xmlns=\"Calendar:\">%@</DTStamp>", [[self created] activeSyncRepresentationWithoutSeparatorsInContext: context]];
   
-  // Timezone
-  tz = [(iCalDateTime *)[self firstChildWithTag: @"dtstart"] timeZone];
-
   // StartTime -- http://msdn.microsoft.com/en-us/library/ee157132(v=exchg.80).aspx
   if ([self startDate])
     {
-      if ([self isAllDay] && !tz)
+      if ([self isAllDay])
         [s appendFormat: @"<StartTime xmlns=\"Calendar:\">%@</StartTime>",
            [[[self startDate] dateByAddingYears: 0 months: 0 days: 0
                                           hours: 0 minutes: 0
@@ -118,7 +114,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   // EndTime -- http://msdn.microsoft.com/en-us/library/ee157945(v=exchg.80).aspx
   if ([self endDate])
     {
-      if ([self isAllDay] && !tz)
+      if ([self isAllDay])
         [s appendFormat: @"<EndTime xmlns=\"Calendar:\">%@</EndTime>",
            [[[self endDate] dateByAddingYears: 0 months: 0 days: 0
                                         hours: 0 minutes: 0
@@ -128,24 +124,26 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
         [s appendFormat: @"<EndTime xmlns=\"Calendar:\">%@</EndTime>", [[self endDate] activeSyncRepresentationWithoutSeparatorsInContext: context]];
     }
 
+  // Timezone
+  tz = [(iCalDateTime *)[self firstChildWithTag: @"dtstart"] timeZone];
+
   if (!tz)
     tz = [iCalTimeZone timeZoneForName: [userTimeZone name]];
 
-  if (![self recurrenceId])
-    [s appendFormat: @"<TimeZone xmlns=\"Calendar:\">%@</TimeZone>", [tz activeSyncRepresentationInContext: context]];
+  [s appendFormat: @"<TimeZone xmlns=\"Calendar:\">%@</TimeZone>", [tz activeSyncRepresentationInContext: context]];
   
   // Organizer and other invitations related properties
   if ((organizer = [self organizer]))
     {
       meetingStatus = 1;  // meeting and the user is the meeting organizer.
       o = [organizer rfc822Email];
-      if (![self recurrenceId] && [o length])
+      if ([o length])
         {
           [s appendFormat: @"<Organizer_Email xmlns=\"Calendar:\">%@</Organizer_Email>", o];
           
           o = [organizer cn];
           if ([o length])
-            [s appendFormat: @"<Organizer_Name xmlns=\"Calendar:\">%@</Organizer_Name>", [o activeSyncRepresentationInContext: context]];
+            [s appendFormat: @"<Organizer_Name xmlns=\"Calendar:\">%@</Organizer_Name>", o];
         }
     }
   
@@ -228,37 +226,9 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   //[s appendFormat: @"<Importance xmlns=\"Calendar:\">%d</Importance>", v];
 
   // UID -- http://msdn.microsoft.com/en-us/library/ee159919(v=exchg.80).aspx
-  if (![self recurrenceId] && [[self uid] length])
-    [s appendFormat: @"<UID xmlns=\"Calendar:\">%@</UID>", [[self uid] activeSyncRepresentationInContext: context]];
-
-  // Recurrence rules
-  if ([self isRecurrent])
-    [s appendString: [[[self recurrenceRules] lastObject] activeSyncRepresentationInContext: context]];
-
-  // Comment
-  o = [self comment];
-  //if (![self recurrenceId] && [o length])
-  if ([o length])
-    {
-      // It is very important here to NOT set <Truncated>0</Truncated> in the response,
-      // otherwise it'll prevent WP8 phones from sync'ing. See #3028 for details.
-      o = [o activeSyncRepresentationInContext: context];
-
-      if ([[[context request] headerForKey: @"MS-ASProtocolVersion"] isEqualToString: @"2.5"])
-        {
-          [s appendFormat: @"<Body xmlns=\"Calendar:\">%@</Body>", o];
-          [s appendString: @"<BodyTruncated xmlns=\"Calendar:\">0</BodyTruncated>"];
-        }
-      else
-        {
-          [s appendString: @"<Body xmlns=\"AirSyncBase:\">"];
-          [s appendFormat: @"<Type>%d</Type>", 1];
-          [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>",  (int)[o length]];
-          [s appendFormat: @"<Data>%@</Data>", o];
-          [s appendString: @"</Body>"];
-       }
-    }
-
+  if ([[self uid] length])
+    [s appendFormat: @"<UID xmlns=\"Calendar:\">%@</UID>", [self uid]];
+  
   // Sensitivity
   if ([[self accessClass] isEqualToString: @"PRIVATE"])
     v = 2;
@@ -281,6 +251,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       [s appendFormat: @"</Categories>"];
     }
 
+  
   // Reminder -- http://msdn.microsoft.com/en-us/library/ee219691(v=exchg.80).aspx
   // TODO: improve this to handle more alarm types
   if ([self hasAlarms]) 
@@ -291,79 +262,36 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       [s appendString: [alarm activeSyncRepresentationInContext: context]];
     }
 
-  // Exceptions
+  // Recurrence rules
   if ([self isRecurrent])
     {
-      NSMutableArray *components, *exdates;
-      iCalEvent *current_component;
-      NSString *recurrence_id;
-
-      unsigned int count, max, i;
-
-      components = [NSMutableArray arrayWithArray: [[self parent] events]];
-      max = [components count];
-
-      if (max > 1 || [self hasExceptionDates])
-        {
-          exdates = [NSMutableArray arrayWithArray: [self exceptionDates]];
-
-          [s appendString: @"<Exceptions xmlns=\"Calendar:\">"];
-
-          for (count = 1; count < max; count++)
-            {
-              current_component = [components objectAtIndex: count] ;
-
-              if ([self isAllDay])
-                {
-                  recurrence_id = [NSString stringWithFormat: @"%@",
-                                            [[[current_component recurrenceId] dateByAddingYears: 0 months: 0 days: 0
-                                                                                           hours: 0 minutes: 0
-                                                                                         seconds: -[userTimeZone secondsFromGMTForDate:
-                                                                                                                   [current_component recurrenceId]]]
-                                              activeSyncRepresentationWithoutSeparatorsInContext: context]];
-                }
-              else
-                {
-                  recurrence_id = [NSString stringWithFormat: @"%@", [[current_component recurrenceId]
-                                                                       activeSyncRepresentationWithoutSeparatorsInContext: context]];
-                }
-
-              [s appendString: @"<Exception>"];
-              [s appendFormat: @"<Exception_StartTime xmlns=\"Calendar:\">%@</Exception_StartTime>", recurrence_id];
-              [s appendFormat: @"%@", [current_component activeSyncRepresentationInContext: context]];
-              [s appendString: @"</Exception>"];
-            }
-
-          for (i = 0; i < [exdates count]; i++)
-            {
-              [s appendString: @"<Exception>"];
-              [s appendString: @"<Exception_Deleted>1</Exception_Deleted>"];
-
-              if ([self isAllDay])
-                {
-                  recurrence_id = [NSString stringWithFormat: @"%@",
-                                   [[[[exdates objectAtIndex: i] asCalendarDate] dateByAddingYears: 0 months: 0 days: 0
-                                                                                             hours: 0 minutes: 0
-                                                                                           seconds: -[userTimeZone secondsFromGMTForDate:
-                                                                                                                 [[exdates objectAtIndex: i] asCalendarDate]]]
-                                     activeSyncRepresentationWithoutSeparatorsInContext: context]];
-                }
-              else
-                {
-                  recurrence_id = [NSString stringWithFormat: @"%@", [[[exdates objectAtIndex: i] asCalendarDate]
-                                                                       activeSyncRepresentationWithoutSeparatorsInContext: context]];
-                }
-
-              [s appendFormat: @"<Exception_StartTime xmlns=\"Calendar:\">%@</Exception_StartTime>", recurrence_id];
-              [s appendString: @"</Exception>"];
-            }
-
-            [s appendString: @"</Exceptions>"];
-        }
+      [s appendString: [[[self recurrenceRules] lastObject] activeSyncRepresentationInContext: context]];
     }
 
-  if (![self recurrenceId])
-    [s appendFormat: @"<NativeBodyType xmlns=\"AirSyncBase:\">%d</NativeBodyType>", 1];
+  // Comment
+  o = [self comment];
+  if ([o length])
+    {
+      // It is very important here to NOT set <Truncated>0</Truncated> in the response,
+      // otherwise it'll prevent WP8 phones from sync'ing. See #3028 for details.
+      o = [o activeSyncRepresentationInContext: context];
+
+      if ([[[context request] headerForKey: @"MS-ASProtocolVersion"] isEqualToString: @"2.5"])
+        {
+          [s appendFormat: @"<Body xmlns=\"Calendar:\">%@</Body>", o];
+          [s appendString: @"<BodyTruncated xmlns=\"Calendar:\">0</BodyTruncated>"];
+        }
+      else
+        {
+          [s appendString: @"<Body xmlns=\"AirSyncBase:\">"];
+          [s appendFormat: @"<Type>%d</Type>", 1];
+          [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>", [o length]];
+          [s appendFormat: @"<Data>%@</Data>", o];
+          [s appendString: @"</Body>"];
+       }
+    }
+
+  [s appendFormat: @"<NativeBodyType xmlns=\"AirSyncBase:\">%d</NativeBodyType>", 1];
 
   return s;
 }
@@ -409,19 +337,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 - (void) takeActiveSyncValues: (NSDictionary *) theValues
                     inContext: (WOContext *) context
 {
-  iCalDateTime *start, *end; //, *oldstart;
-  NSCalendarDate *oldstart;
+  iCalDateTime *start, *end;
   NSTimeZone *userTimeZone;
   iCalTimeZone *tz;
   id o;
-  int deltasecs;
 
   BOOL isAllDay;
-
-  NSMutableArray *occurences;
-
-  occurences = [NSMutableArray arrayWithArray: [[self parent] events]];
-
+  
   if ((o = [theValues objectForKey: @"UID"]))
     [self setUid: o];
     
@@ -434,11 +356,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     {
       isAllDay = YES;
     }
-  else if ([occurences count] && !([theValues objectForKey: @"AllDayEvent"]))
-    {
-      // If the occurence has no AllDay tag use it from master.
-      isAllDay = [[occurences objectAtIndex: 0] isAllDay];
-    }
 
   //
   // 0- free, 1- tentative, 2- busy and 3- out of office
@@ -505,7 +422,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     {
       o = [o calendarDate];
       start = (iCalDateTime *) [self uniqueChildWithTag: @"dtstart"];
-      oldstart = [start dateTime];
       [start setTimeZone: tz];
 
        if (isAllDay)
@@ -517,12 +433,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
         {
           [start setDateTime: o];
         }
-
-      // Calculate delta if start date has been changed.
-      if (oldstart)
-         deltasecs = [[start dateTime ] timeIntervalSinceDate: oldstart] * -1;
-      else
-         deltasecs = 0;
     }
 
   if ((o = [theValues objectForKey: @"EndTime"]))
@@ -581,177 +491,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       RELEASE(rule);
       
       [rule takeActiveSyncValues: o  inContext: context];
-
-      // Exceptions
-      if ((o = [theValues objectForKey: @"Exceptions"]) && [o isKindOfClass: [NSArray class]])
-        {
-          NSCalendarDate *recurrenceId, *adjustedRecurrenceId, *currentId;
-          NSMutableArray *exdates, *exceptionstouched;
-          iCalEvent *currentOccurence;
-          NSDictionary *exception;
-
-          unsigned int i, count, max;
-
-          [self removeAllExceptionDates];
-
-          exdates = [NSMutableArray array];
-          exceptionstouched = [NSMutableArray array];
-
-          for (i = 0; i < [o count]; i++)
-            {
-              exception = [o objectAtIndex: i];
-
-              if (![[exception objectForKey: @"Exception_Deleted"] intValue])
-                {
-                  recurrenceId = [[exception objectForKey: @"Exception_StartTime"] asCalendarDate];
-
-                  if (isAllDay)
-                    recurrenceId = [recurrenceId dateByAddingYears: 0 months: 0 days: 0
-                                                             hours: 0 minutes: 0
-                                                           seconds: [userTimeZone secondsFromGMTForDate:recurrenceId]];
-
-                  // When moving the calendar entry (i.e. changing the startDate) iOS and Android sometimes send a value for
-                  // Exception_StartTime which is not what we expect.
-                  // With this we make sure the recurrenceId is always correct.
-                  //
-                  // iOS problem - If the master is a no-allday-event but the exception is, an invalid Exception_StartTime is in the request.
-                  // e.g. it sends 20150409T040000Z instead of 20150409T060000Z;
-                  // This might be a special case since iPhone doesn't allow an allday-exception on a non-allday-event.
-                  if (!([[start dateTime] compare: [[start dateTime] hour:[recurrenceId hourOfDay] minute:[recurrenceId minuteOfHour]]] == NSOrderedSame))
-                    recurrenceId = [recurrenceId hour:[[start dateTime] hourOfDay] minute:[[start dateTime] minuteOfHour]];
-
-                  // We need to store the recurrenceIds and exception dates adjusted by deltasecs.
-                  // This ensures that the adjustment in SOGoCalendarComponent->updateComponent->_updateRecurrenceIDsWithEvent gives the correct dates.
-                  adjustedRecurrenceId = [recurrenceId dateByAddingYears: 0 months: 0 days: 0
-                                                                   hours: 0 minutes: 0 seconds: deltasecs];
-
-                  // search for an existing occurence and update it
-                  max = [occurences count];
-                  currentOccurence = nil;
-                  count = 1;
-                  while (count < max)
-                    {
-                      currentOccurence = [occurences objectAtIndex: count] ;
-                      currentId = [currentOccurence recurrenceId];
-
-                      if ([currentId compare: adjustedRecurrenceId] == NSOrderedSame)
-                        {
-                          [exceptionstouched addObject: adjustedRecurrenceId];
-                          [currentOccurence takeActiveSyncValues: exception  inContext: context];
-
-                          break;
-                        }
-
-                      count++;
-                      currentOccurence = nil;
-                    }
-
-                  // Create a new occurence if we found none to update.
-                  if (!currentOccurence)
-                    {
-                      iCalDateTime *recid;
-
-                      currentOccurence = [self mutableCopy];
-                      [currentOccurence removeAllRecurrenceRules];
-                      [currentOccurence removeAllExceptionRules];
-                      [currentOccurence removeAllExceptionDates];
-
-                      [[self parent] addToEvents: currentOccurence];
-                      [currentOccurence takeActiveSyncValues: exception  inContext: context];
-
-                      recid = (iCalDateTime *)[currentOccurence uniqueChildWithTag: @"recurrence-id"];
-                      if (isAllDay)
-                        [recid setDate: adjustedRecurrenceId];
-                      else
-                        [recid setDateTime: adjustedRecurrenceId];
-
-                      [exceptionstouched addObject: [recid dateTime]];
-                    }
-                }
-              else if ([[exception objectForKey: @"Exception_Deleted"] intValue])
-                {
-                  recurrenceId = [[exception objectForKey: @"Exception_StartTime"] asCalendarDate];
-
-                  if (isAllDay)
-                    recurrenceId = [recurrenceId dateByAddingYears: 0 months: 0
-                                                              days: 0 hours: 0 minutes: 0
-                                                           seconds: [userTimeZone secondsFromGMTForDate:recurrenceId]];
-
-                  // We add only valid exception dates.
-                  if ([self doesOccurOnDate: recurrenceId] &&
-                      ([[start dateTime] compare: [[start dateTime] hour:[recurrenceId hourOfDay]
-                                                                  minute:[recurrenceId minuteOfHour]]] == NSOrderedSame))
-                    {
-                      // We need to store the recurrenceIds and exception dates adjusted by deltasecs.
-                      // This ensures that the adjustment in SOGoCalendarComponent->updateComponent->_updateRecurrenceIDsWithEvent gives the correct dates.
-                      [exdates addObject: [recurrenceId dateByAddingYears: 0 months: 0 days: 0 hours: 0 minutes: 0 seconds: deltasecs]];
-                    }
-                }
-            }
-
-          // Update exception dates in master event.
-          max = [exdates count];
-          if (max > 0)
-            {
-              for (count = 0; count < max; count++)
-                {
-                  if (([exceptionstouched indexOfObject: [exdates objectAtIndex: count]] == NSNotFound))
-                    [self addToExceptionDates: [exdates objectAtIndex: count]];
-                }
-            }
-
-          // Remove all exceptions included in the request.
-          max = [occurences count];
-          count = 1; // skip the master event
-          while (count < max)
-            {
-              currentOccurence = [occurences objectAtIndex: count] ;
-              currentId = [currentOccurence recurrenceId];
-
-              // Delete all occurences which are not touched (modified/added).
-              if (([exceptionstouched indexOfObject: currentId] == NSNotFound))
-                [[[self parent] children] removeObject: currentOccurence];
-
-              count++;
-            }
-        }
-      else if ([self isRecurrent])
-        {
-          // We have no exceptions in request but there is a recurrence rule.
-          // Remove all excpetions and exception dates.
-          iCalEvent *currentOccurence;
-          unsigned int count, max;
-
-          [self removeAllExceptionDates];
-          max = [occurences count];
-          count = 1; // skip the master event
-          while (count < max)
-            {
-              currentOccurence = [occurences objectAtIndex: count];
-              [[[self parent] children] removeObject: currentOccurence];
-              count++;
-            }
-        }
-    }
-  else if ([self isRecurrent])
-    {
-      // We have no recurrence rule in request.
-      // Remove all exceptions, exception dates and recurrence rules.
-      iCalEvent *currentOccurence;
-      unsigned int count, max;
-
-      [self removeAllRecurrenceRules];
-      [self removeAllExceptionRules];
-      [self removeAllExceptionDates];
-
-      max = [occurences count];
-      count = 1; // skip the master event
-      while (count < max)
-        {
-          currentOccurence = [occurences objectAtIndex: count];
-          [[[self parent] children] removeObject: currentOccurence];
-          count++;
-        }
     }
 
   // Organizer - we don't touch the value unless we're the organizer
@@ -759,7 +498,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
       ([self userIsOrganizer: [context activeUser]] || [[context activeUser] hasEmail: o]))
     {
       iCalPerson *person;
-
+      
       person = [iCalPerson elementWithTag: @"organizer"];
       [person setEmail: o];
       [person setCn: [theValues objectForKey: @"Organizer_Name"]];
@@ -807,7 +546,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     {
       // Windows phones sens sometimes an empty Attendees tag.
       // We check it's an array before processing it.
-      if ((o = [theValues objectForKey: @"Attendees"]) && [o isKindOfClass: [NSArray class]])
+      if ((o = [theValues objectForKey: @"Attendees"])&& [o isKindOfClass: [NSArray class]])
         {
           NSMutableArray *attendees;
           NSDictionary *attendee;
@@ -856,36 +595,4 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     }
 }
 
-- (void) changeParticipationStatus: (NSDictionary *) theValues
-                         inContext: (WOContext *) context
-                         component: (id) component
-{
-  NSString *status;
-  id o;
-
-  // See: https://msdn.microsoft.com/en-us/library/ee202290(v=exchg.80).aspx
-  //
-  // 0 == Free
-  // 1 == Tentative
-  // 2 == Busy
-  // 3 == Out of Office
-  // 4 == Working elsehwere
-  //
-  if ((o = [theValues objectForKey: @"BusyStatus"]))
-    {
-      // We translate >= 2 into ACCEPTED
-      if ([o intValue] == 0)
-        status = @"NEEDS-ACTION";
-      else if ([o intValue] >= 2)
-        status = @"ACCEPTED";
-      else
-        status = @"TENTATIVE";
-
-      // There's no delegate in EAS
-      [(SOGoAppointmentObject *) component changeParticipationStatus: status
-                                                        withDelegate: nil
-                                                               alarm: nil];
-    }
-}
-
 @end

ActiveSync/iCalRecurrenceRule+ActiveSync.m

@@ -140,7 +140,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
           // Simple reccurrence rule of type "Monthly"
           type = 2;
           [s appendFormat: @"<Recurrence_DayOfMonth xmlns=\"Calendar:\">%d</Recurrence_DayOfMonth>",
-             (int)[[[self parent] startDate] dayOfMonth]];
+             [[[self parent] startDate] dayOfMonth]];
         }
     }
   else if ([self frequency] == iCalRecurrenceFrequenceYearly)

ActiveSync/iCalTimeZone+ActiveSync.m

@@ -31,10 +31,15 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include <Foundation/NSArray.h>
 #include <Foundation/NSCalendarDate.h>
+#include <Foundation/NSData.h>
+#include <Foundation/NSDate.h>
 #include <Foundation/NSString.h>
 
 #import <NGCards/iCalByDayMask.h>
 #import <NGCards/iCalTimeZonePeriod.h>
+#import <NGCards/iCalRecurrenceRule.h>
+
+#import <NGExtensions/NGBase64Coding.h>
 
 #include "NSData+ActiveSync.h"
 

ActiveSync/iCalToDo+ActiveSync.m

@@ -29,10 +29,14 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 #import "iCalToDo+ActiveSync.h"
 
+#import <Foundation/NSCalendarDate.h>
+#import <Foundation/NSDate.h>
 #import <Foundation/NSDictionary.h>
+#import <Foundation/NSString.h>
 #import <Foundation/NSTimeZone.h>
 
 #import <NGExtensions/NSString+misc.h>
+#import <NGObjWeb/WOContext.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
 #import <NGObjWeb/WORequest.h>
 
@@ -136,7 +140,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
         {
           [s appendString: @"<Body xmlns=\"AirSyncBase:\">"];
           [s appendFormat: @"<Type>%d</Type>", 1];
-          [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>", (int)[o length]];
+          [s appendFormat: @"<EstimatedDataSize>%d</EstimatedDataSize>", [o length]];
           [s appendFormat: @"<Data>%@</Data>", o];
           [s appendString: @"</Body>"];
         }

Apache/SOGo.conf

@@ -57,6 +57,8 @@ ProxyPreserveHost On
 #   Allow from your-cas-host-addr
 # </Proxy>
 
+ProxyPass /SOGo http://127.0.0.1:20000/SOGo retry=0
+
 # Enable to use Microsoft ActiveSync support
 # Note that you MUST have many sogod workers to use ActiveSync.
 # See the SOGo Installation and Configuration guide for more details.
@@ -65,15 +67,11 @@ ProxyPreserveHost On
 # http://127.0.0.1:20000/SOGo/Microsoft-Server-ActiveSync \
 # retry=60 connectiontimeout=5 timeout=360
 
-ProxyPass /SOGo http://127.0.0.1:20000/SOGo retry=0
-
 <Proxy http://127.0.0.1:20000/SOGo>
 ## adjust the following to your configuration
-## and do not forget to enable the headers module
-<IfModule headers_module>
   RequestHeader set "x-webobjects-server-port" "443"
-#  RequestHeader set "x-webobjects-server-name" "yourhostname"
-#  RequestHeader set "x-webobjects-server-url" "https://yourhostname"
+  RequestHeader set "x-webobjects-server-name" "yourhostname"
+  RequestHeader set "x-webobjects-server-url" "https://yourhostname"
 
 ## When using proxy-side autentication, you need to uncomment and
 ## adjust the following line:
@@ -81,7 +79,6 @@ ProxyPass /SOGo http://127.0.0.1:20000/SOGo retry=0
 #  RequestHeader set "x-webobjects-remote-user" "%{REMOTE_USER}e" env=REMOTE_USER
 
   RequestHeader set "x-webobjects-server-protocol" "HTTP/1.0"
-</IfModule>
 
   AddDefaultCharset UTF-8
 
@@ -93,6 +90,5 @@ ProxyPass /SOGo http://127.0.0.1:20000/SOGo retry=0
 <IfModule rewrite_module>
   RewriteEngine On
   RewriteRule ^/.well-known/caldav/?$ /SOGo/dav [R=301]
-  RewriteRule ^/.well-known/carddav/?$ /SOGo/dav [R=301]
 </IfModule>
 

Documentation/SOGoDevelopersGuide.asciidoc

@@ -1,17 +1,6 @@
-Developer's Guide
-=================
-:toc: left
-:icons: font
-
-////
-
-    This file is part of the SOGo project.
-
-    See docinfo.xml for authors, copyright and license information.
-
-////
-
-include::includes/global-attributes.asciidoc[]
+https://wiki.inverse.ca/focus/SOGo/CodingStyle
+https://wiki.inverse.ca/focus/SOGo/D%C3%A9veloppement
+https://wiki.inverse.ca/focus/PacketFence/Devel/BestPractices
 
 UI and UX
 ---------
@@ -54,14 +43,23 @@ GNUstep
 SOPE
 ~~~~
 
-JavaScript libraries
-~~~~~~~~~~~~~~~~~~~~
+AngularJS
+~~~~~~~~~
 
 * https://angularjs.org/
 * http://angular-ui.github.io/ui-router/
+* https://www.airpair.com/angularjs/posts/angularjs-tutorial
+
+Angular Material
+~~~~~~~~~~~~~~~~
+
 * https://material.angularjs.org/
+
+Lo-Dash
+~~~~~~~
+
 * http://lodash.com/
-* https://github.com/nervgh/angular-file-upload
+* http://underscorejs.org/
 
 Code Style
 ----------
@@ -73,11 +71,6 @@ Objective-C
 
     apidoc -f ".*\\.m" -i UI -o Documentation/JSON-API
 
-* When returning JSON from an object extending UIxComponent, use the following method:
-
-    - (WOResponse *) responseWithStatus: (unsigned int) status
-                  andJSONRepresentation: (NSObject *) contentObject;
-
 HTML
 ~~~~
 
@@ -95,11 +88,8 @@ JavaScript
 ~~~~~~~~~~
 
 * http://eslint.org/
-* http://standardjs.com
 * https://github.com/toddmotto/angularjs-styleguide
 * https://github.com/angular/material/blob/master/docs/guides/CODING.md
-* http://jshint.com/
-* https://github.com/angular/material/tree/master/docs/guides
 
 * We conform to https://github.com/airbnb/javascript[Airbnb coding standards]. Use https://github.com/jscs-dev/node-jscs[jscs] with the 'airbnb' preset to validate your code style:
 
@@ -107,7 +97,7 @@ JavaScript
 
 * For documentation, we follow the http://usejsdoc.org/[JSDoc3] standards:
 
-    jsdoc UI/WebServerResources/js/{Common,Contacts,Mailer,Preferences,Scheduler}/*.js -d Documentation/JavaScript-API
+    jsdoc UI/WebServerResources/js/{Appointments,Common,Contacts,Mailer}/*.js -d Documentation/JavaScript-API
 
 Models (facades)
 ^^^^^^^^^^^^^^^^
@@ -124,13 +114,6 @@ SASS/CSS
 * http://componentcss.com/
 * https://github.com/styleguide/css
 * https://smacss.com/
-* http://cssguidelin.es/
-* http://sixrevisions.com/css/css-methodologies/
-* https://css-tricks.com/what-a-css-code-review-might-look-like/
-* http://una.im/classy-css/
-* http://stylelint.io/
-
-A `@mixin` is like a stamp: it creates a duplicated version of the property block (optionally) with arguments provided. An `@extend` appends the element you are extending to the property block. It is your "yes, and ___" statement.
 
 * For documentation, we follow http://sassdoc.com/[SassDoc] annotations.
 * We need the SASS files of Angular Material to build our CSS. The git repository of Angular Material is included as a submodule of SOGo:
@@ -143,27 +126,14 @@ A `@mixin` is like a stamp: it creates a duplicated version of the property bloc
 Fonts
 ^^^^^
 
-* [Mozilla Fira](http://mozilla.github.io/Fira/)
-* [Material icons](https://www.google.com/design/icons/)
-
-Building frontend
------------------
-
-* Install the latest stable release of https://nodejs.org[Node.js]
-* Install grunt
-
-    npm install -g grunt-cli
-
-* Generate JavaScript files
-
-    cd UI/WebServerResources
-    grunt build
+* We build a custom icons font using the online app https://icomoon.io/app/#/select[icomoon].
+* http://www.carrois.com/fira-4-0/
+* Material Design Iconic Font http://zavoloklom.github.io/material-design-iconic-font/icons.html
 
 Version Control
 ---------------
 
 * https://devcharm.com/articles/46/improve-your-git-workflow/
-* https://github.com/angular/material/blob/master/docs/guides/CONTRIBUTING.md#-commit-message-format
 * Each commit should cover only one thing;
 * Begin the commit message with a single short (less than 50 characters) line summarizing the change, followed by a blank line and then a more thorough description;
 * When fixing a bug, commit to the devel branch as well as the maintenance branch of the latest release version (named maintenance/x.y). When a ticket is associated to the bug, add to the description a line saying *Fixes #1234*.

Documentation/SOGoInstallationGuide.asciidoc

@@ -1,7 +1,5 @@
 Installation and Configuration Guide
 ====================================
-:toc: left
-:icons: font
 
 ////
 
@@ -18,13 +16,13 @@ About this Guide
 
 This guide will walk you through the installation and configuration of
 the SOGo solution. It also covers the installation and configuration of
-SOGo ActiveSync support - the solution used to synchronize mobile
+SOGo ActiveSync support – the solution used to synchronize mobile
 devices with SOGo.
 
 The instructions are based on version {release_version} of SOGo.
 
 The latest version of this guide is available
-at http://sogo.nu/downloads/documentation.html.
+at http://www.sogo.nu/downloads/documentation.html.
 
 Introduction
 ------------
@@ -50,12 +48,13 @@ the SOGo Connector and the SOGo Integrator
 device, or Outlook 2013
 
 SOGo is developed by a community of developers located mainly in North
-America and Europe. More information can be found at http://sogo.nu/
+America and Europe. More information can be found
+at http://www.sogo.nu/
 
 Architecture and Compatibility
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-image::images/architecture.png[System Architecture, 400, 964]
+image::images/architecture.png[System Architecture]
 
 Standard protocols such as CalDAV, CardDAV, GroupDAV, HTTP, IMAP and
 SMTP are used to communicate with the SOGo platform or its
@@ -171,20 +170,20 @@ supported by SOGo:
 * Red Hat Enterprise Linux (RHEL) Server 5, 6 and 7
 * Community ENTerprise Operating System (CentOS) 5, 6 and 7
 * Debian GNU/Linux 6.0 (Squeeze) to 8.0 (Jessie)
-* Ubuntu 12.04 (Precise) to 14.04 (Trusty)
+* Ubuntu 10.04 (Lucid) to 14.04 (Trusty)
 
 Make sure the required components are started automatically at boot time
 and that they are running before proceeding with the SOGo configuration.
 Also make sure that you can install additional packages from your
 standard distribution. For example, if you are using Red Hat Enterprise
-Linux 7, you have to be subscribed to the Red Hat Network before
+Linux 5, you have to be subscribed to the Red Hat Network before
 continuing with the SOGo software installation.
 
-NOTE: This document covers the installation of SOGo under RHEL 7.
+This document covers the installation of SOGo under RHEL 6.
 
 For installation instructions on Debian and Ubuntu, please refer
-directly to the SOGo website at http://sogo.nu/.
-Under the _Support_ section, you will find links for installation steps
+directly to the SOGo website at http://www.sogo.nu/.
+Under the downloads section, you will find links for installation steps
 for Debian and Ubuntu.
 
 Note that once the SOGo packages are installed under Debian and Ubuntu,
@@ -195,7 +194,7 @@ Installation
 
 This section will guide you through the installation of SOGo together
 with its dependencies. The steps described here apply to an RPM-based
-installation for a Red Hat or CentOS 7 distribution. Most of these steps
+installation for a Red Hat or CentOS 6 distribution. Most of these steps
 should apply to all supported operating systems.
 
 Software Downloads
@@ -208,17 +207,19 @@ content:
 ----
 [SOGo]
 name=Inverse SOGo Repository
-baseurl=http://inverse.ca/rhel-v3/7/$basearch
+baseurl=http://inverse.ca/downloads/SOGo/RHEL6/$basearch
 gpgcheck=0
 ----
 
 Some of the softwares on which SOGo depends are available from the
 repository of RepoForge (previously known as RPMforge). To add RepoForge
 to your packages sources, download and install the appropriate RPM
-package from http://packages.sw.be/rpmforge-release/.
+package
+from http://packages.sw.be/rpmforge-release/.
 Also make sure you enabled the "rpmforge-extras" repository.
 
-For more information on using RepoForge, visit http://repoforge.org/use/.
+For more information on using RepoForge,
+visit http://repoforge.org/use/.
 
 Software Installation
 ~~~~~~~~~~~~~~~~~~~~~
@@ -293,7 +294,7 @@ associated to a domain is limited to access only the users data from the
 same domain. Consequently, the configuration parameters of SOGo are
 defined on three levels:
 
-image::images/preferences-hierarchy.png[Preferences Hierarchy, 400, 400]
+image::images/preferences-hierarchy.png[Preferences Hierarchy]
 
 Each level inherits the preferences of the parent level. Therefore,
 domain preferences define the defaults values of the user preferences,
@@ -367,13 +368,6 @@ Defaults to 10 (minutes).
 Do not set this too low as child processes replying to clients on a slow
 internet connection could be killed prematurely.
 
-|S |WOMaxUploadSize
-|Parameter used to set the maximum allowed size for content being
-sent to SOGo using a PUT or a POST call. This can also limit the file
-attachment size being uploaded to SOGo when composing a mail. The
-value is in kilobyte. By default, the value is 0, or disabled so no
-limit will be set.
-
 |S |SxVMemLimit
 |Parameter used to set the maximum amount of memory (in
 megabytes) that a child can use. Reaching that value will force children
@@ -503,8 +497,8 @@ In our example, we set the default domain to `acme.com`.
 meeting participants. Possible values are:
 
 [options="compact"]
-* `YES` - to send notifications
-* `NO` - to not send notifications
+* `YES` – to send notifications
+* `NO` – to not send notifications
 
 Defaults to `NO` when unset.
 
@@ -577,8 +571,6 @@ for SOGo. Possible values are:
 * `Basque`
 * `BrazilianPortuguese`
 * `Catalan`
-* `ChineseTaiwan`
-* `Croatian`
 * `Czech`
 * `Danish`
 * `Dutch`
@@ -589,19 +581,14 @@ for SOGo. Possible values are:
 * `Hungarian`
 * `Icelandic`
 * `Italian`
-* `Lithuanian`
-* `Macedonian`
 * `NorwegianBokmal`
 * `NorwegianNynorsk`
 * `Polish`
-* `Portuguese`
 * `Russian`
 * `Slovak`
-* `Slovenian`
-* `SpanishArgentina`
 * `SpanishSpain`
+* `SpanishArgentina`
 * `Swedish`
-* `TurkishTurkey`
 * `Ukrainian`
 * `Welsh`
 
@@ -610,8 +597,8 @@ for SOGo. Possible values are:
 someone changes his/her own calendar. Possible values are:
 
 [options="compact"]
-- `YES` - to send notifications
-- `NO` - to not send notifications
+- `YES` – to send notifications
+- `NO` – to not send notifications
 
 Defaults to `NO` when unset. User can overwrite this from the calendar
 properties window.
@@ -622,8 +609,8 @@ modification is being done to his/her own calendar by someone else.
 Possible values are:
 
 [options="compact"]
-* `YES` - to send notifications
-* `NO` - to not send notifications
+* `YES` – to send notifications
+* `NO` – to not send notifications
 
 Defaults to `NO` when unset. User can overwrite this from the calendar
 properties window.
@@ -646,8 +633,8 @@ requiring not authentication) their calendars and address books.
 Possible values are:
 
 [options="compact"]
-* `YES` - to allow them
-* `NO` - to prevent them from doing so
+* `YES` – to allow them
+* `NO` – to prevent them from doing so
 
 Defaults to `NO` when unset.
 
@@ -658,8 +645,8 @@ SOGo.
 Possible values are:
 
 [options="compact"]
-* `YES` - to allow them
-* `NO` - to prevent them from doing so
+* `YES` – to allow them
+* `NO` – to prevent them from doing so
 
 Defaults to `NO` when unset.
 
@@ -689,7 +676,7 @@ Defaults to `NO` when unset.
 string (attendee completion, address book search, etc.) prior triggering
 the server-side search operation.
 
-Defaults to `2` when unset - which means a search operation will be
+Defaults to `2` when unset – which means a search operation will be
 triggered on the 3rd typed character.
 
 |S |SOGoMaximumFailedLoginCount
@@ -727,25 +714,6 @@ Default value is `0`, or disabled.
 |Number of seconds, default to `300` (or 5 minutes). Note that
 _SOGoCacheCleanupInterval_ must be set to a value equal or higher than
 _SOGoFailedLoginBlockInterval_.
-
-|S |SOGoMaximumRequestCount
-|Parameter used to control the number of requests a user can send to the SOGo
-server in _SOGoMaximumRequestInterval_ seconds or more. If conditions are met
-or exceeded, the user will not be able to perform requests on the SOGo server
-for _SOGoRequestBlockInterval_ seconds and will receive 429 HTTP responses for
-any requests being made. Default value is 0, or disabled
-
-|S |SOGoMaximumRequestInterval
-|Number of seconds, defaults to `30`.
-
-|S |SOGoRequestBlockInterval
-|Number of seconds, defaults to 300 (or 5 minutes). Note that _SOGoCacheCleanupInterval_
-must be set to a value equal or higher than _SOGoRequestBlockInterval_.
-
-|D |SOGoXSRFValidationEnabled
-|Parameter used to enable or not XSRF (also known as CSRF) protection in SOGo.
-Default value is `NO`, or disabled.
-
 |=======================================================================
 
 Authentication using LDAP
@@ -872,11 +840,11 @@ would be:
     CNFieldName = cn;
     IDFieldName = cn;
     UIDFieldName = cn;
-    baseDN = "ou=groups,dc=inverse,dc=ca";
+    baseDN = "ou=groups,dc=inverse,dc=ca”;
     bindDN = "cn=sogo,ou=services,dc=inverse,dc=ca";
     bindPassword = zot;
     canAuthenticate = YES;
-    displayName = "Inverse Groups";
+    displayName = “Inverse Groups”;
     hostname = ldap://127.0.0.1:389;
     id = inverse_groups;
     isAddressBook = YES;
@@ -898,7 +866,7 @@ source can contain the following values:
 |The type of this user source, set to ldap` for an LDAP source.
 
 |id
-|The identification name of the LDAP repository. This must be unique -
+|The identification name of the LDAP repository. This must be unique –
 even when using multiple domains.
 
 |CNFieldName
@@ -964,8 +932,8 @@ be marked as busy the first time it is booked.
 EOQualifier. The following operators are supported:
 
 [options="compact"]
-* `<>` - inequality operator
-* `=` - equality operator
+* `<>` – inequality operator
+* `=` – equality operator
 
 Multiple qualifiers can be joined by using `OR` and `AND`, they can also
 be grouped together by using parenthesis. Attribute values should be
@@ -1065,10 +1033,6 @@ not work for entries in this source and thus, freebusy lookups.
 |If set as an address book, the human identification name of the LDAP
 repository
 
-|listRequiresDot (optional)
-|If set to `YES`, listing of this LDAP source is only possible when performing a search (respecting the SOGoSearchMinimumWordLength parameter) or when explicitely typing a single dot.
-Defaults to `YES` when unset.
-
 |ModulesConstraints (optional)
 |Limits the access of any module through a constraint based on an LDAP
 attribute; must be a dictionary with keys `Mail`, and/or `Calendar`,
@@ -1141,7 +1105,6 @@ LDAP Attributes Indexing
 To ensure proper performance of the SOGo application, the following LDAP
 attributes must be fully indexed:
 
-[options="compact"]
 * givenName
 * cn
 * mail
@@ -1162,7 +1125,7 @@ fax number, one could map it to the _facsimiletelephonenumber_ attribute
 like this:
 
 ----
-mapping = {
+mapping = \{
   facsimiletelephonenumber = ("fax", "facsimiletelephonenumber");
 };
 ----
@@ -1337,7 +1300,7 @@ If you want to test the IdP-initiated logout using SimpleSAMLphp, you can do so
 the following URL:
 
 ----
-https://idp.example.org/simplesaml/saml2/idp/SingleLogoutService.php?ReturnTo=sogo.nu
+https://idp.example.org/simplesaml/saml2/idp/SingleLogoutService.php?ReturnTo=www.sogo.nu
 ----
 
 In order to relay authentication information to your IMAP server and if
@@ -1359,35 +1322,12 @@ supported, such as MySQL and Oracle.
 First, make sure that your PostgreSQL server has TCP/IP connections
 support enabled.
 
-[TIP]
-===============================
-SOGo stores the database hostname together with table references inside
-several database tables. To prevent possible future issues when moving
-the database to another host, it is best practice to add a local alias name to
-your `/etc/hosts` file, and using this in `/etc/sogo/sogo.conf` instead of the
-actual name of your server or localhost. When the database host name changes,
-you can now simply change the hosts file instead of updating several table
-columns replacing the old hostname. An example entry for `/etc/hosts` when
-running the database on the same host, registering `127.0.0.1` not only for
-`localhost`, but also the `db-alias` alias:
-
- 127.0.0.1		localhost db-alias
-
-In the SOGo configuration, use the alias name instead of the real IP address or
-host name, for example
-
-----
-SOGoProfileURL =
-    "postgresql://sogo:sogo@db-alias:5432/sogo/sogo_user_profile";
-----
-===============================
-
 Create the database user and schema using the following commands:
 
 ----
-su - postgres
-createuser --no-superuser --no-createdb --no-createrole \
-	--encrypted --pwprompt sogo
+su – postgres
+createuser --no-superuser --no-createdb –-no-createrole \
+	–-encrypted --pwprompt sogo
 (specify “sogo” as password)
 createdb -O sogo sogo
 ----
@@ -1442,46 +1382,9 @@ _SOGoEnableEMailAlarms_ is set to `YES`. For PostgreSQL, the database
 URL could be set to something like:
 `postgresql://sogo:sogo@localhost:5432/sogo/sogo_alarms_folder`
 
-|S |OCSStoreURL
-|Parameter used to set the database URL so that SOGo can use to start
-all content data. You must also set `OCSAclURL` and `OCSCacheFolderURL`
-if you set this parameter. Using these parameters will allow SOGo to use
-a total of nine database tables - and prevent SOGo from creating three
-database tables per collection.
-
-For PostgresSQL, set the database URL to something like:
-`postgresql://sogo:@localhost:5432/sogo/sogo_store`.
-
-|S |OCSAclURL
-|Parameter used to set the database URL so that SOGo can use to start
-all ACL data. You must also set `OCSStoreURL` and `OCSCacheFolderURL`
-if you set this parameter.
-
-For PostgresSQL, set the database URL to something like:
-`postgresql://sogo:@localhost:5432/sogo/sogo_acl`.
-
-|S |OCSCacheFolderURL
-|Parameter used to set the database URL so that SOGo can use to start
-all cache data. You must also set `OCSStoreURL` and `OCSAclURL`
-if you set this parameter.
-
-For PostgresSQL, set the database URL to something like:
-`postgresql://sogo:@localhost:5432/sogo/sogo_cache_folder`.
-
 See the "EMail reminders" section in this document for more information.
 |=======================================================================
 
-
-[NOTE]
-Any non-URL safe characters in username/password must be URL-encoded.
-For example, if your SOGo database password is `so%go`, you must set
-the value in your preferences to `so%25go` - where `%` is encoded
-to `%25`.
-
-In addition to the seven tables described above, two other tables get
-created in the database: `sogo_quick_appointment` and `sogo_quick_contact`
-which store calendar and contact information.
-
 If you're using MySQL, make sure in your `my.cnf` file you have:
 
 ----
@@ -1497,72 +1400,6 @@ default-character-set=utf8
 default-character-set=utf8
 ----
 
-MySQL complete Unicode compliance
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-By default MySQL only supports a subset of UTF-8, meaning that characters such
-as emoji are not handled properly.  Some extra steps at installation can be
-undertaken to leverage full Unicode support under MySQL.
-
-IMPORTANT: Switching to complete Unicode compliance on an already-deployed SOGo
-is out of scope of this document, as it would typically involve delicate manual
-operations on the database system.
-
-Requirements:
-
-* MySQL >= 5.5
-* SOGo >= 3.1.0
-
-Strongly suggested MySQL configuration settings (innodb* parameters are
-mandatory):
-
-----
-[client]
-default-character-set          = utf8mb4
-
-[mysql]
-default-character-set          = utf8mb4
-
-[mysqld]
-character-set-client-handshake = FALSE
-character-set-server           = utf8mb4
-collation-server               = utf8mb4_unicode_ci
-innodb_file_per_table          = TRUE
-innodb_file_format             = barracuda
-innodb_large_prefix            = TRUE
-----
-
-CAUTION: Changing InnoDB parameters on an already deployed database server can
-cause severe data loss.  Do not blindly edit MySQL parameters without reading
-and understanding the implication of such changes.
-
-A parameter must be added to `sogo.conf` to turn on complete Unicode
-compliance:
-
-----
-MySQL4Encoding = "utf8mb4";
-----
-
-SOGo automatically creates missing database tables on start but slightly
-different table creation parameters are needed for complete Unicode compliance;
-meaning that before SOGo runs for the first time, all database tables must
-already exist.  A MySQL script to achieve just that is provided in the SOGo
-distribution under `Scripts/mysql-utf8mb4.sql` and you can deploy it with
-a command such as:
-
-----
-mysql -hHOST -uUSER -p -D SOGO < Scripts/mysql-utf8mb4.sql
-----
-
-Where `HOST`, `USER` and `SOGO` are your MySQL host, username and database name
-respectively.
-
-Once SOGo is running, you can test correctness by creating an event such as
-“Lunch with &#127829; and fries” and seeing it properly displayed in the SOGo
-calendar.
-
-Ensure the computer used for the test has emoji fonts installed.
-
 Authentication using SQL
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -1584,7 +1421,7 @@ source can contain the following values:
 |The type of this user source, set to `sql` for a SQL source.
 
 |id
-|The identification name of the SQL repository. This must be unique -
+|The identification name of the SQL repository. This must be unique –
 even when using multiple domains.
 
 |viewURL
@@ -1592,14 +1429,14 @@ even when using multiple domains.
 present. Required columns are:
 
 [options="compact"]
-* `c_uid`: will be used for authentication - it's a username or
+* `c_uid`: will be used for authentication – it's a username or
   username@domain.tld
-* `c_name`: will be used to uniquely identify entries - which can be
+* `c_name`: will be used to uniquely identify entries – which can be
   identical to `c_uid`
 * `c_password`: password of the user, plain text, crypt, md5 or sha
   encoded 
 * `c_cn`: the user's common name
-* `mail`: the user's email address
+* mail : the user's email address
 
 Other columns can exist and will actually be mapped automatically if
 they have the same name as popular LDAP attributes (such as `givenName`,
@@ -1700,14 +1537,14 @@ SOGoUserSources =
 
 Certain database columns must be present in the view/table, such as:
 
-* `c_uid` - will be used for authentication - it's the username
+* `c_uid` – will be used for authentication – it's the username
 or username@domain.tld
-* `c_name` - which can be identical to `c_uid` - will be used to
+* `c_name` – which can be identical to `c_uid` – will be used to
   uniquely identify entries
-* `c_password` - password of the user, plain-text, md5 or sha encoded
+* `c_password` – password of the user, plain-text, md5 or sha encoded
   for now
-* `c_cn` - the user's common name - such as "John Doe"
-* `mail` - the user's mail address
+* `c_cn` – the user's common name – such as "John Doe"
+* `mail` – the user's mail address
 
 Note that groups are currently not supported for SQL-based
 authentication sources.
@@ -1727,8 +1564,8 @@ The following table describes the related parameters.
 are:
 
 [options="compact"]
-* `sendmail` - to use the sendmail binary
-* `smtp` - to use the SMTP protocol
+* `sendmail` – to use the sendmail binary
+* `smtp` – to use the SMTP protocol
 
 |D |SOGoSMTPServer
 |The DNS name or IP address of the SMTP server used when
@@ -1791,16 +1628,6 @@ Defaults to `Trash` when unset.
 Use a `/`  as a hierarchy separator if referring to an IMAP subfolder.
 For example: `INBOX/Trash`.
 
-|U |SOGoJunkFolderName
-|Parameter used to set the IMAP folder name used to store junk
-messages.
-
-Defaults to `Junk` when unset.
-
-Use a `/`  as a hierarchy separator if referring to an IMAP subfolder.
-For example: `INBOX/Junk`. Also see the SOGoMailJunkSettings for
-more options regarding junk/not-junk actions.
-
 |D |SOGoIMAPCASServiceName
 |Parameter used to set the CAS service name (URL) of the imap service.
 This is useful if SOGo is connecting to the IMAP service through a
@@ -1928,11 +1755,6 @@ behaviour of SOGo.
 
 Defaults to `SOGo` when unset.
 
-|S |SOGoHelpURL
-|Parameter used to define the URL to online help for SOGo. When set,
-an additional icon will appear near the logout button in SOGo's
-web interface. The URL will always be open in a separate page.
-
 |U |SOGoLoginModule
 |Parameter used to specify which module to show after login. Possible
 values are:
@@ -1971,17 +1793,7 @@ interface)
 |Parameter used to specify the default order of the columns from the
 SOGo webmail interface. The parameter is an array, for example:
 
-`SOGoMailListViewColumnsOrder = (Flagged, Attachment, Priority, From, Subject, Unread, Date, Size);`
-
-|D |SOGoExternalAvatarsEnabled
-|Parameter used to enable fetching of avatars from remote services.
-
-Defaults to `YES` when unset.
-
-|U |SOGoGravatarEnabled
-|Parameter used to activate fetching of avatars from http://gravatar.com/[Gravatar].
-
-Defaults to `YES` when unset.
+ SOGoMailListViewColumnsOrder = (Flagged, Attachment, Priority, From, Subject, Unread, Date, Size);
 
 |D |SOGoVacationEnabled
 |Parameter used to activate the edition from the preferences window of a
@@ -2270,21 +2082,7 @@ Defaults to `%{FolderName} (%{UserName} <%{Email}>)` when unset.
 the template named `UIxAdditionalPreferences.wox`. This template should
 be put under `~sogo/GNUstep/Library/SOGo/Templates/PreferencesUI/`.
 
-|D |SOGoMailJunkSettings
-|Parameter used to enable email junk settings. The value is a dictionary
-and the follow keys are supported: `vendor` (which must be set to "generic"
-for now), `junkEmailAddress` which sets the email address to whom SOGo will
-send junk mails to, `notJunkEmailAddress` which sets the email address to
-whome SOGo will send non-junk mails to and `limit`, which is an integer value
-and sets the maximum number of mails that will be attached to a
-junk/not junk report sent by SOGo. Example: `SOGoMailJunkSettings = {
-vendor = "generic"; junkEmailAddress = "spam@foo.com";
-notJunkEmailAddress = "ham@foo.com"; limit = 10;
-};`
-
-|D |SOGoMailKeepDraftsAfterSend
-|Parameter used to keep mails in the drafts folder once they have been
-sent by SOGo. Defaults to `NO` when unset.
+Defaults to `NO` when unset.
 |=======================================================================
 
 SOGo Configuration Summary
@@ -2313,7 +2111,6 @@ like this:
     SOGoDraftsFolderName = Drafts;
     SOGoSentFolderName = Sent;
     SOGoTrashFolderName = Trash;
-    SOGoJunkFolderName = Junk;
     SOGoMailingMechanism = smtp;
     SOGoSMTPServer = 127.0.0.1;
     SOGoUserSources = (
@@ -2454,7 +2251,7 @@ RequestHeader set "x-webobjects-server-url" "http://yourhostname"
 You may consider enabling SSL on top of this current installation to
 secure access to your SOGo installation.
 
-See http://httpd.apache.org/docs/2.4/ssl/ for details.
+See http://httpd.apache.org/docs/2.2/ssl/ for details.
 
 You might also have to adjust the configuration if you have SELinux
 enabled.
@@ -2469,13 +2266,13 @@ Starting Services
 Once SOGo if fully installed and configured, start the services using
 the following command:
 
- systemctl start sogod.service
+ service sogod start
 
-You may verify using the `systemctl is-enabled sogod` command that the SOGo
-service is automatically started at boot time. Restart the Apache service since
+You may verify using thechkconfigcommand that the SOGo service is
+automatically started at boot time. Restart the Apache service since
 modules and configuration files were added:
 
- systemctl restart httpd.service
+ service httpd restart
 
 Finally, you should also make sure that the `memcached` service is
 started and that it is also automatically started at boot time.
@@ -2819,7 +2616,7 @@ your site. However, be aware that in order to use the SOGo Integrator
 plug in, you will need to repackage it with specific modifications.
 Please refer to the documentation published online:
 
-http://sogo.nu/downloads/documentation.html
+http://www.sogo.nu/downloads/documentation.html
 
 If you only use the SOGo Connector plug in, you can still easily access
 your data.

Documentation/SOGoMobileDevicesConfigurationGuide.asciidoc

@@ -1,7 +1,5 @@
 Mobile Devices Configuration Guide
 ==================================
-:toc: left
-:icons: font
 
 ////
 

Documentation/SOGoMozillaThunderbirdConfigurationGuide.asciidoc

@@ -1,7 +1,5 @@
 Mozilla Thunderbird Configuration Guide
 =======================================
-:toc: left
-:icons: font
 
 ////
 
@@ -90,7 +88,7 @@ fixes from the current development version of Mozilla Lightning. For
 Thunderbird 2, it is based on release version 0.9 of Lightning. For
 Thunderbird 3.1, it is based on 1.0b2.
 
-In order to download and install Mozilla Lightning - Inverse Edition for
+In order to download and install Mozilla Lightning – Inverse Edition for
 Thunderbird 2 or 3.1, please visit:
 
 http://www.sogo.nu/downloads/frontends.html
@@ -138,7 +136,7 @@ extensions, please visit:
 http://www.sogo.nu/downloads/frontends.html
 
 Prior to installing the SOGo Integrator extension, you should read the
-following chapter - _SOGo Integrator Customization_.
+following chapter – _SOGo Integrator Customization_.
 
 SOGo Integrator Customization
 -----------------------------
@@ -197,7 +195,7 @@ if the SOGo server is accessible from the following URL:
 
 Note that if you changed the `x-webobjects-server-url` configuration
 setting from your HTTP server configuration file for SOGo, the
-value *must* match the one you specify in `isi:updateURL` - even the
+value *must* match the one you specify in `isi:updateURL` – even the
 port number.
 
 Moreover, you *must* change the value of the
@@ -218,7 +216,7 @@ In this section, you will learn how to install and configure the SOGo
 Update Server.
 
 The SOGo Update Server can be used to automatically install or uninstall
-Mozilla Thunderbird extensions, push user settings and more - all from a
+Mozilla Thunderbird extensions, push user settings and more – all from a
 central place managed by system administrators.
 
 Installation

Documentation/SOGoNativeOutlookConfigurationGuide.asciidoc

@@ -1,7 +1,5 @@
 Native Microsoft Outlook Configuration Guide
 ============================================
-:toc: left
-:icons: font
 
 ////
 
@@ -144,7 +142,7 @@ to authenticate users. A SOGoUserSources entry to achieve this wold look
 like this:
 
 ----
-su - sogo
+su – sogo
 defaults write sogod SOGoUserSources '(
     {
         CNFieldName = displayName;
@@ -235,7 +233,6 @@ Installation
 This section will guide you through the installation of the native
 Microsoft Outlook compatibility layer SOGo offers.
 
-////
 Red Hat Enterprise Linux v6 x86_64
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -247,7 +244,7 @@ http://www.sogo.nu/english/downloads/backend.html.
 In order to satisfy certain dependencies, you should also add the EPEL
 source corresponding to your distribution and architecture. More
 information on this is available here:
-http://fedoraproject.org/wiki/EPEL - or more specifically,
+http://fedoraproject.org/wiki/EPEL – or more specifically,
 http://fedoraproject.org/wiki/EPEL/FAQ#How_can_I_install_the_packages_from_the_EPEL_software_repository.3F.
 
 Once ready, install the OpenChange packages on top of an existing SOGo
@@ -319,7 +316,7 @@ from this guide.
 On Ubuntu 12.04, the Samba init scripts need to be modified to
 disable the upstart check. For more details, refer to:
 https://wiki.samba.org/index.php/Samba4/InitScript
-////
+
 
 Debian 8 (Jessie) and Ubuntu 14.04 (Trusty Tahr)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -390,7 +387,7 @@ Run the following commands as root:
 
 ----
 samba-tool domain provision --realm=example.com \
-          --domain=EXAMPLE \
+          --domain=OPENCHANGE \
           --adminpass='%1OpenChange' \
           --server-role='domain controller'
 
@@ -398,7 +395,7 @@ samba-tool user setexpiry administrator --noexpiry
 ----
 
 You might consider changing the realm and domain used, to suit your
-environment.
+enviroment.
 
 You might also have to
 remove `/etc/samba/smb.conf` prior running this command.
@@ -444,7 +441,7 @@ Your Samba 4 configuration file should look like this:
 OpenChange Configuration
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
-Since v2.2, OpenChange stores its metadata in MySQL so you need to have it installed.
+OpenChange 2.2 stores its metadata in MySQL so you need to have it installed.
 
 First, create the OpenChange MySQL user:
 
@@ -515,11 +512,9 @@ mapistore:indexing_backend = mysql://openchange-user:openchange$123@localhost/op
 mapiproxy:openchangedb = mysql://openchange-user:openchange$123@localhost/openchange
 ----
 
-////
 On RHEL, make sure SELinux is disabled:
 
  setenforce 0
-////
 
 Next, you can start Samba using the usual command:
 
@@ -550,11 +545,9 @@ This service runs as a WSGI application under apache (mod_wsgi).
 While HTTPS is not required to access this service, it is strongly
 recommended.
 
-////
 On RHEL-based distributions, the apache configuration required by these
 services can be found in `/etc/httpd/conf.d/ocsmanager.conf` and
 `/etc/httpd/conf.d/rpcproxy.conf`.
-////
 
 For Debian-based distributions, these files can be found
 in `/etc/apache2/conf.d/` or `/etc/apache2/conf-available`.
@@ -570,10 +563,8 @@ The OCS Manager and RPC Proxy configuration module can be enabled using:
  a2enconf ocsmanager
  a2enconf rpcproxy
 
-////
 On RHEL-based distributions, make sure the `LoadModule` directive is
 uncommented in `/etc/httpd/conf.d/wsgi.conf`.
-////
 
 The _reqtimeout_ apache module is known to cause problems when using the
 default configuration shipped with Debian-based systems. On such
@@ -589,12 +580,10 @@ To avoid this problem, use a much higher timeout or disable the module:
  a2dismod reqtimeout
 
 You should now restart the Apache service and make sure it will start on
-boot.
-////
-On RHEL-based distributions, do:
+boot. On RHEL-based distributions, do:
 
  chkconfig httpd on && /etc/init.d/httpd restart
-////
+
 On Debian-based distributions, do:
 
  update-rc.d apache2 defaults && /etc/init.d/apache2 restart
@@ -722,7 +711,7 @@ Adding Users
 ------------
 
 Users that wish to connect natively to SOGo must be provisioned in
-Samba 4 and in OpenChange - even if they already exist in your current
+Samba 4 and in OpenChange – even if they already exist in your current
 LDAP or Microsoft Active Directory server.
 
 To add a user, execute the following commands: 
@@ -820,10 +809,11 @@ can be ignored for now. This feature is currently not supported.
 remove any data associated with the user from the SOGo server and
 recreate a Microsoft Outlook profile.
 To remove any data associated to a user, use
-the `openchange_user_cleanup` script distributed with OpenChange. The script
-can be found in `/usr/share/openchange/`.
+the `openchange_user_cleanup` script distributed with SOGo. The script
+can be found in `/usr/share/doc/sogo/` (`/usr/share/sogo-VERSION/` on
+RHEL).
 To reset a user, run the script as root:
-`openchange_user_cleanup username`. See the usage output for additional options.
+`python openchange_user_cleanup username`. See the usage output for additional options.
 * The "Out of Office Assistant" will not currently work. This feature
 has not been implemented.
 * Creating folders below INBOX (when not normally permitted by the IMAP

Documentation/docinfo.xml

@@ -1,7 +1,7 @@
 <!-- TODO have the build system take care of this  -->
-<releaseinfo>Version 3.1.1 - June 2016</releaseinfo>
-<subtitle>for version 3.1.1</subtitle>
-<date>2016-06-02</date>
+<releaseinfo>Version 2.3.1 - July 2015</releaseinfo>
+<subtitle>for version 2.3.1</subtitle>
+<date>2015-07-23</date>
 
 <legalnotice>
   <para>Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.2 or any later version published by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts. A copy of the license is included in the section entitled "GNU Free Documentation License".</para>

Documentation/includes/additional-info.asciidoc

@@ -6,7 +6,7 @@
     Authors: 
       - Inverse inc. <info@inverse.ca>
 
-    Copyright (C) 2008-2016 Inverse inc.
+    Copyright (C) 2008-2014 Inverse inc.
     License: GFDL 1.2 or later. http://www.gnu.org/licenses/fdl.html
 
 ////
@@ -17,7 +17,7 @@ Additional Information
 For more information, please consult the online FAQs (Frequently Asked
 Questions) :
 
-http://sogo.nu/support/faq.html
+http://www.sogo.nu/english/support/faq.html
 
 You can also read the mailing archives or post your questions to it. For
 details, see :

Documentation/includes/global-attributes.asciidoc

@@ -6,13 +6,13 @@
     Authors:
       - Inverse inc. <info@inverse.ca>
 
-    Copyright (C) 2008-2016 Inverse inc.
+    Copyright (C) 2008-2015 Inverse inc.
     License: GFDL 1.2 or later. http://www.gnu.org/licenses/fdl.html
 
 ////
 
 // TODO have the build system take care of this
 
-:release_version: 3.1.1
+:release_version: 2.3.1
 
 // vim: set syntax=asciidoc tabstop=2 shiftwidth=2 expandtab:

Main/MainUIProduct.m

@@ -19,6 +19,7 @@
   02111-1307, USA.
 */
 
+#import <Foundation/NSObject.h>
 
 @interface MainUIProduct : NSObject
 {
@@ -26,6 +27,7 @@
 
 @end
 
+#import <Foundation/Foundation.h>
 
 @implementation MainUIProduct
 

Main/NSException+Stacktrace.h

@@ -20,6 +20,7 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#import <Foundation/NSException.h>
 
 @interface NSException (SOGoExtensions)
 

Main/NSException+Stacktrace.m

@@ -19,6 +19,7 @@
  * the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  * Boston, MA 02111-1307, USA.
  */
+#include <execinfo.h>
 
 #import "NSException+Stacktrace.h"
 

Main/SOGo+DAV.m

@@ -18,12 +18,18 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#import <Foundation/NSDictionary.h>
+#import <Foundation/NSEnumerator.h>
 
 #import <NGObjWeb/NSException+HTTP.h>
 #import <NGObjWeb/SoObject+SoDAV.h>
 #import <NGObjWeb/WOContext+SoObjects.h>
+#import <NGObjWeb/WORequest.h>
 #import <NGExtensions/NSObject+Logs.h>
 
+#import <DOM/DOMDocument.h>
+#import <DOM/DOMNode.h>
+#import <DOM/DOMProtocols.h>
 #import <SaxObjC/XMLNamespaces.h>
 
 #import <SOGo/NSArray+Utilities.h>
@@ -261,7 +267,7 @@
   NSObject <DOMNodeList> *list;
   NSObject <DOMNode> *valueNode;
   NSArray *elements;
-  NSString *property=nil, *match=nil;
+  NSString *property, *match;
 
   list = [searchElement getElementsByTagName: @"prop"];
   if ([list length])

Main/SOGo.h

@@ -1,5 +1,6 @@
 /*
-  Copyright (C) 2005-2016 Inverse inc.
+  Copyright (C) 2005-2010 Inverse inc.
+  Copyright (C) 2004-2005 SKYRIX Software AG
 
   This file is part of SOGo.
 
@@ -26,6 +27,7 @@
 
 @class NSArray;
 @class NSDictionary;
+@class NSMutableDictionary;
 
 @class SOGoCache;
 

Main/SOGo.m

@@ -1,5 +1,6 @@
 /*
-  Copyright (C) 2005-2016 Inverse inc.
+  Copyright (C) 2005-2014 Inverse inc.
+  Copyright (C) 2004-2005 SKYRIX Software AG
 
   This file is part of SOGo
 
@@ -19,11 +20,18 @@
   02111-1307, USA.
 */
 
+#import <Foundation/NSAutoreleasePool.h>
+#import <Foundation/NSDebug.h>
+#import <Foundation/NSData.h>
+#import <Foundation/NSDate.h>
+#import <Foundation/NSEnumerator.h>
+#import <Foundation/NSProcessInfo.h>
+#import <Foundation/NSRunLoop.h>
+#import <Foundation/NSURL.h>
 
 #import <GDLAccess/EOAdaptorChannel.h>
 #import <GDLContentStore/GCSChannelManager.h>
 #import <GDLContentStore/GCSFolderManager.h>
-#import <GDLContentStore/GCSFolderType.h>
 #import <GDLContentStore/GCSAlarmsFolder.h>
 #import <GDLContentStore/GCSSessionsFolder.h>
 
@@ -50,6 +58,7 @@
 #import <SOGo/SOGoPublicBaseFolder.h>
 #import <SOGo/SOGoProductLoader.h>
 #import <SOGo/SOGoProxyAuthenticator.h>
+#import <SOGo/SOGoUserFolder.h>
 #import <SOGo/SOGoUser.h>
 #import <SOGo/SOGoSystemDefaults.h>
 #import <SOGo/SOGoWebAuthenticator.h>
@@ -211,94 +220,36 @@ static BOOL debugLeaks;
   [cm releaseChannel: tc];
 }
 
-- (void) _checkQuickTableWithTypeName: typeName
-                               withCm: (GCSChannelManager *) cm
-                             tableURL: (NSString *) url
-{
-  GCSFolderType *type;
-  NSString *sql;
-  NSString *tableName;
-  EOAdaptorChannel *channel;
-
-  channel = [cm acquireOpenChannelForURL: [NSURL URLWithString: url]];
-
-  tableName = [NSString stringWithFormat: @"sogo_quick_%@", typeName];
-  sql = [NSString stringWithFormat: @"SELECT count(*) FROM %@",
-                  tableName];
-  if ([channel evaluateExpressionX: sql])
-    {
-      type = [GCSFolderType folderTypeWithName: typeName];
-      if (type)
-        {
-          sql = [type sqlQuickCreateWithTableName: tableName];
-          if (![channel evaluateExpressionX: sql])
-            [self logWithFormat: @"sogo quick table %@ successfully created!",
-                  tableName];
-        }
-    }
-  else
-    [channel cancelFetch];
-
-  [cm releaseChannel:channel];
-}
-
-
-//
-// If OCSStoreURL is defined, we also check for OCSAclURL, OCSCacheFolderURL
-// and we create the combined quick tables.
-//
 - (BOOL) _checkMandatoryTables
 {
   GCSChannelManager *cm;
   GCSFolderManager *fm;
-  NSArray *urlStrings;
-  NSArray *quickTypeStrings;
-  NSString *tmp, *value;
+  NSString *urlStrings[] = {@"SOGoProfileURL", @"OCSFolderInfoURL", nil};
+  NSString **urlString;
+  NSString *value;
   SOGoSystemDefaults *defaults;
-  NSEnumerator *e;
-  BOOL ok, combined;
+  BOOL ok;
 
   defaults = [SOGoSystemDefaults sharedSystemDefaults];
   ok = YES;
-
-  if ([GCSFolderManager singleStoreMode])
-    {
-      urlStrings = [NSArray arrayWithObjects: @"SOGoProfileURL", @"OCSFolderInfoURL", @"OCSStoreURL", @"OCSAclURL", @"OCSCacheFolderURL", nil];
-      quickTypeStrings = [NSArray arrayWithObjects: @"contact", @"appointment", nil];
-      combined = YES;
-    }
-  else
-    {
-      urlStrings = [NSArray arrayWithObjects: @"SOGoProfileURL", @"OCSFolderInfoURL", nil];
-      combined = NO;
-    }
-
   cm = [GCSChannelManager defaultChannelManager];
 
-  e = [urlStrings objectEnumerator];
-  while (ok && (tmp = [e nextObject]))
+  urlString = urlStrings;
+  while (ok && *urlString)
     {
-      value = [defaults stringForKey: tmp];
+      value = [defaults stringForKey: *urlString];
       if (value)
-	  [self _checkTableWithCM: cm tableURL: value andType: tmp];
+	{
+	  [self _checkTableWithCM: cm tableURL: value andType: *urlString];
+	  urlString++;
+	}
       else
 	{
-	  [self errorWithFormat: @"No value specified for '%@'", tmp];
+	  [self errorWithFormat: @"No value specified for '%@'", *urlString];
 	  ok = NO;
 	}
     }
 
-  if (combined)
-    {
-      e = [quickTypeStrings objectEnumerator];
-      while ((tmp = [e nextObject]))
-        {
-          [self _checkQuickTableWithTypeName: tmp
-                                      withCm: cm
-                                    tableURL: [defaults stringForKey: @"OCSFolderInfoURL"]];
-        }
-    }
-
   if (ok)
     {
       fm = [GCSFolderManager defaultFolderManager];
@@ -474,12 +425,8 @@ static BOOL debugLeaks;
 {
   static NSArray *runLoopModes = nil;
   static BOOL debugOn = NO;
-
-  SOGoSystemDefaults *sd;
   WOResponse *resp;
   NSDate *startDate;
-  NSString *path;
-
   NSTimeInterval timeDelta;
 
   if (debugRequests)
@@ -489,7 +436,6 @@ static BOOL debugLeaks;
       startDate = [NSDate date];
     }
 
-  sd = [SOGoSystemDefaults sharedSystemDefaults];
   cache = [SOGoCache sharedCache];
 #ifdef GNUSTEP_BASE_LIBRARY
   if (debugLeaks)
@@ -504,64 +450,6 @@ static BOOL debugLeaks;
     }
 #endif
 
-  // We check for rate-limiting settings - ignore anything actually
-  // sent to /SOGo/ (so unauthenticated requests).
-  path = [_request requestHandlerPath];
-  if ([path length] && [sd maximumRequestCount] > 0)
-    {
-      NSDictionary *requestCount;
-      NSString *username;
-      NSRange r;
-
-      r = [path rangeOfString: @"/"];
-
-      // We handle /sogo1/Calendar/.../ and "sogo1" as paths
-      if (r.length)
-        username = [path substringWithRange: NSMakeRange(0, r.location)];
-      else
-        username = path;
-
-      requestCount = [cache requestCountForLogin: username];
-
-      if (requestCount)
-        {
-          unsigned int  current_time, start_time, delta, block_time, request_count;
-
-          current_time = [[NSCalendarDate date] timeIntervalSince1970];
-          start_time = [[requestCount objectForKey: @"InitialDate"] unsignedIntValue];
-          delta = current_time - start_time;
-
-          block_time = [sd requestBlockInterval];
-          request_count = [[requestCount objectForKey: @"RequestCount"] intValue];
-
-          if ( request_count >= [sd maximumRequestCount] &&
-               delta < [sd maximumRequestInterval] &&
-               delta <= block_time )
-            {
-              resp = [WOResponse responseWithRequest: _request];
-              [resp setStatus: 429];
-              return resp;
-            }
-
-          if (delta > block_time)
-            {
-              [cache setRequestCount: 1
-                            forLogin: username
-                            interval: current_time];
-            }
-          else
-            [cache setRequestCount: (request_count+1)
-                          forLogin: username
-                          interval: start_time];
-        }
-      else
-        {
-          [cache setRequestCount: 1
-                        forLogin: username
-                        interval: 0];
-        }
-    }
-
   resp = [super dispatchRequest: _request];
   [cache killCache];
 

Main/sogod.m

@@ -21,8 +21,10 @@
 */
 
 #include <unistd.h>
+#include <sys/types.h>
 
 #import <Foundation/NSAutoreleasePool.h>
+#import <Foundation/NSString.h>
 #import <Foundation/NSTimeZone.h>
 
 #import <NGObjWeb/SoApplication.h>

NEWS

@@ -1,343 +1,12 @@
-3.1.1 (2016-06-02)
+2.3.x (2015-MM-DD)
 ------------------
 
-Enhancements
- - [web] expose all email addresses in autocompletion of message editor (#3443)
- - [web] Gravatar service can now be disabled (#3600)
- - [web] collapsable mail accounts (#3493)
- - [web] show progress indicator when loading messages and cards
- - [web] display messages sizes in list of Mail module
- - [web] link event's attendees email addresses to mail composer
- - [web] respect SOGoSearchMinimumWordLength when searching for events or tasks
- - [web] updated CKEditor to version 4.5.9
- - [web] CKEditor: switched to the minimalist skin
- - [web] CKEditor: added the base64image plugin
-
-Bug fixes
- - [core] strip X- tags when securing content (#3695)
- - [web] fixed creation of chip on blur (sgTransformOnBlur directive)
- - [web] fixed composition of new messages from Contacts module
- - [web] fixed autocompletion of LDAP-based groups (#3673)
- - [web] fixed month view when current month covers six weeks (#3663)
- - [web] fixed negative offset when converting a regular event to an all-day event (#3655)
- - [web] fixed event classification icon (private/confidential) in day/week/multicolumn views
- - [web] fixed display of mailboxes list on mobiles (#3654)
- - [web] restored Catalan and Slovak translations (#3687)
- - [web] fixed restore of mailboxes expansion state when multiple IMAP accounts are configured
- - [web] improved CSS sanitizer for HTML messages (#3700)
- - [web] fixed toolbar of mail editor when sender address was too long (#3705)
- - [web] fixed decoding of filename in attachments (quotes and Cyrillic characters) (#2272)
- - [web] fixed recipients when replying from a message in the Sent mailbox (#2625)
- - [eas] when using EAS/ItemOperations, use IMAP PEEK operation
-
-3.1.0 (2016-05-18)
-------------------
-
-New features
- - [core] new database structure options to make SOGo use a total of nine tables
- - [core] new user-based rate-limiting support for all SOGo requests (#3188)
- - [web] toolbar of all-day events can be expanded to display all events
- - [web] added AngularJS's XSRF support (#3246)
- - [web] calendars list can be reordered and filtered
- - [web] user can limit the calendars view to specific week days (#1841)
-
-Enhancements
- - [web] updated Angular Material to version 1.1.0rc4
- - [web] added Lithuanan (lt) translation - thanks to Mantas Liobė
- - [web] added Turkish (Turkey) (tr_TR) translation - thanks to Sinan Kurşunoğlu
- - [web] we now "cc" delegates during invitation updates (#3195)
- - [web] new SOGoHelpURL preference to set a custom URL for SOGo help (#2768)
- - [web] now able to copy/move events and also duplicate them (#3196)
- - [web] improved preferences validation and now check for unsaved changes
- - [web] display events and tasks priorities in list and day/week views (#3162)
- - [web] style events depending on the user participation state
- - [web] style transparent events (show time as free) (#3192)
- - [web] improved input parsing of time picker (#3659)
- - [web] restored support for Web calendars that require authentication
-
-Bug fixes
- - [core] properly escape wide characters (#3616)
- - [core] avoid double-appending domains in cache for multi-domain configurations (#3614)
- - [core] fixed multidomain issue with non-unique ID accross domains (#3625)
- - [core] fixed bogus headers generation when stripping folded bcc header (#3664)
- - [core] fixed issue with multi-value org units (#3630)
- - [core] sanity checks for events with bogus timezone offsets
- - [web] fixed missing columns in SELECT statements (PostgreSQL)
- - [web] fixed display of ghosts when dragging events
- - [web] fixed management of mail labels in Preferences module
- - [web] respect super user privileges to create in any calendar and addressbook (#3533)
- - [web] properly null-terminate IS8601-formatted dates (#3539)
- - [web] display CC/BCC fields in message editor when initialized with values
- - [web] fixed message initialization in popup window (#3583)
- - [web] create chip (recipient) on blur (#3470)
- - [web] fixed position of warning when JavaScript is disabled (#3449)
- - [web] respect the LDAP attributes mapping in the list view
- - [web] handle empty body data when forwarding mails (#3581)
- - [web] show repeating events when we ask for "All" or "Future" events (#69)
- - [web] show the To instead of From when we are in the Sent folder (#3547)
- - [web] fixed handling of mail tags in mail viewer
- - [web] avoid marking mails as read when archiving a folder (#2792)
- - [web] fixed crash when sending a message with a special priority
- - [web] fixed saving of a custom weekly recurrence definition
- - [web] properly escape the user's display name (#3617)
- - [web] avoid returning search results on objects without read permissions (#3619)
- - [web] restore priority of event or task in component editor
- - [web] fixed menu content visibility when printing an email (#3584)
- - [web] retired CSS reset so the style of HTML messages is respected (#3582)
- - [web] fixed messages archiving as zip file
- - [web] adapted time picker to match changes of md calendar picker
- - [web] fixed sender addresses of draft when using multiple IMAP accounts (#3577)
- - [web] create a new message when clicking on a "mailto" link (#3588)
- - [web] fixed handling of Web calendars option "reload on login"
- - [web] add recipient chip when leaving an input field (to/cc/bcc) (#3470)
- - [dav] we now handle the default classifications for tasks (#3541)
- - [eas] properly unfold long mail headers (#3152)
- - [eas] correctly set EAS message class for S/MIME messages (#3576)
- - [eas] handle FilterType changes using EAS (#3543)
- - [eas] handle Dovecot's mail_shared_explicit_inbox parameter
- - [eas] prevent concurrent Sync ops from same device (#3603)
- - [eas] handle EAS loop termination when SOGo is being shutdown (#3604)
- - [eas] now cache heartbeat interval and folders list during Ping ops (#3606)
- - [eas] sanitize non-us-ascii 7bit emails (#3592)
- - [eas] properly escape organizer name (#3615)
- - [eas] correctly set answered/forwarded flags during smart operations
- - [eas] don't mark calendar invitations as read when fetching messages
-
-3.0.2 (2016-03-04)
-------------------
-
-New features
- - [web] show all/only this calendar
- - [web] convert a message to an appointment or a task (#1722)
- - [web] customizable base font size for HTML messages
- - [web you can now limit the file upload size using the WOMaxUploadSize
-   configuration parameter (integer value in kilobytes) (#3510, #3135)
-
-Enhancements
- - [web] added Junk handling feature from v2
- - [web] updated Material Icons font to version 2.1.3
- - [web] don't offer forward/vacation options in filters if not enabled
- - [web] mail filters are now sortable
- - [web] now supports RFC6154 and NoInferiors IMAP flag
- - [web] improved confirm dialogs for deletions
- - [web] allow resources to prevent invitations (#3410)
- - [web] warn when double-booking attendees and offer force save option
- - [web] list search now displays a warning regarding the minlength constraint
- - [web] loading an LDAP-based addressbook is now instantaneous when listRequiresDot is disabled (#438, #3464)
- - [web] improve display of messages with many recipients
- - [web] colorize categories chips in event and task viewers
- - [web] initial stylesheet for printing (#3484)
- - [web] updated lodash to version 4.6.1
- - [i18n] updated French and Finnish translations
- - [eas] now support EAS MIME truncation
-
-Bug fixes
- - [web] handle birthday dates before 1970 (#3567)
- - [web] safe-guarding against bogus value coming from the quick tables
- - [web] apply search filters when automatically reloading current mailbox (#3507)
- - [web] fixed virtual repeater when moving up in messages list
- - [web] really delete mailboxes being deleted from the Trash folder (#595, #1189, #641)
- - [web] fixed address autocompletion of mail editor affecting cards list of active addressbook
- - [web] fixed batched delete of components (#3516)
- - [web] fixed mail draft autosave in preferences (#3519)
- - [web] fixed password change (#3496)
- - [web] fixed saving of notification email for calendar changes (#3522)
- - [web] fixed ACL editor for authenticated users in Mail module
- - [web] fixed fab button position in Calendar module (#3462)
- - [web] fixed default priority of sent messages (#3542)
- - [web] removed double-quotes from Chinese (Taiwan) translations that were breaking templates
- - [web] fixed unseen count retrieval of nested IMAP folders
- - [web] properly extract the mail column values from an SQL contacts source (#3544)
- - [web] fixed incorrect date formatting when timezone was after UTC+0 (#3481, #3494)
- - [web] replaced checkboxes in menu by a custom checkmark (#3557)
- - [web] fixed attachments display when forwarding a message (#3560)
- - [web] activate new calendar subscriptions by default
- - [web] keep specified task status when not completed (#3499)
- - [eas] allow EAS attachments get on 2nd-level mailboxes (#3505)
- - [eas] fix EAS bday shift (#3518)
- - [eas] encode CR in EAS payload (#3626)
-
-3.0.1 (2016-02-05)
-------------------
-
-Enhancements
- - [web] improved scrolling behavior when deleting a single message (#3489)
- - [web] added "Move To" option for selected messages (#3477)
- - [web] updated CKEditor to version 4.5.7
- - [web] updated Angular Material to 1.0.5
- - [web/eas] add shared/public namespaces in the list or returned folders
-
-Bug fixes
- - [web] safeguard against mailboxes with no quota (#3468)
- - [web] fixed blank calendar view when selecting "Descending Order" in the sort menu
- - [web] show active user's default email address instead of system email address (#3473)
- - [web] fixed display of HTML tags when viewing a message raw source (#3490)
- - [web] fixed IMIP accept/decline when there is only one MIME part
- - [web] improved handling of IMAP connection problem in Web interface
- - [web] fixed frequency parsing of recurrence rule when saving new appointment (#3472)
- - [web] added support for %p in date formatting (#3480)
- - [web] make sure an email is defined before trying to use it (#3488)
- - [web] handle broken messages that have no date (#3498)
- - [web] fixed virtual-repeater display in Webmail when a search is performed (#3500)
- - [web] fixed drag'n'drop of all-day events in multicolumn view
- - [eas] correctly encode filename of attachments over EAS (#3491)
-
-3.0.0 (2016-01-27)
-------------------
-
-New features
- - complete rewrite of the JavaScript frontend using Angular and AngularMaterial
- - responsive design and accessible options focused on mobile devices
- - horizontal 3-pane view for a better experience on large desktop screens
- - new color palette and better contrast ratio as recommended by the W3C
- - improved accessibility to persons with disabilities by enabling common ARIA attributes
- - use of Mozilla's Fira Sans typeface
- - and many more!
-
-2.3.7 (2016-01-25)
-------------------
-
-New features
- - new junk/not junk capability with generic SMTP integration
-
-Enhancements
- - newly created folders using EAS are always sync'ed by default (#3454)
- - added Croatian (hr_HR) translation - thanks to Jens Riecken
-
-Bug fixes
- - now always generate invitation updates when using EAS
- - rewrote the string sanitization to be 32-bit Unicode safe
- - do not try to decode non-wbxml responses for debug output (#3444)
-
-2.3.6 (2016-01-18)
-------------------
-
-New features
- - now able to sync only default mail folders when using EAS
-
-Enhancements
- - Unit testing for RTFHandler
- - JUnit output for sogo-tests
-
-Bug fixes
- - don't unescape twice mail folder names (#3423)
- - don't consider mobile Outlook EAS clients as DAV ones (#3431)
- - we now follow 301 redirects when fetching ICS calendars
- - when deleting an event using EAS, properly invoke the auto-scheduling code
- - do not include failure attachments (really long filenames)
- - fix encoding of email subjects with non-ASCII characters
- - fix appointment notification mails using SOGoEnableDomainBasedUID configuration
- - fix shifts in event times on Outlook
-
-2.3.5 (2016-01-05)
-------------------
-
-Enhancements
- - return an error to openchange if mail message delivery fails
- - return the requested elements on complex requests from Outlook when downloading changes
- - user sources can be loaded dynamically
- - unify user sources API
- - updated Russian translation (#3383)
-
-Bug fixes
- - properly compute the last week number for the year (#1010)
- - share calendar, tasks and contacts folders in Outlook 2013 with editor permissions
- - priorize filename in Content-Disposition against name in Content-Type to get the filename of an attachment in mail
- - request all contacts when there is no filter in Contacts menu in Webmail
- - personal contacts working properly on Outlook
- - fixes on RTF parsing used by event/contact description and mail as RTF to read non-ASCII characters:
-   better parsing of font table, when using a font, switch to its character set, correct parsing of
-   escaped characters and Unicode character command word support for unicode characters greater than 32767
- - no crash resolving recipients after reconnecting LDAP connection
- - avoid creation of phantom contacts in SOGo from distribution list synced from Outlook.
- - accepted & updated event names are now shown correctly in Outlook
- - provide safe guards in mail and calendar to avoid exceptions while syncing
-
-2.3.4 (2015-12-15)
-------------------
-
-New features
- - initial support for EAS calendar exceptions
-
-Enhancements
- - limit the maximum width of toolbar buttons (#3381)
- - updated CKEditor to version 4.5.6
-
-Bug fixes
- - JavaScript exception when printing events from calendars with no assigned color (#3203)
- - EAS fix for wrong charset being used (#3392)
- - EAS fix on qp-encoded subjects (#3390)
- - correctly handle all-day event exceptions when the master event changes
- - prevent characters in calendar component UID causing issues during import process
- - avoid duplicating attendees when accepting event using a different identity over CalDAV
-
-2.3.3a (2015-11-18)
--------------------
-
-Bug fixes
- - expanded mail folders list is not saved (#3386)
- - cleanup translations
-
-2.3.3 (2015-11-11)
-------------------
-
-New features
- - initial S/MIME support for EAS (#3327)
- - now possible to choose which folders to sync over EAS
-
-Enhancements
- - we no longer always entirely rewrite messages for Outlook 2013 when using EAS
- - support for ghosted elements on contacts over EAS
- - added Macedonian (mk_MK) translation - thanks to Miroslav Jovanovic
- - added Portuguese (pt) translation - thanks to Eduardo Crispim
-
-Bug fixes
- - numerous EAS fixes when connections are dropped before the EAS client receives the response (#3058, #2849)
- - correctly handle the References header over EAS (#3365)
- - make sure English is always used when generating Date headers using EAS (#3356)
- - don't escape quoted strings during versit generation
- - we now return all cards when we receive an empty addressbook-query REPORT
- - avoid crash when replying to a mail with no recipients (#3359)
- - inline images sent from SOGo webmail are not displayed in Mozilla Thunderbird (#3271)
- - prevent postal address showing on single line over EAS (#2614)
- - display missing events when printing working hours only
- - fix corner case making server crash when syncing hard deleted messages when clear offline items was set up (Zentyal)
- - avoid infinite Outlook client loops trying to set read flag when it is already set (Zentyal)
- - avoid crashing when calendar metadata is missing in the cache (Zentyal)
- - fix recurrence pattern event corner case created by Mozilla Thunderbird which made server crash (Zentyal)
- - fix corner case that removes attachments on sending messages from Outlook (Zentyal)
- - freebusy on web interface works again in multidomain environments (Zentyal)
- - fix double creation of folders in Outlook when the folder name starts with a digit (Zentyal)
- - avoid crashing Outlook after setting a custom view in a calendar folder (Zentyal)
- - handle emails having an attachment as their content
- - fixed JavaScript syntax error in attendees editor
- - fixed wrong comparison of meta vs. META tag in HTML mails
- - fixed popup menu position when moved to the left (#3381)
- - fixed dialog position when at the bottom of the window (#2646, #3378)
-
-2.3.2 (2015-09-16)
-------------------
-
-Enhancements
- - improved EAS speed and memory usage, avoiding many IMAP LIST commands (#3294)
- - improved EAS speed during initial syncing of large mailboxes (#3293)
- - updated CKEditor to version 4.5.3
-
 Bug fixes
  - fixed display of whitelisted attendees in Preferences window on Firefox (#3285)
- - non-latin subfolder names are displayed correctly on Outlook (Zentyal)
- - fixed several sync issues on environments with multiple users (Zentyal)
- - folders from other users will no longer appear on your Outlook (Zentyal)
- - use right auth in multidomain environments in contacts and calendar from Outlook (Zentyal)
- - session fix when SOGoEnableDomainBasedUID is enabled but logins are domain-less
- - less sync issues when setting read flag (Zentyal)
- - attachments with non-latin filenames sent by Outlook are now received (Zentyal)
- - support attachments from more mail clients (Zentyal)
- - avoid conflicting message on saving a draft mail (Zentyal)
- - less conflicting messages in Outlook while moving messages between folders (Zentyal)
- - start/end shifting by 1 hour due to timezone change on last Sunday of October 2015 (#3344)
- - fixed localization of calendar categories with empty profile (#3295)
- - fixed options availability in contextual menu of Contacts module (#3342)
+ - Non-latin subfolder names are displayed correctly on Outlook (Zentyal)
+ - Fixed several sync issues on environments with multiple users (Zentyal)
+ - Folders from other users will no longer appear on your Outlook (Zentyal)
+ - Use right auth in multidomain environments in contacts and calendar from Outlook (Zentyal)
 
 2.3.1 (2015-07-23)
 ------------------
@@ -350,7 +19,6 @@ Enhancements
  - added create-folder subcommand to sogo-tool to create contact and calendar folders
  - group mail addresses can be used as recipient in Outlook
  - added 'ActiveSync' module constraints
- - updated CKEditor to version 4.5.1
  - added Slovenian translation - thanks to Jens Riecken
  - added Chinese (Taiwan) translation
 

OpenChange/GNUmakefile

@@ -145,8 +145,7 @@ $(DBMSGREADER_TOOL)_LIB_DIRS += \
 	-L../SoObjects/SOGo/SOGo.framework/sogo -lSOGo \
 	-L../SOPE/GDLContentStore/obj/ -lGDLContentStore \
 	-L../SOPE/NGCards/obj/ -lNGCards \
-	-lNGObjWeb \
-	$(LIBMAPI_LIBS)
+	-lNGObjWeb
 
 TEST_TOOL_NAME += $(PLREADER_TOOL) $(DBMSGREADER_TOOL)
 

OpenChange/MAPIStoreAppointmentWrapper.h

@@ -24,7 +24,6 @@
 #define MAPISTORECALENDARWRAPPER_H
 
 #import <NGCards/iCalPerson.h>
-#import <NGCards/iCalTimeZone.h>
 #import <Appointments/iCalEntityObject+SOGo.h>
 
 #import "MAPIStoreObjectProxy.h"
@@ -43,7 +42,7 @@
   iCalCalendar *calendar;
   iCalEvent *firstEvent;
   iCalEvent *event;
-  iCalTimeZone *timeZone;
+  NSTimeZone *timeZone;
   SOGoUser *user;
   NSString *senderEmail;
   NSData *globalObjectId;
@@ -58,10 +57,12 @@
 + (id) wrapperWithICalEvent: (iCalEvent *) newEvent
                     andUser: (SOGoUser *) newUser
              andSenderEmail: (NSString *) newSenderEmail
+                 inTimeZone: (NSTimeZone *) newTimeZone
          withConnectionInfo: (struct mapistore_connection_info *) newConnInfo;
 - (id) initWithICalEvent: (iCalEvent *) newEvent
                  andUser: (SOGoUser *) newUser
           andSenderEmail: (NSString *) newSenderEmail
+              inTimeZone: (NSTimeZone *) newTimeZone
       withConnectionInfo: (struct mapistore_connection_info *) newConnInfo;
 
 /* getters */

OpenChange/MAPIStoreAppointmentWrapper.m

@@ -37,9 +37,7 @@
 #import <NGCards/iCalEventChanges.h>
 #import <NGCards/iCalPerson.h>
 #import <NGCards/iCalTrigger.h>
-#import <NGCards/iCalTimeZonePeriod.h>
 #import <NGCards/NSString+NGCards.h>
-#import <SOGo/SOGoDomainDefaults.h>
 #import <SOGo/SOGoUser.h>
 #import <SOGo/SOGoUserManager.h>
 
@@ -82,6 +80,7 @@ static NSCharacterSet *hexCharacterSet = nil;
 + (id) wrapperWithICalEvent: (iCalEvent *) newEvent
                     andUser: (SOGoUser *) newUser
              andSenderEmail: (NSString *) newSenderEmail
+                 inTimeZone: (NSTimeZone *) newTimeZone
          withConnectionInfo: (struct mapistore_connection_info *) newConnInfo
 {
   MAPIStoreAppointmentWrapper *wrapper;
@@ -89,6 +88,7 @@ static NSCharacterSet *hexCharacterSet = nil;
   wrapper = [[self alloc] initWithICalEvent: newEvent
                                     andUser: newUser
                              andSenderEmail: newSenderEmail
+                                 inTimeZone: newTimeZone
                          withConnectionInfo: newConnInfo];
   [wrapper autorelease];
 
@@ -182,10 +182,10 @@ static NSCharacterSet *hexCharacterSet = nil;
 - (id) initWithICalEvent: (iCalEvent *) newEvent
                  andUser: (SOGoUser *) newUser
           andSenderEmail: (NSString *) newSenderEmail
+              inTimeZone: (NSTimeZone *) newTimeZone
       withConnectionInfo: (struct mapistore_connection_info *) newConnInfo
 {
   NSArray *events;
-  iCalTimeZone *tz;
 
   if ((self = [self init]))
     {
@@ -194,20 +194,9 @@ static NSCharacterSet *hexCharacterSet = nil;
       event = newEvent;
       events = [calendar events];
       firstEvent = [events objectAtIndex: 0];
+      ASSIGN (timeZone, newTimeZone);
       ASSIGN (user, newUser);
       ASSIGN (senderEmail, newSenderEmail);
-      /* If newEvent comes from the client, we set its time zone in
-         updateFromMAPIProperties. If it is not present, we use the
-         time zone of the user */
-      tz = (iCalTimeZone *) [calendar firstChildWithTag: @"vtimezone"];
-      if (!tz)
-        {
-          tz = [iCalTimeZone timeZoneForName: [[[user userDefaults] timeZone] name]];
-          if (!tz)
-            [self logWithFormat: @"no time zone could be set"];
-	}
-      ASSIGN (timeZone, tz);
-
       [self _setupITIPContext];
     }
 
@@ -277,7 +266,7 @@ static NSCharacterSet *hexCharacterSet = nil;
             {
               username = [contactInfos objectForKey: @"sAMAccountName"];
               recipient->username = [username asUnicodeInMemCtx: msgData];
-              entryId = MAPIStoreInternalEntryId (connInfo, username);
+              entryId = MAPIStoreInternalEntryId (connInfo->sam_ctx, username);
             }
           else
             {
@@ -378,7 +367,7 @@ static NSCharacterSet *hexCharacterSet = nil;
           {
             username = [contactInfos objectForKey: @"sAMAccountName"];
             recipient->username = [username asUnicodeInMemCtx: msgData];
-            entryId = MAPIStoreInternalEntryId (connInfo, username);
+            entryId = MAPIStoreInternalEntryId (connInfo->sam_ctx, username);
           }
         else
           {
@@ -732,15 +721,22 @@ static NSCharacterSet *hexCharacterSet = nil;
                               inMemCtx: (TALLOC_CTX *) memCtx
 {
   NSCalendarDate *dateValue;
+  NSInteger offset;
 
   // if ([event isRecurrent])
   //   dateValue = [event firstRecurrenceStartDate];
   // else
   dateValue = [event startDate];
   if ([event isAllDay])
-    dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+    {
+      offset = -[timeZone secondsFromGMTForDate: dateValue];
+      dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                         hours: 0 minutes: 0
+                                       seconds: offset];
+    }
+  [dateValue setTimeZone: utcTZ];
   *data = [dateValue asFileTimeInMemCtx: memCtx];
-
+  
   return MAPISTORE_SUCCESS;
 }
 
@@ -753,14 +749,22 @@ static NSCharacterSet *hexCharacterSet = nil;
      exceptions, where it is the normal start date for the day of the
      exception. */
   NSCalendarDate *dateValue;
+  NSInteger offset;
 
   dateValue = [event recurrenceId];
   if (!dateValue)
     dateValue = [event startDate];
+  [dateValue setTimeZone: timeZone];
   if ([event isAllDay])
-    dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+    {
+      offset = -[timeZone secondsFromGMTForDate: dateValue];
+      dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                         hours: 0 minutes: 0
+                                       seconds: offset];
+    }
+  [dateValue setTimeZone: utcTZ];
   *data = [dateValue asFileTimeInMemCtx: memCtx];
-
+  
   return MAPISTORE_SUCCESS;
 }
 
@@ -768,12 +772,19 @@ static NSCharacterSet *hexCharacterSet = nil;
                     inMemCtx: (TALLOC_CTX *) memCtx
 {
   NSCalendarDate *dateValue;
+  NSInteger offset;
 
   dateValue = [firstEvent startDate];
   if ([firstEvent isAllDay])
-    dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+    {
+      offset = -[timeZone secondsFromGMTForDate: dateValue];
+      dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                         hours: 0 minutes: 0
+                                       seconds: offset];
+    }
+  [dateValue setTimeZone: utcTZ];
   *data = [dateValue asFileTimeInMemCtx: memCtx];
-
+  
   return MAPISTORE_SUCCESS;
 }
 
@@ -793,8 +804,8 @@ static NSCharacterSet *hexCharacterSet = nil;
                                          month: [start monthOfYear]
                                            day: [start dayOfMonth]
                                           hour: 0 minute: 0 second: 0
-                                      timeZone: utcTZ];
-      dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+                                      timeZone: timeZone];
+      [dateValue setTimeZone: utcTZ];
       *data = [dateValue asFileTimeInMemCtx: memCtx];
       rc = MAPISTORE_SUCCESS;
     }
@@ -818,7 +829,7 @@ static NSCharacterSet *hexCharacterSet = nil;
   dateValue = [event startDate];
   offset = [event durationAsTimeInterval];
   if ([event isAllDay])
-    offset -= [[timeZone periodForDate: dateValue] secondsOffsetFromGMT];
+    offset -= [timeZone secondsFromGMTForDate: dateValue];
   dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
                                      hours: 0 minutes: 0
                                    seconds: offset];
@@ -836,14 +847,15 @@ static NSCharacterSet *hexCharacterSet = nil;
   dateValue = [event recurrenceId];
   if (!dateValue)
     dateValue = [event startDate];
+  [dateValue setTimeZone: timeZone];
   offset = [firstEvent durationAsTimeInterval];
   if ([firstEvent isAllDay])
-    offset -= [[timeZone periodForDate: dateValue] secondsOffsetFromGMT];
+    offset -= [timeZone secondsFromGMTForDate: dateValue];
   dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
                                      hours: 0 minutes: 0
                                    seconds: offset];
   *data = [dateValue asFileTimeInMemCtx: memCtx];
-
+  
   return MAPISTORE_SUCCESS;
 }
 
@@ -859,7 +871,7 @@ static NSCharacterSet *hexCharacterSet = nil;
   dateValue = [firstEvent startDate];
   offset = [firstEvent durationAsTimeInterval];
   if ([event isAllDay])
-    offset -= [[timeZone periodForDate: dateValue] secondsOffsetFromGMT];
+    offset -= [timeZone secondsFromGMTForDate: dateValue];
   dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
                                      hours: 0 minutes: 0
                                    seconds: offset];
@@ -873,14 +885,23 @@ static NSCharacterSet *hexCharacterSet = nil;
 {
   enum mapistore_error rc;
   NSCalendarDate *dateValue;
+  NSInteger offset;
   iCalRecurrenceRule *rrule;
 
   if ([event isRecurrent])
     {
       rrule = [[event recurrenceRules] objectAtIndex: 0];
       dateValue = [rrule untilDate];
-      if (dateValue && [event isAllDay])
-        dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+      if (dateValue)
+        {
+          if ([event isAllDay])
+            offset = -[timeZone secondsFromGMTForDate: dateValue];
+          else
+            offset = 0;
+          dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                             hours: 0 minutes: 0
+                                           seconds: offset];
+        }
       else
         dateValue = [NSCalendarDate dateWithYear: 4500 month: 8 day: 31
                                             hour: 23 minute: 59 second: 00
@@ -911,7 +932,7 @@ static NSCharacterSet *hexCharacterSet = nil;
   if (contactInfos)
     {
       username = [contactInfos objectForKey: @"sAMAccountName"];
-      entryId = MAPIStoreInternalEntryId (connInfo, username);
+      entryId = MAPIStoreInternalEntryId (connInfo->sam_ctx, username);
     }
   else
     entryId = MAPIStoreExternalEntryId (cn, email);
@@ -1317,14 +1338,21 @@ static NSCharacterSet *hexCharacterSet = nil;
 {
   enum mapistore_error rc;
   NSCalendarDate *dateValue;
+  NSInteger offset;
 
   dateValue = [event recurrenceId];
   if (dateValue)
     {
       rc = MAPISTORE_SUCCESS;
-
+      
       if ([event isAllDay])
-        dateValue = [timeZone shiftedCalendarDateForDate: dateValue];
+        {
+          offset = -[timeZone secondsFromGMTForDate: dateValue];
+          dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                             hours: 0 minutes: 0
+                                           seconds: offset];
+        }
+      [dateValue setTimeZone: utcTZ];
       *data = [dateValue asFileTimeInMemCtx: memCtx];
     }
   else
@@ -1349,6 +1377,7 @@ static NSCharacterSet *hexCharacterSet = nil;
   iCalEventChanges *changes;
   NSArray *changedProperties;
   NSCalendarDate *dateValue;
+  NSInteger offset;
 
   changes = [iCalEventChanges changesFromEvent: event toEvent: exceptionEvent];
 
@@ -1356,17 +1385,28 @@ static NSCharacterSet *hexCharacterSet = nil;
   memset (extendedException, 0, sizeof (struct ExtendedException));
   extendedException->ChangeHighlight.Size = sizeof (uint32_t);
 
-  dateValue = [timeZone computedDateForDate: [exceptionEvent startDate]];
+  dateValue = [exceptionEvent startDate];
+  offset = [timeZone secondsFromGMTForDate: dateValue];
+  dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                     hours: 0 minutes: 0
+                                   seconds: offset];
   exceptionInfo->StartDateTime = [dateValue asMinutesSince1601];
   extendedException->ChangeHighlight.Value = BIT_CH_START;
   extendedException->StartDateTime = exceptionInfo->StartDateTime;
 
-  dateValue = [timeZone computedDateForDate: [exceptionEvent endDate]];
+  dateValue = [exceptionEvent endDate];
+  offset = [timeZone secondsFromGMTForDate: dateValue];
+  dateValue = [dateValue dateByAddingYears: 0 months: 0 days: 0
+                                     hours: 0 minutes: 0
+                                   seconds: offset];
   exceptionInfo->EndDateTime = [dateValue asMinutesSince1601];
   extendedException->ChangeHighlight.Value |= BIT_CH_END;
   extendedException->EndDateTime = exceptionInfo->EndDateTime;
 
-  dateValue = [timeZone computedDateForDate: [exceptionEvent recurrenceId]];
+  dateValue = [[exceptionEvent recurrenceId]
+                dateByAddingYears: 0 months: 0 days: 0
+                hours: 0 minutes: 0
+                seconds: offset];
   exceptionInfo->OriginalStartDate = [dateValue asMinutesSince1601];
   extendedException->OriginalStartDate = exceptionInfo->OriginalStartDate;
 
@@ -1424,6 +1464,7 @@ static NSCharacterSet *hexCharacterSet = nil;
       arp = talloc_zero (NULL, struct AppointmentRecurrencePattern);
       [rule fillRecurrencePattern: &arp->RecurrencePattern
                         withEvent: event
+                       inTimeZone: timeZone
                          inMemCtx: arp];
       arp->ReaderVersion2 = 0x00003006;
       arp->WriterVersion2 = 0x00003008; /* 0x3008 for compatibility with
@@ -1434,7 +1475,7 @@ static NSCharacterSet *hexCharacterSet = nil;
 	 fields are relative to midnight of those days ([MS-OXOCAL] 2.2.1.44.5),
 	 so no time zone adjustment is needed */
       if (![event isAllDay])
-        firstStartDate = [timeZone computedDateForDate: firstStartDate];
+        [firstStartDate setTimeZone: timeZone];
       startMinutes = ([firstStartDate hourOfDay] * 60
                       + [firstStartDate minuteOfHour]);
       arp->StartTimeOffset = startMinutes;
@@ -1660,16 +1701,15 @@ ReservedBlockEE2Size: 00 00 00 00
                  fromDate: (NSCalendarDate *) instanceDate;
 {
   uint16_t year;
-  NSCalendarDate *dateValue;
 
   if (instanceDate)
     {
-      dateValue = [timeZone computedDateForDate: instanceDate];
-      year = [dateValue yearOfCommonEra];
+      [instanceDate setTimeZone: timeZone];
+      year = [instanceDate yearOfCommonEra];
       newGlobalId->YH = year >> 8;
       newGlobalId->YL = year & 0xff;
-      newGlobalId->Month = [dateValue monthOfYear];
-      newGlobalId->D = [dateValue dayOfMonth];
+      newGlobalId->Month = [instanceDate monthOfYear];
+      newGlobalId->D = [instanceDate dayOfMonth];
     }
 }
 
@@ -1934,6 +1974,7 @@ ReservedBlockEE2Size: 00 00 00 00
   if (alarm)
     {
       alarmDate = [alarm nextAlarmDate];
+      [alarmDate setTimeZone: utcTZ];
       *data = [alarmDate asFileTimeInMemCtx: memCtx];
     }
   else
@@ -1995,7 +2036,8 @@ ReservedBlockEE2Size: 00 00 00 00
   enum mapistore_error rc;
   NSString *tzid;
 
-  tzid = [timeZone tzId];
+  tzid = [(iCalDateTime *) [event firstChildWithTag: @"dtstart"]
+           value: 0 ofAttribute: @"tzid"];
   if ([tzid length] > 0)
     {
       *data = [tzid asUnicodeInMemCtx: memCtx];
@@ -2011,9 +2053,16 @@ ReservedBlockEE2Size: 00 00 00 00
                        inMemCtx: (TALLOC_CTX *) memCtx
 {
   enum mapistore_error rc;
+  iCalTimeZone *icalTZ;
 
-  *data = [timeZone asTimeZoneStructInMemCtx: memCtx];
-  rc = MAPISTORE_SUCCESS;
+  icalTZ = [(iCalDateTime *) [event firstChildWithTag: @"dtstart"] timeZone];
+  if (icalTZ)
+    {
+      *data = [icalTZ asTimeZoneStructInMemCtx: memCtx];
+      rc = MAPISTORE_SUCCESS;
+    }
+  else
+    rc = MAPISTORE_ERR_NOT_FOUND;
 
   return rc;
 }
@@ -2022,16 +2071,24 @@ ReservedBlockEE2Size: 00 00 00 00
                                                   inMemCtx: (TALLOC_CTX *) memCtx
 {
   enum mapistore_error rc;
+  iCalTimeZone *icalTZ;
 
   /* [MS-OXOCAL] 3.1.5.5.1: This property is used in floating (all-day) events,
      specified in floating time, to convert the start date from UTC to the user's
      time zone */
-  if ([event isAllDay] | [event isRecurrent])
+  if ([event isAllDay])
+    icalTZ = [iCalTimeZone timeZoneForName: [timeZone timeZoneName]];
+  else if ([event isRecurrent])
+    icalTZ = [(iCalDateTime *) [event firstChildWithTag: @"dtstart"] timeZone];
+  else
+    icalTZ = nil;
+
+  if (icalTZ)
     {
       /* [MS-OXOCAL] 2.2.1.42: This property can only have the E flag set in the
          TimeZoneDefinition struct */
-      *data = [timeZone asZoneTimeDefinitionWithFlags: TZRULE_FLAG_EFFECTIVE_TZREG
-                                             inMemCtx: memCtx];
+      *data = [icalTZ asZoneTimeDefinitionWithFlags: TZRULE_FLAG_EFFECTIVE_TZREG
+                                           inMemCtx: memCtx];
       rc = MAPISTORE_SUCCESS;
     }
   else

OpenChange/MAPIStoreAuthenticator.h

@@ -46,9 +46,6 @@
                               forURL: (NSURL *) server
                           forceRenew: (BOOL) renew;
 
-- (NSString *) passwordInContext: (WOContext *) context;
-
-
 @end
 
 #endif /* MAPISTOREAUTHENTICATOR_H */

OpenChange/MAPIStoreAuthenticator.m

@@ -72,8 +72,4 @@
         return imapPassword;
 }
 
-- (NSString *) passwordInContext: (WOContext *) context
-{
-	return password;
-}
 @end

OpenChange/MAPIStoreCalendarEmbeddedMessage.m

@@ -58,6 +58,7 @@
                 wrapperWithICalEvent: [newContainer event]
                              andUser: [userContext sogoUser]
                       andSenderEmail: nil
+                          inTimeZone: [userContext timeZone]
                   withConnectionInfo: [context connectionInfo]];
       [self addProxy: appointmentWrapper];
     }

OpenChange/MAPIStoreCalendarFolder.m

@@ -77,17 +77,6 @@
 
 - (NSArray *) rolesForExchangeRights: (uint32_t) rights
 {
-  /* Limitations
-
-     Following rights are not supported by SOGo specifically:
-
-     - DeleteOwned : Delete only own objects
-     - EditOwned : Edit only own objects
-     - CreateSubfolders: No calendar subfolders
-     - FolderOwner: No sharing folder ownership?
-     - FolderContact: No support to store this information
-     - FolderVisible: It is inferred by other rights when extracting
-   */
   NSMutableArray *roles;
 
   roles = [NSMutableArray arrayWithCapacity: 6];
@@ -128,11 +117,11 @@
   if ([roles containsObject: SOGoRole_ObjectCreator])
     rights |= RightsCreateItems;
   if ([roles containsObject: SOGoRole_ObjectEraser])
-    rights |= RightsDeleteAll | RightsDeleteOwn;
+    rights |= RightsDeleteAll;
   if ([roles containsObject: SOGoCalendarRole_PublicModifier]
       && [roles containsObject: SOGoCalendarRole_PrivateModifier]
       && [roles containsObject: SOGoCalendarRole_ConfidentialModifier])
-    rights |= RightsReadItems | RightsEditAll | RightsEditOwn | RightsFreeBusySimple | RightsFreeBusyDetailed;
+    rights |= RightsReadItems | RightsEditAll;
   else if ([roles containsObject: SOGoCalendarRole_PublicViewer]
            && [roles containsObject: SOGoCalendarRole_PrivateViewer]
            && [roles containsObject: SOGoCalendarRole_ConfidentialViewer])
@@ -146,7 +135,7 @@
   if ([roles containsObject: SOGoCalendarRole_ConfidentialDAndTViewer])
       rights |= RightsFreeBusyDetailed;
 
-  if ((rights & RightsReadItems) != 0 || (rights & RightsCreateItems) != 0 || (rights & RightsDeleteAll) != 0)
+  if (rights != 0)
     rights |= RoleNone; /* actually "folder visible" */
 
   // [self logWithFormat: @"rights for roles (%@) = %.8x", roles, rights];

OpenChange/MAPIStoreCalendarMessage.m

@@ -197,6 +197,7 @@ static Class NSArrayK, MAPIStoreAppointmentWrapperK;
         = [MAPIStoreAppointmentWrapper wrapperWithICalEvent: masterEvent
                                                     andUser: [userContext sogoUser]
                                              andSenderEmail: nil
+                                                 inTimeZone: [userContext timeZone]
                                          withConnectionInfo: [context connectionInfo]];
       [self addProxy: appointmentWrapper];
     }
@@ -670,7 +671,7 @@ static Class NSArrayK, MAPIStoreAppointmentWrapperK;
   return newAttachment;
 }
 
-- (enum mapistore_error) setReadFlag: (uint8_t) flag
+- (int) setReadFlag: (uint8_t) flag
 {
   return MAPISTORE_SUCCESS;
 }

OpenChange/MAPIStoreContactsFolder.m

@@ -96,9 +96,9 @@
   if ([roles containsObject: SOGoRole_ObjectCreator])
     rights |= RightsCreateItems;
   if ([roles containsObject: SOGoRole_ObjectEraser])
-    rights |= RightsDeleteAll | RightsDeleteOwn;
+    rights |= RightsDeleteAll;
   if ([roles containsObject: SOGoRole_ObjectEditor])
-    rights |= RightsEditAll | RightsEditOwn;
+    rights |= RightsEditAll;
   if ([roles containsObject: SOGoRole_ObjectViewer])
     rights |= RightsReadItems;
   if (rights != 0)

OpenChange/MAPIStoreDBFolder.m

@@ -102,7 +102,7 @@ static NSString *MAPIStoreRightFolderContact = @"RightsFolderContact";
     {
       value = get_SPropValue_SRow (aRow, PidTagDisplayName_string8);
       if (value)
-        folderName = [NSString stringWithUTF8String: (const char *) value->value.lpszA];
+        folderName = [NSString stringWithUTF8String: value->value.lpszA];
       else
         folderName = nil;
     }
@@ -321,9 +321,9 @@ static NSString *MAPIStoreRightFolderContact = @"RightsFolderContact";
   if ([roles containsObject: MAPIStoreRightDeleteOwn])
     rights |= RightsDeleteOwn;
   if ([roles containsObject: MAPIStoreRightEditAll])
-    rights |= RightsEditAll | RightsEditOwn;
+    rights |= RightsEditAll;
   if ([roles containsObject: MAPIStoreRightDeleteAll])
-    rights |= RightsDeleteAll | RightsDeleteOwn;
+    rights |= RightsDeleteAll;
   if ([roles containsObject: MAPIStoreRightCreateSubfolders])
     rights |= RightsCreateSubfolders;
   if ([roles containsObject: MAPIStoreRightFolderOwner])

OpenChange/MAPIStoreDBMessage.m

@@ -22,7 +22,6 @@
 
 #import <Foundation/NSArray.h>
 #import <Foundation/NSCalendarDate.h>
-#import <Foundation/NSData.h>
 #import <Foundation/NSDictionary.h>
 #import <Foundation/NSString.h>
 #import <Foundation/NSValue.h>
@@ -35,7 +34,6 @@
 #import "MAPIStoreDBFolder.h"
 #import "MAPIStoreDBMessage.h"
 #import "MAPIStoreTypes.h"
-#import "NSData+MAPIStore.h"
 #import "NSObject+MAPIStore.h"
 #import "NSString+MAPIStore.h"
 
@@ -45,28 +43,16 @@
 
 @implementation MAPIStoreDBMessage
 
-+ (enum mapistore_error) getAvailableProperties: (struct SPropTagArray **) propertiesP
-                                       inMemCtx: (TALLOC_CTX *) memCtx
++ (int) getAvailableProperties: (struct SPropTagArray **) propertiesP
+                      inMemCtx: (TALLOC_CTX *) memCtx
 {
   struct SPropTagArray *properties;
   NSUInteger count;
-
-  enum MAPITAGS faiProperties[] = {
-    0x68330048, /* PR_VIEW_CLSID */
-    0x68350102, /* PR_VIEW_STATE */
-    0x683c0102,
-    0x683d0040,
-    0x683e0102,
-    0x683f0102, /* PR_VIEW_VIEWTYPE_KEY */
-    0x68410003,
-    0x68420102,
-    0x68450102,
-    0x68460003,
-    0x7006001F, /* PR_VD_NAME_W */
-    0x70030003, /* PR_VD_FLAGS */
-    0x70070003  /* PR_VD_VERSION */
-  };
-
+  enum MAPITAGS faiProperties[] = { 0x68350102, 0x683c0102, 0x683e0102,
+                                    0x683f0102, 0x68410003, 0x68420102,
+                                    0x68450102, 0x68460003,
+                                    // PR_VD_NAME_W, PR_VD_FLAGS, PR_VD_VERSION, PR_VIEW_CLSID
+                                    0x7006001F, 0x70030003, 0x70070003, 0x68330048 };
   size_t faiSize = sizeof(faiProperties) / sizeof(enum MAPITAGS);
 
   properties = talloc_zero (memCtx, struct SPropTagArray);
@@ -88,13 +74,6 @@
   return MAPISTORE_SUCCESS;
 }
 
-- (enum mapistore_error) getAvailableProperties: (struct SPropTagArray **) propertiesP
-                                       inMemCtx: (TALLOC_CTX *) memCtx
-{
-  return [[self class] getAvailableProperties: propertiesP
-                                     inMemCtx: memCtx];
-}
-
 - (id) initWithSOGoObject: (id) newSOGoObject
               inContainer: (MAPIStoreObject *) newContainer
 {
@@ -109,173 +88,22 @@
   return self;
 }
 
-- (NSString *) description
-{
-  id key, value;
-  NSEnumerator *propEnumerator;
-  NSMutableString *description;
-
-  description = [NSMutableString stringWithFormat: @"%@ %@. Properties: {", NSStringFromClass ([self class]),
-                                 [self url]];
-
-  propEnumerator = [properties keyEnumerator];
-  while ((key = [propEnumerator nextObject]))
-    {
-      uint32_t proptag = 0;
-      if ([key isKindOfClass: [NSString class]] && [(NSString *)key intValue] > 0)
-        proptag = [(NSString *)key intValue];
-      else if ([key isKindOfClass: [NSNumber class]])
-        proptag = [key unsignedLongValue];
-
-      if (proptag > 0)
-        {
-          const char *propTagName = get_proptag_name ([key unsignedLongValue]);
-          NSString *propName;
-
-          if (propTagName)
-            propName = [NSString stringWithCString: propTagName
-                                          encoding: NSUTF8StringEncoding];
-          else
-            propName = [NSString stringWithFormat: @"0x%.4x", [key unsignedLongValue]];
-
-          [description appendFormat: @"'%@': ", propName];
-        }
-      else
-        [description appendFormat: @"'%@': ", key];
-
-      value = [properties objectForKey: key];
-      [description appendFormat: @"%@ (%@), ", value, NSStringFromClass ([value class])];
-    }
-
-  [description appendString: @"}\n"];
-
-  return description;
-}
-
 - (uint64_t) objectVersion
 {
-  /* Return the global counter from CN structure.
-     See [MS-OXCFXICS] Section 2.2.2.1 */
-  NSNumber *versionNbr, *cn;
+  NSNumber *versionNbr;
   uint64_t objectVersion;
 
   [(SOGoMAPIDBMessage *) sogoObject reloadIfNeeded];
-  versionNbr = [properties objectForKey: @"version_number"];
+  versionNbr = [properties objectForKey: @"version"];
   if (versionNbr)
-    objectVersion = exchange_globcnt ([versionNbr unsignedLongLongValue]);
+    objectVersion = (([versionNbr unsignedLongLongValue] >> 16)
+                     & 0x0000ffffffffffffLL);
   else
-    {
-      /* Old version which stored the CN structure not useful for searching */
-      cn = [properties objectForKey: @"version"];
-      if (cn)
-        objectVersion = (([cn unsignedLongLongValue] >> 16)
-                          & 0x0000ffffffffffffLL);
-      else
-        objectVersion = ULLONG_MAX;
-    }
+    objectVersion = ULLONG_MAX;
 
   return objectVersion;
 }
 
-- (void) _updatePredecessorChangeList
-{
-  BOOL updated;
-  enum mapistore_error rc;
-  NSData *currentChangeList, *changeKey;
-  NSMutableArray *changeKeys;
-  NSMutableData *newChangeList;
-  NSUInteger count, len;
-  struct SizedXid *changes;
-  struct SPropValue property;
-  struct SRow aRow;
-  struct XID *currentChangeKey;
-  TALLOC_CTX *localMemCtx;
-  uint32_t nChanges;
-
-  localMemCtx = talloc_new (NULL);
-  if (!localMemCtx)
-    {
-      [self errorWithFormat: @"No more memory"];
-      return;
-    }
-
-  changeKey = [self getReplicaKeyFromGlobCnt: [self objectVersion]];
-
-  currentChangeList = [properties objectForKey: MAPIPropertyKey (PidTagPredecessorChangeList)];
-  if (!currentChangeList)
-    {
-      /* Create a new PredecessorChangeList */
-      len = [changeKey length];
-      newChangeList = [NSMutableData dataWithCapacity: len + 1];
-      [newChangeList appendUInt8: len];
-      [newChangeList appendData: changeKey];
-    }
-  else
-    {
-      /* Update current predecessor change list with new change key */
-      changes = [currentChangeList asSizedXidArrayInMemCtx: localMemCtx
-                                                      with: &nChanges];
-
-      updated = NO;
-      currentChangeKey = [changeKey asXIDInMemCtx: localMemCtx];
-      for (count = 0; count < nChanges && !updated; count++)
-        {
-          if (GUID_equal(&changes[count].XID.NameSpaceGuid, &currentChangeKey->NameSpaceGuid))
-            {
-              NSData *globCnt, *oldGlobCnt;
-              oldGlobCnt = [NSData dataWithBytes: changes[count].XID.LocalId.data length: changes[count].XID.LocalId.length];
-              globCnt = [NSData dataWithBytes: currentChangeKey->LocalId.data length: currentChangeKey->LocalId.length];
-              if ([globCnt compare: oldGlobCnt] == NSOrderedDescending)
-                {
-                  if ([globCnt length] != [oldGlobCnt length])
-                    {
-                      [self errorWithFormat: @"Cannot compare globcnt with different length: %@ and %@", globCnt, oldGlobCnt];
-                      abort();
-                    }
-                  memcpy (changes[count].XID.LocalId.data, currentChangeKey->LocalId.data, currentChangeKey->LocalId.length);
-                  updated = YES;
-                }
-            }
-        }
-
-      /* Serialise it */
-      changeKeys = [NSMutableArray array];
-
-      if (!updated)
-        [changeKeys addObject: changeKey];
-
-      for (count = 0; count < nChanges; count++)
-        {
-          changeKey = [NSData dataWithXID: &changes[count].XID];
-          [changeKeys addObject: changeKey];
-        }
-
-      [changeKeys sortUsingFunction: MAPIChangeKeyGUIDCompare context: localMemCtx];
-
-      newChangeList = [NSMutableData data];
-      len = [changeKeys count];
-      for (count = 0; count < len; count++)
-        {
-          changeKey = [changeKeys objectAtIndex: count];
-          [newChangeList appendUInt8: [changeKey length]];
-          [newChangeList appendData: changeKey];
-        }
-    }
-
-  if ([newChangeList length] > 0)
-    {
-      property.ulPropTag = PidTagPredecessorChangeList;
-      property.value.bin = *[newChangeList asBinaryInMemCtx: localMemCtx];
-      aRow.cValues = 1;
-      aRow.lpProps = &property;
-      rc = [self addPropertiesFromRow: &aRow];
-      if (rc != MAPISTORE_SUCCESS)
-          [self errorWithFormat: @"Impossible to add a new predecessor change list: %d", rc];
-    }
-
-  talloc_free (localMemCtx);
-}
-
 //
 // FIXME: how this can happen?
 //
@@ -335,19 +163,10 @@
     [properties setObject: attachmentParts forKey: @"attachments"];
 
   newVersion = [[self context] getNewChangeNumber];
-  newVersion = exchange_globcnt ((newVersion >> 16) & 0x0000ffffffffffffLL);
-
   [properties setObject: [NSNumber numberWithUnsignedLongLong: newVersion]
-                 forKey: @"version_number"];
+                 forKey: @"version"];
 
-  /* Remove old version */
-  [properties removeObjectForKey: @"version"];
-
-  /* Update PredecessorChangeList accordingly */
-  [self _updatePredecessorChangeList];
-
-  // [self logWithFormat: @"Saving %@", [self description]];
-  // [self logWithFormat: @"%d props in dict", [properties count]];
+  [self logWithFormat: @"%d props in dict", [properties count]];
 
   [sogoObject save];
 }
@@ -390,36 +209,4 @@
   return [sogoObject lastModified];
 }
 
-- (enum mapistore_error) setReadFlag: (uint8_t) flag
-{
-  /* Modify PidTagMessageFlags from SetMessageReadFlag and
-     SyncImportReadStateChanges ROPs */
-  NSNumber *flags;
-  uint32_t newFlag;
-
-  flags = [properties objectForKey: MAPIPropertyKey (PR_MESSAGE_FLAGS)];
-  if (flags)
-    {
-      newFlag = [flags unsignedLongValue];
-      if (flag & SUPPRESS_RECEIPT)
-        newFlag |= MSGFLAG_READ;
-      if (flag & CLEAR_RN_PENDING)
-        newFlag &= ~MSGFLAG_RN_PENDING;
-      if (flag & CLEAR_READ_FLAG)
-        newFlag &= ~MSGFLAG_READ;
-      if (flag & CLEAR_NRN_PENDING)
-        newFlag &= ~MSGFLAG_NRN_PENDING;
-    }
-  else
-    {
-      newFlag = MSGFLAG_READ;
-      if (flag & CLEAR_READ_FLAG)
-        newFlag = 0x0;
-    }
-  [properties setObject: [NSNumber numberWithUnsignedLong: newFlag]
-                 forKey: MAPIPropertyKey (PR_MESSAGE_FLAGS)];
-
-  return MAPISTORE_SUCCESS;
-}
-
 @end

OpenChange/MAPIStoreDBMessageTable.m

@@ -61,15 +61,14 @@ static Class MAPIStoreDBMessageK = Nil;
 
   if ((uint32_t) res->ulPropTag == PidTagChangeNumber)
     {
-      SEL operator;
-
       value = NSObjectFromMAPISPropValue (&res->lpProp);
       cVersion = exchange_globcnt (([value unsignedLongLongValue] >> 16)
                                    & 0x0000ffffffffffffLL);
       version = [NSNumber numberWithUnsignedLongLong: cVersion];
-      operator = [self operatorFromRestrictionOperator: res->relop];
-      *qualifier = [[EOKeyValueQualifier alloc] initWithKey: @"version_number"
-                                           operatorSelector: operator
+      //[self logWithFormat: @"change number from oxcfxics: %.16lx", [value unsignedLongLongValue]];
+      [self logWithFormat: @"  version: %.16lx", cVersion];
+      *qualifier = [[EOKeyValueQualifier alloc] initWithKey: @"version"
+                                           operatorSelector: EOQualifierOperatorGreaterThanOrEqualTo
                                                       value: version];
       [*qualifier autorelease];
       rc = MAPIRestrictionStateNeedsEval;

OpenChange/MAPIStoreFolder.h

@@ -121,7 +121,6 @@
                       fromFolder: (MAPIStoreFolder *) sourceFolder
                         withMIDs: (uint64_t *) targetMids
                    andChangeKeys: (struct Binary_r **) targetChangeKeys
-       andPredecessorChangeLists: (struct Binary_r **) targetPredecessorChangeLists
                         wantCopy: (uint8_t) want_copy
                         inMemCtx: (TALLOC_CTX *) memCtx;
 

OpenChange/MAPIStoreFolder.m

@@ -642,7 +642,6 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
                      fromFolder: (MAPIStoreFolder *) sourceFolder
                         withMID: (uint64_t) targetMid
                    andChangeKey: (struct Binary_r *) targetChangeKey
-       andPredecessorChangeList: (struct Binary_r *) targetPredecessorChangeList
                        wantCopy: (uint8_t) wantCopy
                        inMemCtx: (TALLOC_CTX *) memCtx
 {
@@ -670,18 +669,15 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
 
   [sourceMsg copyToMessage: destMsg  inMemCtx: memCtx];
 
-  if (targetPredecessorChangeList)
+  if (targetChangeKey)
     {
-      property.ulPropTag = PidTagPredecessorChangeList;
-      property.value.bin = *targetPredecessorChangeList;
+      property.ulPropTag = PidTagChangeKey;
+      property.value.bin = *targetChangeKey;
       aRow.cValues = 1;
       aRow.lpProps = &property;
       rc = [destMsg addPropertiesFromRow: &aRow];
       if (rc != MAPISTORE_SUCCESS)
-        {
-          [self errorWithFormat: @"Cannot add PredecessorChangeList on move"];
-          goto end;
-        }
+        goto end;
     }
   [destMsg save: memCtx];
   if (!wantCopy)
@@ -700,7 +696,6 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
                       fromFolder: (MAPIStoreFolder *) sourceFolder
                         withMIDs: (uint64_t *) targetMids
                    andChangeKeys: (struct Binary_r **) targetChangeKeys
-       andPredecessorChangeLists: (struct Binary_r **) targetPredecessorChangeLists
                         wantCopy: (uint8_t) wantCopy
                         inMemCtx: (TALLOC_CTX *) memCtx
 {
@@ -710,7 +705,7 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
   NSString *oldMessageURL;
   MAPIStoreMapping *mapping;
   SOGoUser *ownerUser;
-  struct Binary_r *targetChangeKey, *targetPredecessorChangeList;
+  struct Binary_r *targetChangeKey;
   //TALLOC_CTX *memCtx;
 
   //memCtx = talloc_zero (NULL, TALLOC_CTX);
@@ -731,21 +726,14 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
           if (oldMessageURL)
             {
               [oldMessageURLs addObject: oldMessageURL];
-              if (targetChangeKeys && targetPredecessorChangeList)
-                {
-                  targetChangeKey = targetChangeKeys[count];
-                  targetPredecessorChangeList = targetPredecessorChangeLists[count];
-                }
+              if (targetChangeKeys)
+                targetChangeKey = targetChangeKeys[count];
               else
-                {
-                  targetChangeKey = NULL;
-                  targetPredecessorChangeList = NULL;
-                }
+                targetChangeKey = NULL;
               rc = [self _moveCopyMessageWithMID: srcMids[count]
                                       fromFolder: sourceFolder
                                          withMID: targetMids[count]
                                     andChangeKey: targetChangeKey
-                        andPredecessorChangeList: targetPredecessorChangeList
                                         wantCopy: wantCopy
                                         inMemCtx: memCtx];
             }
@@ -1549,6 +1537,7 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
   struct Binary_r bin32;
   struct AddressBookEntryId *entryId;
   NSString *username;
+  struct ldb_context *samCtx;
 
   if (bin && bin->cb)
     {
@@ -1558,8 +1547,8 @@ Class NSExceptionK, MAPIStoreFAIMessageK, MAPIStoreMessageTableK, MAPIStoreFAIMe
       entryId = get_AddressBookEntryId (NULL, &bin32);
       if (entryId)
         {
-          username = MAPIStoreSamDBUserAttribute ([[self context] connectionInfo],
-                                                  @"legacyExchangeDN",
+          samCtx = [[self context] connectionInfo]->sam_ctx;
+          username = MAPIStoreSamDBUserAttribute (samCtx, @"legacyExchangeDN",
                                                   [NSString stringWithUTF8String: entryId->X500DN],
                                                   @"sAMAccountName");
         }

OpenChange/MAPIStoreGCSFolder.h

@@ -41,10 +41,8 @@
 
 /* synchronisation */
 - (BOOL) synchroniseCache;
-- (BOOL) synchroniseCacheFor: (NSString *) nameInContainer;
 - (void) updateVersionsForMessageWithKey: (NSString *) messageKey
-                           withChangeKey: (NSData *) oldChangeKey
-                andPredecessorChangeList: (NSData *) pcl;
+                           withChangeKey: (NSData *) newChangeKey;
 - (NSNumber *) lastModifiedFromMessageChangeNumber: (NSString *) changeNumber;
 - (NSString *) changeNumberForMessageWithKey: (NSString *) messageKey;
 - (NSData *) changeKeyForMessageWithKey: (NSString *) messageKey;

OpenChange/MAPIStoreGCSFolder.m

@@ -75,7 +75,6 @@ static Class NSNumberK;
           [SOGoMAPIDBMessage objectWithName: @"versions.plist"
                                 inContainer: dbFolder]);
   [versionsMessage setObjectType: MAPIInternalCacheObject];
-  [versionsMessage reloadIfNeeded];
 }
 
 - (void) dealloc
@@ -262,6 +261,7 @@ static Class NSNumberK;
  */
 - (void) _setChangeKey: (NSData *) changeKey
        forMessageEntry: (NSMutableDictionary *) messageEntry
+      inChangeListOnly: (BOOL) inChangeListOnly
 {
   struct XID *xid;
   NSString *guid;
@@ -270,15 +270,19 @@ static Class NSNumberK;
   NSMutableDictionary *changeList;
 
   xid = [changeKey asXIDInMemCtx: NULL];
-  guid = [NSString stringWithGUID: &xid->NameSpaceGuid];
-  globCnt = [NSData dataWithBytes: xid->LocalId.data length: xid->LocalId.length];
+  guid = [NSString stringWithGUID: &xid->GUID];
+  globCnt = [NSData dataWithBytes: xid->Data length: xid->Size];
   talloc_free (xid);
 
-  /* 1. set change key association */
-  changeKeyDict = [NSDictionary dictionaryWithObjectsAndKeys: guid, @"GUID",
-                                globCnt, @"LocalId",
-                                nil];
-  [messageEntry setObject: changeKeyDict forKey: @"ChangeKey"];
+  if (!inChangeListOnly)
+    {
+      /* 1. set change key association */
+      changeKeyDict = [NSDictionary dictionaryWithObjectsAndKeys:
+                                      guid, @"GUID",
+                                    globCnt, @"LocalId",
+                                    nil];
+      [messageEntry setObject: changeKeyDict forKey: @"ChangeKey"];
+    }
 
   /* 2. append/update predecessor change list */
   changeList = [messageEntry objectForKey: @"PredecessorChangeList"];
@@ -292,77 +296,6 @@ static Class NSNumberK;
   [changeList setObject: globCnt forKey: guid];
 }
 
-- (void) _updatePredecessorChangeList: (NSData *) predecessorChangeList
-                      forMessageEntry: (NSMutableDictionary *) messageEntry
-                     withOldChangeKey: (NSData *) oldChangeKey
-{
-  NSData *globCnt, *oldGlobCnt;
-  NSDictionary *changeKeyDict;
-  NSString *guid;
-  NSMutableDictionary *changeList;
-  struct SizedXid *sizedXIDList;
-  struct XID xid, *givenChangeKey;
-  TALLOC_CTX *localMemCtx;
-  uint32_t i, length;
-
-  localMemCtx = talloc_new (NULL);
-  if (!localMemCtx)
-    {
-      [self errorWithFormat: @"No more memory"];
-      return;
-    }
-
-  if (predecessorChangeList)
-    {
-      sizedXIDList = [predecessorChangeList asSizedXidArrayInMemCtx: localMemCtx with: &length];
-
-      changeList = [messageEntry objectForKey: @"PredecessorChangeList"];
-      if (!changeList)
-        {
-          changeList = [NSMutableDictionary new];
-          [messageEntry setObject: changeList
-                           forKey: @"PredecessorChangeList"];
-          [changeList release];
-        }
-
-      if (sizedXIDList) {
-        for (i = 0; i < length; i++)
-          {
-            xid = sizedXIDList[i].XID;
-            guid = [NSString stringWithGUID: &xid.NameSpaceGuid];
-            globCnt = [NSData dataWithBytes: xid.LocalId.data length: xid.LocalId.length];
-            oldGlobCnt = [changeList objectForKey: guid];
-            if (!oldGlobCnt || ([globCnt compare: oldGlobCnt] == NSOrderedDescending))
-              [changeList setObject: globCnt forKey: guid];
-          }
-      }
-    }
-
-  if (oldChangeKey)
-    {
-      givenChangeKey = [oldChangeKey asXIDInMemCtx: localMemCtx];
-      if (givenChangeKey) {
-        guid = [NSString stringWithGUID: &givenChangeKey->NameSpaceGuid];
-        globCnt = [NSData dataWithBytes: givenChangeKey->LocalId.data length: givenChangeKey->LocalId.length];
-
-        changeKeyDict = [messageEntry objectForKey: @"ChangeKey"];
-        if (!changeKeyDict ||
-            ([guid isEqualToString: [changeKeyDict objectForKey: @"GUID"]]
-             && ([globCnt compare: [changeKeyDict objectForKey: @"LocalId"]] == NSOrderedDescending)))
-          {
-            /* The given change key is greater than current one stored in
-               metadata or it does not exist */
-            [messageEntry setObject: [NSDictionary dictionaryWithObjectsAndKeys: guid, @"GUID",
-                                                   globCnt, @"LocalId",
-                                                   nil]
-                             forKey: @"ChangeKey"];
-          }
-      }
-    }
-
-  talloc_free (localMemCtx);
-}
-
 - (EOQualifier *) componentQualifier
 {
   if (!componentQualifier)
@@ -532,7 +465,8 @@ static Class NSNumberK;
 	      // A GLOBCNT structure is a 6-byte global namespace counter,
 	      // we strip the first 2 bytes. The first two bytes is the ReplicaId
               changeKey = [self getReplicaKeyFromGlobCnt: newChangeNum >> 16];
-              [self _setChangeKey: changeKey forMessageEntry: messageEntry];
+              [self _setChangeKey: changeKey forMessageEntry: messageEntry
+                 inChangeListOnly: NO];
             }
 
           now = [NSCalendarDate date];
@@ -548,123 +482,13 @@ static Class NSNumberK;
   return rc;
 }
 
-- (BOOL) synchroniseCacheFor: (NSString *) nameInContainer
-{
-  /* Try to synchronise old messages in versions.plist cache using an
-     specific c_name. It returns a boolean indicating if the
-     synchronisation was carried out succesfully.
-
-     It should be used as last resort, keeping synchroniseCache as the
-     main sync entry point. */
-
-  uint64_t changeNumber;
-  NSString *changeNumberStr;
-  NSData *changeKey;
-  NSNumber *cLastModified, *cDeleted, *cVersion;
-  EOFetchSpecification *fs;
-  EOQualifier *searchQualifier, *fetchQualifier;
-  NSArray *fetchResults;
-  NSDictionary *result;
-  NSMutableDictionary *currentProperties, *messages, *mapping, *messageEntry;
-  GCSFolder *ocsFolder;
-  static NSArray *fields;
-
-  [versionsMessage reloadIfNeeded];
-  currentProperties = [versionsMessage properties];
-
-  messages = [currentProperties objectForKey: @"Messages"];
-  if (!messages)
-    {
-        messages = [NSMutableDictionary new];
-        [currentProperties setObject: messages forKey: @"Messages"];
-        [messages release];
-    }
-
-  messageEntry = [messages objectForKey: nameInContainer];
-  if (!messageEntry)
-    {
-      /* Fetch the message by its name */
-      if (!fields)
-        fields = [[NSArray alloc]
-                  initWithObjects: @"c_name", @"c_version", @"c_lastmodified",
-                  @"c_deleted", nil];
-
-      searchQualifier = [[EOKeyValueQualifier alloc] initWithKey: @"c_name"
-                                     operatorSelector: EOQualifierOperatorEqual
-                                                value: nameInContainer];
-      fetchQualifier = [[EOAndQualifier alloc]
-                        initWithQualifiers: searchQualifier,
-                        [self contentComponentQualifier],
-                        nil];
-      [fetchQualifier autorelease];
-      [searchQualifier release];
-
-      ocsFolder = [sogoObject ocsFolder];
-      fs = [EOFetchSpecification
-            fetchSpecificationWithEntityName: [ocsFolder folderName]
-                                   qualifier: fetchQualifier
-                               sortOrderings: nil];
-      fetchResults = [ocsFolder fetchFields: fields
-                         fetchSpecification: fs
-                              ignoreDeleted: NO];
-
-      if ([fetchResults count] == 1)
-        {
-          result = [fetchResults objectAtIndex: 0];
-          cLastModified = [result objectForKey: @"c_lastmodified"];
-          cDeleted = [result objectForKey: @"c_deleted"];
-          if ([cDeleted isKindOfClass: NSNumberK] && [cDeleted intValue])
-            cVersion = [NSNumber numberWithInt: -1];
-          else
-            cVersion = [result objectForKey: @"c_version"];
-
-          changeNumber = [[self context] getNewChangeNumber];
-          changeNumberStr = [NSString stringWithUnsignedLongLong: changeNumber];
-
-          /* Create new message entry in Messages dict */
-          messageEntry = [NSMutableDictionary new];
-          [messages setObject: messageEntry forKey: nameInContainer];
-          [messageEntry release];
-
-          /* Store cLastModified, cVersion and the change number */
-          [messageEntry setObject: cLastModified forKey: @"c_lastmodified"];
-          [messageEntry setObject: cVersion forKey: @"c_version"];
-          [messageEntry setObject: changeNumberStr forKey: @"version"];
-
-          /* Store the change key */
-          changeKey = [self getReplicaKeyFromGlobCnt: changeNumber >> 16];
-          [self _setChangeKey: changeKey forMessageEntry: messageEntry];
-
-          /* Store the changeNumber -> cLastModified mapping */
-          mapping = [currentProperties objectForKey: @"VersionMapping"];
-          if (!mapping)
-            {
-              mapping = [NSMutableDictionary new];
-              [currentProperties setObject: mapping forKey: @"VersionMapping"];
-              [mapping release];
-            }
-          [mapping setObject: cLastModified forKey: changeNumberStr];
-
-          /* Save the message */
-          [versionsMessage save];
-          return YES;
-        }
-      else
-          return NO;
-    }
-
-  /* If message entry exists, then synchroniseCache did its job */
-  return YES;
-}
-
 - (void) updateVersionsForMessageWithKey: (NSString *) messageKey
-                           withChangeKey: (NSData *) oldChangeKey
-                andPredecessorChangeList: (NSData *) pcl
+                           withChangeKey: (NSData *) newChangeKey
 {
   NSMutableDictionary *messages, *messageEntry;
 
   [self synchroniseCache];
-  if (oldChangeKey || pcl)
+  if (newChangeKey)
     {
       messages = [[versionsMessage properties] objectForKey: @"Messages"];
       messageEntry = [messages objectForKey: messageKey];
@@ -672,8 +496,8 @@ static Class NSNumberK;
         [NSException raise: @"MAPIStoreIOException"
                     format: @"no version record found for message '%@'",
                      messageKey];
-      [self _updatePredecessorChangeList: pcl forMessageEntry: messageEntry
-                        withOldChangeKey: oldChangeKey];
+      [self _setChangeKey: newChangeKey forMessageEntry: messageEntry
+         inChangeListOnly: YES];
       [versionsMessage save];
     }
 }
@@ -681,12 +505,12 @@ static Class NSNumberK;
 - (NSNumber *) lastModifiedFromMessageChangeNumber: (NSString *) changeNumber
 {
   NSDictionary *mapping;
-  NSNumber *lastModified;
+  NSNumber *modseq;
 
   mapping = [[versionsMessage properties] objectForKey: @"VersionMapping"];
-  lastModified = [mapping objectForKey: changeNumber];
+  modseq = [mapping objectForKey: changeNumber];
 
-  return lastModified;
+  return modseq;
 }
 
 - (NSString *) changeNumberForMessageWithKey: (NSString *) messageKey

OpenChange/MAPIStoreGCSMessage.m

@@ -140,16 +140,9 @@
           [parentFolder synchroniseCache];
           changeKey = [parentFolder changeKeyForMessageWithKey: nameInContainer];
         }
-      if (changeKey)
-        *data = [changeKey asBinaryInMemCtx: memCtx];
-      else
-        {
-          [self warnWithFormat: @"No change key for %@ in folder %@",
-                nameInContainer,
-                [parentFolder url]
-           ];
-          rc = MAPISTORE_ERR_NOT_FOUND;
-        }
+      if (!changeKey)
+        abort ();
+      *data = [changeKey asBinaryInMemCtx: memCtx];
     }
 
   return rc;
@@ -187,8 +180,7 @@
 {
   uint64_t version = ULLONG_MAX;
   NSString *changeNumber;
-  BOOL synced;
-
+ 
   if (!isNew)
     {
       changeNumber = [(MAPIStoreGCSFolder *) container
@@ -197,28 +189,16 @@
         {
           [self warnWithFormat: @"attempting to get change number"
                 @" by synchronising folder..."];
-          synced = [(MAPIStoreGCSFolder *) container synchroniseCache];
-          if (synced)
+          [(MAPIStoreGCSFolder *) container synchroniseCache];
+          changeNumber = [(MAPIStoreGCSFolder *) container
+                            changeNumberForMessageWithKey: [self nameInContainer]];
+          
+          if (changeNumber)
+            [self logWithFormat: @"got one"];
+          else
             {
-              changeNumber = [(MAPIStoreGCSFolder *) container
-                                changeNumberForMessageWithKey: [self nameInContainer]];
-            }
-          if (!changeNumber)
-            {
-              [self warnWithFormat: @"attempting to get change number"
-                    @" by synchronising this specific message..."];
-              synced = [(MAPIStoreGCSFolder *) container
-                        synchroniseCacheFor: [self nameInContainer]];
-              if (synced)
-                {
-                  changeNumber = [(MAPIStoreGCSFolder *) container
-                                  changeNumberForMessageWithKey: [self nameInContainer]];
-                }
-              if (!changeNumber)
-                {
-                  [self errorWithFormat: @"still nothing. We crash!"];
-                  abort();
-                }
+              [self errorWithFormat: @"still nothing. We crash!"];
+              abort();
             }
         }
       version = [changeNumber unsignedLongLongValue] >> 16;
@@ -229,16 +209,13 @@
 
 - (void) updateVersions
 {
-  /* Update ChangeKey and PredecessorChangeList on message's save */
-  NSData *newChangeKey, *predecessorChangeList;
+  NSData *newChangeKey;
 
   newChangeKey = [properties objectForKey: MAPIPropertyKey (PR_CHANGE_KEY)];
-  predecessorChangeList = [properties objectForKey: MAPIPropertyKey (PR_PREDECESSOR_CHANGE_LIST)];
 
   [(MAPIStoreGCSFolder *) container
-      updateVersionsForMessageWithKey: [self nameInContainer]
-                        withChangeKey: newChangeKey
-             andPredecessorChangeList: predecessorChangeList];
+    updateVersionsForMessageWithKey: [self nameInContainer]
+                      withChangeKey: newChangeKey];
 }
 
 @end

OpenChange/MAPIStoreGCSMessageTable.m

@@ -27,7 +27,6 @@
 #import <Foundation/NSString.h>
 
 #import <NGExtensions/NSObject+Logs.h>
-#import <NGExtensions/NSObject+Values.h>
 
 #import <EOControl/EOFetchSpecification.h>
 #import <EOControl/EOQualifier.h>
@@ -39,6 +38,7 @@
 
 #import "MAPIStoreTypes.h"
 #import "MAPIStoreGCSFolder.h"
+
 #import "MAPIStoreGCSMessageTable.h"
 
 #undef DEBUG
@@ -89,31 +89,21 @@
 
   if (res->ulPropTag == PidTagChangeNumber)
     {
-      NSString *changeNumber;
-
       value = NSObjectFromMAPISPropValue (&res->lpProp);
-      changeNumber = [NSString stringWithUnsignedLongLong: [(NSNumber *)value unsignedLongLongValue]];
       lastModified = [(MAPIStoreGCSFolder *)
-                       container lastModifiedFromMessageChangeNumber: changeNumber];
+                       container lastModifiedFromMessageChangeNumber: value];
       //[self logWithFormat: @"change number from oxcfxics: %.16lx", [value unsignedLongLongValue]];
       //[self logWithFormat: @"  c_lastmodified: %@", lastModified];
       if (lastModified)
         {
-          SEL operator;
-
-          operator = [self operatorFromRestrictionOperator: res->relop];
           *qualifier = [[EOKeyValueQualifier alloc] initWithKey: @"c_lastmodified"
-                                               operatorSelector: operator
+                                               operatorSelector: EOQualifierOperatorGreaterThanOrEqualTo
                                                           value: lastModified];
           [*qualifier autorelease];
           rc = MAPIRestrictionStateNeedsEval;
         }
       else
-        {
-          [self logWithFormat: @"No last modified found for: 0x%.16"PRIx64". Then no restriction applied",
-                [value unsignedLongLongValue]];
-          rc = MAPIRestrictionStateAlwaysTrue;
-        }
+        rc = MAPIRestrictionStateAlwaysTrue;
     }
   else
     {

OpenChange/MAPIStoreMailAttachment.m

@@ -30,7 +30,6 @@
 #import <SOGo/NSArray+Utilities.h>
 #import <Mailer/SOGoMailBodyPart.h>
 #import <Mailer/SOGoMailObject.h>
-#import <Mailer/NSDictionary+Mail.h>
 
 #import "MAPIStoreTypes.h"
 #import "MAPIStoreMailMessage.h"
@@ -109,7 +108,7 @@
   static char recordBytes[] = {0xd9, 0xd8, 0x11, 0xa3, 0xe2, 0x90, 0x18, 0x41,
                                0x9e, 0x04, 0x58, 0x46, 0x9d, 0x6d, 0x1b,
                                0x68};
-
+  
   *data = [[NSData dataWithBytes: recordBytes length: 16]
             asBinaryInMemCtx: memCtx];
 
@@ -118,7 +117,19 @@
 
 - (NSString *) _fileName
 {
-  return [bodyInfo filename];
+  NSString *fileName;
+  NSDictionary *parameters;
+
+  fileName = [[bodyInfo objectForKey: @"parameterList"]
+               objectForKey: @"name"];
+  if (!fileName)
+    {
+      parameters = [[bodyInfo objectForKey: @"disposition"]
+                     objectForKey: @"parameterList"];
+      fileName = [parameters objectForKey: @"filename"];
+    }
+
+  return fileName;
 }
 
 - (int) getPidTagAttachLongFilename: (void **) data
@@ -167,7 +178,7 @@
 
 - (int) getPidTagAttachContentId: (void **) data
                         inMemCtx: (TALLOC_CTX *) memCtx
-{
+{ 
   *data = [[bodyInfo objectForKey: @"bodyId"]
             asUnicodeInMemCtx: memCtx];
 

OpenChange/MAPIStoreMailContext.m

@@ -160,25 +160,23 @@ MakeDisplayFolderName (NSString *folderName)
   for (count = 0; count < max; count++)
     {
       context = talloc_zero (memCtx, struct mapistore_contexts_list);
-      // secondaryFolders has the names (1) Imap4Encoded ,(2) asCSSIdentifier and (3) "folder"-prefixed
-      //     e.g.: folderProbl&AOg-mes_SP_de_SP_synchronisation
+      // secondaryFolders has the names (1) Imap4Encoded and (2) asCSSIdentifier
+      //     e.g.: Probl&AOg-mes_SP_de_SP_synchronisation
       currentName = [secondaryFolders objectAtIndex: count];
-      // To get the real name we have to revert that (applying the decode functions
-      // in reverse order)
+      // To get the real name we have to revert that (applying the decode functions)
+      // in reverse order
       //     e.g.: Problèmes de synchronisation
-      realName = [[[currentName substringFromIndex: 6]
-                                fromCSSIdentifier]
-                                stringByDecodingImap4FolderName];
+      realName = [[currentName fromCSSIdentifier]
+                               stringByDecodingImap4FolderName];
       // And finally to represent that as URI we have to (1) asCSSIdentifier,
-      // (2) Imap4Encode (3) AddPercentEscapes and (4) add the "folder" prefix
-      //     e.g.: folderProbl&AOg-mes_SP_de_SP_synchronisation
+      // (2) Imap4Encode and (3) AddPercentEscapes
+      //     e.g.: Probl&AOg-mes_SP_de_SP_synchronisation
       // In the example there are no percent escapes added because is already ok
       stringData = [[[realName asCSSIdentifier]
                                stringByEncodingImap4FolderName]
                                stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding];
-      stringData = [NSString stringWithFormat: @"folder%@", stringData];
       context->url = [[NSString stringWithFormat: @"%@%@", urlBase, stringData] asUnicodeInMemCtx: context];
-      context->name = [realName asUnicodeInMemCtx: context];
+      context->name = [[realName substringFromIndex: 6] asUnicodeInMemCtx: context];
       context->main_folder = false;
       context->role = MAPISTORE_MAIL_ROLE;
       context->tag = "tag";
@@ -202,7 +200,7 @@ MakeDisplayFolderName (NSString *folderName)
                                                andTDBIndexing: NULL];
   accountFolder = [[userContext rootFolders] objectForKey: @"mail"];
   folderName = [NSString stringWithFormat: @"folder%@",
-                         [[newFolderName stringByEncodingImap4FolderName] asCSSIdentifier]];
+                         [newFolderName asCSSIdentifier]];
   newFolder = [SOGoMailFolder objectWithName: folderName
                                  inContainer: accountFolder];
   if ([newFolder create])
@@ -211,7 +209,7 @@ MakeDisplayFolderName (NSString *folderName)
                                        withString: @"%40"],
                              [userName stringByReplacingOccurrencesOfString: @"@"
                                        withString: @"%40"],
-                             [folderName stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding]];
+                             [[folderName stringByEncodingImap4FolderName] stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding]];
   else
     mapistoreURI = nil;
 

OpenChange/MAPIStoreMailFolder.h

@@ -52,8 +52,6 @@
 - (NSString *) changeNumberForMessageUID: (NSString *) messageUid;
 - (void) setChangeKey: (NSData *) changeKey
     forMessageWithKey: (NSString *) messageKey;
-- (BOOL) updatePredecessorChangeListWith: (NSData *) changeKey
-                       forMessageWithKey: (NSString *) messageKey;
 - (NSData *) changeKeyForMessageWithKey: (NSString *) messageKey;
 - (NSData *) predecessorChangeListForMessageWithKey: (NSString *) messageKey;
 

OpenChange/MAPIStoreMailFolder.m

@@ -68,13 +68,10 @@
 
 static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
 
-#include <gen_ndr/exchange.h>
-
 #undef DEBUG
 #include <util/attr.h>
 #include <libmapi/libmapi.h>
 #include <libmapiproxy.h>
-#include <limits.h>
 #include <mapistore/mapistore.h>
 #include <mapistore/mapistore_errors.h>
 
@@ -112,7 +109,6 @@ static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
           [SOGoMAPIDBMessage objectWithName: @"versions.plist"
                                 inContainer: dbFolder]);
   [versionsMessage setObjectType: MAPIInternalCacheObject];
-  [versionsMessage reloadIfNeeded];
 }
 
 - (BOOL) ensureFolderExists
@@ -182,7 +178,7 @@ static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
       if (aRow->lpProps[i].ulPropTag == PR_DISPLAY_NAME_UNICODE)
         folderName = [NSString stringWithUTF8String: aRow->lpProps[i].value.lpszW];
       else if (aRow->lpProps[i].ulPropTag == PR_DISPLAY_NAME)
-        folderName = [NSString stringWithUTF8String: (const char *) aRow->lpProps[i].value.lpszA];
+        folderName = [NSString stringWithUTF8String: aRow->lpProps[i].value.lpszA];
     }
 
   if (folderName)
@@ -258,67 +254,6 @@ static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
   return MAPISTORE_SUCCESS;
 }
 
-- (EOQualifier *) simplifyQualifier: (EOQualifier *) qualifier
-{
-  /* Hack: Reduce the number of MODSEQ constraints to a single one as
-     we assume the difference among MODSEQs will be small enough to
-     return a small number of UIDs.
-
-     This is the only case we do simplify:
-     MODSEQ >= x | MODSEQ >= y | MODSEQ >= z => MODSEQ >= min(x,y,z)
-  */
-  if (qualifier && [qualifier isKindOfClass: [EOOrQualifier class]])
-    {
-      EOQualifier *simplifiedQualifier;
-      NSArray  *quals;
-      NSNumber *minModseq;
-      NSUInteger i, count;
-
-      quals = [(EOOrQualifier *)qualifier qualifiers];
-      count = [quals count];
-      if (count < 2)
-        return qualifier;
-
-      minModseq = [NSNumber numberWithUnsignedLongLong: ULLONG_MAX];
-
-      for (i = 0; i < count; i++)
-        {
-          EOQualifier *subQualifier;
-
-          subQualifier = [quals objectAtIndex: i];
-          if ([subQualifier isKindOfClass: [EOAndQualifier class]]
-              && [[(EOAndQualifier *)subQualifier qualifiers] count] == 1)
-            subQualifier = [[(EOAndQualifier *)subQualifier qualifiers] objectAtIndex: 0];
-
-          if ([subQualifier isKindOfClass: [EOKeyValueQualifier class]]
-              && [[(EOKeyValueQualifier *)subQualifier key] isEqualToString: @"MODSEQ"])
-            {
-              NSNumber *value;
-
-              value = (NSNumber *)[(EOKeyValueQualifier *)subQualifier value];
-              if ([minModseq compare: value] == NSOrderedDescending
-                  && [value unsignedLongLongValue] > 0)
-                minModseq = (NSNumber *)[(EOKeyValueQualifier *)subQualifier value];
-
-            }
-          else
-            return qualifier;
-        }
-
-      if ([minModseq unsignedLongLongValue] > 0 && [minModseq unsignedLongLongValue] < ULLONG_MAX)
-        {
-          simplifiedQualifier = [[EOKeyValueQualifier alloc]
-                                       initWithKey: @"MODSEQ"
-                                  operatorSelector: EOQualifierOperatorGreaterThanOrEqualTo
-                                             value: minModseq];
-          [simplifiedQualifier autorelease];
-          return simplifiedQualifier;
-        }
-    }
-
-  return qualifier;
-}
-
 - (EOQualifier *) nonDeletedQualifier
 {
   static EOQualifier *nonDeletedQualifier = nil;
@@ -343,7 +278,7 @@ static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
                           andSortOrderings: (NSArray *) sortOrderings
 {
   NSArray *uidKeys;
-  EOQualifier *fetchQualifier, *simplifiedQualifier;
+  EOQualifier *fetchQualifier;
 
   if ([self ensureFolderExists])
     {
@@ -352,10 +287,9 @@ static Class SOGoMailFolderK, MAPIStoreMailFolderK, MAPIStoreOutboxFolderK;
 
       if (qualifier)
         {
-          simplifiedQualifier = [self simplifyQualifier: qualifier];
           fetchQualifier
             = [[EOAndQualifier alloc] initWithQualifiers:
-                                        [self nonDeletedQualifier], simplifiedQualifier,
+                                        [self nonDeletedQualifier], qualifier,
                                       nil];
           [fetchQualifier autorelease];
         }
@@ -582,44 +516,6 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
   return [modseq1 compare: modseq2];
 }
 
-- (void) _updatePredecessorChangeListWith: (NSData *) predecessorChangeList
-                          forMessageEntry: (NSMutableDictionary *) messageEntry
-{
-  NSData *globCnt, *oldGlobCnt;
-  NSMutableDictionary *changeList;
-  NSString *guid;
-  struct SizedXid *sizedXIDList;
-  struct XID xid;
-  uint32_t i, length;
-
-  sizedXIDList = [predecessorChangeList asSizedXidArrayInMemCtx: NULL with: &length];
-
-  changeList = [messageEntry objectForKey: @"PredecessorChangeList"];
-  if (!changeList)
-    {
-      changeList = [NSMutableDictionary new];
-      [messageEntry setObject: changeList
-                    forKey: @"PredecessorChangeList"];
-      [changeList release];
-    }
-
-  if (sizedXIDList) {
-    for (i = 0; i < length; i++)
-      {
-        xid = sizedXIDList[i].XID;
-        guid = [NSString stringWithGUID: &xid.NameSpaceGuid];
-        globCnt = [NSData dataWithBytes: xid.LocalId.data length: xid.LocalId.length];
-        oldGlobCnt = [changeList objectForKey: guid];
-        if (!oldGlobCnt || ([globCnt compare: oldGlobCnt] == NSOrderedDescending))
-          [changeList setObject: globCnt forKey: guid];
-      }
-
-    talloc_free (sizedXIDList);
-  }
-
-  [versionsMessage save];
-}
-
 - (void) _setChangeKey: (NSData *) changeKey
        forMessageEntry: (NSMutableDictionary *) messageEntry
 {
@@ -630,8 +526,8 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
   NSMutableDictionary *changeList;
 
   xid = [changeKey asXIDInMemCtx: NULL];
-  guid = [NSString stringWithGUID: &xid->NameSpaceGuid];
-  globCnt = [NSData dataWithBytes: xid->LocalId.data length: xid->LocalId.length];
+  guid = [NSString stringWithGUID: &xid->GUID];
+  globCnt = [NSData dataWithBytes: xid->Data length: xid->Size];
   talloc_free (xid);
 
   /* 1. set change key association */
@@ -657,12 +553,13 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
 {
   BOOL rc = YES;
   uint64_t newChangeNum;
-  NSNumber *ti, *modseq, *lastModseq, *nextModseq;
+  NSNumber *ti, *modseq, *initialLastModseq, *lastModseq,
+    *nextModseq;
   NSString *changeNumber, *uid, *messageKey;
   uint64_t lastModseqNbr;
   EOQualifier *searchQualifier;
   NSArray *uids, *changeNumbers;
-  NSUInteger count, max, nFetched;
+  NSUInteger count, max;
   NSArray *fetchResults;
   NSDictionary *result;
   NSData *changeKey;
@@ -696,6 +593,7 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
     }
 
   lastModseq = [currentProperties objectForKey: @"SyncLastModseq"];
+  initialLastModseq = lastModseq;
   if (lastModseq)
     {
       lastModseqNbr = [lastModseq unsignedLongLongValue];
@@ -741,13 +639,6 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
         = [fetchResults sortedArrayUsingFunction: _compareFetchResultsByMODSEQ
                                          context: NULL];
 
-      nFetched = [fetchResults count];
-      if (nFetched != max) {
-        [self errorWithFormat: @"Error fetching UIDs. Asked: %d Received: %d."
-              @"Check the IMAP conversation for details", max, nFetched];
-        return NO;
-      }
-
       for (count = 0; count < max; count++)
         {
           result = [fetchResults objectAtIndex: count];
@@ -786,37 +677,40 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
     }
 
   /* 2. we synchronise expunged UIDs */
-  fetchResults = [(SOGoMailFolder *) sogoObject
-                     fetchUIDsOfVanishedItems: lastModseqNbr];
-
-  max = [fetchResults count];
-
-  changeNumber = nil;
-  for (count = 0; count < max; count++)
+  if (initialLastModseq)
     {
-      uid = [[fetchResults objectAtIndex: count] stringValue];
-      if ([messages objectForKey: uid])
+      fetchResults = [(SOGoMailFolder *) sogoObject
+                         fetchUIDsOfVanishedItems: lastModseqNbr];
+
+      max = [fetchResults count];
+
+      changeNumber = nil;
+      for (count = 0; count < max; count++)
         {
-          if (!changeNumber)
+          uid = [[fetchResults objectAtIndex: count] stringValue];
+          if ([messages objectForKey: uid])
             {
-              newChangeNum = [[self context] getNewChangeNumber];
-              changeNumber = [NSString stringWithUnsignedLongLong: newChangeNum];
+              if (!changeNumber)
+                {
+                  newChangeNum = [[self context] getNewChangeNumber];
+                  changeNumber = [NSString stringWithUnsignedLongLong: newChangeNum];
+                }
+              [messages removeObjectForKey: uid];
+              [self logWithFormat: @"Removed message entry for UID %@", uid];
+            }
+          else
+            {
+              [self logWithFormat:@"Message entry not found for UID %@", uid];
             }
-          [messages removeObjectForKey: uid];
-          [self logWithFormat: @"Removed message entry for UID %@", uid];
         }
-      else
+      if (changeNumber)
         {
-          [self logWithFormat:@"Message entry not found for UID %@", uid];
+          [currentProperties setObject: changeNumber
+                                forKey: @"SyncLastDeleteChangeNumber"];
+          [mapping setObject: lastModseq forKey: changeNumber];
+          foundChange = YES;
         }
     }
-  if (changeNumber)
-    {
-      [currentProperties setObject: changeNumber
-                            forKey: @"SyncLastDeleteChangeNumber"];
-      [mapping setObject: lastModseq forKey: changeNumber];
-      foundChange = YES;
-    }
 
   if (foundChange)
     {
@@ -1030,7 +924,8 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
   return changeNumber;
 }
 
-- (NSMutableDictionary *) _messageEntryFromMessageKey: (NSString *) messageKey
+- (void) setChangeKey: (NSData *) changeKey
+    forMessageWithKey: (NSString *) messageKey
 {
   NSMutableDictionary *messages, *messageEntry;
   NSString *messageUid;
@@ -1041,7 +936,7 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
   messageEntry = [messages objectForKey: messageUid];
   if (!messageEntry)
     {
-      [self warnWithFormat: @"attempting to synchronise to get the message entry for "
+      [self warnWithFormat: @"attempting to synchronise to set the change key for "
                             @"this message %@", messageKey];
       synced = [self synchroniseCacheForUID: messageUid];
       if (synced)
@@ -1052,57 +947,11 @@ _compareFetchResultsByMODSEQ (id entry1, id entry2, void *data)
           abort ();
         }
     }
-
-  return messageEntry;
-}
-
-- (void) setChangeKey: (NSData *) changeKey
-    forMessageWithKey: (NSString *) messageKey
-{
-  [self _setChangeKey: changeKey
-      forMessageEntry: [self _messageEntryFromMessageKey: messageKey]];
+  [self _setChangeKey: changeKey forMessageEntry: messageEntry];
 
   [versionsMessage save];
 }
 
-- (BOOL) updatePredecessorChangeListWith: (NSData *) changeKey
-                       forMessageWithKey: (NSString *) messageKey
-{
-  /* Update predecessor change list property given the change key. It
-     returns if the change key has been added to the list or not */
-  BOOL added = NO;
-  NSData *globCnt, *oldGlobCnt;
-  NSDictionary *messageEntry;
-  NSMutableDictionary *changeList;
-  NSString *guid;
-  struct XID *xid;
-
-  xid = [changeKey asXIDInMemCtx: NULL];
-  guid = [NSString stringWithGUID: &xid->NameSpaceGuid];
-  globCnt = [NSData dataWithBytes: xid->LocalId.data length: xid->LocalId.length];
-  talloc_free (xid);
-
-  messageEntry = [self _messageEntryFromMessageKey: messageKey];
-  if (messageEntry)
-    {
-      changeList = [messageEntry objectForKey: @"PredecessorChangeList"];
-      if (changeList)
-        {
-          oldGlobCnt = [changeList objectForKey: guid];
-          if (!oldGlobCnt || ([globCnt compare: oldGlobCnt] == NSOrderedDescending))
-            {
-              [changeList setObject: globCnt forKey: guid];
-              [versionsMessage save];
-              added = YES;
-            }
-        }
-      else
-        [self errorWithFormat: @"Missing predecessor change list to update"];
-    }
-
-  return added;
-}
-
 - (NSData *) changeKeyForMessageWithKey: (NSString *) messageKey
 {
   NSDictionary *messages, *changeKeyDict;
@@ -1368,7 +1217,6 @@ _parseCOPYUID (NSString *line, NSArray **destUIDsP)
                       fromFolder: (MAPIStoreFolder *) sourceFolder
                         withMIDs: (uint64_t *) targetMids
                    andChangeKeys: (struct Binary_r **) targetChangeKeys
-       andPredecessorChangeLists: (struct Binary_r **) targetPredecessorChangeLists
                         wantCopy: (uint8_t) wantCopy
                         inMemCtx: (TALLOC_CTX *) memCtx
 
@@ -1383,13 +1231,12 @@ _parseCOPYUID (NSString *line, NSArray **destUIDsP)
   NSDictionary *result;
   NSUInteger count;
   NSArray *a;
-  NSData *changeList;
+  NSData *changeKey;
 
   if (![sourceFolder isKindOfClass: [MAPIStoreMailFolder class]])
     return [super moveCopyMessagesWithMIDs: srcMids andCount: midCount
                                 fromFolder: sourceFolder withMIDs: targetMids
                              andChangeKeys: targetChangeKeys
-                 andPredecessorChangeLists: targetPredecessorChangeLists
                                   wantCopy: wantCopy
                                   inMemCtx: memCtx];
 
@@ -1478,11 +1325,11 @@ _parseCOPYUID (NSString *line, NSArray **destUIDsP)
       [self synchroniseCache];
       for (count = 0; count < midCount; count++)
         {
-          changeList = [NSData dataWithBinary: targetPredecessorChangeLists[count]];
+          changeKey = [NSData dataWithBinary: targetChangeKeys[count]];
           messageKey = [NSString stringWithFormat: @"%@.eml",
                                  [destUIDs objectAtIndex: count]];
-          [self _updatePredecessorChangeListWith: changeList
-                                 forMessageEntry: [self _messageEntryFromMessageKey: messageKey]];
+          [self   setChangeKey: changeKey
+             forMessageWithKey: messageKey];
         }
     }
 
@@ -1711,10 +1558,10 @@ _parseCOPYUID (NSString *line, NSArray **destUIDsP)
     rights |= RightsCreateItems;
   if ([roles containsObject: SOGoRole_ObjectEraser]
       && [roles containsObject: SOGoRole_FolderEraser])
-    rights |= RightsDeleteAll | RightsDeleteOwn;
+    rights |= RightsDeleteAll;
 
   if ([roles containsObject: SOGoRole_ObjectEditor])
-    rights |= RightsEditAll | RightsEditOwn;
+    rights |= RightsEditAll;
   if ([roles containsObject: SOGoRole_ObjectViewer])
     rights |= RightsReadItems;
   if ([roles containsObject: SOGoRole_FolderCreator])

OpenChange/MAPIStoreMailMessage.m

@@ -40,7 +40,6 @@
 #import <Mailer/NSData+Mail.h>
 #import <Mailer/SOGoMailBodyPart.h>
 #import <Mailer/SOGoMailObject.h>
-#import <Mailer/NSDictionary+Mail.h>
 
 #import "Codepages.h"
 #import "NSData+MAPIStore.h"
@@ -197,7 +196,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   count1 = [keys indexOfObject: data1];
   data2 = [entry2 objectForKey: @"mimeType"];
   count2 = [keys indexOfObject: data2];
-
+  
   if (count1 == count2)
     {
       data1 = [entry1 objectForKey: @"key"];
@@ -340,6 +339,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                                  wrapperWithICalEvent: event
                                               andUser: [context activeUser]
                                        andSenderEmail: senderEmail
+                                           inTimeZone: [[self userContext] timeZone]
                                    withConnectionInfo: [context connectionInfo]];
           [appointmentWrapper retain];
         }
@@ -521,9 +521,6 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   NSUInteger colIdx;
   NSString *stringValue;
 
-  /* As specified in [MS-OXCMAIL] 2.2.3.2.6.1, if there are three
-     or less characters followed by a colon at the beginning of
-     the subject, we can assume that's the subject prefix */
   subject = [self subject];
   colIdx = [subject rangeOfString: @":"].location;
   if (colIdx != NSNotFound && colIdx < 4)
@@ -532,52 +529,24 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   else
     stringValue = @"";
   *data = [stringValue asUnicodeInMemCtx: memCtx];
-
+  
   return MAPISTORE_SUCCESS;
 }
 
 - (int) getPidTagNormalizedSubject: (void **) data
                           inMemCtx: (TALLOC_CTX *) memCtx
 {
-  NSString *stringValue, *subject;
-  NSUInteger quoteStartIdx, quoteEndIdx, colIdx;
-  NSRange quoteRange;
-
-  if (!headerSetup)
-    [self _fetchHeaderData];
+  NSString *subject;
+  NSUInteger colIdx;
+  NSString *stringValue;
 
   subject = [self subject];
-  if (mailIsMeetingRequest)
-    {
-
-      /* SOGo "spices up" the invitation/update mail's subject, but
-         the client uses it to name the attendee's event, so we keep
-         only what's inside the quotes */
-      quoteStartIdx = [subject rangeOfString: @"\""].location;
-      quoteEndIdx = [subject rangeOfString: @"\""
-                                   options: NSBackwardsSearch].location;
-      if (quoteStartIdx != NSNotFound
-          && quoteEndIdx != NSNotFound
-          && quoteStartIdx != quoteEndIdx)
-        {
-            quoteRange = NSMakeRange(quoteStartIdx + 1, quoteEndIdx - quoteStartIdx - 1);
-            stringValue = [subject substringWithRange: quoteRange];
-        }
-      else stringValue = subject;
-    }
+  colIdx = [subject rangeOfString: @":"].location;
+  if (colIdx != NSNotFound && colIdx < 4)
+    stringValue = [[subject substringFromIndex: colIdx + 1]
+                    stringByTrimmingLeadSpaces];
   else
-    {
-
-      /* As specified in [MS-OXCMAIL] 2.2.3.2.6.1, if there are three
-         or less characters followed by a colon at the beginning of
-         the subject, we can assume that's the subject prefix */
-      colIdx = [subject rangeOfString: @":"].location;
-      if (colIdx != NSNotFound && colIdx < 4)
-        stringValue = [[subject substringFromIndex: colIdx + 1]
-                       stringByTrimmingLeadSpaces];
-      else
-        stringValue = subject;
-    }
+    stringValue = subject;
   if (!stringValue)
     stringValue = @"";
   *data = [stringValue asUnicodeInMemCtx: memCtx];
@@ -655,7 +624,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   NSDictionary *coreInfos;
   NSArray *flags;
   unsigned int v = 0;
-
+    
   coreInfos = [sogoObject fetchCoreInfos];
   flags = [coreInfos objectForKey: @"flags"];
 
@@ -667,7 +636,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   if ([[self attachmentKeys]
         count] > 0)
     v |= MSGFLAG_HASATTACH;
-
+    
   *data = MAPILongValue (memCtx, v);
 
   return MAPISTORE_SUCCESS;
@@ -687,7 +656,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
     v = 2;
   else
     v = 0;
-
+    
   *data = MAPILongValue (memCtx, v);
 
   return MAPISTORE_SUCCESS;
@@ -699,15 +668,15 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   NSDictionary *coreInfos;
   NSArray *flags;
   unsigned int v;
-
+    
   coreInfos = [sogoObject fetchCoreInfos];
-
+  
   flags = [coreInfos objectForKey: @"flags"];
   if ([flags containsObject: @"flagged"])
     v = 6;
   else
     v = 0;
-
+    
   *data = MAPILongValue (memCtx, v);
 
   return MAPISTORE_SUCCESS;
@@ -786,7 +755,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   if ([ngAddress isKindOfClass: [NGMailAddress class]])
     {
       cn = [ngAddress displayName];
-
+      
       // If we don't have a displayName, we use the email address instead. This
       // avoid bug #2119 - where Outlook won't display anything in the "From" field,
       // nor in the recipient field if we reply to the email.
@@ -810,6 +779,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   NSDictionary *contactInfos;
   NGMailAddress *ngAddress;
   NSData *entryId;
+  struct ldb_context *samCtx;
   int rc;
 
   if (fullMail)
@@ -832,13 +802,14 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
       if (contactInfos)
         {
           username = [contactInfos objectForKey: @"sAMAccountName"];
-          entryId = MAPIStoreInternalEntryId([[self context] connectionInfo], username);
+          samCtx = [[self context] connectionInfo]->sam_ctx;
+          entryId = MAPIStoreInternalEntryId (samCtx, username);
         }
       else
         entryId = MAPIStoreExternalEntryId (cn, email);
 
       *data = [entryId asBinaryInMemCtx: memCtx];
-
+      
       rc = MAPISTORE_SUCCESS;
     }
   else
@@ -995,15 +966,15 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
 {
   uint32_t v;
   NSString *s;
-
+    
   s = [[sogoObject mailHeaders] objectForKey: @"x-priority"];
   v = 0x1;
-
+    
   if ([s hasPrefix: @"1"]) v = 0x2;
   else if ([s hasPrefix: @"2"]) v = 0x2;
   else if ([s hasPrefix: @"4"]) v = 0x0;
   else if ([s hasPrefix: @"5"]) v = 0x0;
-
+    
   *data = MAPILongValue (memCtx, v);
 
   return MAPISTORE_SUCCESS;
@@ -1192,14 +1163,14 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
 
   if (!headerSetup)
     [self _fetchHeaderData];
-
+    
   if ([headerMimeType isEqualToString: @"text/plain"])
     format = EDITOR_FORMAT_PLAINTEXT;
   else if ([headerMimeType isEqualToString: @"text/html"])
     format = EDITOR_FORMAT_HTML;
   else
     format = 0; /* EDITOR_FORMAT_DONTKNOW */
-
+    
   *data = MAPILongValue (memCtx, format);
 
   return MAPISTORE_SUCCESS;
@@ -1475,9 +1446,11 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   NSData *entryId;
   NSDictionary *contactInfos;
   SOGoUserManager *mgr;
+  struct ldb_context *samCtx;
   struct mapistore_message *msgData;
   struct mapistore_message_recipient *recipient;
 
+  samCtx = [[self context] connectionInfo]->sam_ctx;
   [super getMessageData: &msgData inMemCtx: memCtx];
 
   if (!headerSetup)
@@ -1531,7 +1504,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                     {
                       username = [contactInfos objectForKey: @"sAMAccountName"];
                       recipient->username = [username asUnicodeInMemCtx: msgData];
-                      entryId = MAPIStoreInternalEntryId ([[self context] connectionInfo], username);
+                      entryId = MAPIStoreInternalEntryId (samCtx, username);
                     }
                   else
                     {
@@ -1544,7 +1517,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                   p = 0;
                   recipient->data = talloc_array (msgData, void *, msgData->columns->cValues);
                   memset (recipient->data, 0, msgData->columns->cValues * sizeof (void *));
-
+                  
                   // PR_OBJECT_TYPE = MAPI_MAILUSER (see MAPI_OBJTYPE)
                   recipient->data[p] = MAPILongValue (msgData, MAPI_MAILUSER);
                   p++;
@@ -1552,7 +1525,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                   // PR_DISPLAY_TYPE = DT_MAILUSER (see MS-NSPI)
                   recipient->data[p] = MAPILongValue (msgData, 0);
                   p++;
-
+              
                   // PR_7BIT_DISPLAY_NAME_UNICODE
                   recipient->data[p] = [cn asUnicodeInMemCtx: msgData];
                   p++;
@@ -1560,7 +1533,7 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                   // PR_SMTP_ADDRESS_UNICODE
                   recipient->data[p] = [email asUnicodeInMemCtx: msgData];
                   p++;
-
+              
                   // PR_SEND_INTERNET_ENCODING = 0x00060000 (plain text, see OXCMAIL)
                   recipient->data[p] = MAPILongValue (msgData, 0x00060000);
                   p++;
@@ -1593,9 +1566,12 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
                               withPrefix: (NSString *) keyPrefix
 {
   NSArray *parts;
+  NSDictionary *parameters;
   NSUInteger count, max;
 
-  if ([[bodyInfo filename] length] > 0)
+  parameters = [[bodyInfo objectForKey: @"disposition"]
+                 objectForKey: @"parameterList"];
+  if ([[parameters objectForKey: @"filename"] length] > 0)
     {
       if ([keyPrefix length] == 0)
         keyPrefix = @"0";
@@ -1669,13 +1645,15 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   return attachment;
 }
 
-- (enum mapistore_error) setReadFlag: (uint8_t) flag
+- (int) setReadFlag: (uint8_t) flag
 {
+  NSString *imapFlag = @"\\Seen";
+
   /* TODO: notifications should probably be emitted from here */
   if (flag & CLEAR_READ_FLAG)
-    [properties setObject: [NSNumber numberWithBool: NO] forKey: @"read_flag_set"];
+    [sogoObject removeFlags: imapFlag];
   else
-    [properties setObject: [NSNumber numberWithBool: YES] forKey: @"read_flag_set"];
+    [sogoObject addFlags: imapFlag];
 
   return MAPISTORE_SUCCESS;
 }
@@ -1716,12 +1694,9 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
   return nil;
 }
 
-- (void) save: (TALLOC_CTX *) memCtx
+- (void) save: (TALLOC_CTX *) memCtx 
 {
-  BOOL modified = NO;
-  BOOL seen, storedSeenFlag;
   NSNumber *value;
-  NSString *imapFlag = @"\\Seen";
 
   value = [properties objectForKey: MAPIPropertyKey (PR_FLAG_STATUS)];
   if (value)
@@ -1731,35 +1706,8 @@ _compareBodyKeysByPriority (id entry1, id entry2, void *data)
         [sogoObject addFlags: @"\\Flagged"];
       else /* 0: unflagged, 1: follow up complete */
         [sogoObject removeFlags: @"\\Flagged"];
-
-      modified = YES;
     }
 
-  /* Manage seen flag on save */
-  value = [properties objectForKey: @"read_flag_set"];
-  if (value)
-    {
-      seen = [value boolValue];
-      storedSeenFlag = [[[sogoObject fetchCoreInfos] objectForKey: @"flags"] containsObject: @"seen"];
-      /* We modify the flags anyway to generate a new change number */
-      if (seen)
-        {
-          if (storedSeenFlag)
-            [sogoObject removeFlags: imapFlag];
-          [sogoObject addFlags: imapFlag];
-        }
-      else
-        {
-          if (!storedSeenFlag)
-            [sogoObject addFlags: imapFlag];
-          [sogoObject removeFlags: imapFlag];
-        }
-      modified = YES;
-    }
-
-  if (modified)
-    [(MAPIStoreMailFolder *)[self container] synchroniseCache];
-
   if (mailIsSharingObject)
     [[self _sharingObject] saveWithMessage: self
                              andSOGoObject: sogoObject];

OpenChange/MAPIStoreMailMessageTable.m

@@ -161,30 +161,15 @@ static Class MAPIStoreMailMessageK, NSDataK, NSStringK;
         //[self logWithFormat: @"change number from oxcfxics: %.16lx", [value unsignedLongLongValue]];
         //[self logWithFormat: @"  modseq: %.16lx", [modseq unsignedLongLongValue]];
         if (modseq)
-          {
-            if (res->relop == RELOP_GT)
-              modseq = [NSNumber numberWithUnsignedLongLong:
-                                   [modseq unsignedLongLongValue] + 1];
-
-          }
+          modseq = [NSNumber numberWithUnsignedLongLong:
+                               [modseq unsignedLongLongValue] + 1];
         else
           modseq = [NSNumber numberWithUnsignedLongLong: 0];
-
-        if (res->relop == RELOP_GT || res->relop == RELOP_GE)
-          {
-            *qualifier = [[EOKeyValueQualifier alloc] initWithKey: @"MODSEQ"
-                                                 operatorSelector: EOQualifierOperatorGreaterThanOrEqualTo
-                                                            value: modseq];
-            [*qualifier autorelease];
-            rc = MAPIRestrictionStateNeedsEval;
-          }
-        else
-          {
-            /* Ignore other operations as IMAP only support MODSEQ >= X */
-            [self warnWithFormat: @"Ignoring '%@' as only supported operators are > and >=",
-                  NSStringFromSelector ([self operatorFromRestrictionOperator: res->relop])];
-            rc = MAPIRestrictionStateAlwaysTrue;
-          }
+        *qualifier = [[EOKeyValueQualifier alloc] initWithKey: @"MODSEQ"
+                                                  operatorSelector: EOQualifierOperatorGreaterThanOrEqualTo
+                                                  value: modseq];
+        [*qualifier autorelease];
+        rc = MAPIRestrictionStateNeedsEval;
       }
       break;
       

OpenChange/MAPIStoreMailVolatileMessage.m

@@ -34,7 +34,6 @@
 #import <NGExtensions/NGBase64Coding.h>
 #import <NGExtensions/NGHashMap.h>
 #import <NGExtensions/NSObject+Logs.h>
-#import <NGExtensions/NSObject+Values.h>
 #import <NGExtensions/NSString+Encoding.h>
 #import <NGMime/NGMimeBodyPart.h>
 #import <NGMime/NGMimeMultipartBody.h>
@@ -167,9 +166,9 @@ static NSString *recTypes[] = { @"orig", @"to", @"cc", @"bcc" };
 
 - (BOOL) hasContentId
 {
-  NSString *contentId = [properties
-                          objectForKey: MAPIPropertyKey (PR_ATTACH_CONTENT_ID_UNICODE)];
-  return contentId && [contentId length] > 0;
+  return ([properties
+            objectForKey: MAPIPropertyKey (PR_ATTACH_CONTENT_ID_UNICODE)]
+          != nil);
 }
 
 - (NGMimeBodyPart *) asMIMEBodyPart
@@ -233,7 +232,7 @@ static NSString *recTypes[] = { @"orig", @"to", @"cc", @"bcc" };
       [map addObject: contentDisposition forKey: @"content-disposition"];
       contentId = [properties
                      objectForKey: MAPIPropertyKey (PR_ATTACH_CONTENT_ID_UNICODE)];
-      if (contentId && [contentId length] > 0)
+      if (contentId)
         [map setObject: [NSString stringWithFormat: @"<%@>", contentId]
                 forKey: @"content-id"];
       bodyPart = [NGMimeBodyPart bodyPartWithHeader: map];
@@ -286,7 +285,7 @@ static NSString *recTypes[] = { @"orig", @"to", @"cc", @"bcc" };
   version = [properties objectForKey: @"version"];
 
   return (version
-          ? [version unsignedLongLongValue]
+          ? exchange_globcnt ([version unsignedLongLongValue])
           : ULLONG_MAX);
 }
 
@@ -338,10 +337,13 @@ static NSString *recTypes[] = { @"orig", @"to", @"cc", @"bcc" };
   NSData *entryId;
   NSDictionary *allRecipients, *dict, *contactInfos;
   SOGoUserManager *mgr;
+  struct ldb_context *samCtx;
   struct mapistore_message *msgData;
   struct mapistore_message_recipient *recipient;
   enum ulRecipClass type;
 
+  samCtx = [[self context] connectionInfo]->sam_ctx;
+
   // [super getMessageData: &msgData inMemCtx: memCtx];
 
   msgData = talloc_zero (memCtx, struct mapistore_message);
@@ -386,7 +388,7 @@ static NSString *recTypes[] = { @"orig", @"to", @"cc", @"bcc" };
             {
               username = [contactInfos objectForKey: @"sAMAccountName"];
               recipient->username = [username asUnicodeInMemCtx: msgData];
-              entryId = MAPIStoreInternalEntryId ([[self context] connectionInfo], username);
+              entryId = MAPIStoreInternalEntryId (samCtx, username);
             }
           else
             {
@@ -679,14 +681,6 @@ FillMessageHeadersFromProperties (NGMutableHashMap *headers,
 
   if (!fromResolved)
     {
-      TALLOC_CTX *local_mem_ctx;
-      local_mem_ctx = talloc_new(NULL);
-      if (!local_mem_ctx)
-        {
-          NSLog (@"%s: Out of memory", __PRETTY_FUNCTION__);
-          return;
-        }
-
       NSLog (@"Message without an orig from, try to guess it from PidTagSenderEntryId");
       senderEntryId = [mailProperties objectForKey: MAPIPropertyKey (PR_SENDER_ENTRYID)];
       if (senderEntryId)
@@ -700,12 +694,12 @@ FillMessageHeadersFromProperties (NGMutableHashMap *headers,
 
           bin32.cb = [senderEntryId length];
           bin32.lpb = (uint8_t *) [senderEntryId bytes];
-          addrBookEntryId = get_AddressBookEntryId (local_mem_ctx, &bin32);
+          addrBookEntryId = get_AddressBookEntryId (connInfo->sam_ctx, &bin32);
           if (addrBookEntryId && [[NSString stringWithGUID: &addrBookEntryId->ProviderUID]
                                    hasSuffix: @"08002b2fe182"])
             {
               /* TODO: better way to distinguish local and other ones */
-              username = MAPIStoreSamDBUserAttribute (connInfo, @"legacyExchangeDN",
+              username = MAPIStoreSamDBUserAttribute (connInfo->sam_ctx, @"legacyExchangeDN",
                                                       [NSString stringWithUTF8String: addrBookEntryId->X500DN], @"sAMAccountName");
               if (username)
                 {
@@ -726,7 +720,7 @@ FillMessageHeadersFromProperties (NGMutableHashMap *headers,
               /* Try with One-Off EntryId */
               struct OneOffEntryId *oneOffEntryId;
 
-              oneOffEntryId = get_OneOffEntryId (local_mem_ctx, &bin32);
+              oneOffEntryId = get_OneOffEntryId (connInfo->sam_ctx, &bin32);
               if (oneOffEntryId && [[NSString stringWithGUID: &oneOffEntryId->ProviderUID]
                                      hasSuffix: @"00dd010f5402"])
                 {
@@ -735,7 +729,9 @@ FillMessageHeadersFromProperties (NGMutableHashMap *headers,
                   [fromRecipient setObject: [NSString stringWithUTF8String: oneOffEntryId->EmailAddress.lpszW]
                                     forKey: @"email"];
                 }
+              talloc_free (oneOffEntryId);
             }
+          talloc_free (addrBookEntryId);
 
           if ([[fromRecipient allKeys] count] > 0)
             {
@@ -745,8 +741,6 @@ FillMessageHeadersFromProperties (NGMutableHashMap *headers,
             }
 
         }
-      /* Free entryId */
-      talloc_free(local_mem_ctx);
     }
 
   if (!recipients)
@@ -1013,7 +1007,7 @@ MakeMessageBody (NSDictionary *mailProperties, NSDictionary *attachmentParts, NS
 - (NGMimeMessage *) _generateMessageWithBcc: (BOOL) withBcc
 {
   NSString *contentType;
-  NGMimeMessage *message;
+  NGMimeMessage *message;  
   NGMutableHashMap *headers;
   id messageBody;
 
@@ -1053,7 +1047,6 @@ MakeMessageBody (NSDictionary *mailProperties, NSDictionary *attachmentParts, NS
 
 - (int) submitWithFlags: (enum SubmitFlags) flags
 {
-  enum mapistore_error rc = MAPISTORE_SUCCESS;
   NSDictionary *recipients;
   NSData *messageData;
   NSMutableArray *recipientEmails;
@@ -1100,10 +1093,7 @@ MakeMessageBody (NSDictionary *mailProperties, NSDictionary *attachmentParts, NS
                   withAuthenticator: authenticator
                           inContext: woContext];
       if (error)
-        {
-          [self errorWithFormat: @"an error occurred: '%@'", error];
-          rc = MAPISTORE_ERR_MSG_SEND;
-        }
+        [self logWithFormat: @"an error occurred: '%@'", error];
 
       // mapping = [self mapping];
       // [mapping unregisterURLWithID: [self objectId]];
@@ -1115,13 +1105,12 @@ MakeMessageBody (NSDictionary *mailProperties, NSDictionary *attachmentParts, NS
     [self logWithFormat: @"skipping submit of message with class '%@'",
           msgClass];
 
-  return rc;
+  return MAPISTORE_SUCCESS;
 }
 
 - (void) save: (TALLOC_CTX *) memCtx
 {
-  BOOL updatedMetadata;
-  NSString *folderName, *flag, *newIdString, *messageKey, *changeNumber;
+  NSString *folderName, *flag, *newIdString, *messageKey;
   NSData *changeKey, *messageData;
   NGImap4Connection *connection;
   NGImap4Client *client;
@@ -1157,33 +1146,21 @@ MakeMessageBody (NSDictionary *mailProperties, NSDictionary *attachmentParts, NS
       [sogoObject setNameInContainer: messageKey];
       [mapping registerURL: [self url] withID: mid];
 
-      /* synchronise the cache and update the predecessor change list
-         with the change key provided by the client. Before doing
-         this, lets issue a unselect/select combo because of timing
-         issues with Dovecot in obtaining the latest modseq.
-         Sometimes, Dovecot doesn't return the newly appended UID if
-         we do a "UID SORT (DATE) UTF-8 (MODSEQ XYZ) (NOT DELETED)"
-         command (where XYZ is the HIGHESTMODSEQ+1) immediately after
-         IMAP APPEND */
+      /* synchronise the cache and update the change key with the one provided
+         by the client. Before doing this, lets issue a unselect/select combo 
+         because of timing issues with Dovecot in obtaining the latest modseq.
+         Sometimes, Dovecot doesn't return the newly appended UID if we do
+         a "UID SORT (DATE) UTF-8 (MODSEQ XYZ) (NOT DELETED)" command (where
+         XYZ is the HIGHESTMODSEQ+1) immediately after IMAP APPEND */
       [client unselect];
       [client select: folderName];
 
       [(MAPIStoreMailFolder *) container synchroniseCache];
       changeKey = [properties objectForKey: MAPIPropertyKey (PR_CHANGE_KEY)];
       if (changeKey)
-        {
-          updatedMetadata = [(MAPIStoreMailFolder *) container updatePredecessorChangeListWith: changeKey
-                                                                             forMessageWithKey: messageKey];
-          if (!updatedMetadata)
-            [self warnWithFormat: @"Predecessor change list not updated with client data"];
-        }
-
-      /* Update version property (PR_CHANGE_KEY indeed) as it is
-         requested once it is saved */
-      changeNumber = [(MAPIStoreMailFolder *) container changeNumberForMessageUID: newIdString];
-      if (changeNumber)
-        [properties setObject: [NSNumber numberWithUnsignedLongLong: [changeNumber unsignedLongLongValue] >> 16]
-                       forKey: @"version"];
+        [(MAPIStoreMailFolder *) container
+                setChangeKey: changeKey
+           forMessageWithKey: messageKey];
     }
 }
 

OpenChange/MAPIStoreMessage.h

@@ -63,7 +63,7 @@
               withAID: (uint32_t) aid;
 - (int) getAttachmentTable: (MAPIStoreAttachmentTable **) tablePtr
                andRowCount: (uint32_t *) countPtr;
-- (enum mapistore_error) setReadFlag: (uint8_t) flag;
+- (int) setReadFlag: (uint8_t) flag;
 - (enum mapistore_error) saveMessage: (TALLOC_CTX *) memCtx;
 
 - (NSArray *) activeContainerMessageTables;

OpenChange/MAPIStoreMessage.m

@@ -549,12 +549,11 @@ rtf2html (NSData *compressedRTF)
         }
   
       [self save: memCtx];
-      /* We make sure that any change-related properties are removed from the
+      /* We make sure that any change-related properties are removes from the
          properties dictionary, to make sure that related methods will be
          invoked the next time they are requested. */
       [properties removeObjectForKey: MAPIPropertyKey (PidTagChangeKey)];
       [properties removeObjectForKey: MAPIPropertyKey (PidTagChangeNumber)];
-      [properties removeObjectForKey: MAPIPropertyKey (PidTagPredecessorChangeList)];
 
       if ([container isKindOfClass: MAPIStoreFolderK])
         {
@@ -919,7 +918,7 @@ rtf2html (NSData *compressedRTF)
   return [self getNo: data inMemCtx: memCtx];;
 }
 
-- (enum mapistore_error) setReadFlag: (uint8_t) flag
+- (int) setReadFlag: (uint8_t) flag
 {
   // [self subclassResponsibility: _cmd];
 

OpenChange/MAPIStorePermissionsTable.m

@@ -103,7 +103,7 @@
   else
     {
       connInfo = [(MAPIStoreContext *) [container context] connectionInfo];
-      entryId = MAPIStoreInternalEntryId (connInfo, userId);
+      entryId = MAPIStoreInternalEntryId (connInfo->sam_ctx, userId);
     }
   *data = [entryId asBinaryInMemCtx: memCtx];
 

OpenChange/MAPIStoreRecurrenceUtils.h

@@ -25,9 +25,12 @@
 
 #include <talloc.h>
 
+#import <Foundation/NSTimeZone.h>
+
 #import <NGCards/iCalCalendar.h>
 #import <NGCards/iCalRecurrenceRule.h>
-#import <NGCards/iCalTimeZone.h>
+
+@class NSTimeZone;
 
 @class iCalEvent;
 @class iCalRepeatableEntityObject;
@@ -43,7 +46,7 @@
                    fromRecurrencePattern: (struct RecurrencePattern *) rp
                           withExceptions: (struct ExceptionInfo *) exInfos
                        andExceptionCount: (uint16_t) exInfoCount
-                              inTimeZone: (iCalTimeZone *) tz;
+                              inTimeZone: (NSTimeZone *) tz;
 
 @end
 
@@ -51,6 +54,7 @@
 
 - (void) fillRecurrencePattern: (struct RecurrencePattern *) rp
                      withEvent: (iCalEvent *) event
+                    inTimeZone: (NSTimeZone *) timeZone
                       inMemCtx: (TALLOC_CTX *) memCtx;
 
 @end

OpenChange/MAPIStoreRecurrenceUtils.m

@@ -24,6 +24,7 @@
 #import <Foundation/NSCalendarDate.h>
 #import <Foundation/NSSet.h>
 #import <Foundation/NSString.h>
+#import <Foundation/NSTimeZone.h>
 
 #import <NGExtensions/NSCalendarDate+misc.h>
 #import <NGExtensions/NSObject+Logs.h>
@@ -34,7 +35,6 @@
 #import <NGCards/iCalRepeatableEntityObject.h>
 #import <NGCards/iCalRecurrenceRule.h>
 #import <NGCards/iCalTimeZone.h>
-#import <NGCards/iCalTimeZonePeriod.h>
 
 #import "NSDate+MAPIStore.h"
 #import "MAPIStoreRecurrenceUtils.h"
@@ -51,7 +51,7 @@
                    fromRecurrencePattern: (struct RecurrencePattern *) rp
                           withExceptions: (struct ExceptionInfo *) exInfos
                        andExceptionCount: (uint16_t) exInfoCount
-                              inTimeZone: (iCalTimeZone *) tz
+                              inTimeZone: (NSTimeZone *) tz
 
 {
   NSCalendarDate *startDate, *olEndDate, *untilDate, *exDate;
@@ -63,7 +63,7 @@
   iCalWeekOccurrence weekOccurrence;
   iCalWeekOccurrences dayMaskDays;
   NSUInteger count, max;
-  NSInteger bySetPos, tzOffset;
+  NSInteger bySetPos;
   unsigned char maskValue;
 
   [entity removeAllRecurrenceRules];
@@ -242,10 +242,9 @@
           {
             /* The OriginalStartDate is in local time */
             exDate = [NSDate dateFromMinutesSince1601: exInfos[count].OriginalStartDate];
-            tzOffset = -[[tz periodForDate: exDate] secondsOffsetFromGMT];
             exDate = [exDate dateByAddingYears: 0 months: 0 days: 0
                                          hours: 0 minutes: 0
-                                       seconds: tzOffset];
+                                       seconds: - [tz secondsFromGMT]];
             [exceptionDates removeObject: exDate];
           }
       }
@@ -264,6 +263,7 @@
 
 - (void) fillRecurrencePattern: (struct RecurrencePattern *) rp
                      withEvent: (iCalEvent *) event
+                    inTimeZone: (NSTimeZone *) timeZone
                       inMemCtx: (TALLOC_CTX *) memCtx
 {
   iCalRecurrenceFrequency freq;
@@ -279,8 +279,10 @@
   NSMutableArray *deletedDates, *modifiedDates;
 
   startDate = [event firstRecurrenceStartDate];
+  [startDate setTimeZone: timeZone];
   endDate = [event lastPossibleRecurrenceStartDate];
-
+  [endDate setTimeZone: timeZone];
+  
   rp->ReaderVersion = 0x3004;
   rp->WriterVersion = 0x3004;
 

OpenChange/MAPIStoreSOGo.m

@@ -64,11 +64,11 @@ static BOOL initialization_done = NO;
     } \
     OC_DEBUG(5, "[SOGo] --->");
 
-#define NS_CURRENT_THREAD_TRY_UNREGISTER(rc) \
+#define NS_CURRENT_THREAD_TRY_UNREGISTER() \
     if (__nsrct_thread_registered) { \
         GSUnregisterCurrentThread(); \
     } \
-    OC_DEBUG(6, "[SOGo] <--- [%s]", mapistore_errstr (rc));
+    OC_DEBUG(6, "[SOGo] <---");
 
 #define TRYCATCH_START @try {
 #define TRYCATCH_END(pool)  \
@@ -76,7 +76,7 @@ static BOOL initialization_done = NO;
             enum mapistore_error ret = sogo_backend_handle_objc_exception(e, __PRETTY_FUNCTION__, __LINE__); \
             mapiapp_cleanup(); \
             [pool release]; \
-            NS_CURRENT_THREAD_TRY_UNREGISTER(ret); \
+            NS_CURRENT_THREAD_TRY_UNREGISTER(); \
             return ret; \
           } \
         mapiapp_cleanup();
@@ -253,7 +253,7 @@ sogo_backend_create_context(TALLOC_CTX *mem_ctx,
     rc = MAPISTORE_ERROR;
 
   [pool release];
-  NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+  NS_CURRENT_THREAD_TRY_UNREGISTER();
 
   return rc;
 }
@@ -291,7 +291,7 @@ sogo_backend_create_root_folder (const char *username,
     rc = MAPISTORE_ERROR;
 
   [pool release];
-  NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+  NS_CURRENT_THREAD_TRY_UNREGISTER();
 
   return rc;
 }
@@ -322,7 +322,7 @@ sogo_backend_list_contexts(const char *username, struct indexing_context *indexi
     rc = MAPISTORE_ERROR;
 
   [pool release];
-  NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+  NS_CURRENT_THREAD_TRY_UNREGISTER();
 
   return rc;
 }
@@ -363,7 +363,7 @@ sogo_context_get_path(void *backend_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -397,7 +397,7 @@ sogo_context_get_root_folder(void *backend_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -439,7 +439,7 @@ sogo_folder_open_folder(void *folder_object, TALLOC_CTX *mem_ctx, uint64_t fid,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -480,7 +480,7 @@ sogo_folder_create_folder(void *folder_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -519,7 +519,7 @@ sogo_folder_delete(void *folder_object)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -549,7 +549,7 @@ sogo_folder_get_child_count(void *folder_object, enum mapistore_table_type table
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -588,7 +588,7 @@ sogo_folder_open_message(void *folder_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -627,7 +627,7 @@ sogo_folder_create_message(void *folder_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -657,7 +657,7 @@ sogo_folder_delete_message(void *folder_object, uint64_t mid, uint8_t flags)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -674,7 +674,6 @@ sogo_folder_move_copy_messages(void *folder_object,
                                uint32_t mid_count,
                                uint64_t *src_mids, uint64_t *t_mids,
                                struct Binary_r **target_change_keys,
-                               struct Binary_r **target_predecessor_change_lists,
                                uint8_t want_copy)
 {
   MAPIStoreFolder *sourceFolder, *targetFolder;
@@ -699,13 +698,12 @@ sogo_folder_move_copy_messages(void *folder_object,
                                        fromFolder: sourceFolder
                                          withMIDs: t_mids
                                     andChangeKeys: target_change_keys
-                        andPredecessorChangeLists: target_predecessor_change_lists
                                          wantCopy: want_copy
                                          inMemCtx: mem_ctx];
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -753,7 +751,7 @@ sogo_folder_move_folder(void *folder_object, void *target_folder_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -795,7 +793,7 @@ sogo_folder_copy_folder(void *folder_object, void *target_folder_object, TALLOC_
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -831,7 +829,7 @@ sogo_folder_get_deleted_fmids(void *folder_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -869,7 +867,7 @@ sogo_folder_open_table(void *folder_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -903,7 +901,7 @@ sogo_folder_modify_permissions(void *folder_object, uint8_t flags,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -934,7 +932,7 @@ sogo_folder_preload_message_bodies(void *folder_object, enum mapistore_table_typ
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -967,8 +965,8 @@ sogo_message_get_message_data(void *message_object,
       TRYCATCH_END(pool)
 
       [pool release];
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
       rc = MAPISTORE_SUCCESS;
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
     }
   else
     {
@@ -1001,7 +999,7 @@ sogo_message_create_attachment (void *message_object, TALLOC_CTX *mem_ctx, void
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1035,7 +1033,7 @@ sogo_message_open_attachment (void *message_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1069,7 +1067,7 @@ sogo_message_get_attachment_table (void *message_object, TALLOC_CTX *mem_ctx, vo
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1104,7 +1102,7 @@ sogo_message_modify_recipients (void *message_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1120,7 +1118,7 @@ sogo_message_set_read_flag (void *message_object, uint8_t flag)
   struct MAPIStoreTallocWrapper *wrapper;
   NSAutoreleasePool *pool;
   MAPIStoreMessage *message;
-  enum mapistore_error rc;
+  int rc;
 
   if (message_object)
     {
@@ -1134,7 +1132,7 @@ sogo_message_set_read_flag (void *message_object, uint8_t flag)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1164,7 +1162,7 @@ sogo_message_save (void *message_object, TALLOC_CTX *mem_ctx)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1194,7 +1192,7 @@ sogo_message_submit (void *message_object, enum SubmitFlags flags)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1234,7 +1232,7 @@ sogo_message_attachment_open_embedded_message (void *attachment_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1272,7 +1270,7 @@ sogo_message_attachment_create_embedded_message (void *attachment_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1302,7 +1300,7 @@ static enum mapistore_error sogo_table_get_available_properties(void *table_obje
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1333,7 +1331,7 @@ sogo_table_set_columns (void *table_object, uint16_t count, enum MAPITAGS *prope
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1366,7 +1364,7 @@ sogo_table_set_restrictions (void *table_object, struct mapi_SRestriction *restr
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1399,7 +1397,7 @@ sogo_table_set_sort_order (void *table_object, struct SSortOrderSet *sort_order,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1432,7 +1430,7 @@ sogo_table_get_row (void *table_object, TALLOC_CTX *mem_ctx,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1465,7 +1463,7 @@ sogo_table_get_row_count (void *table_object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1495,8 +1493,8 @@ sogo_table_handle_destructor (void *table_object, uint32_t handle_id)
       TRYCATCH_END(pool)
 
       [pool release];
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
       rc = MAPISTORE_SUCCESS;
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
     }
   else
     {
@@ -1527,7 +1525,7 @@ static enum mapistore_error sogo_properties_get_available_properties(void *objec
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1562,7 +1560,7 @@ sogo_properties_get_properties (void *object,
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1592,7 +1590,7 @@ sogo_properties_set_properties (void *object, struct SRow *aRow)
       TRYCATCH_END(pool)
 
       [pool release];
-      NS_CURRENT_THREAD_TRY_UNREGISTER(rc);
+      NS_CURRENT_THREAD_TRY_UNREGISTER();
     }
   else
     {
@@ -1646,7 +1644,7 @@ sogo_manager_generate_uri (TALLOC_CTX *mem_ctx,
   TRYCATCH_END(pool)
 
   [pool release];
-  NS_CURRENT_THREAD_TRY_UNREGISTER(MAPISTORE_SUCCESS);
+  NS_CURRENT_THREAD_TRY_UNREGISTER();
 
   return MAPISTORE_SUCCESS;
 }

OpenChange/MAPIStoreSOGoObject.m

@@ -197,7 +197,6 @@ static Class MAPIStoreFolderK;
                      inMemCtx: (TALLOC_CTX *) memCtx
 {
   int rc;
-  struct mapistore_connection_info *connInfo;
   uint64_t obVersion;
 
   obVersion = [self objectVersion];
@@ -205,9 +204,8 @@ static Class MAPIStoreFolderK;
     rc = MAPISTORE_ERR_NOT_FOUND;
   else
     {
-      connInfo = [[self context] connectionInfo];
       *data = MAPILongLongValue (memCtx, ((obVersion << 16)
-                                          | connInfo->repl_id));
+                                          | 0x0001));
       rc = MAPISTORE_SUCCESS;
     }
 

OpenChange/MAPIStoreSamDBUtils.h

@@ -25,13 +25,13 @@
 
 @class NSString;
 
-#include <mapistore/mapistore.h>
+struct ldb_context;
 
-NSString *MAPIStoreSamDBUserAttribute (struct mapistore_connection_info *connInfo,
+NSString *MAPIStoreSamDBUserAttribute (struct ldb_context *samCtx,
                                        NSString *userKey,
                                        NSString *value,
                                        NSString *attributeName);
-NSData *MAPIStoreInternalEntryId (struct mapistore_connection_info *connInfo, NSString *username);
+NSData *MAPIStoreInternalEntryId (struct ldb_context *, NSString *username);
 NSData *MAPIStoreExternalEntryId (NSString *cn, NSString *email);
 
 #endif /* MAPISTORESAMDBUTILS_H */

OpenChange/MAPIStoreSamDBUtils.m

@@ -24,18 +24,13 @@
 #import <Foundation/NSString.h>
 #include <talloc.h>
 #include <ldb.h>
-#include <libmapiproxy.h>
-#include <samba/version.h>
 
 #import "NSData+MAPIStore.h"
 
 #import "MAPIStoreSamDBUtils.h"
 
-
-
-
 NSString *
-MAPIStoreSamDBUserAttribute (struct mapistore_connection_info *connInfo,
+MAPIStoreSamDBUserAttribute (struct ldb_context *samCtx,
                              NSString *userKey,
                              NSString *value,
                              NSString *attributeName)
@@ -53,20 +48,10 @@ MAPIStoreSamDBUserAttribute (struct mapistore_connection_info *connInfo,
   attrs[0] = [attributeName UTF8String];
   searchFormat
     = [NSString stringWithFormat: @"(&(objectClass=user)(%@=%%s))", userKey];
-#if SAMBA_VERSION_MAJOR <= 4 && SAMBA_VERSION_MINOR < 3
-  ret = ldb_search (connInfo->sam_ctx, memCtx, &res,
-                    ldb_get_default_basedn(connInfo->sam_ctx),
+  ret = ldb_search (samCtx, memCtx, &res, ldb_get_default_basedn(samCtx),
                     LDB_SCOPE_SUBTREE, attrs,
                     [searchFormat UTF8String],
                     [value UTF8String]);
-#else
-  ret = safe_ldb_search (&connInfo->sam_ctx, memCtx, &res,
-                         ldb_get_default_basedn(connInfo->sam_ctx),
-                         LDB_SCOPE_SUBTREE, attrs,
-                         [searchFormat UTF8String],
-                         [value UTF8String]);
-#endif
-
   if (ret == LDB_SUCCESS && res->count == 1)
     {
       result = ldb_msg_find_attr_as_string (res->msgs[0], attrs[0], NULL);
@@ -80,7 +65,7 @@ MAPIStoreSamDBUserAttribute (struct mapistore_connection_info *connInfo,
 }
 
 NSData *
-MAPIStoreInternalEntryId (struct mapistore_connection_info *connInfo, NSString *username)
+MAPIStoreInternalEntryId (struct ldb_context *samCtx, NSString *username)
 {
   static const uint8_t const providerUid[] = { 0xdc, 0xa7, 0x40, 0xc8,
                                                0xc0, 0x42, 0x10, 0x1a,
@@ -97,7 +82,7 @@ MAPIStoreInternalEntryId (struct mapistore_connection_info *connInfo, NSString *
      type: 32
      X500DN: variable */
 
-  legacyDN = MAPIStoreSamDBUserAttribute (connInfo, @"sAMAccountName", username,
+  legacyDN = MAPIStoreSamDBUserAttribute (samCtx, @"sAMAccountName", username,
                                           @"legacyExchangeDN");
   if (legacyDN)
     {

OpenChange/MAPIStoreTasksFolder.m

@@ -107,11 +107,11 @@
   if ([roles containsObject: SOGoRole_ObjectCreator])
     rights |= RightsCreateItems;
   if ([roles containsObject: SOGoRole_ObjectEraser])
-    rights |= RightsDeleteAll | RightsDeleteOwn;
+    rights |= RightsDeleteAll;
   if ([roles containsObject: SOGoCalendarRole_PublicModifier]
       && [roles containsObject: SOGoCalendarRole_PrivateModifier]
       && [roles containsObject: SOGoCalendarRole_ConfidentialModifier])
-    rights |= RightsReadItems | RightsEditAll | RightsEditOwn;
+    rights |= RightsReadItems | RightsEditAll;
   else if ([roles containsObject: SOGoCalendarRole_PublicViewer]
            && [roles containsObject: SOGoCalendarRole_PrivateViewer]
            && [roles containsObject: SOGoCalendarRole_ConfidentialViewer])

OpenChange/MAPIStoreTasksMessage.m

@@ -531,7 +531,7 @@
     }
   [vToDo setTimeStampAsDate: now];
 
-  [sogoObject saveCalendar: vCalendar];
+  [sogoObject saveComponent: vCalendar];
 
   [self updateVersions];
 }

OpenChange/MAPIStoreTypes.m

@@ -198,7 +198,7 @@ NSObjectFromSPropValue (const struct SPropValue *value)
       break;
     case PT_STRING8:
       result = (value->value.lpszA
-                ? [NSString stringWithUTF8String: (const char *) value->value.lpszA]
+                ? [NSString stringWithUTF8String: value->value.lpszA]
                 : (id) @"");
       break;
     case PT_SYSTIME:

OpenChange/MAPIStoreUserContext.m

@@ -1,6 +1,8 @@
 /* MAPIStoreUserContext.m - this file is part of SOGo
  *
- * Copyright (C) 2012-2016 Inverse inc
+ * Copyright (C) 2012 Inverse inc
+ *
+ * Author: Wolfgang Sourdeau <wsourdeau@inverse.ca>
  *
  * This file is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -33,7 +35,6 @@
 #import <NGImap4/NGImap4Connection.h>
 
 #import <GDLContentStore/GCSChannelManager.h>
-#import <GDLContentStore/GCSFolderManager.h>
 #import <SOGo/SOGoDomainDefaults.h>
 #import <SOGo/SOGoUser.h>
 #import <SOGo/SOGoUserFolder.h>
@@ -72,8 +73,6 @@ static NSMapTable *contextsTable = nil;
       [userContext autorelease];
       [contextsTable setObject: userContext forKey: username];
     }
-  else
-    [userContext activate];
 
   return userContext;
 }
@@ -338,9 +337,6 @@ static NSMapTable *contextsTable = nil;
   NSString *tableName, *query;
   GCSSpecialQueries *queries;
 
-  if ([GCSFolderManager singleStoreMode])
-    return;
-
   [self folderTableURL];
 
   cm = [GCSChannelManager defaultChannelManager];

OpenChange/NSArray+MAPIStore.m

@@ -228,7 +228,7 @@
   mvResult = [NSMutableArray arrayWithCapacity: mvString->cValues];
   for (count = 0; count < mvString->cValues; count++)
     {
-      subObject = [NSString stringWithUTF8String: (const char *) mvString->lppszA[count]];
+      subObject = [NSString stringWithUTF8String: mvString->lppszA[count]];
       [mvResult addObject: subObject];
     }
 

OpenChange/NSData+MAPIStore.h

@@ -41,8 +41,6 @@
 
 + (id) dataWithXID: (const struct XID *) xid;
 - (struct XID *) asXIDInMemCtx: (void *) memCtx;
-- (struct SizedXid *) asSizedXidArrayInMemCtx: (void *) memCtx
-                                         with: (uint32_t *) length;
 
 + (id) dataWithChangeKeyGUID: (NSString *) guidString
                       andCnt: (NSData *) globCnt;

OpenChange/NSData+MAPIStore.m

@@ -22,7 +22,6 @@
 
 #import <NGExtensions/NSObject+Logs.h>
 
-#import "MAPIStoreTypes.h"
 #import "NSObject+MAPIStore.h"
 #import "NSString+MAPIStore.h"
 
@@ -30,7 +29,6 @@
 
 #undef DEBUG
 #include <stdbool.h>
-#include <libmapi/libmapi.h>
 #include <talloc.h>
 #include <util/time.h>
 #include <gen_ndr/exchange.h>
@@ -138,11 +136,11 @@ static void _fillFlatUIDWithGUID (struct FlatUID_r *flatUID, const struct GUID *
   NSMutableData *xidData;
   struct FlatUID_r flatUID;
 
-  _fillFlatUIDWithGUID (&flatUID, &xid->NameSpaceGuid);
+  _fillFlatUIDWithGUID (&flatUID, &xid->GUID);
 
-  xidData = [NSMutableData dataWithCapacity: 16 + xid->LocalId.length];
+  xidData = [NSMutableData dataWithCapacity: 16 + xid->Size];
   [xidData appendBytes: flatUID.ab length: 16];
-  [xidData appendBytes: xid->LocalId.data length: xid->LocalId.length];
+  [xidData appendBytes: xid->Data length: xid->Size];
 
   return xidData;
 }
@@ -158,12 +156,12 @@ static void _fillFlatUIDWithGUID (struct FlatUID_r *flatUID, const struct GUID *
     {
       xid = talloc_zero (memCtx, struct XID);
 
-      [self _extractGUID: &xid->NameSpaceGuid];
+      [self _extractGUID: &xid->GUID];
 
-      xid->LocalId.length = max - 16;
+      xid->Size = max - 16;
 
       bytes = (uint8_t *) [self bytes];
-      xid->LocalId.data = talloc_memdup (xid, (bytes+16), xid->LocalId.length);
+      xid->Data = talloc_memdup (xid, (bytes+16), xid->Size);
     }
   else
     {
@@ -174,38 +172,6 @@ static void _fillFlatUIDWithGUID (struct FlatUID_r *flatUID, const struct GUID *
   return xid;
 }
 
-- (struct SizedXid *) asSizedXidArrayInMemCtx: (void *) memCtx
-                                         with: (uint32_t *) length
-{
-  struct Binary_r bin;
-  struct SizedXid *sizedXIDArray;
-
-  bin.cb = [self length];
-  bin.lpb = (uint8_t *)[self bytes];
-
-  sizedXIDArray = get_SizedXidArray(memCtx, &bin, length);
-  if (!sizedXIDArray)
-    {
-      NSLog (@"Impossible to parse SizedXID array");
-      return NULL;
-    }
-
-  return sizedXIDArray;
-}
-
-- (NSComparisonResult) compare: (NSData *) otherGlobCnt
-{
-  uint64_t globCnt = 0, oGlobCnt = 0;
-
-  if ([self length] > 0)
-    globCnt = *(uint64_t *) [self bytes];
-
-  if ([otherGlobCnt length] > 0)
-      oGlobCnt = *(uint64_t *) [otherGlobCnt bytes];
-
-  return MAPICNCompare (globCnt, oGlobCnt, NULL);
-}
-
 + (id) dataWithChangeKeyGUID: (NSString *) guidString
                       andCnt: (NSData *) globCnt;
 {

OpenChange/NSDate+MAPIStore.h

@@ -37,8 +37,6 @@
 
 - (BOOL) isNever; /* occurs on 4500-12-31 */
 
-+ (NSCalendarDate *) dateFromSystemTime: (struct SYSTEMTIME) date
-                            andRuleYear: (uint16_t) rYear;
 @end
 
 NSComparisonResult NSDateCompare (id date1, id date2, void *);

OpenChange/NSDate+MAPIStore.m

@@ -24,7 +24,6 @@
 #import <Foundation/NSString.h>
 #import <Foundation/NSTimeZone.h>
 
-#import "MAPIStoreTypes.h"
 #import "NSDate+MAPIStore.h"
 
 #undef DEBUG
@@ -49,7 +48,7 @@ _setupRefDate ()
   refDate = [[NSCalendarDate alloc]
               initWithYear: 1601 month: 1 day: 1
                       hour: 0 minute: 0 second: 0
-                  timeZone: utcTZ];
+                  timeZone: [NSTimeZone timeZoneWithName: @"UTC"]];
 }
 
 + (NSCalendarDate *) dateFromMinutesSince1601: (uint32_t) minutes
@@ -129,64 +128,6 @@ _setupRefDate ()
   return [calDate yearOfCommonEra] == 4500;
 }
 
-+ (NSCalendarDate *) dateFromSystemTime: (struct SYSTEMTIME) date
-                            andRuleYear: (uint16_t) rYear
-{
-  NSCalendarDate *result;
-  NSInteger daysToDate;
-  NSUInteger firstDayOfWeek, year;
-
-  /* ([MS-OXOCAL] 2.2.1.41.1) When we're provided an absolute date (i.e., it
-     happens once), the SYSTEMTIME structure is enough to fill the date.
-     When we're parsing a SYSTEMTIME field from a time zone rule, however, a
-     relative date can be provided for the peroidicity of its periods. In this
-     scenario, the wYear field is empty and we have to use the wYear field in
-     the parent rule */
-  if (date.wYear != 0)
-    year = date.wYear;
-  else
-    year = rYear;
-
-  /* The wDay field indicates the occurrence of the wDayOfWeek within the month.
-     The 5th occurrence means the last one, even if it is the 4th. */
-  if (date.wDay < 5)
-    {
-      result = [[NSCalendarDate alloc] initWithYear: year month: date.wMonth day: 1
-                                               hour: date.wHour minute: date.wMinute second: date.wSecond
-                                           timeZone: utcTZ];
-      [result autorelease];
-
-      firstDayOfWeek = [result dayOfWeek];
-
-      daysToDate = 7 * (date.wDay - 1) + date.wDayOfWeek - firstDayOfWeek;
-      if (date.wDayOfWeek < firstDayOfWeek)
-        daysToDate += 7;
-
-      result = [result dateByAddingYears: 0 months: 0 days: daysToDate
-                                   hours: 0 minutes: 0
-                                 seconds: 0];
-    }
-  else
-    {
-      result = [[NSCalendarDate alloc] initWithYear: year month: date.wMonth + 1 day: 1
-                                               hour: date.wHour minute: date.wMinute second: date.wSecond
-                                           timeZone: utcTZ];
-      [result autorelease];
-
-      firstDayOfWeek = [result dayOfWeek];
-
-      daysToDate = date.wDayOfWeek - firstDayOfWeek;
-      if (date.wDayOfWeek >= firstDayOfWeek)
-        daysToDate -= 7;
-
-      result = [result dateByAddingYears: 0 months: 0 days: daysToDate
-                                   hours: 0 minutes: 0
-                                 seconds: 0];
-    }
-
-  return result;
-}
-
 @end
 
 NSComparisonResult

OpenChange/RTFHandler.h

@@ -28,8 +28,6 @@
 //
 //
 //
-@class RTFFontTable;
-
 @interface RTFHandler : NSObject
 {
   NSMapTable *_charsets;
@@ -43,11 +41,6 @@
 
 - (id) initWithData: (NSData *) theData;
 - (NSMutableData *) parse;
-
-- (RTFFontTable *) parseFontTable;
-- (void) mangleInternalStateWithBytesPtr: (const char*) newBytes
-                          andCurrentPos: (int) newCurrentPos;
-
 @end
 
 //
@@ -74,7 +67,6 @@
   int font_index;
   int color_index;
   int start_pos;
-  const unsigned short *charset;
 }
 @end
 
@@ -85,13 +77,12 @@
 {
 @public
   NSString *family;
-  unsigned char charset;
+  NSString *charset;
   NSString *name;
   unsigned int pitch;
   unsigned int index;
 }
 
-- (NSString *) description;
 @end
 
 //
@@ -105,8 +96,8 @@
 
 - (void) addFontInfo: (RTFFontInfo *) theFontInfo
              atIndex: (unsigned int ) theIndex;
+  
 - (RTFFontInfo *) fontInfoAtIndex: (unsigned int ) theIndex;
-- (NSString *) description;
 
 @end
 

OpenChange/dbmsgreader.m

@@ -1,8 +1,8 @@
 /* dbmsgreader.m - this file is part of SOGo
  *
  * Copyright (C) 2011-2012 Inverse inc
- *               2015 Enrique J. Hernandez
  *
+ * Author: Wolfgang Sourdeau <wsourdeau@inverse.ca>
  *
  * This file is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -33,58 +33,21 @@
 #import <SOGo/SOGoProductLoader.h>
 #import <SOGo/SOGoSystemDefaults.h>
 
-#import <libmapi/libmapi.h>
-
 #import "MAPIStoreUserContext.h"
 #import <SOGo/SOGoCacheGCSObject.h>
 
 #import <SOGo/BSONCodec.h>
 #import "NSObject+PropertyList.h"
 
-
-Class MAPIStoreUserContextK, SOGoCacheGCSObjectK, NSStringK;
+Class MAPIStoreUserContextK, SOGoCacheGCSObjectK;
 
 static void
 DumpBSONData(NSData *data)
 {
-  id key, value;
-  NSEnumerator *dictEnum;
   NSDictionary *dvalue;
-  NSMutableString *outStr;
-  NSUInteger max;
-
   dvalue = [data BSONValue];
-  max = [dvalue count];
-  dictEnum = [dvalue keyEnumerator];
-  NSStringK = [NSString class];
-  outStr = [NSMutableString stringWithFormat: @"{ %d items\n", max];
-  while ((key = [dictEnum nextObject]))
-    {
-      uint32_t proptag = 0;
-      if ([key isKindOfClass: NSStringK] && [(NSString *)key intValue] > 0)
-        proptag = [(NSString *)key intValue];
-
-      if (proptag > 0)
-        {
-          const char *propTagName = get_proptag_name (proptag);
-          NSString *propName;
-
-          if (propTagName)
-            propName = [NSString stringWithCString: propTagName
-                                          encoding: NSUTF8StringEncoding];
-          else
-            propName = [NSString stringWithFormat: @"0x%.4x", [key unsignedLongValue]];
-
-          [outStr appendFormat: @"  %@ = ", propName];
-        }
-      else
-        [outStr appendFormat: @"  %@ = ", key];
-
-      value = [dvalue objectForKey: key];
-      [outStr appendFormat: @"(%@) %@,\n", NSStringFromClass ([value class]), value];
-    }
-  [outStr appendFormat: @"}\n"];
-  printf ("%s\n", [outStr UTF8String]);
+  [dvalue displayWithIndentation:0];
+  printf("\n");
 }
 
 static void
@@ -104,7 +67,7 @@ DbDumpObject (NSString *username, NSString *path)
     {
       printf("record found: %p\n", record);
       content = [[record objectForKey: @"c_content"] dataByDecodingBase64];
-      DumpBSONData (content);
+      DumpBSONData(content);
     }
   else
     NSLog (@"record not found");

OpenChange/iCalEvent+MAPIStore.m

@@ -36,7 +36,6 @@
 #import <NGCards/iCalDateTime.h>
 #import <NGCards/iCalPerson.h>
 #import <NGCards/iCalTimeZone.h>
-#import <NGCards/iCalTimeZonePeriod.h>
 #import <NGCards/iCalTrigger.h>
 #import <SOGo/SOGoPermissions.h>
 #import <SOGo/SOGoUser.h>
@@ -71,12 +70,11 @@
 #include <mapistore/mapistore_nameid.h>
 
 #import "iCalEvent+MAPIStore.h"
-#import "iCalTimeZone+MAPIStore.h"
 
 @implementation iCalEvent (MAPIStoreProperties)
 
 - (void) _setupEventRecurrence: (NSData *) mapiRecurrenceData
-                    inTimeZone: (iCalTimeZone *) tz
+                    inTimeZone: (NSTimeZone *) tz
                       inMemCtx: (TALLOC_CTX *) memCtx
 {
   struct Binary_r *blob;
@@ -252,8 +250,10 @@
   BOOL isAllDay;
   iCalDateTime *start, *end;
   iCalTimeZone *tz;
-  NSString *priority, *class = nil, *tzDescription = nil;
+  NSTimeZone *userTimeZone;
+  NSString *priority, *class = nil;
   NSUInteger responseStatus = 0;
+  NSInteger tzOffset;
   SOGoUser *ownerUser;
   id value;
 
@@ -274,31 +274,7 @@
 	[self setAccessClass: @"PUBLIC"];
     }
 
-  /* Time zone = PidLidAppointmentTimeZoneDefinitionRecur
-     or PidLidAppointmentTimeZoneDefinition[Start|End]Display */
-  value = [properties objectForKey: MAPIPropertyKey (PidLidAppointmentTimeZoneDefinitionStartDisplay)];
-  if (!value)
-    {
-      value = [properties objectForKey: MAPIPropertyKey (PidLidAppointmentTimeZoneDefinitionEndDisplay)];
-      if (!value)
-        {
-          /* If PidLidtimeZoneStruct, TZID SHOULD come from PidLidTimeZoneDescription,
-            if PidLidAppointmentTimeZoneDefinition[Start|End]Display it MUST be derived from KeyName
-            (MS-OXCICAL] 2.1.3.1.1.19.1) */
-          value = [properties objectForKey: MAPIPropertyKey (PidLidAppointmentTimeZoneDefinitionRecur)];
-          tzDescription = [properties objectForKey: MAPIPropertyKey (PidLidTimeZoneDescription)];
-        }
-    }
-  if (value)
-    {
-      tz = [[iCalTimeZone alloc] iCalTimeZoneFromDefinition: value
-                                            withDescription: tzDescription
-                                                   inMemCtx: memCtx];
-    }
-  else
-    /* The client is more likely to have the webmail's time zone than any other */
-    tz = [iCalTimeZone timeZoneForName: [[userContext timeZone] name]];
-  [(iCalCalendar *) parent addTimeZone: tz];
+  userTimeZone = [userContext timeZone];
 
   /* CREATED */
   value = [properties objectForKey: MAPIPropertyKey (PidTagCreationTime)];
@@ -330,13 +306,20 @@
                 objectForKey: MAPIPropertyKey (PidLidAppointmentSubType)];
   if (value)
     isAllDay = [value boolValue];
+  if (!isAllDay)
+    {
+      tz = [iCalTimeZone timeZoneForName: [userTimeZone name]];
+      [(iCalCalendar *) parent addTimeZone: tz];
+    }
+  else
+    tz = nil;
 
   // recurrence-id
   value
     = [properties objectForKey: MAPIPropertyKey (PidLidExceptionReplaceTime)];
   if (value)
     [self setRecurrenceId: value];
-
+ 
   // start
   value = [properties objectForKey: MAPIPropertyKey (PidLidAppointmentStartWhole)];
   if (!value)
@@ -347,7 +330,15 @@
       [start setTimeZone: tz];
       if (isAllDay)
         {
-          /* All-day events are set in floating time ([MS-OXCICAL] 2.1.3.1.1.20.8) */
+          /* when user TZ is positive (East) all-day events were not
+             shown properly in SOGo UI. This day delay fixes it */
+          tzOffset = [userTimeZone secondsFromGMTForDate: value];
+          if (tzOffset > 0)
+            {
+              value = [value dateByAddingYears: 0 months: 0 days: 1
+                                         hours: 0 minutes: 0
+                                       seconds: 0];
+            }
           [start setDate: value];
           [start setTimeZone: nil];
         }
@@ -365,7 +356,15 @@
       [end setTimeZone: tz];
       if (isAllDay)
         {
-          /* All-day events are set in floating time ([MS-OXCICAL] 2.1.3.1.1.20.8) */
+          /* when user TZ is positive (East) all-day events were not
+             shown properly in SOGo UI. This day delay fixes it */
+          tzOffset = [userTimeZone secondsFromGMTForDate: value];
+          if (tzOffset > 0)
+            {
+              value = [value dateByAddingYears: 0 months: 0 days: 1
+                                         hours: 0 minutes: 0
+                                       seconds: 0];
+            }
           [end setDate: value];
           [end setTimeZone: nil];
         }
@@ -468,7 +467,7 @@
   value = [properties
                 objectForKey: MAPIPropertyKey (PidLidAppointmentRecur)];
   if (value)
-    [self _setupEventRecurrence: value inTimeZone: tz inMemCtx: memCtx];
+    [self _setupEventRecurrence: value inTimeZone: userTimeZone inMemCtx: memCtx];
 
   /* alarm */
   [self _setupEventAlarmFromProperties: properties];

OpenChange/iCalTimeZone+MAPIStore.h

@@ -30,11 +30,6 @@
 - (struct Binary_r *) asTimeZoneStructInMemCtx: (TALLOC_CTX *) memCtx;
 - (struct Binary_r *) asZoneTimeDefinitionWithFlags: (enum TZRuleFlag) flags
                                            inMemCtx: (TALLOC_CTX *) memCtx;
-- (iCalTimeZone *) iCalTimeZoneFromDefinition: (NSData *) value
-                              withDescription: (NSString *) description
-                                     inMemCtx: (TALLOC_CTX *) memCtx;
-- (NSCalendarDate *) shiftedCalendarDateForDate: (NSCalendarDate *) date;
-
 
 @end
 

OpenChange/iCalTimeZone+MAPIStore.m

@@ -23,15 +23,11 @@
 #import <Foundation/NSArray.h>
 #import <Foundation/NSCalendarDate.h>
 #import <Foundation/NSString.h>
-#import <Foundation/NSTimeZone.h>
 #import <NGCards/iCalByDayMask.h>
-#import <NGCards/iCalDateTime.h>
 #import <NGCards/iCalTimeZonePeriod.h>
 #import <NGCards/iCalRecurrenceRule.h>
 
 #import "NSString+MAPIStore.h"
-#import "NSData+MAPIStore.h"
-#import "NSDate+MAPIStore.h"
 
 #include <stdbool.h>
 #include <stdint.h>
@@ -40,7 +36,6 @@
 #include <libmapi/libmapi.h>
 
 #import "iCalTimeZone+MAPIStore.h"
-#import "MAPIStoreTypes.h"
 
 @interface iCalTimeZonePeriod (MAPIStorePropertiesPrivate)
 
@@ -108,18 +103,18 @@
 {
   iCalTimeZonePeriod *period;
   struct TimeZoneStruct tz;
-  int32_t lBias, dlBias;
+  int lBias, dlBias;
 
   memset (&tz, 0, sizeof (struct TimeZoneStruct));
   period = [self _mostRecentPeriodWithName: @"STANDARD"];
   lBias = -[period secondsOffsetFromGMT] / 60;
-  tz.lBias = lBias;
+  tz.lBias = (uint32_t) lBias;
   [period _fillTZDate: &tz.stStandardDate];
   period = [self _mostRecentPeriodWithName: @"DAYLIGHT"];
   if (!period)
     tz.stStandardDate.wMonth = 0;
   dlBias = -([period secondsOffsetFromGMT] / 60) - lBias;
-  tz.lDaylightBias = dlBias;
+  tz.lDaylightBias = (uint32_t) (dlBias);
   [period _fillTZDate: &tz.stDaylightDate];
   tz.wStandardYear = tz.stStandardDate.wYear;
   tz.wDaylightYear = tz.stDaylightDate.wYear;
@@ -158,220 +153,18 @@
   period = [self _mostRecentPeriodWithName: @"STANDARD"];
   rule.wYear = [[period startDate] yearOfCommonEra];
   lBias = -[period secondsOffsetFromGMT] / 60;
-  rule.lBias = lBias;
+  rule.lBias = (uint32_t) lBias;
   [period _fillTZDate: &rule.stStandardDate];
   period = [self _mostRecentPeriodWithName: @"DAYLIGHT"];
   if (!period)
     rule.stStandardDate.wMonth = 0;
   dlBias = -([period secondsOffsetFromGMT] / 60) - lBias;
-  rule.lDaylightBias = dlBias;
+  rule.lDaylightBias = (uint32_t) (dlBias);
   [period _fillTZDate: &rule.stDaylightDate];
 
 
   return set_TimeZoneDefinition (memCtx, &definition);
 }
 
-- (NSString *) _offsetStringFromOffset: (NSInteger) offset
-{
-  NSInteger offsetHours, offsetMins;
-  NSString *offsetSign;
-
-  /* The offset format is, eg, "+0200" for 2 hours 0 minutes ahead */
-  if (offset < 0)
-    offsetSign = @"-";
-  else
-    offsetSign = @"+";
-  offsetHours = abs (offset) / 60;
-  offsetMins = abs (offset) % 60;
-
-  return [NSString stringWithFormat:  @"%@%d%d%d%d",
-           offsetSign, offsetHours / 10, offsetHours % 10,
-           offsetMins / 10, offsetMins % 10];
-
-}
-
-- (NSString *) _rRuleStringFromSystemTime: (struct SYSTEMTIME) date
-{
-  NSString *result, *byDay;
-
-  /* The conversion tables between the SYSTEMTIME fields and the RRULE ones
-     can be found at [MS-OXCICAL] 2.1.3.2.1 */
-  if (date.wDay == 5)
-    byDay = @"-1";
-  else
-    byDay = [NSString stringWithFormat: @"%d", date.wDay];
-
-  switch (date.wDayOfWeek)
-    {
-    case iCalWeekDaySunday:
-      byDay = [byDay stringByAppendingString: @"SU"];
-      break;
-    case iCalWeekDayMonday:
-      byDay = [byDay stringByAppendingString: @"MO"];
-      break;
-    case iCalWeekDayTuesday:
-      byDay = [byDay stringByAppendingString: @"TU"];
-      break;
-    case iCalWeekDayWednesday:
-      byDay = [byDay stringByAppendingString: @"WE"];
-      break;
-    case iCalWeekDayThursday:
-      byDay = [byDay stringByAppendingString: @"TH"];
-      break;
-    case iCalWeekDayFriday:
-      byDay = [byDay stringByAppendingString: @"FR"];
-      break;
-    case iCalWeekDaySaturday:
-      byDay = [byDay stringByAppendingString: @"SA"];
-      break;
-    }
-
-  result = [NSString stringWithFormat: @"FREQ=YEARLY;BYDAY=%@;BYMONTH=%d", byDay, date.wMonth];
-
-  return result;
-}
-
-- (iCalTimeZone *) iCalTimeZoneFromDefinition: (NSData *) value
-                              withDescription: (NSString *) description
-                                     inMemCtx: (TALLOC_CTX *) memCtx
-{
-  BOOL daylightDefined = NO, ruleFound = NO;
-  iCalDateTime *daylightStart, *standardStart;
-  iCalRecurrenceRule *daylightRRule, *standardRRule;
-  iCalTimeZone *tz = nil;
-  iCalTimeZonePeriod *daylight, *standard;
-  NSCalendarDate *dlStartValue, *stStartValue;
-  NSString *strOffsetFrom, *strOffsetTo, *tzID;
-  char *keyName;
-  struct Binary_r *binValue;
-  struct SYSTEMTIME initDate;
-  struct TimeZoneDefinition *definition;
-  struct TZRule rule;
-  uint16_t count;
-
-  binValue = [value asBinaryInMemCtx: memCtx];
-  definition = get_TimeZoneDefinition (memCtx, binValue);
-
-  if (!definition)
-    return nil;
-
-  if (!definition->cRules)
-    goto end;
-
-  for (count = 0; count < definition->cRules; count++)
-    {
-      /* ([MS-OXCICAL] 2.1.3.1.1.19) The TZRule with the
-         TZRULE_FLAG_EFFECTIVE_TZREG bit set in the TZRule flags field
-         is the one that MUST be exported */
-      if (definition->TZRules[count].flags & TZRULE_FLAG_EFFECTIVE_TZREG)
-        {
-          rule = definition->TZRules[count];
-          ruleFound = YES;
-          break;
-        }
-    }
-
-  if (!ruleFound)
-    goto end;
-
-  if (!description)
-    {
-      /* The cbHeader field contains the size, in bytes of the Reserved (2b),
-         cchKeyName (2b) keyName (variable Unicode string) and cRules (2b)
-         ([MS-OXOCAL] 2.2.1.41). The keyName field is a non-NULL-terminated
-         char array. */
-      keyName = talloc_strndup (memCtx, definition->keyName, (definition->cbHeader - 6) / 2);
-      tzID = [NSString stringWithCString: keyName
-                                encoding: [NSString defaultCStringEncoding]];
-      talloc_free (keyName);
-    }
-  else
-    tzID = [NSString stringWithString: description];
-
-  tz = [iCalTimeZone groupWithTag: @"vtimezone"];
-  [tz addChild: [CardElement simpleElementWithTag: @"tzid"
-                                            value: tzID]];
-
-  if (rule.stStandardDate.wMonth != 0)
-    daylightDefined = YES;
-
-  /* STANDARD TIME ([MS-OXCICAL] 2.1.3.1.1.19.2) */
-  standard = [iCalTimeZonePeriod groupWithTag: @"standard"];
-
-  /* TZOFFSETFROM = -1 * (PidLidTimeZoneStruct.lBias + PidLidTimeZoneStruct.lDaylightBias) */
-  strOffsetFrom = [self _offsetStringFromOffset: -1 * (rule.lBias + rule.lDaylightBias)];
-  [standard addChild: [CardElement simpleElementWithTag: @"tzoffsetfrom"
-                                                  value: strOffsetFrom]];
-
-  /* TZOFFSETTO = -1 * (PidLidTimeZoneStruct.lBias + PidLidTimeZoneStruct.lStandardBias) */
-  strOffsetTo = [self _offsetStringFromOffset: -1 * (rule.lBias + rule.lStandardBias)];
-  [standard addChild: [CardElement simpleElementWithTag: @"tzoffsetto"
-                                                  value: strOffsetTo]];
-
-  /* DTSTART & RRULE are derived from the stStandardDate and wYear properties */
-  standardStart = [iCalDateTime elementWithTag: @"dtstart"];
-
-  initDate = rule.stStandardDate;
-  stStartValue = [NSCalendarDate dateFromSystemTime: initDate
-                                        andRuleYear: rule.wYear];
-
-  [standardStart setDateTime: stStartValue];
-  [standard addChild: standardStart];
-
-  if (daylightDefined)
-    {
-      standardRRule = [[iCalRecurrenceRule alloc] initWithString: [self _rRuleStringFromSystemTime: initDate]];
-      [standard addChild: standardRRule];
-
-      /* DAYLIGHT SAVING TIME ([MS-OXCICAL] 2.1.3.1.1.19.3) */
-      daylight = [iCalTimeZonePeriod groupWithTag: @"daylight"];
-      /* TZOFFSETFROM = -1 * (PidLidTimeZoneStruct.lBias + PidLidTimeZoneStruct.lStandardBias) */
-      [daylight addChild: [CardElement simpleElementWithTag: @"tzoffsetfrom"
-                                                      value: strOffsetTo]];
-      /* TZOFFSETTO = -1 * (PidLidTimeZoneStruct.lBias + PidLidTimeZoneStruct.lDaylightBias) */
-      [daylight addChild: [CardElement simpleElementWithTag: @"tzoffsetto"
-                                                      value: strOffsetFrom]];
-
-      /* DTSTART & RRULE are derived from the stDaylightDate and wYear properties */
-      daylightStart = [iCalDateTime elementWithTag: @"dtstart"];
-      initDate = rule.stDaylightDate;
-      dlStartValue = [NSCalendarDate dateFromSystemTime: initDate
-                                            andRuleYear: rule.wYear];
-
-      [daylightStart setDateTime: dlStartValue];
-      [daylight addChild: daylightStart];
-
-      daylightRRule = [[iCalRecurrenceRule alloc] initWithString: [self _rRuleStringFromSystemTime: initDate]];
-      [daylight addChild: daylightRRule];
-      [tz addChild: daylight];
-    }
-  [tz addChild: standard];
-
-end:
-
-  talloc_free (definition);
-  return tz;
-}
-
-/**
- * Adjust a date in this vTimeZone to its representation in UTC
- * Example: Timezone is +0001, the date is 2015-12-15 00:00:00 +0000
- *                              it returns 2015-12-14 23:00:00 +0000
- * @param date the date to adjust to the timezone.
- * @return a new GMT date adjusted with the offset of the timezone.
- */
-- (NSCalendarDate *) shiftedCalendarDateForDate: (NSCalendarDate *) date
-{
-  NSCalendarDate *tmpDate;
-
-  tmpDate = [date copy];
-  [tmpDate autorelease];
-
-  [tmpDate setTimeZone: utcTZ];
-
-  return [tmpDate addYear: 0 month: 0 day: 0
-                     hour: 0 minute: 0
-                   second: -[[self periodForDate: tmpDate] secondsOffsetFromGMT]];
-}
 
 @end

README.md

@@ -1,66 +1,27 @@
-## Contribute
+[![SOGo Logo](http://www.sogo.nu/fileadmin/sogo/logos/sogo.logo.png)](http://www.sogo.nu/)
 
-SOGo is a collaborative effort in order to create the best Free and Open Source groupware solution.
+Share your calendars, address books and mails in your community with a completely free and open source solution.
 
-There are multiple ways you can contribute to the project
+Let your Mozilla Thunderbird/Lightning, Microsoft Outlook, Apple iCal/iPhone, Android and BlackBerry users collaborate using a modern platform.
 
-* Documentation reviews, enhancements and translations
-* Feature requests or by sharing your ideas (see the roadmap)
-* Participate in the discussion on mailing lists
-* Patches for bugs or enhancements
-* Provide new translations
+## What is SOGo?
 
-## Source Code
+SOGo is [fully supported](http://www.sogo.nu/support/commercial_support.html) and [trusted](http://www.sogo.nu/tour/testimonials.html) groupware server with a focus on scalability and open standards. SOGo is released under the GNU GPL/LGPL v2 and above.
 
-You can browse the lastest version of the source code online from Inverse's github repository:
+SOGo provides a rich AJAX-based Web interface and supports multiple native clients through the use of standard protocols such as CalDAV, CardDAV and GroupDAV.
 
-* [https://github.com/inverse-inc](https://github.com/inverse-inc)
+SOGo is the missing component of your infrastructure; it sits in the middle of your servers to offer your users an uniform and complete interface to access their information. It has been deployed in production environments where thousands of users are involved.
 
-To compile SOGo, you first need to obtain the source code of both SOGo and SOPE. The source code of SOPE and SOGo can be obtained from Inverse's github repository:
+[![Sogo diagram](http://www.sogo.nu/uploads/pics/sogo.png)](http://www.sogo.nu/)
 
-* [https://github.com/inverse-inc/sope](https://github.com/inverse-inc/sope)
-* [https://github.com/inverse-inc/sogo](https://github.com/inverse-inc/sogo)
+[Learn more...](http://www.sogo.nu/about/overview.html)
 
-The source code of the SOGo Connector and SOGo Integrator extensions for Thunderbird 31+ can be obtained from Inverse's github repository:
+## Microsoft Outlook Compatible
 
-* [https://github.com/inverse-inc/sogo-connector.tb31](https://github.com/inverse-inc/sogo-connector.tb31)
-* [https://github.com/inverse-inc/sogo-integrator.tb31](https://github.com/inverse-inc/sogo-integrator.tb31)
+SOGo offers native Microsoft Outlook compatibility using the [OpenChange](http://www.openchange.org/) backend developed by [Inverse](http://www.inverse.ca/). This means Microsoft Outlook 2003, 2007, 2010 and 2013 can talk directly to SOGo – just like if it was a Microsoft Exchange server. **No plugins are required in Outlook to make this work**.
 
-Please refer to the [FAQ](http://sogo.nu/support/faq.html) for [compilation instructions](http://sogo.nu/support/faq/article/how-do-i-compile-sogo-2.html).
+The following screencast shows Outlook 2010 connected to SOGo as if it was an Exchange server, along the Web interface of SOGo.
 
-## Translations
+[![SOGo Screencast](http://img.youtube.com/vi/1hcBSB4Kxww/0.jpg)](http://www.youtube.com/watch?v=1hcBSB4Kxww)
 
-SOGo and its associated components are available in various languages. The following list describes the official translations alongside their maintainers :
-
-* English - [Inverse inc.](http://www.inverse.ca/)
-* Arabic - Anass Ahmed
-* Basque - Gorka Gonzalez
-* Brazilian Portuguese - Alexandre Marcilio
-* Catalan - Hector M. Rulot Segovia
-* Chinese (Taiwan)
-* Croatian - Jens Riecken
-* Czech - Šimon Halamásek
-* Danish (Denmark) - Altibox
-* Dutch - Roel van Os
-* Finnish - Kari Salmu
-* French - [Inverse](http://www.inverse.ca/)
-* German - Alexander Greiner-Baer
-* Hungarian - Sándor Kuti
-* Icelandic - Anna Jonna Armannsdottir
-* Italian - Alessio Fattorini
-* Lithuanian - Mantas Liobė
-* Macedonian - Miroslav Jovanovic
-* Norwegian (Bokmål) - Jan Ivar Karlsen
-* Norwegian (Nynorsk) - Altibox
-* Polish - Paweł Bogusławski
-* Russian - Alex Kabakaev
-* Slovak - Martin Pastor
-* Slovenian - Jens Riecken
-* Spanish (Argentina) - Federico Alberto Sayd
-* Spanish (Spain) - Dominique Couot
-* Swedish - Peter Johansson
-* Turkish (Turkey) - Sinan Kurşunoğlu
-* Ukrainian - Oleksa Stasevych
-* Welsh - Iona Bailey
- 
-If you would like to translate the software in an other language, please consult the [FAQ](http://sogo.nu/support/faq/article/how-to-translate-sogo-in-another-language-2.html). You can also subscribe to the SOGo i18n mailing list to follow string additions or changes. To subscribe to i18n@sogo.nu, send an email to i18n-request@sogo.nu with SUBSCRIBE i18n as the subject. Archived posts are [available online](https://inverse.ca/sogo/lists/arc/i18n).
+[![SOGo on GitHub](http://www.sogo.nu/fileadmin/images/icon.github.png)](https://github.com/inverse-inc/sogo/) [![SOGo Ohloh](http://www.sogo.nu/fileadmin/images/icon.ohloh.png)](https://www.ohloh.net/p/sogo) [![SOGo on Twitter](http://www.sogo.nu/fileadmin/images/icon.twitter.png)](http://twitter.com/scalableogo) [![SOGo on SourceForge](http://www.sogo.nu/fileadmin/images/icon.sourceforge.png)](http://sourceforge.net/projects/sogo-zeg) [![SOGo on free code](http://www.sogo.nu/fileadmin/images/icon.freecode.png)](https://freecode.com/projects/sogo-inverse) [![SOGo on LinkedIn](http://www.sogo.nu/fileadmin/images/icon.linkedin.png)](http://www.linkedin.com/groups/SOGo-Groupware-4164805)

SOPE/GDLContentStore/EOQualifier+GCS.m

@@ -20,6 +20,7 @@
 */
 
 #import <Foundation/NSValue.h>
+#import <Foundation/NSString.h>
 
 #import <NGExtensions/NSNull+misc.h>
 #import <NGExtensions/NSObject+Logs.h>

SOPE/GDLContentStore/GCSAlarmsFolder.h

@@ -23,6 +23,7 @@
 #ifndef GCSALARMSFOLDER_H
 #define GCSALARMSFOLDER_H
 
+#import <Foundation/NSObject.h>
 
 @class NSCalendarDate;
 @class NSException;

SOPE/GDLContentStore/GCSAlarmsFolder.m

@@ -18,10 +18,16 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#import <Foundation/NSDictionary.h>
+#import <Foundation/NSString.h>
+#import <Foundation/NSURL.h>
+#import <Foundation/NSUserDefaults.h>
+#import <Foundation/NSValue.h>
 
 #import <NGExtensions/NSObject+Logs.h>
 #import <NGExtensions/NSNull+misc.h>
 
+#import <GDLAccess/EOAdaptorChannel.h>
 #import <GDLAccess/EOAdaptorContext.h>
 #import <GDLAccess/EOAttribute.h>
 #import <GDLAccess/EOEntity.h>
@@ -31,6 +37,7 @@
 #import "GCSChannelManager.h"
 #import "GCSFolderManager.h"
 #import "GCSSpecialQueries.h"
+#import "GCSStringFormatter.h"
 #import "NSURL+GCS.h"
 
 #import "GCSAlarmsFolder.h"

SOPE/GDLContentStore/GCSChannelManager.h

@@ -22,6 +22,7 @@
 #ifndef __GDLContentStore_GCSChannelManager_H__
 #define __GDLContentStore_GCSChannelManager_H__
 
+#import <Foundation/NSObject.h>
 
 /*
   GCSChannelManager

SOPE/GDLContentStore/GCSChannelManager.m

@@ -22,6 +22,8 @@
 #import <Foundation/NSArray.h>
 #import <Foundation/NSCalendarDate.h>
 #import <Foundation/NSDictionary.h>
+#import <Foundation/NSEnumerator.h>
+#import <Foundation/NSLock.h>
 #import <Foundation/NSTimer.h>
 #import <Foundation/NSUserDefaults.h>
 #import <Foundation/NSValue.h>
@@ -31,6 +33,7 @@
 
 #import <GDLAccess/EOAdaptor.h>
 #import <GDLAccess/EOAdaptorContext.h>
+#import <GDLAccess/EOAdaptorChannel.h>
 
 #import "GCSChannelManager.h"
 #import "NSURL+GCS.h"
@@ -497,7 +500,7 @@ static NSTimeInterval ChannelCollectionTimer = 5 * 60;
   ms = [NSMutableString stringWithCapacity: 256];
   [ms appendFormat: @"<0x%p[%@]: ", self, NSStringFromClass ([self class])];
 
-  [ms appendFormat: @" #adaptors=%d", (int)[urlToAdaptor count]];
+  [ms appendFormat: @" #adaptors=%d", [urlToAdaptor count]];
 
   [ms appendString: @">"];
   return ms;