Commit Graph
11419 Commits
Author SHA1 Message Date
netniV dcafe08776 Minor fix to #4295 2021-06-09 17:12:33 +00:00
netniV 5a2d51c02f Further fix of test_data_source() [#4250] 2021-06-09 14:00:59 +00:00
netniV 1c3c4bf142 If a page contains multiple tables, a larger table can cause small ones to lose columns (#4295)
Closes #4295
2021-06-09 02:58:11 +00:00
Martin HorsleyandMark Brugnoli-Vinten 5a53ffc28b Fixing #4284 - Parameters in array_key_exists (1.2.17 database upgrade) (#4285)
* Fixing #4284 - Parameters in array_key_exists

* Fixing issue #4284 - Database upgrade can fail - Uncaught argument count error

* Fixing issue #4284 - Database upgrade can fail - Uncaught argument count error

Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
2021-06-05 21:38:11 +01:00
netniV 9c5720137b Unable to create graphs due to Data Source verification failure (#4250)
Closes #4250
2021-06-05 20:32:01 +00:00
Jing Chen cff7bd1faf Security: session fixation for PHP 5.4 (#4282) 2021-05-26 19:42:45 +01:00
netniV ed8cc7cd5f Fix minor issue with #4271 2021-05-21 16:51:10 +00:00
netniV cd632331a1 Another update for #4271 2021-05-20 00:43:46 +00:00
netniV 076ee5745f SNMP library can display extra warning messages when host does not resolve (#4267)
Closes #4267
2021-05-19 22:11:56 +00:00
Jing Chen b19f780a82 Fixed: XSS issue in graph_realtime.php (#4276)
* Fixed: XSS issue in graph_realtime.php

* Update CHANGELOG for PR#4276
2021-05-19 11:11:24 -04:00
TheWitness 652c137782 Fixing Issue #4272 - dns_get_record() wrarnings
dns_get_record(): A temporary server error occurred
2021-05-18 21:43:01 -04:00
TheWitness 3cd8e8c56b Fixing issue #4269 - background process lacks snmp
Installation Wizard - Uncaught Error: Call to undefined function cacti_snmp_session()
2021-05-18 20:52:42 -04:00
TheWitness 04ee69168c Fixing #4271 - Continued timeout of registered processes
By moving the calculation fully under SQL, this should solve the problem.
2021-05-18 20:37:37 -04:00
Kris Shannon c5b8e5838e Remove bogus early return from nth_percentile_fetch_statistics (#4265) 2021-05-18 23:30:21 +01:00
netniV 1a23052e11 Incomplete Poller items from a previous run may be updated twice #4266 2021-05-17 09:08:05 +00:00
Jing Chen d12800ab47 Fixed: Merge solution of #3628 to 'midwinter' theme(CVE-2020-14424) (#4261) 2021-05-17 09:26:41 +01:00
kim-fitnessandMark Brugnoli-Vinten 232aeb914e Fix bug #4259 (#4260)
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
2021-05-14 17:56:54 +01:00
DavidLiedke d85a1eb75c Update phpseclib to 2.0.31 (#4258) 2021-05-14 09:42:05 +01:00
kim-fitness bdc353e96b Fix issue #4251 (#4252) 2021-05-11 18:02:40 +01:00
Weblate 502a60dc26 Update translation files
Updated by "Squash Git commits" hook in Weblate.

Translation: Cacti/core (v1.2.x)
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/
2021-05-10 21:41:39 -05:00
WeblateandLinya Huang 8ec0dc74ec Translated using Weblate (Chinese (Traditional))
Currently translated at 17.3% (732 of 4221 strings)

Co-authored-by: Linya Huang <linya0405@gmail.com>
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/zh_Hant/
Translation: Cacti/core (v1.2.x)
2021-05-10 21:41:39 -05:00
netniV a2febc0115 When poller first runs, time since last run produces an error (#4254)
When a poller first runs, there is no previous run timestamp but the code was trying to round on the default value which is a string.

Closes #4254
2021-05-08 10:53:24 +00:00
Weblate 39e337a4ec Update translation files
Updated by "Squash Git commits" hook in Weblate.

Translation: Cacti/core (v1.2.x)
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/
2021-05-04 03:47:28 -05:00
WeblateandLinya Huang ae87c9ed75 Translated using Weblate (Chinese (Traditional))
Currently translated at 17.3% (731 of 4221 strings)

Co-authored-by: Linya Huang <linya0405@gmail.com>
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/zh_Hant/
Translation: Cacti/core (v1.2.x)
2021-05-04 03:47:28 -05:00
netniV c4cdb56644 Update CHANGELOG for release release/1.2.17 rel-1.2.17 2021-05-03 16:00:12 +00:00
netniV ad02f2f5ba Update CHANGELOG in prep for release 2021-04-30 23:47:10 +00:00
TheWitness 1f39156de2 Light PSR following #4241
Just some cleanup.  No programmatic changes
2021-04-22 08:47:14 -04:00
Browniebraun 7b20dfc805 support to sort sites within a tree
related to #4241
2021-04-22 14:12:50 +02:00
TheWitness b1686206a3 Correct two minor issues, one unchecked variable and one with a forced zone issue 2021-04-21 19:21:56 -04:00
TheWitness 4a417272b6 Fixing Issue #4237 - Damaged Graphs Repair Query
Changes to graph template like add new Comment will cause the graph being marked as "Damaged" in Management->Graphs

This issue was already fixed in another fix, but the SQL Query here will fix the damaged graphs.
2021-04-15 21:16:52 -04:00
Chris RowatandChris Rowat a7a336ff90 Fixing a couple database related typos and adding support for SSL CA checking without client side certificates (1.2.x) (#4234)
* Fixing a couple database related typos and adding support for SSL CA checking without client side certificates

* Updating changelog

Co-authored-by: Chris Rowat <chris.rowat@terago.ca>
2021-04-14 13:20:23 -04:00
TheWitness 514cbe3086 Increase number of boost processes 2021-04-14 08:46:34 -04:00
TheWitness 92a5b0e27f Re-fixing Issue #4223
Parallel boost restart due to timeout can result in errors
2021-04-14 08:42:34 -04:00
TheWitness 4ffd1df804 Issue #4229 - Automation networks and unset snmp_id
Errors running autom8 without snmp option set
2021-04-14 08:26:17 -04:00
TheWitness fb67f35cef Add user_agent to audit schema for release. 2021-04-14 08:16:48 -04:00
TheWitness 3d62cf2723 Fixing #4223 - Parallel boost killing incorrect processes 2021-04-13 18:34:15 -04:00
TheWitness 8af84e4b11 Fixing #4228 - Redirect ssues after login
- Redirection issues after login under specific circumstances
2021-04-13 08:35:19 -04:00
TheWitness 7345225cf7 Fixing issue #4227 and move flush to end of poller
When remote poller is in offline mode data is written to poller_output as well as poller_output_boost
2021-04-12 21:37:47 -04:00
TheWitness 669713bc0e Update recovery logging 2021-04-12 21:35:30 -04:00
Sean Mancini 3b845b8e21 Update api_automation.php (#4226)
fix misspelled variable
2021-04-12 17:55:42 -04:00
TheWitness d03fbb5c4c Update changelog. 2021-04-12 09:22:11 -04:00
TheWitness 82004e1261 Change logic so that remote data collectors properly accumulate data #4215 2021-04-11 20:43:51 -04:00
TheWitness 9144519a88 Better logging on #4215 2021-04-11 20:11:02 -04:00
TheWitness 7043a539a3 Merge branch '1.2.x' of https://github.com/Cacti/cacti into 1.2.x 2021-04-11 20:05:02 -04:00
TheWitness c21d0ba91b Final resolution to #4215
This change modifies logic slightly as follows:

1) Retry only twice for a connection (speed up the GUI in offline mode)
2) Don't update resource cache when in offline or recovery, you could downgrade yourself
3) Don't flush_boost() function if you are not a remote data collector
4) Better logging for automation to indicate offline or remote
2021-04-11 20:04:58 -04:00
BerndPandBernd 467085146f Poller recovery - related to #4215: log-verbosity, fixing a minor bug, code cleanup (#4224)
* removed unused variable "$end_count"

* renamed $count to more speaking $record_size

* renamed $inserted to $records_inserted

* code clean-up

* add log verbosity

When sending data to main, this happens in portions and this uses
several DB-queries. For optimization purposes, we want to know how much
time these queries took.
It is also good to know, how fast the recovery is processing data, hence
we also log the max timestamp for the current loop's data portion.

* correction of recovery core loop

The previous handling was a bit off. Though this was technically not
critical, it was not correctly calculating the data sizes, which would
lead to wrong annotations in the logs.

Introducing the helper variable $sql_size helps to keep track properly
about the size of the SQL string for the currently processed record.
Previously the size was already added even if the current record was not
taken into account in the current loop run, and after transfering the
complete data-frame, the size was nulled, therefore the next size was
not reflecting this record.

Adding $record_count allows to log the actual amount of data that was
transfered to the main poller in the current loop cycle.

Co-authored-by: Bernd <berni@berni.lan>
2021-04-11 08:50:55 -04:00
The Cacti Group b92634eae9 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: Cacti/core (v1.2.x)
Translate-URL: http://translate.cacti.net/projects/cacti/core-v12x/
2021-04-10 22:30:30 -05:00
TheWitness 0f987ca15a Two issues with db_fetch_cell*() with poller #4215 2021-04-10 15:19:45 -04:00
Weblate 537849f766 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/
Translation: Cacti/core (v1.2.x)
2021-04-10 09:58:27 -05:00
Weblate f1a70c7a1b Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: http://translate.cacti.net/projects/cacti/core-v1-2-x/
Translation: Cacti/core (v1.2.x)
2021-04-10 09:58:27 -05:00