Commit Graph
64 Commits
Author SHA1 Message Date
TheWitness cc13fca8ac Correcting 2/3 Issues in #4033
- Two of three issues resolved
- XSS security issue from WebScan report
- Data Template unable to reproduce
2021-01-05 22:00:48 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
cigamit 4cbb045e03 Resolving Issue #3191
* Vulnerability report: Lack of escaping on some pages can lead
to XSS exposure
* Also cleaning up additional copyrights
* Make the way filter headers are escaped consistent
2020-01-15 19:56:32 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 3ed390c4fc Resolve Issue where label was presented twice
* Also correct SQL formatting
* Double to single quote
* Whitespace removal
* One i18n issue
2018-06-10 10:43:46 -05:00
Tony Roman 6a17e0edf3 Merge branch 'develop' into feature/1.2.x 2018-02-09 21:18:19 -05:00
cigamit c9e16e357b Reverted last change. CSS Changes were not required. 2018-02-09 07:13:33 -06:00
cigamit 45109b266b Revert "Additional changes for issue #1323"
This reverts commit 5595c0be07.
2018-02-09 07:11:20 -06:00
cigamit 5595c0be07 Additional changes for issue #1323
Additional changes to clean up layout of graph_templates_inputs.php
2018-02-09 07:10:20 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
Tony Roman 6d1b0a9a76 Merge branch 'develop' into feature/1.2.x
Conflicts:
	aggregate_graphs.php
	auth_login.php
	automation_templates.php
	cli/add_tree.php
	graph_templates_items.php
	lib/api_automation.php
	lib/api_tree.php
	lib/auth.php
	lib/html_form_template.php
2017-11-18 09:44:33 -05:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 3a8d4f7ff9 Use html_escape() over htmlspecialchars() for consistency and security 2017-09-04 21:26:27 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit ff125d01cb Update all pages to include div based forms
This requires a CSS change which is going to be committed next and
separately to call out the changes required there.
2017-04-30 13:15:58 -05:00
Patrick 623611cd16 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed unnecessary reset() calls used for resetting pointers of an array before iterating by a foreach() loop
2017-04-18 14:40:29 +02:00
patrick cc1cc7eab2 PHP7.2 changes:
- Replaced deprecated each() for foreach()
- Removed reset() calls used for each() loops
2017-04-15 18:00:13 +02:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit bbde2e29d2 allow input items to be removed 2016-09-26 17:20:07 -05:00
cigamit 7695dfa3ab i18n graph_templates_inputs.php 2016-05-22 15:54:34 -05:00
cigamit 26053b7527 replace deprecated get_request_var_post() with get_nfilter_request_var()
replace the deprecated calls and also start developer mode injection
checking
2016-02-11 16:46:14 -06:00
cigamit 2387bd4a08 removing many $_GET, $_REQUEST, and $_POST variable usage
There are still three steps to go in this overall.  The first is to
replace all the page filtering session storing and validation functions
and the second is to propagate those changes into various areas of the
lib directory that include the use of the various variables, lastly,
developer mode will have to be enable to see if there are any variables
used in the code that have not been sanitized.  Note, at this point the
develop branch should be thought of as slightly unstable
2016-02-07 12:51:49 -06:00
Linegod 8dadf2d9a9 first pass of _POST to get_request_var_post 2016-02-06 10:44:05 -06:00
Linegod dabfabf219 replace ['action'] with set_default_action 2016-02-06 09:57:05 -06:00
cigamit da34108e21 remove use of deprecated function get_request_var_request(). replace it with get_request_var()
this is part three of project to remove the use of $_GET, $_REQUEST, and
$_POST in the code.  Parts one and two have already been completed.
Part one was to remove the use of $_GET throughout the code, part two
was the incorporation of wrapper functions to handle specific
validation, verification and sanitization cases.  This third part will
remove the use of the get_request_var_request() from the code.  Part
four, and beyond will include the removal of both $_REQUEST and $_POST
super globals from the code.
2016-01-30 15:53:08 -06:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit ed2d5e9660 Fix save graph template inputs
form logic was pre html5 syntax
2015-11-08 13:26:34 -06:00
cigamit 4fc14f929d Remove deprecated tags and remove inline styles
Removing <strong> in many areas
Moving inline styles to classes
2015-08-09 19:55:44 -05:00
Jimmy Conner 455d855894 1) Convert double quotes to single quotes
2) Remove references to $_GET replace with $_REQUEST
3) Remove some inline styles

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7706 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-17 16:53:24 +00:00
Jimmy Conner 5bde3da972 1) Update Copyright Years Correct a few minor CY Issues
2) Allow Locking/UnLocking of Graphs
3) ToolTips
4) Correct Minor Issues with Login/Out/Permission associated with Theme JS
5) Upgrade jQuery which has Fixes for Major issue in Safari 7/8.1

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7662 860744bd-22fc-0310-8c96-e9fe5004b5ca
2015-01-04 01:52:50 +00:00
Jimmy Conner 5646c33484 A little bit of cleanup
Change double quotes to single quotes where possible
Move to prepared statements were possible
Fix line endings on a few files

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7609 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-12-25 07:00:57 +00:00
Tony Roman b09354888e Addition theme fixes and javascript updates
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7482 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-11-09 23:49:23 +00:00
Tony Roman d82550439a Now with Themes!
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7480 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-11-08 19:14:29 +00:00
Andreas Braun 0a67496c07 deprecation of $colors array
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7479 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-11-05 06:03:18 +00:00
Jimmy Conner e6c083b055 -bug#0002456: CVE-2014-5025 / CVE-2014-5026 - Cross-Site Scripting Vulnerability - Special Thanks to flekyy
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7461 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-10-28 19:50:27 +00:00
Jimmy Conner be800c9e55 Add some validation
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7451 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-06-15 21:54:20 +00:00
Tony Roman 65be30ffe0 Update copyright to 2014
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7437 860744bd-22fc-0310-8c96-e9fe5004b5ca
2014-03-30 19:54:50 +00:00
Tony Roman ce40281901 Update copyright to 2013 for 0.8.8
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.8@7386 860744bd-22fc-0310-8c96-e9fe5004b5ca
2013-07-21 23:00:42 +00:00
Tony Roman a257958a0b Update copyright to 2012
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@7016 860744bd-22fc-0310-8c96-e9fe5004b5ca
2012-02-27 07:04:37 +00:00
Tony Roman 9acba795fe Update copyright to 2011
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@6233 860744bd-22fc-0310-8c96-e9fe5004b5ca
2011-01-27 03:44:05 +00:00
Tony Roman 1469eb9c48 XSS fixed for attempt to insert scripting through template import
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@6037 860744bd-22fc-0310-8c96-e9fe5004b5ca
2010-07-06 03:01:35 +00:00
Larry Adams 81c2d7abb9 QA: Make the-feature: Convert base Cacti UI to use buttons and not images
QA: Make UI components more compatible when executing actions

git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@5845 860744bd-22fc-0310-8c96-e9fe5004b5ca
2010-05-03 21:08:29 +00:00
Larry Adams c5403f3844 QA: Update copyrights
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@5806 860744bd-22fc-0310-8c96-e9fe5004b5ca
2010-04-28 03:48:09 +00:00
Tony Roman 26d1957d62 Update copyright to 2009
git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@4931 860744bd-22fc-0310-8c96-e9fe5004b5ca
2009-02-11 22:53:50 +00:00
Tony Roman a1f2d76563 0001258: "Remove Verification" is an ambiguous definition, leads to data loss
Update to 0.8.8 installer to be consistant with 0.8.7 branch


git-svn-id: svn+ssh://repo.cacti.net/var/data/svnroot/cacti/cacti/branches/0.8.7@4685 860744bd-22fc-0310-8c96-e9fe5004b5ca
2008-09-01 23:34:13 +00:00