Commit Graph
115 Commits
Author SHA1 Message Date
TheWitness f314dbe3a9 Regression on import
This change was between 1.2.16 and 1.2.17 so no  CHANGELOG entry.
2021-02-20 12:57:59 -05:00
TheWitness ffffc13aa1 Fixing Issue #4131
A design flaw makes importing new Graph Template slow on large systems
2021-02-16 20:47:25 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
TheWitness 862538860a Fixing Issue #4008
PHP8 support: Debian test suites shows lots of PHP Errors and Warnings with PHP8
2020-12-12 17:28:03 -05:00
TheWitness b953148af1 Second attempt at issue #3871
This should fix the remainder of the issues.
2020-10-19 13:06:25 -04:00
TheWitness f7f6ee4b21 Fixing Issue #3871
Import DataQuery show PHP Error: ERROR PHP NOTICE: Undefined index: fname
2020-10-19 12:58:04 -04:00
netniV 39458efcd5 Improper escaping of error message leads to XSS during template import preview (#3723)
Closes #3723
2020-07-26 23:40:44 +00:00
TheWitness 20a1b07342 Fixing Issue #3596
When importing template, resources aren't checked properly
2020-06-13 10:08:44 -04:00
TheWitness 80ec47b08a Issue #3549
Several XSS Vulnerabilities
2020-06-13 09:43:27 -04:00
TheWitness 030506b820 Missing closing the package file if it is not readable 2020-04-09 20:33:08 -04:00
TheWitness 75580b386e Fixing Issue #3313
Installing cacti 1.2.10 in debian and ubuntu stopped at 41%
2020-03-21 13:26:42 -04:00
TheWitness 9d38ca43cb Fixing Issue #3348
Remove Orphans and Sync Graphs not working as expected
2020-03-15 15:43:53 -04:00
cigamit 47408aafcb Improve import warnings
Prior patch did not work as expected.  This makes the import more sensible.
2020-02-02 09:55:34 -06:00
cigamit 72279f131c Minor change for issue #3225
* Unable to Import Templates in Cacti 1.2.9+
* This change address another instance found of an snmp_port being added to a data input method.
2020-02-01 12:18:09 -06:00
cigamit b71ec3dc11 Resolving Issue #3225
Unable to Import Templates in Cacti 1.2.9+
2020-02-01 09:38:43 -06:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
cigamit 33ed3079bb Partial resolution to issue #3164
* Array and string offset access syntax with curly braces is deprecated in php 7.4
* As mentioned by @netniv, this will be a 1.3 project, but resolving what was identified in the mean tiem.
* I have verified that multiple plugins are also impacted by this change.
2020-01-08 07:33:36 -06:00
cigamit ba21617bb7 Resolving Issue #2712
The hard code of set memory_limit need to be removed
2019-05-30 07:51:12 -05:00
cigamit 07ad04c576 Resolving Issue #2578
Import package will not write a file if it's new
2019-03-27 20:30:15 -05:00
cigamit c24ff59446 Allow compare to function properly
When importing a pre 1.2.3 template, don't confuse the users with warnings about the compare failing.
2019-03-26 18:42:34 -05:00
cigamit 65e777fc18 Resolving Issue #2527
Package installation can fail if the Cacti hash version code is ahead of installed Cacti
2019-03-16 10:38:43 -05:00
cigamit 64a7c81ca1 Bug in system test on issue #2502
Need to use version compare
Unable to have a min or max value for RRDfile at zero '0'
2019-03-11 07:27:52 -05:00
cigamit 0964412f19 Resolving Issue #2502
Unable to have a min or max value for RRDfile at zero '0'
2019-03-10 10:17:21 -05:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
cigamit 7cb00f6e96 Resolving Issue #2240
SNMP system Data Input Methods should not be modified on import
2018-12-29 10:46:42 -06:00
cigamit db96c65335 Missing raise message in a few import areas 2018-12-23 14:37:35 -06:00
cigamit a3a0fb6926 Resolving Issue #2223
[1.2.0 Beta 4] : fakepath for import
2018-12-23 14:24:56 -06:00
netniV 451476031f Resolving issue #2103 2018-10-27 07:53:09 +00:00
cigamit 76ae351222 Resolving Issue #1936
[1.2.0] Upgrade fails to import templates properly
2018-09-25 18:11:58 -05:00
Mark Brugnoli-Vinten 39efc75c49 Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939 (#1937)
* Resolving issues #1931, #1932, #1933, #1934, #1935, #1938 and #1939

* Update import.php
2018-09-16 13:22:32 -05:00
Mark Brugnoli-Vinten 1ca32862a9 Resolving issue #1920 (#1922)
* Resolving issue #1920

* Minor QA issue
2018-09-14 20:59:52 -05:00
cigamit 22d9444c31 Allow Import/Export to be hookable 2018-09-08 13:32:11 -05:00
Tom Yearke efc6b83466 Import: Fixed handling of references to objects not included in file (#1796)
* Import: Fixed handling of references to objects not included in file

When exporting an object with the "Include Dependencies" option disabled and then importing the resulting file, the import process will not complete successfully. This is because the mapping of object hashes to object IDs only tracks objects that have been included in the file.

This commit resolves the issue by first loading the mapping with all existing hashes and IDs before processing the file's objects. This results in the expected behavior when a referenced object is not in the file but is already loaded into the Cacti installation.

* Revised #1787 based on review from @cigamit

- Removed unnecessary double quotes
- Encapsulated `foreach` on possibly-empty array with size check
- Added whitespace

* Updated CHANGELOG to include #1796
2018-08-06 07:43:18 -05:00
cigamit d532a25723 Don't issue warning if zlib can not be changed. 2018-06-02 19:34:26 -05:00
cigamit bc9448b133 Resolving Issue #1559
CLI Output Issues due to over escaping
2018-04-21 18:35:19 -05:00
cigamit f59e60f9e5 Ensure compression levels are consistent
The import package function will fail when the web server has
compression enabled
2018-02-11 06:55:30 -06:00
cigamit 7199064681 Resolving Issue #1244
Errors importing templates with deprecated hashes
2018-02-11 06:55:29 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit e65c26d341 Remove debug code from import_package() function. 2017-12-31 13:40:06 -06:00
cigamit 1731dd4c46 Resolve issue with importation of packages
Additionally, update package version numbers to 1.1.29 to match the
Cacti version.
2017-12-31 13:38:38 -06:00
netniV f2790006af Fix Issue #1133 - Incorrect variable name (#1134)
* Fix Issue #1133 - Incorrect variable name

Fixed the incorrect use of $totle in place of $title resulting in database insertion errors.

* Update import.php

Fix debug display to match code.

* Update CHANGELOG
2017-12-21 07:49:03 -06:00
Patrick 4bc2f4c0bc Various updates (#1073)
* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Fixed warnings in graph_view

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes
- Fixed one i18n entry in api_automation.php

* Updated changelog

* Layout changes (tab instead of spaces)

* Layout changes (tab instead of spaces)

* Various fixes
- Changed array access identifiers
- Fixed some code layout changes

* Some fixes for better querying

* Layout change only

* Updated Dutch translations

* Updated changelog

* Updated changelog

* Fixed upgrade script 1_1_28.zip

* Few final fixes after CR or changes

* Updated Dutch translations
2017-11-11 05:45:12 -06:00
cigamit e961202f70 Resolving Issue #1048
Unable to import vdef's from templatesl
2017-10-27 06:52:44 -05:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 86f719b923 Resolving Issue #989
- Spaces lost on re-import of data input method.
- Possible injection point in templates_export.php
- Minor format changes to db calls

Note that this will not 100% resolve the importation of old templates.
However, all new templates will base64_encode all input strings prior to
XML encoding, which resolves this issue ongoing.
2017-10-15 09:54:07 -05:00
Patrick c3419aa36e Various fixes && Updated Translations (#1032)
Good catch on the bug fixes too.  Hard to spot.
_______________________________________________________

* Updated Dutch translations
- Fixed i18n

* Defined fields in queries

* Fixed changelog

* Updated Dutch translations

* Various fixes

All committed files:
- true|false to lowercase

add_perms.php:
- displayGroups() was undefined

add_tree.php:
- duplicate case for '--quiet'

repair_templates.php:
- correction function call to diaplay_version()

gettext.php:
- PHP EOF unneeded

* Updated Dutch translations
- Updated Dutch translations with latest cacti.pot file

* Updated Dutch translations
- Fixed conflicts in translations
2017-10-15 07:27:25 -05:00
John Horne 9b359d932a Trivial - removed tabbed blank line. 2017-06-02 17:12:35 +01:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
Tony Roman 27045ea52d Fixup install process to streamline releases
- Added and moved code to CACTI_VERSION constant
 - Merged cacti versions and hash codes array to have one place to add versions
 - Moved cacti version to file to facitate automation needs
 - Cleaned up cli database upgrade script
2017-05-01 08:58:29 -04:00
cigamit ab746b0e38 Add new field for graph templates to form actions
Increase the minimum import level for new templates, insure that new
templates imported with this column are saved properly, include
duplicate graph functionality, change field to a char(2)
2017-04-28 04:45:13 -05:00