Commit Graph
72 Commits
Author SHA1 Message Date
TheWitness c4ba292b49 Fixing Issue #4075
- LDAP Settings lead to confusion when setting up LDAP authentication
- This is a fairly large consolidation of code blocks.
2021-01-21 18:59:25 -05:00
TheWitness df54a4a3f3 Updating copright years 2021-01-01 20:28:58 -05:00
netniV 99926932a0 QA on LDAP patch 2020-06-28 19:41:31 +00:00
netniV 67c8e72e7e LDAP Authentication succeeds, but login fails due to bad session handling (#3576)
Also applying a QA fix on poller maintenances logrotation function

Closes #3576
2020-06-28 19:12:36 +00:00
TheWitness 5ebe97be19 Fix login issues with LDAP users 2020-06-28 11:26:01 -04:00
riversdev0 de55ddc956 Update ldap.php (#3627) 2020-06-18 18:08:45 +01:00
ddb4github 25638ab23c Correct various runtime errors due to incorrect message variables (#3571) 2020-05-23 18:33:08 +01:00
TheWitness 4e062fb6aa Use Cacti functions for session handling where possible. 2020-05-19 12:29:54 -04:00
TheWitness d65f40d2bf Abstract Cacti session handler 2020-03-29 19:08:29 -04:00
TheWitness 68831cd01e Fixing #1566
Need to change to $config due to old PHP5.
2020-03-21 14:53:17 -04:00
TheWitness 265ebc27ea Fixing Issue #1566
* Add SameSite support for cookies
* Add some light formatting for readability
2020-03-21 14:40:17 -04:00
1ebe6108ea Resolve issue encountered if the Preferred Realm has not been preset and add additional group search check (#3322)
* fixed realm value not being sent as a part of post request if select #realm element was not clicked by user.

* added suport for nested group search support when using samba or microsoft AD
https://ldapwiki.com/wiki/1.2.840.113556.1.4.1941

* Slight edit to pulle request to follow PSR for Cacti

* Minor Cacti PSR Changes

This should be part of the class and not a standalone function.

* Minor formatting error.

* Minor format issue

* Add error handling to the function just in case

Co-authored-by: Peter Vilhan <vilhan@vnet.eu>
Co-authored-by: Jimmy Conner <jimmy@sqmail.org>
2020-03-08 11:58:06 -05:00
netniV 4fa9a68fb3 Update copyright to 2020 2020-01-12 12:19:49 +00:00
ddb4github dfc6b64595 Fixed: Resolved some PHP NOTICE about undefined variables #2650 (#2651)
* Fixed: Resolved some PHP NOTICE about undefined variables.

* Fixd previous fixing. Should add 'global $l10n' only

* Fixed: typo miss '$'

* Minor change
2019-04-27 21:26:17 +06:00
netniV 308292e2d7 Update copyright notices for 2019 2019-01-25 08:05:00 +00:00
netniV e5f736e6cb Correct LDAP logging issue 2018-12-21 10:31:00 +00:00
oshiewan 0af69825dc Fix for pulling Full Name and Email from LDAP (#2225)
Call GetErrorDetails before trying to set elements of the output array or we'll lose them as GetErrorDetails does not currently accept an existing output object to keep custom elements.
2018-12-21 10:23:10 +00:00
netniV a47a6a52fc Improve LDAP logging of connection type 2018-12-05 07:37:25 +00:00
netniV 280f1690b6 Resolving issues #2163 and #2164 2018-11-13 12:19:27 +00:00
Mark Brugnoli-Vinten f4314c5a65 More QA Fixes (#2013)
* Correct issue with template and table selections

* More QA on Tables

* Make LDAP slowness not block sessions

* Resolving issue #2015

* Add some extra logging items for RECACHE event
2018-10-06 10:23:50 -05:00
cigamit f89ab3b3bc Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	auth_login.php
#	data_sources.php
#	graphs_new.php
#	include/auth.php
#	lib/api_tree.php
#	lib/html_form_template.php
#	lib/html_tree.php
#	lib/template.php
#	permission_denied.php
#	poller_automation.php
#	tree.php
2018-03-25 11:08:00 -05:00
Mark Brugnoli-Vinten 5cdc090361 Issue #1487 - Undefined constant in ldap.php (#1488) 2018-03-21 17:26:07 -05:00
cigamit 901537e1b6 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
#	lib/ldap.php
2018-03-03 13:10:27 -06:00
netniV b533cd050f Make LDAP errors consistent across functions (#1430)
* Make LDAP errors consistent across functions

* Correct syntax issue in PHP5
2018-03-03 12:22:47 -06:00
cigamit 62615311b5 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
# Conflicts:
#	docs/CHANGELOG
2018-01-06 14:08:07 -06:00
Tony Roman 519b35f5cd Update copyright to 2018 2018-01-06 09:10:15 -05:00
cigamit 251a22ecff Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
Updating feature 1.2 branch from Develop
2017-12-03 08:02:58 -06:00
netniV 1025bd4a7f Fix issue #965 - LDAP search error results (#1112)
* Fix issue #965 - LDAP search erorr results

Corrected the error number returned by "Unable to set referrrals" to the correct number.

Added a new error for finding a users DN but not finding the user from the DN.

* Updated changelog for issue #965
2017-12-02 11:30:58 -05:00
Tony Roman 6c73dd6105 Merge branch 'develop' into feature/1.2.x
Conflicts:
	cli/add_tree.php
	docs/CHANGELOG
2017-10-16 11:36:51 -04:00
Wolfgang Stöggl 4a1a15d72c Correct spelling of RRDtool (#1038)
- Change RRDTool -> RRDtool with a lowercase t.
- Replace in all files except *.mo, *.po, *.pot
2017-10-16 11:32:05 -04:00
cigamit 4680aa3a7e Correct remaining whitespace issues
Do a little cleanup of SQL queryies to use less horizontal space
2017-09-16 16:26:30 -05:00
cigamit e0bfca2b80 Merge remote-tracking branch 'refs/remotes/origin/develop' into feature/1.2.x
Merge from develop to feature-1.2 branch.
2017-09-16 15:55:25 -05:00
Arno Streuli cedc671eaa Feature/1.2.x (#979)
* Update cacti.sql

Added 2 entry for cn_full_name and cn_email

* Update cacti.sql

Change the size to 50

* Create 1_2_0.php

Added the change on table user_domains_ldap, to provide info for full_name and email

* Update global_settings.php

Added the 2 new entry as new section for LDAP settings:
ldap_cn_fullname
ldap_cn_email

* Update auth.php

Added the email address on user_copy function

* Update ldap.php

Added the ldap_search_cn to search 2 specific CN on LDAP server

* Update auth_login.php

Added the Get user CN part for new LDAP users

* Update ldap.php

little error on ldap_search inside Getcn function

* Update user_domains.php

Add option to manage Full name and email taken from LDAP server

* Update auth_login.php

Change for multidomain authentication

* Update global_settings.php

change the name ldap_cn_xxx to just cn_xxx

* Update ldap.php

Correction to the error number and message when the CN is not find

* Update settings.php

Added the visibility of CN fields only for LDAP authentication mode

* Update ldap.php

correct on line 729 missing $ before this->cn

* Update cacti.sql

column definitions consistent with the definitions under install/upgrades/1_2_0.php

* Update auth_login.php

correct tab, as space, and add {} in if else statment

* Update ldap.php

correction on cacti_log with $output['error_text'], correction on all error_num 99 as '99'
and made some correction int tab/space

* Update auth_login.php

add missing {} on else function
2017-09-16 15:51:56 -05:00
Kevin Bonner 1d4e35d5dc fix LDAP search success log line (#972) 2017-09-13 17:23:39 -05:00
cigamit 480fbaac2c Resolving Issue #922
When using LDAP domains some settings are not passed correctly to the
Cacti LDAP library
2017-08-22 07:07:56 -05:00
cigamit 19701b5f2c Resolving Issue #916
Resolve display of errors when encountering ldap issues
Resolve JavaScript errors on Login page
2017-08-19 08:53:36 -05:00
Tony Roman 8a179d7d7f Fix up to move if elseif else blocks to PSR 2017-05-07 19:57:36 -04:00
cigamit d13f1f873e Resolving Issue #462
LDAP authorization issues: group membership check broken for 'Group
Member Type' = 'Username'
2017-03-21 19:22:23 -05:00
cigamit 7f8d7b91e6 Resolve PHP 7 Travis CI test failure 2017-01-12 19:32:46 -06:00
cigamit a8c560966a Correcting spelling and grammar issues 2017-01-12 19:09:16 -06:00
Tony Roman d4bade1656 Fix some PHP 7 depreciation warnings in classes
- removed no longer used mailer class
 - Updated constructor for ldap class
2017-01-02 11:13:45 -05:00
Tony Roman 35a5988f41 Update source code files copyright to new year 2017-01-01 13:45:29 -05:00
cigamit c5a5e020fb resolving bug#2177 2016-08-26 21:34:47 -05:00
cigamit eb0a1601c1 i18n on lib directory, double to single quotes 2016-05-30 19:49:54 -05:00
Micke2k d188f1631d Change Copyright year 2015 -> 2016 2016-01-29 21:46:02 +04:00
cigamit b079d6f68a Resolve compatibility issues with RHEL6
ENT_HTML401 was not introduced until PHP 5.4
2015-08-09 17:27:26 -05:00
cigamit 879c0e22ab Revert "Resolve LDAP compatibility with RHEL6"
This reverts commit 6adcb2d01f.
2015-08-09 17:23:26 -05:00
cigamit 6adcb2d01f Resolve LDAP compatibility with RHEL6
ENT_HTML401 not introduced until PHP 5.4
2015-08-09 17:23:11 -05:00
cigamit 2e506c59c0 Change the html_entity_decode in 1.0 to match 0.8.8d 2015-04-06 09:20:21 -05:00
cigamit abdc1e3d55 Merging 0.8.8d Updates with GitHub
Changes include:
- Convert some <br> to </li>
- Update ChangeLog per 0.8.8d release
- Fix Max Values on UCD/SNMP Memory Template
- Change Cacti Group Format to Modern Theme
- Fix Locking on Graphs
- Force Image format to PNG for Legacy Graph Image
- Correct form Logic on Settings to Fix Reverse Proxy's
- Shorten Uptime Display on Device Edit
- Force a Locale Setting for i18n on Graphs
- Fix Resizable Columns to resize only the current column
- Add DropIcon selectmenu Widget to modern theme
- Fix Issue where delete data source multi leaves orphan records
- Correct performance bug in Boost engine
- Optimize array_to_sql_or performance
- Correct and issue where pushing out data query objects to host cache
could leave orphan elements
- Add OID_REWRITE_PATTERN Feature on input
- Add VALUE/REGEXP Feature on output
- Optimize strip_quotes function to be more intellegent
- Escape shell arguments on Script Data Input types
- Allow Special Characters for LDAP passwords
- Correct LDAP class defect for anonymous binding
- Bypass php-snmp for now
- Correct rrdcleaner bytes units
- Fix loadavg_multi.pl to respect i18n
- Remove legacy row counters from snmpagent pages
2015-03-23 17:02:45 -05:00