mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-23 03:27:02 +09:00
* PHPStan Level 8 - Phase 1 Conversion
Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).
Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
return array (was mixed); the _prepared workers coerce the connection-failure
path to an empty array so the declared type is honest. empty()/cacti_sizeof()
checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
now return self instead of a bare object so chained calls type-check.
Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
(json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
wrap foreach over array|false/list|false results with `?: []`.
Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
entry (passing null to api_tree_item_save(int $type) -> TypeError), and
api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
(an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.
Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
existing always-true/false ignore family (same "PHPStan gets confused"
dynamic-constant cause already covered by identical.alwaysTrue,
notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
untouched long tail for Phase 2.
* Remove redundant @phpstan-ignore comments
Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:
- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
match any reported error after the type-safety fixes (e.g. the
db_fetch_row_prepared() return-type narrowing removed the offset-assign
errors the api_automation ignores were suppressing).
Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.
* ci: satisfy validator ratchet and refresh security sink baselines
- lib/api_tree.php: give the new tree-item site_id a real numeric
constraint ('^[-0-9]+$', matching html_reports.php) instead of an
empty regex, so the validator constraint ratchet passes without
bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
whose code text changed from the (string) casts added in this branch
(lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
simplexml_load_string).
* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test
The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.
* test: update sql.php null-handling assertion for the (string) cast
This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.
* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound
- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
(guarding the false lookup) instead of string-casting them, which made
them resolve account/group names like '1001' and fail. Covers
lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
lib/package.php returns false, lib/clog_webapi.php and utilities.php
render an error, and snmpagent_mibcachechild.php skips the cache write
and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
only the array offset, so a non-even entries/columns split no longer
truncates the loop and drops a cached row.
* revert: keep db_fetch_* returning false on error; baseline Level 8 instead
Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.
Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.
---------
Co-authored-by: TheWitness <copilot@users.noreply.github.com>
912 lines
28 KiB
PHP
912 lines
28 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
| |
|
|
| This program is distributed in the hope that it will be useful, |
|
|
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
| GNU General Public License for more details. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
| This code is designed, written, and maintained by the Cacti Group. See |
|
|
| about.php and/or the AUTHORS file for specific developer information. |
|
|
+-------------------------------------------------------------------------+
|
|
| http://www.cacti.net/ |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
require('./include/auth.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/CactiValidator.php');
|
|
|
|
use Symfony\Component\Validator\Constraints as Assert;
|
|
|
|
$actions = [
|
|
1 => __('Delete'),
|
|
2 => __('Disable'),
|
|
3 => __('Enable'),
|
|
];
|
|
|
|
$mactions = [
|
|
1 => __('Disable'),
|
|
2 => __('Enable')
|
|
];
|
|
|
|
$tabs_manager_edit = [
|
|
'general' => __('General'),
|
|
'notifications' => __('Notifications'),
|
|
'logs' => __('Logs'),
|
|
];
|
|
|
|
// set default action
|
|
set_default_action();
|
|
|
|
gfrv('tab', FILTER_CALLBACK, ['options' => 'sanitize_search_string']);
|
|
|
|
switch (grv('action')) {
|
|
case 'save':
|
|
form_save();
|
|
|
|
break;
|
|
case 'actions':
|
|
form_actions();
|
|
|
|
break;
|
|
case 'edit':
|
|
top_header();
|
|
manager_edit();
|
|
bottom_footer();
|
|
|
|
break;
|
|
default:
|
|
top_header();
|
|
manager();
|
|
bottom_footer();
|
|
|
|
break;
|
|
}
|
|
|
|
function manager() : void {
|
|
global $actions, $item_rows;
|
|
|
|
// create the page filter
|
|
$pageFilter = new CactiTableFilter(__('SNMP Notification Receivers'), 'managers.php', 'form_snmpagent_managers', 'sess_snmp_mgr', 'managers.php?action=edit');
|
|
|
|
$pageFilter->rows_label = __('Receivers');
|
|
$pageFilter->set_sort_array('hostname', 'ASC');
|
|
$pageFilter->render();
|
|
|
|
if (grv('rows') == '-1') {
|
|
$rows = read_config_option('num_rows_table');
|
|
} else {
|
|
$rows = grv('rows');
|
|
}
|
|
|
|
// form the 'where' clause for our main sql query
|
|
$sql_where = 'WHERE (
|
|
sm.hostname LIKE ' . db_qstr('%' . grv('filter') . '%') . '
|
|
OR sm.description LIKE ' . db_qstr('%' . grv('filter') . '%') . ')';
|
|
|
|
$total_rows = db_fetch_cell("SELECT
|
|
COUNT(sm.id)
|
|
FROM snmpagent_managers AS sm
|
|
$sql_where");
|
|
|
|
$sql_order = get_order_string();
|
|
$sql_limit = ' LIMIT ' . ($rows * (grv('page') - 1)) . ',' . $rows;
|
|
|
|
$managers = db_fetch_assoc("SELECT sm.id, sm.description,
|
|
sm.hostname, sm.disabled, smn.count_notify, snl.count_log
|
|
FROM snmpagent_managers AS sm
|
|
LEFT JOIN (
|
|
SELECT COUNT(*) as count_notify, manager_id
|
|
FROM snmpagent_managers_notifications
|
|
GROUP BY manager_id
|
|
) AS smn
|
|
ON smn.manager_id = sm.id
|
|
LEFT JOIN (
|
|
SELECT COUNT(*) as count_log, manager_id
|
|
FROM snmpagent_notifications_log
|
|
GROUP BY manager_id
|
|
) AS snl
|
|
ON snl.manager_id = sm.id
|
|
$sql_where
|
|
$sql_order
|
|
$sql_limit");
|
|
|
|
$display_text = [
|
|
'description' => [ __('Description'), 'ASC'],
|
|
'id' => [ __('Id'), 'ASC'],
|
|
'disabled' => [ __('Status'), 'ASC'],
|
|
'hostname' => [ __('Hostname'), 'ASC'],
|
|
'count_notify' => [ __('Notifications'), 'ASC'],
|
|
'count_log' => [ __('Logs'), 'ASC']
|
|
];
|
|
|
|
// generate page list
|
|
$nav = html_nav_bar('managers.php?filter=' . grv('filter'), MAX_DISPLAY_PAGES, grv('page'), $rows, $total_rows, 11, __('Receivers'), 'page', 'main');
|
|
|
|
form_start('managers.php', 'chk');
|
|
|
|
print $nav;
|
|
|
|
html_start_box('', '100%', false, 3, 'center', '');
|
|
|
|
html_header_sort_checkbox($display_text, grv('sort_column'), grv('sort_direction'), false);
|
|
|
|
if (cacti_sizeof($managers)) {
|
|
foreach ($managers as $item) {
|
|
$description = filter_value($item['description'], grv('filter'));
|
|
$hostname = filter_value($item['hostname'], grv('filter'));
|
|
|
|
$url = 'managers.php?action=edit&id=' . $item['id'];
|
|
$url1 = 'managers.php?action=edit&tab=notifications&id=' . $item['id'];
|
|
$url2 = 'managers.php?action=edit&tab=logs&id=' . $item['id'];
|
|
|
|
form_alternate_row('line' . $item['id'], false);
|
|
|
|
form_selectable_cell(filter_value($description, '', $url), $item['id']);
|
|
form_selectable_cell($item['id'], $item['id']);
|
|
|
|
form_selectable_cell($item['disabled'] ? '<span class="deviceDown">' . __('Disabled') . '</span>' : '<span class="deviceUp">' . __('Enabled') . '</span>', $item['id']);
|
|
|
|
form_selectable_ecell($hostname, $item['id']);
|
|
form_selectable_cell(filter_value($item['count_notify'] ? $item['count_notify'] : 0, '', $url1), $item['id']);
|
|
form_selectable_cell(filter_value($item['count_log'] ? $item['count_log'] : 0, '', $url2), $item['id']);
|
|
|
|
form_checkbox_cell($item['description'], $item['id']);
|
|
|
|
form_end_row();
|
|
}
|
|
} else {
|
|
print '<tr class="tableRow odd"><td colspan="7"><em>' . __('No SNMP Notification Receivers') . '</em></td></tr>';
|
|
}
|
|
|
|
html_end_box(false);
|
|
|
|
if (cacti_sizeof($managers)) {
|
|
print $nav;
|
|
}
|
|
|
|
form_hidden_box('action_receivers', '1', '');
|
|
|
|
draw_actions_dropdown($actions);
|
|
|
|
form_end();
|
|
}
|
|
|
|
function manager_edit() : void {
|
|
global $snmp_auth_protocols, $snmp_priv_protocols, $snmp_versions,
|
|
$tabs_manager_edit, $fields_manager_edit, $mactions;
|
|
|
|
// ================= input validation =================
|
|
gfrv('id');
|
|
// ====================================================
|
|
|
|
if (!isrv('tab')) {
|
|
srv('tab', 'general');
|
|
}
|
|
|
|
$id = (isrv('id') ? grv('id') : '0');
|
|
|
|
if ($id) {
|
|
$manager = db_fetch_row_prepared('SELECT * FROM snmpagent_managers WHERE id = ?', [grv('id')]);
|
|
$header_label = __esc('SNMP Notification Receiver [edit: %s]', $manager['description']);
|
|
} else {
|
|
$header_label = __('SNMP Notification Receiver [new]');
|
|
}
|
|
|
|
if (cacti_sizeof($tabs_manager_edit) && isrv('id')) {
|
|
$i = 0;
|
|
|
|
// draw the tabs
|
|
print "<div class='tabs'><nav><ul role='tablist'>";
|
|
|
|
foreach (array_keys($tabs_manager_edit) as $tab_short_name) {
|
|
if (($id == 0 && $tab_short_name != 'general')) {
|
|
print "<li class='subTab'><a href='#' " . (($tab_short_name == grv('tab')) ? "class='selected'" : '') . "'>" . $tabs_manager_edit[$tab_short_name] . '</a></li>';
|
|
} else {
|
|
print "<li class='subTab'><a " . (($tab_short_name == grv('tab')) ? "class='selected'" : '') .
|
|
" href='" . htmle(CACTI_PATH_URL .
|
|
'managers.php?action=edit&id=' . grv('id') .
|
|
'&tab=' . $tab_short_name) .
|
|
"'>" . $tabs_manager_edit[$tab_short_name] . '</a></li>';
|
|
}
|
|
|
|
$i++;
|
|
}
|
|
|
|
print '</ul></nav></div>';
|
|
|
|
if (read_config_option('legacy_menu_nav') != 'on') { ?>
|
|
<script type='text/javascript'>
|
|
|
|
$(function() {
|
|
$('.subTab').find('a').click(function(event) {
|
|
event.preventDefault();
|
|
|
|
strURL = $(this).attr('href');
|
|
strURL += (strURL.indexOf('?') > 0 ? '&':'?');
|
|
loadUrl({url:strURL})
|
|
});
|
|
});
|
|
</script>
|
|
<?php }
|
|
}
|
|
|
|
switch(grv('tab')) {
|
|
case 'notifications':
|
|
manager_notifications($id, $header_label);
|
|
|
|
break;
|
|
case 'logs':
|
|
manager_logs($id, $header_label);
|
|
|
|
break;
|
|
default:
|
|
form_start('managers.php');
|
|
|
|
html_start_box($header_label, '100%', true, 3, 'center', '');
|
|
|
|
draw_edit_form(
|
|
[
|
|
'config' => ['no_form_tag' => true],
|
|
'fields' => inject_form_variables($fields_manager_edit, (isset($manager) ? $manager : []))
|
|
]
|
|
);
|
|
|
|
html_end_box(true, true);
|
|
|
|
form_save_button('managers.php', 'return');
|
|
|
|
?>
|
|
<script type='text/javascript'>
|
|
|
|
// Need to set this for global snmpv3 functions to remain sane between edits
|
|
snmp_security_initialized = false;
|
|
|
|
$(function() {
|
|
setSNMP();
|
|
});
|
|
</script>
|
|
<?php
|
|
}
|
|
|
|
?>
|
|
<script language='javascript' type='text/javascript' >
|
|
$('.tooltip').tooltip({
|
|
track: true,
|
|
position: { collision: 'flipfit' },
|
|
content: function() { return DOMPurify.sanitize($(this).attr('title')); }
|
|
});
|
|
</script>
|
|
<?php
|
|
}
|
|
|
|
function create_manager_notification_filter() : array {
|
|
global $item_rows;
|
|
|
|
$mibs = array_rekey(
|
|
db_fetch_assoc("SELECT 'any' AS id, '" . __esc('Any') . "' AS name UNION SELECT DISTINCT mib AS id, mib AS name FROM snmpagent_cache"),
|
|
'id', 'name'
|
|
);
|
|
|
|
return [
|
|
'rows' => [
|
|
[
|
|
'filter' => [
|
|
'method' => 'textbox',
|
|
'friendly_name' => __('Search'),
|
|
'filter' => FILTER_DEFAULT,
|
|
'placeholder' => __('Enter a search term'),
|
|
'size' => '30',
|
|
'default' => '',
|
|
'pageset' => true,
|
|
'max_length' => '120',
|
|
'value' => ''
|
|
],
|
|
'mib' => [
|
|
'method' => 'drop_array',
|
|
'friendly_name' => __('MIB'),
|
|
'filter' => FILTER_CALLBACK,
|
|
'filter_options' => ['options' => 'sanitize_search_string'],
|
|
'default' => 'any',
|
|
'pageset' => true,
|
|
'array' => $mibs,
|
|
'value' => 'any'
|
|
],
|
|
'rows' => [
|
|
'method' => 'drop_array',
|
|
'friendly_name' => __('Entries'),
|
|
'filter' => FILTER_VALIDATE_INT,
|
|
'default' => '-1',
|
|
'pageset' => true,
|
|
'array' => $item_rows,
|
|
'value' => '-1'
|
|
]
|
|
]
|
|
],
|
|
'buttons' => [
|
|
'go' => [
|
|
'method' => 'submit',
|
|
'display' => __('Go'),
|
|
'title' => __('Apply Filter to Table'),
|
|
],
|
|
'clear' => [
|
|
'method' => 'button',
|
|
'display' => __('Clear'),
|
|
'title' => __('Reset Filter to Default Values'),
|
|
]
|
|
]
|
|
];
|
|
}
|
|
|
|
function draw_manager_notification_filter(bool $render = false, string $header_label = '') : void {
|
|
$filters = create_manager_notification_filter();
|
|
|
|
// create the page filter
|
|
$pageFilter = new CactiTableFilter($header_label, 'managers.php?action=edit&tab=notifications&id=' . gfrv('id'), 'form_snmpagent_managers', 'sess_snmp_cache');
|
|
|
|
$pageFilter->rows_label = __('OIDs');
|
|
$pageFilter->set_filter_array($filters);
|
|
|
|
if ($render) {
|
|
$pageFilter->render();
|
|
} else {
|
|
$pageFilter->sanitize();
|
|
}
|
|
}
|
|
|
|
function manager_notifications(int $id, string $header_label) : void {
|
|
global $item_rows, $mactions;
|
|
|
|
draw_manager_notification_filter(true, $header_label);
|
|
|
|
if (grv('rows') == '-1') {
|
|
$rows = read_config_option('num_rows_table');
|
|
} else {
|
|
$rows = grv('rows');
|
|
}
|
|
|
|
html_start_box($header_label, '100%', false, 3, 'center', '');
|
|
|
|
$sql_where = "WHERE `kind`='Notification'";
|
|
$sql_params = [];
|
|
|
|
// filter by host
|
|
if (grv('mib') != 'any' && grv('mib') != '-1') {
|
|
$sql_where .= ($sql_where != '' ? ' AND ' : 'WHERE ') . ' snmpagent_cache.mib = ?';
|
|
$sql_params[] = grv('mib');
|
|
}
|
|
|
|
// filter by search string
|
|
if (grv('filter') != 'any') {
|
|
$sql_where .= ($sql_where != '' ? ' AND ' : 'WHERE ') . ' (`oid` LIKE ? OR `name` LIKE ? OR `mib` LIKE ?)';
|
|
|
|
$sql_params[] = '%' . grv('filter') . '%';
|
|
$sql_params[] = '%' . grv('filter') . '%';
|
|
$sql_params[] = '%' . grv('filter') . '%';
|
|
}
|
|
|
|
$sql_order = ' ORDER by `oid`';
|
|
|
|
form_start('managers.php', 'chk');
|
|
|
|
$total_rows = db_fetch_cell_prepared("SELECT COUNT(*)
|
|
FROM snmpagent_cache
|
|
$sql_where",
|
|
$sql_params);
|
|
|
|
$snmp_cache_sql = "SELECT *
|
|
FROM snmpagent_cache
|
|
$sql_where
|
|
$sql_order
|
|
LIMIT " . ($rows * (grv('page') - 1)) . ',' . $rows;
|
|
|
|
$snmp_cache = db_fetch_assoc_prepared($snmp_cache_sql, $sql_params);
|
|
|
|
$registered_notifications = db_fetch_assoc_prepared('SELECT notification, mib
|
|
FROM snmpagent_managers_notifications
|
|
WHERE manager_id = ?',
|
|
[$id]);
|
|
|
|
$notifications = [];
|
|
|
|
if ($registered_notifications && cacti_sizeof($registered_notifications) > 0) {
|
|
foreach ($registered_notifications as $registered_notification) {
|
|
$notifications[$registered_notification['mib']][$registered_notification['notification']] = 1;
|
|
}
|
|
}
|
|
|
|
$display_text = [
|
|
__('Name'),
|
|
__('OID'),
|
|
__('MIB'),
|
|
__('Kind'),
|
|
__('Max-Access'),
|
|
__('Monitored')
|
|
];
|
|
|
|
// generate page list
|
|
$nav = html_nav_bar('managers.php?action=edit&id=' . $id . '&tab=notifications&mib=' . grv('mib') . '&filter=' . grv('filter'), MAX_DISPLAY_PAGES, grv('page'), $rows, $total_rows, cacti_sizeof($display_text) + 1, __('Notifications'), 'page', 'main');
|
|
|
|
print $nav;
|
|
|
|
html_start_box('', '100%', false, 3, 'center', '');
|
|
|
|
html_header_checkbox($display_text, true, 'managers.php?action=edit&tab=notifications&id=' . $id);
|
|
|
|
if (cacti_sizeof($snmp_cache)) {
|
|
foreach ($snmp_cache as $item) {
|
|
$row_id = $item['mib'] . '__' . $item['name'];
|
|
$oid = filter_value($item['oid'], grv('filter'));
|
|
$name = filter_value($item['name'], grv('filter'));
|
|
$mib = filter_value($item['mib'], grv('filter'));
|
|
|
|
form_alternate_row('line' . $row_id, false);
|
|
|
|
if ($item['description']) {
|
|
form_selectable_cell(filter_value($name, '', '#', $item['description']), $row_id);
|
|
} else {
|
|
form_selectable_cell($name, $row_id);
|
|
}
|
|
|
|
form_selectable_cell($oid, $row_id);
|
|
form_selectable_cell($mib, $row_id);
|
|
form_selectable_ecell($item['kind'], $row_id);
|
|
form_selectable_cell($item['max-access'],$row_id);
|
|
form_selectable_cell(((isset($notifications[$item['mib']]) && isset($notifications[$item['mib']][$item['name']])) ? '<span class="deviceUp">' . __('Enabled') : '<span class="deviceDown">' . __('Disabled')) . '</span>', $row_id);
|
|
form_checkbox_cell($item['oid'], $row_id);
|
|
|
|
form_end_row();
|
|
}
|
|
} else {
|
|
print '<tr class="tableRow odd"><td colspan="7"><em>' . __('No SNMP Notifications') . '</em></td></tr>';
|
|
}
|
|
|
|
form_hidden_box('id', grv('id'), '');
|
|
|
|
html_end_box(false);
|
|
|
|
if (cacti_sizeof($snmp_cache)) {
|
|
print $nav;
|
|
}
|
|
|
|
draw_actions_dropdown($mactions);
|
|
|
|
form_end();
|
|
}
|
|
|
|
function create_manager_log_filter(array $severity_levels) : array {
|
|
global $item_rows;
|
|
|
|
$all = ['-1' => __('All')];
|
|
|
|
$severity_levels = $all + $severity_levels;
|
|
|
|
return [
|
|
'rows' => [
|
|
[
|
|
'filter' => [
|
|
'method' => 'textbox',
|
|
'friendly_name' => __('Search'),
|
|
'filter' => FILTER_DEFAULT,
|
|
'placeholder' => __('Enter a search term'),
|
|
'size' => '30',
|
|
'default' => '',
|
|
'pageset' => true,
|
|
'max_length' => '120',
|
|
'value' => ''
|
|
],
|
|
'severity' => [
|
|
'method' => 'drop_array',
|
|
'friendly_name' => __('Severity'),
|
|
'filter' => FILTER_VALIDATE_INT,
|
|
'default' => '-1',
|
|
'pageset' => true,
|
|
'array' => $severity_levels,
|
|
'value' => '-1'
|
|
],
|
|
'rows' => [
|
|
'method' => 'drop_array',
|
|
'friendly_name' => __('Entries'),
|
|
'filter' => FILTER_VALIDATE_INT,
|
|
'default' => '-1',
|
|
'pageset' => true,
|
|
'array' => $item_rows,
|
|
'value' => '-1'
|
|
]
|
|
]
|
|
],
|
|
'buttons' => [
|
|
'go' => [
|
|
'method' => 'submit',
|
|
'display' => __('Go'),
|
|
'title' => __('Apply Filter to Table'),
|
|
],
|
|
'clear' => [
|
|
'method' => 'button',
|
|
'display' => __('Clear'),
|
|
'title' => __('Reset Filter to Default Values'),
|
|
],
|
|
'purge' => [
|
|
'method' => 'button',
|
|
'display' => __('Purge'),
|
|
'title' => __('Purge the Notification Receiver Log'),
|
|
]
|
|
]
|
|
];
|
|
}
|
|
|
|
function draw_manager_log_filter(bool $render = false, array $severity_levels = [], string $header_label = '') : void {
|
|
$filters = create_manager_log_filter($severity_levels);
|
|
|
|
// create the page filter
|
|
$pageFilter = new CactiTableFilter($header_label, 'managers.php?action=edit&tab=logs&id=' . gfrv('id'), 'form_log', 'sess_snmp_log');
|
|
|
|
$pageFilter->rows_label = __('Entries');
|
|
$pageFilter->set_filter_array($filters);
|
|
|
|
if ($render) {
|
|
$pageFilter->render();
|
|
} else {
|
|
$pageFilter->sanitize();
|
|
}
|
|
}
|
|
|
|
function manager_logs(int $id, string $header_label) : void {
|
|
$severity_levels = [
|
|
SNMPAGENT_EVENT_SEVERITY_LOW => 'LOW',
|
|
SNMPAGENT_EVENT_SEVERITY_MEDIUM => 'MEDIUM',
|
|
SNMPAGENT_EVENT_SEVERITY_HIGH => 'HIGH',
|
|
SNMPAGENT_EVENT_SEVERITY_CRITICAL => 'CRITICAL'
|
|
];
|
|
|
|
$severity_colors = [
|
|
SNMPAGENT_EVENT_SEVERITY_LOW => '#00FF00',
|
|
SNMPAGENT_EVENT_SEVERITY_MEDIUM => '#FFFF00',
|
|
SNMPAGENT_EVENT_SEVERITY_HIGH => '#FF0000',
|
|
SNMPAGENT_EVENT_SEVERITY_CRITICAL => '#FF00FF'
|
|
];
|
|
|
|
if (grv('action') == 'purge') {
|
|
db_execute_prepared('DELETE FROM snmpagent_notifications_log WHERE manager_id = ?', [$id]);
|
|
srv('clear', true);
|
|
}
|
|
|
|
draw_manager_log_filter(true, $severity_levels, $header_label);
|
|
// ====================================================
|
|
|
|
if (grv('rows') == '-1') {
|
|
$rows = read_config_option('num_rows_table');
|
|
} else {
|
|
$rows = grv('rows');
|
|
}
|
|
|
|
$sql_params = [];
|
|
|
|
$sql_where = 'WHERE snl.manager_id = ?';
|
|
$sql_params[] = $id;
|
|
|
|
// filter by severity
|
|
if (grv('severity') > 0) {
|
|
$sql_where .= ' AND snl.severity = ?';
|
|
$sql_params[] = grv('severity');
|
|
}
|
|
|
|
// filter by search string
|
|
if (grv('filter') != '') {
|
|
$sql_where .= ' AND (`varbinds` LIKE ?)';
|
|
$sql_params[] = '%' . grv('severity') . '%';
|
|
}
|
|
|
|
$sql_order = ' ORDER by `id` DESC';
|
|
|
|
$sql_query = "SELECT snl.*, sc.description
|
|
FROM snmpagent_notifications_log AS snl
|
|
LEFT JOIN snmpagent_cache AS sc
|
|
ON sc.name = snl.notification
|
|
$sql_where
|
|
$sql_order
|
|
LIMIT " . ($rows * (grv('page') - 1)) . ',' . $rows;
|
|
|
|
form_start('managers.php', 'chk');
|
|
|
|
$total_rows = db_fetch_cell_prepared("SELECT COUNT(*)
|
|
FROM snmpagent_notifications_log AS snl
|
|
$sql_where",
|
|
$sql_params);
|
|
|
|
$logs = db_fetch_assoc_prepared($sql_query, $sql_params);
|
|
|
|
$display_text = [
|
|
__('Data'),
|
|
__('Time'),
|
|
__('Notification'),
|
|
__('Varbinds')
|
|
];
|
|
|
|
$nav = html_nav_bar('managers.php?action=exit&id=' . $id . '&tab=logs&mib=' . grv('mib') . '&filter=' . grv('filter'), MAX_DISPLAY_PAGES, grv('page'), $rows, $total_rows, cacti_sizeof($display_text), __('Receivers'), 'page', 'main');
|
|
|
|
print $nav;
|
|
|
|
html_start_box('', '100%', false, 3, 'center', '');
|
|
|
|
html_header($display_text);
|
|
|
|
if (cacti_sizeof($logs)) {
|
|
foreach ($logs as $item) {
|
|
$varbinds = filter_value($item['varbinds'], grv('filter'));
|
|
|
|
form_alternate_row('line' . $item['id'], true);
|
|
|
|
form_selectable_cell(filter_value('', '', '#', __esc('Severity Level') . ': ' . $severity_levels[$item['severity']]), $item['id'], '', 'width:10px;background-color:' . $severity_colors[$item['severity']] . ';border-top:1px solid white;border-bottom:1px solid white;');
|
|
form_selectable_cell(date('Y/m/d H:i:s', $item['time']), $item['id']);
|
|
|
|
if ($item['description']) {
|
|
$description = '';
|
|
$lines = preg_split('/\r\n|\r|\n/', $item['description']);
|
|
|
|
foreach (($lines ?: []) as $line) {
|
|
$description .= htmle(trim($line)) . '<br>';
|
|
}
|
|
|
|
form_selectable_cell(filter_value($item['notification'], '', '#', $item['notification'] . $description), $item['id']);
|
|
} else {
|
|
form_selectable_ecell($item['notification'], $item['id']);
|
|
}
|
|
|
|
form_selectable_cell($varbinds, $item['id']);
|
|
|
|
form_end_row();
|
|
}
|
|
} else {
|
|
print '<tr class="tableRow odd"><td colspan="4"><em>' . __('No SNMP Notification Log Entries') . '</em></td></tr>';
|
|
}
|
|
|
|
html_end_box();
|
|
|
|
if (cacti_sizeof($logs)) {
|
|
print $nav;
|
|
}
|
|
|
|
?>
|
|
<input type='hidden' name='id' value='<?php print gfrv('id'); ?>'>
|
|
<div style='display:none' id='snmpagentTooltip'></div>
|
|
<?php
|
|
}
|
|
|
|
function form_save() : void {
|
|
if (!isrv('tab')) {
|
|
srv('tab', 'general');
|
|
}
|
|
|
|
// ================= input validation =================
|
|
gfrv('id');
|
|
gfrv('max_log_size');
|
|
|
|
if (!in_array(gnrv('max_log_size'), range(1,31), true)) {
|
|
die_html_input_error('max_log_size');
|
|
}
|
|
// ================= input validation =================
|
|
|
|
switch(gnrv('tab')) {
|
|
case 'notifications':
|
|
header('Location: managers.php?action=edit&tab=notifications&id=' . grv('id'));
|
|
|
|
break;
|
|
default:
|
|
$save['id'] = grv('id');
|
|
$save['description'] = CactiValidator::validateInput(trim(gnrv('description')), 'description', [new Assert\NotBlank()], 3);
|
|
$save['hostname'] = CactiValidator::validateInput(trim(gnrv('hostname')), 'hostname', [new Assert\NotBlank()], 3);
|
|
$save['disabled'] = CactiValidator::validateInput(gnrv('disabled'), 'disabled', [new Assert\Regex('/^(on)?$/')], 3);
|
|
$save['max_log_size'] = gnrv('max_log_size');
|
|
$save['snmp_version'] = CactiValidator::validateInput(gnrv('snmp_version'), 'snmp_version', [new Assert\NotBlank(), new Assert\Regex('/^[1-3]$/')], 3);
|
|
$save['snmp_community'] = CactiValidator::validateInput(gnrv('snmp_community'), 'snmp_community', [], 3);
|
|
|
|
if ($save['snmp_version'] == 3) {
|
|
$save['snmp_username'] = CactiValidator::validateInput(gnrv('snmp_username'), 'snmp_username', [], 3);
|
|
$save['snmp_password'] = CactiValidator::validateInput(gnrv('snmp_password'), 'snmp_password', [], 3);
|
|
$save['snmp_auth_protocol'] = CactiValidator::validateInput(gnrv('snmp_auth_protocol'), 'snmp_auth_protocol', [new Assert\Regex('/^(\[None\]|MD5|SHA|SHA224|SHA256|SHA392|SHA512)?$/')], 3);
|
|
$save['snmp_priv_passphrase'] = CactiValidator::validateInput(gnrv('snmp_priv_passphrase'), 'snmp_priv_passphrase', [], 3);
|
|
$save['snmp_priv_protocol'] = CactiValidator::validateInput(gnrv('snmp_priv_protocol'), 'snmp_priv_protocol', [new Assert\Regex('/^(\[None\]|DES|AES|AES128|AES192|AES192C|AES256|AES256C)?$/')], 3);
|
|
$save['snmp_engine_id'] = CactiValidator::validateInput(get_request_var_post('snmp_engine_id'), 'snmp_engine_id', [new Assert\NotBlank()], 3);
|
|
} else {
|
|
$save['snmp_username'] = '';
|
|
$save['snmp_password'] = '';
|
|
$save['snmp_auth_protocol'] = '';
|
|
$save['snmp_priv_passphrase'] = '';
|
|
$save['snmp_priv_protocol'] = '';
|
|
$save['snmp_engine_id'] = '';
|
|
}
|
|
|
|
$save['snmp_port'] = CactiValidator::validateInput(gnrv('snmp_port'), 'snmp_port', [new Assert\NotBlank(), new Assert\Regex('/^[0-9]+$/')], 3);
|
|
$save['snmp_message_type'] = CactiValidator::validateInput(gnrv('snmp_message_type'), 'snmp_message_type', [new Assert\NotBlank(), new Assert\Regex('/^[1-2]$/')], 3);
|
|
$save['notes'] = CactiValidator::validateInput(gnrv('notes'), 'notes', [], 3);
|
|
|
|
if ($save['snmp_version'] == 3 && ($save['snmp_password'] != gnrv('snmp_password_confirm'))) {
|
|
raise_message(4);
|
|
}
|
|
|
|
if ($save['snmp_version'] == 3 && ($save['snmp_priv_passphrase'] != gnrv('snmp_priv_passphrase_confirm'))) {
|
|
raise_message(4);
|
|
}
|
|
|
|
$manager_id = 0;
|
|
|
|
if (!is_error_message()) {
|
|
$manager_id = sql_save($save, 'snmpagent_managers');
|
|
raise_message(($manager_id) ? 1 : 2);
|
|
}
|
|
|
|
break;
|
|
}
|
|
|
|
header('Location: managers.php?action=edit&id=' . (empty($manager_id) ? gnrv('id') : $manager_id));
|
|
}
|
|
|
|
function form_actions() : void {
|
|
global $actions, $mactions;
|
|
|
|
if (isrv('selected_items')) {
|
|
if (isrv('action_receivers')) {
|
|
$selected_items = sanitize_unserialize_selected_items(gnrv('selected_graphs_array'));
|
|
|
|
if (!empty($selected_items) && is_array($selected_items)) {
|
|
$selected_ids = implode(',', array_map('intval', $selected_items));
|
|
|
|
if (gnrv('drp_action') == '1') { // delete
|
|
db_execute('DELETE FROM snmpagent_managers WHERE id IN (' . $selected_ids . ')');
|
|
db_execute('DELETE FROM snmpagent_managers_notifications WHERE manager_id IN (' . $selected_ids . ')');
|
|
db_execute('DELETE FROM snmpagent_notifications_log WHERE manager_id IN (' . $selected_ids . ')');
|
|
} elseif (gnrv('drp_action') == '2') { // disable
|
|
db_execute("UPDATE snmpagent_managers SET disabled = 'on' WHERE id IN (" . $selected_ids . ')');
|
|
} elseif (gnrv('drp_action') == '3') { // enable
|
|
db_execute("UPDATE snmpagent_managers SET disabled = '' WHERE id IN (" . $selected_ids . ')');
|
|
}
|
|
|
|
header('Location: managers.php');
|
|
|
|
exit;
|
|
}
|
|
} elseif (isrv('action_receiver_notifications')) {
|
|
// ================= input validation =================
|
|
gfrv('id');
|
|
// ====================================================
|
|
|
|
$selected_items = cacti_unserialize(stripslashes(gnrv('selected_items')));
|
|
|
|
if ($selected_items !== false) {
|
|
if (gnrv('drp_action') == '1') { // disable
|
|
foreach ($selected_items as $mib => $notifications) {
|
|
foreach ($notifications as $notification => $state) {
|
|
db_execute_prepared('DELETE FROM snmpagent_managers_notifications
|
|
WHERE `manager_id` = ?
|
|
AND `mib` = ?
|
|
AND `notification` = ?
|
|
LIMIT 1',
|
|
[gnrv('id'), $mib, $notification]);
|
|
}
|
|
}
|
|
} elseif (gnrv('drp_action') == '2') { // enable
|
|
foreach ($selected_items as $mib => $notifications) {
|
|
foreach ($notifications as $notification => $state) {
|
|
db_execute_prepared('INSERT IGNORE INTO snmpagent_managers_notifications
|
|
(`manager_id`, `notification`, `mib`)
|
|
VALUES (?, ?, ?)',
|
|
[gnrv('id'), $notification, $mib]);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
header('Location: managers.php?action=edit&id=' . gnrv('id') . '&tab=notifications');
|
|
|
|
exit;
|
|
}
|
|
} elseif (isrv('action_receivers')) {
|
|
$ilist = '';
|
|
$iarray = [];
|
|
|
|
foreach ($_POST as $key => $value) {
|
|
if (strstr($key, 'chk_')) {
|
|
// grep manager's id
|
|
$id = substr($key, 4);
|
|
// ================= input validation =================
|
|
input_validate_input_number($id, 'id');
|
|
// ====================================================
|
|
|
|
$ilist .= '<li>' . htmle(db_fetch_cell_prepared('SELECT description FROM snmpagent_managers WHERE id = ?', [$id])) . '</li>';
|
|
|
|
$iarray[] = $id;
|
|
}
|
|
}
|
|
|
|
$form_data = [
|
|
'general' => [
|
|
'page' => 'managers.php',
|
|
'actions' => $actions,
|
|
'eaction' => 'action_receivers',
|
|
'optvar' => 'drp_action',
|
|
'item_array' => $iarray,
|
|
'item_list' => $ilist
|
|
],
|
|
'options' => [
|
|
1 => [
|
|
'smessage' => __('Click \'Continue\' to Delete the following Notification Receiver.'),
|
|
'pmessage' => __('Click \'Continue\' to Delete following Notification Receivers.'),
|
|
'scont' => __('Delete Notification Receiver'),
|
|
'pcont' => __('Delete Notification Receivers')
|
|
],
|
|
2 => [
|
|
'smessage' => __('Click \'Continue\' to Disable the following Notification Receiver.'),
|
|
'pmessage' => __('Click \'Continue\' to Disable following Notification Receivers.'),
|
|
'scont' => __('Disable Notification Receiver'),
|
|
'pcont' => __('Disable Notification Receivers')
|
|
],
|
|
3 => [
|
|
'smessage' => __('Click \'Continue\' to Enable the following Notification Receiver.'),
|
|
'pmessage' => __('Click \'Continue\' to Enable following Notification Receivers.'),
|
|
'scont' => __('Enable Notification Receiver'),
|
|
'pcont' => __('Enable Notification Receivers'),
|
|
]
|
|
]
|
|
];
|
|
|
|
form_continue_confirmation($form_data);
|
|
} else {
|
|
$ilist = '';
|
|
$iarray = [];
|
|
|
|
// ================= input validation =================
|
|
gfrv('id');
|
|
// ====================================================
|
|
|
|
foreach ($_POST as $key => $value) {
|
|
if (strstr($key, 'chk_')) {
|
|
// grep mib and notification name
|
|
$row_id = substr($key, 4);
|
|
|
|
[$mib, $name] = explode('__', $row_id);
|
|
|
|
$ilist .= '<li>' . htmle($name) . ' (' . htmle($mib) . ')</li>';
|
|
|
|
$iarray[$mib][$name] = 1;
|
|
}
|
|
}
|
|
|
|
$form_data = [
|
|
'general' => [
|
|
'page' => 'managers.php?action=edit&tab=notifications&id=' . grv('id'),
|
|
'actions' => $mactions,
|
|
'eaction' => 'action_receiver_notifications',
|
|
'optvar' => 'drp_action',
|
|
'item_array' => $iarray,
|
|
'item_list' => $ilist
|
|
],
|
|
'options' => [
|
|
1 => [
|
|
'smessage' => __('Click \'Continue\' to Disable Forwarding the following Notification Object the following Notification Receiver.'),
|
|
'pmessage' => __('Click \'Continue\' to Disable Forwarding the following Notification Objects to the following Notification Receiver.'),
|
|
'scont' => __('Disable Forwarding Object'),
|
|
'pcont' => __('Disable Forwarding Objects')
|
|
],
|
|
2 => [
|
|
'smessage' => __('Click \'Continue\' to Enable Forwarding the following Notification Object to this Notification Receiver.'),
|
|
'pmessage' => __('Click \'Continue\' to Enable Forwarding the following Notification Objects Notification Receivers.'),
|
|
'scont' => __('Enable Forwarding Object'),
|
|
'pcont' => __('Enable Forwarding Objects')
|
|
]
|
|
]
|
|
];
|
|
|
|
form_continue_confirmation($form_data);
|
|
}
|
|
}
|