Files
cacti/snmpagent_mibcache.php
Thomas VincentandTheWitness f2a5ef0d51 fix: cast path_php_binary before passing it to string parameters (#7576) (#7577)
* fix: cast path_php_binary before passing it to string parameters

The setting has no default, so it is null on a fresh install, and PHP 9 turns
the resulting coercion from a deprecation into a TypeError.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* docs: append the changelog entry at the end of the issue block

Matches .github/copilot-instructions.md, which appends rather than inserting
in numeric order.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: use the full licence header on the new test files

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: cast path_php_binary at every site that escapes it

The first pass covered three of them; a repo-wide scan found 21, and the test
now fails if a new one appears.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* test: strengthen PHP binary path guard

* fix: cover default-config PHP binary reads

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2026-08-06 09:42:52 -04:00

61 lines
2.5 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
// let's report all errors
error_reporting(E_ALL);
require(__DIR__ . '/include/cli_check.php');
// allow the script to hang around.
set_time_limit(0);
chdir(__DIR__);
$path_mibcache = CACTI_PATH_CACHE . '/mibcache/mibcache.tmp';
$path_mibcache_lock = CACTI_PATH_CACHE . '/mibcache/mibcache.lock';
// remove temporary cache
if (file_exists($path_mibcache) && is_writable($path_mibcache)) {
unlink($path_mibcache);
}
// remove lock file
if (file_exists($path_mibcache_lock) && is_writable($path_mibcache_lock)) {
unlink($path_mibcache_lock);
}
// start background caching process if not running
$php = cacti_escapeshellcmd((string) read_config_option('path_php_binary'));
$extra_args = ' ' . cacti_escapeshellarg('./snmpagent_mibcachechild.php');
while (true) {
if (cacti_strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
popen('start "CactiSNMPCacheChild" /I ' . $php . ' ' . $extra_args, 'r');
} else {
exec($php . ' ' . $extra_args . ' > /dev/null &');
}
sleep(30 - time() % 30);
}