cacti/tests/Unit/Security/Csrf/ItemActionPostOnlyTest.php

<?php
/*
 +-------------------------------------------------------------------------+
 | Copyright (C) 2004-2026 The Cacti Group                                 |
 |                                                                         |
 | This program is free software; you can redistribute it and/or           |
 | modify it under the terms of the GNU General Public License             |
 | as published by the Free Software Foundation; either version 2          |
 | of the License, or (at your option) any later version.                  |
 +-------------------------------------------------------------------------+
 | Cacti: The Complete RRDtool-based Graphing Solution                     |
 +-------------------------------------------------------------------------+
*/

/*
 * Item, tree, RRA, and ordering actions change state and were reachable by GET,
 * so a cross-origin request could delete or reorder objects using the victim's
 * authentication state.
 *
 * The guard and the links have to move together: adding the actions to
 * $bad_actions while a page still links them by GET breaks the delete it is
 * meant to protect. These two assertions fail in opposite directions, so
 * neither half can land alone.
 */

/**
 * Every GET reachable action whose handler mutates state. Read-only actions are
 * deliberately absent: item_edit, readme, changelog, latest, avail and the
 * *_confirm dialogs render a page and change nothing.
 *
 * @return array<int, string> Action names.
 */
function guarded_actions() {
	return [
		'item_remove', 'item_moveup', 'item_movedown',
		'item_remove_gsv', 'item_remove_dssv',
		'item_moveup_gsv', 'item_moveup_dssv',
		'item_movedown_gsv', 'item_movedown_dssv',
		'delete_node', 'gt_remove', 'query_remove', 'remove', 'change_leaf',
		'moveup', 'movedown',
		'tree_up', 'tree_down', 'move_page_up', 'move_page_down',
		'rrd_add', 'rrd_remove',
		'ds_repair',
	];
}

/**
 * A pattern matching any guarded action, longest name first so that
 * item_remove_gsv is not matched as item_remove.
 *
 * @return string A regex alternation.
 */
function guarded_action_pattern() {
	$actions = guarded_actions();

	usort($actions, function ($a, $b) {
		return strlen($b) - strlen($a);
	});

	return 'action=(?:' . implode('|', array_map('preg_quote', $actions)) . ')(?![a-z_])';
}

function item_action_files() {
	$root  = dirname(__DIR__, 4);
	$found = [];

	$it = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($root, FilesystemIterator::SKIP_DOTS));

	foreach ($it as $file) {
		$path = $file->getPathname();

		if (substr($path, -4) !== '.php') {
			continue;
		}

		if (strpos($path, '/include/vendor/') !== false || strpos($path, '/tests/') !== false) {
			continue;
		}

		$src = file_get_contents($path);

		if ($src !== false && preg_match('/' . guarded_action_pattern() . '/', $src)) {
			$found[] = substr($path, strlen($root) + 1);
		}
	}

	sort($found);

	return $found;
}

test('every state changing action is refused without a POST token', function () {
	$src = file_get_contents(dirname(__DIR__, 4) . '/include/global.php');

	expect($src)->not->toBeFalse();

	preg_match('/\$bad_actions\s*=\s*(?:array\(|\[)(.*?)(?:\);|\];)/s', $src, $matches);

	expect($matches)->toHaveKey(1);

	$list = $matches[1];

	$missing = [];

	foreach (guarded_actions() as $action) {
		if (strpos($list, "'" . $action . "'") === false) {
			$missing[] = $action;
		}
	}

	expect($missing)->toBe([]);
	expect($src)->toContain("(\$_SERVER['REQUEST_METHOD'] ?? 'GET') !== 'POST'")
		->and($src)->toContain("header('Allow: POST')")
		->and($src)->toContain('http_response_code(405)')
		->and($src)->toContain('http_response_code(403)');
});

test('no page still links a state changing action by GET', function () {
	$files = item_action_files();

	expect($files)->not->toBe([]);

	$unconverted = [];

	foreach ($files as $file) {
		$src = file_get_contents(dirname(__DIR__, 4) . '/' . $file);

		/* Anchors are emitted across two lines in places, so collapse the file
		   before pairing an href with the class that posts it. */
		$flat = preg_replace('/\s+/', ' ', $src);

		if (preg_match_all('/<a\b[^>]*?' . guarded_action_pattern() . '[^>]*>/', $flat, $matches)) {
			foreach ($matches[0] as $anchor) {
				$has_safe_href = strpos($anchor, "href='#'") !== false
					|| strpos($anchor, 'href="#"') !== false;
				$uses_global_handler = strpos($anchor, 'cactiPostAction') !== false;
				$uses_page_handler   = strpos($anchor, 'remover') !== false
					&& strpos($src, "$('.remover').on('click'") !== false
					&& strpos($src, 'cactiPreparePostRequestFromUrl') !== false;

				if (!$has_safe_href || (!$uses_global_handler && !$uses_page_handler)) {
					$unconverted[] = $file;

					break;
				}
			}
		}
	}

	expect($unconverted)->toBe([]);
});

test('the cactiPostAction handler posts the token and refuses another origin', function () {
	$js = file_get_contents(dirname(__DIR__, 4) . '/include/layout.js');

	expect($js)->not->toBeFalse();

	/* The class has to be bound on its own, not only through the ajaxAnchors
	   selector, because several tagged anchors carry none of the classes that
	   selector names. */
	expect($js)->toContain("$(document).rebind('click.cactiPostAction', 'a.cactiPostAction'")
		->and($js)->toContain(".not('.cactiPostAction').rebind('click'")
		->and($js)->toContain('submitPageUsingPost')
		->and($js)->toContain('cactiPreparePostRequestFromUrl');

	$start = strpos($js, 'function cactiPreparePostRequest(');

	expect($start)->not->toBeFalse();

	$body = substr($js, $start, 600);

	expect($body)->toContain('csrfMagicToken')
		->and($body)->toContain('__csrf_magic')
		->and($body)->toContain('Refusing to send a CSRF token to a different origin');
});

test('state action URLs use attribute-safe escaping and the page handler posts', function () {
	$data_queries = file_get_contents(dirname(__DIR__, 4) . '/data_queries.php');
	$html         = file_get_contents(dirname(__DIR__, 4) . '/lib/html.php');

	expect($data_queries)->not->toBeFalse()
		->and($html)->not->toBeFalse()
		->and(substr_count($data_queries, "data-url='<?php print html_escape_url("))->toBeGreaterThanOrEqual(6)
		->and(substr_count($html, "data-url='\" . html_escape_url("))->toBeGreaterThanOrEqual(3)
		->and($data_queries)->toContain("$('.remover').on('click'")
		->and($data_queries)->toContain('cactiPreparePostRequestFromUrl(href)')
		->and($data_queries)->toContain('$.post(request.url, request.data)');
});

test('every guarded data URL uses attribute-safe URL escaping', function () {
	$unsafe = [];

	foreach (item_action_files() as $file) {
		$lines = file(dirname(__DIR__, 4) . '/' . $file);

		foreach ($lines as $line_number => $line) {
			$attribute_start = strpos($line, 'data-url=');

			if ($attribute_start === false || !preg_match('/' . guarded_action_pattern() . '/', $line)) {
				continue;
			}

			$attribute = substr($line, $attribute_start);

			if (strpos($attribute, 'html_escape_url(') === false
				|| strpos($attribute, 'htmle(') !== false
				|| strpos($attribute, 'htmlspecialchars(') !== false) {
				$unsafe[] = $file . ':' . ($line_number + 1);
			}
		}
	}

	expect($unsafe)->toBe([]);
});

test('the data template add button submits its guarded action by POST', function () {
	$data_templates = file_get_contents(dirname(__DIR__, 4) . '/data_templates.php');
	$html           = file_get_contents(dirname(__DIR__, 4) . '/lib/html.php');

	expect($data_templates)->toContain("'data_url' => 'data_templates.php?action=rrd_add&id='")
		->and($html)->toContain("isset(\$icon['data_url'])")
		->and($html)->toContain("html_escape_url(\$icon['data_url'])")
		->and($html)->toContain("linkOverDark cactiPostAction");
});