Files
cacti/tests/Unit/Security/Csrf/SupportLockoutCsrfTest.php
Sean Mancini 96033267cb refactor(tests): reorganize unit tests into domain category folders (#7733)
* refactor(tests): reorganize unit tests into domain category folders

- Consolidate per-advisory GHSA regression tests into Security/ subfolders by vuln class
- Group all 186 test files into domain folders: DataCollection/, Ui/, Core/,
  Database/, Installer/, Scripts/, Security/, Plugin/
- Strip GitHub issue/GHSA numbers from filenames; keep IDs in test descriptions
- Fix all __DIR__ relative paths to match new folder nesting depth
- Update CI workflow path triggers and phpunit XML configs for new file locations
- Update .github/copilot-instructions.md with unit test organization guidelines
- Add tests/vendor/ to .gitignore

* add gaurds

* fix up guard for unit tests

* fix redeclaration of cacti_log in tests

* fix updates to unit tests

* fix test patjhs

* fix: update test __DIR__ paths for reorganized test structure

* fix: conditionally define read_user_setting to prevent redeclaration in tests

* fix: conditionally define functions to prevent redeclaration in tests

- Wrap clean_up_lines, raise_message, cacti_debug_backtrace, and get_debug_prefix
  with function_exists() checks to prevent conflicts when test stubs are loaded
  before lib/functions.php in the same PHP process

* fix: add unit test bootstrap to prevent function redeclaration errors

- Create tests/bootstrap-unit.php to load core libraries before tests
- Ensures lib/functions.php loads before test stubs define stub functions
- Test stubs use function_exists() checks, so they detect pre-loaded functions
- Update phpunit.xml to use bootstrap-unit.php for Unit testsuite
- Fixes 'Cannot redeclare read_user_setting()' errors when tests run in same process

* fix: load test stubs before global.php in unit test bootstrap

- Reorder bootstrap to load CactiStubs.php and UnitStubs.php first
- Ensures stub functions like __() are available when global.php loads
- global.php calls get_cacti_version_text() which needs __() for translations
- Fixes 'Call to undefined function __()' error during bootstrap

* fix: remove function conflicts from test stubs

- Remove stub definitions for functions already in lib/functions.php:
  cacti_sizeof, cacti_log, cacti_strtolower, read_config_option,
  read_user_setting, cacti_count
- Keep translation function stubs (__(), __esc()) needed by global.php
- Update bootstrap to load lib/functions.php after stubs
- This prevents function redeclaration errors while maintaining test isolation

* fix: prevent constant and variable redeclaration in bootstrap

- Remove explicit PHP_TESTING and CACTI_TEST_BOOTSTRAP defines from bootstrap
  (CactiStubs.php now handles this with guards)
- Add guards to CactiStubs.php to prevent redefinition of PHP_TESTING
- Only set CACTI_TEST_BOOTSTRAP env vars if not already set
- Fixes PHP warnings about 'Constant X already defined'

* fix: remove redundant lib/functions.php load from bootstrap

include/global.php already loads lib/functions.php at lines 287-288.
The bootstrap was trying to load it again after global.php, but global.php
needs format_cacti_version() to be available on lines 293-294 to define
CACTI_VERSION and CACTI_VERSION_FULL constants.

Solution: Let global.php handle loading lib/functions.php itself, and don't
load it separately in the bootstrap.

* fix: remove more conflicting function stubs from test helpers

- Remove stubs for functions also defined in lib/functions.php:
  raise_message, clean_up_lines, cacti_debug_backtrace, get_debug_prefix
- Remove POLLER_ID constant stub (defined unconditionally by global.php)
- Keep only translation functions and test-specific helpers
- This prevents function/constant redeclaration errors

* fix: minimize test stubs to only translation functions

Remove ALL helper functions and constants from UnitStubs.php that are:
- Defined in lib/functions.php (raise_message, clean_up_lines, etc.)
- Defined in lib/html_utility.php (srv, set_request_var)
- Defined in global_constants.php (POLLER_VERBOSITY_*, MESSAGE_LEVEL_*)
- Defined in global.php (POLLER_ID)

Keep ONLY translation functions (__(), __esc()) that are:
- Called by global.php during initialization
- Not defined elsewhere
- Required for proper bootstrap sequence

This eliminates all constant and function redeclaration errors.

* fix: remove __esc stub - already defined in global_languages.php

Keep only __() translation function stub, which is needed by global.php
and not defined elsewhere in Cacti core.

* fix: handle no-arg case in __() translation stub

The __() function may be called with just a string and no format arguments.
Previously, vsprintf() would fail with 'arguments array must contain 2 items'.
Now, if no args are provided, return the text as-is.
2026-08-16 19:23:31 -07:00

154 lines
6.3 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
require_once dirname(__DIR__, 3) . '/Helpers/CactiStubs.php';
require_once dirname(__DIR__, 4) . '/include/global.php';
/*
* support_lockout() (support.php, #7352) cannot be called directly: it ends in
* exit and redirects with header(). Extract the function source and evaluate a
* copy with exit -> return, and the header()/cacti_log() side effects removed,
* so each decision branch runs in-process. This mirrors the source-extraction
* convention in Issue7070PercentileContractTest. eval() runs only Cacti's own
* source, extracted at test time, with no external input.
*
* The stored lockout state is read with read_config_option(..., true), a forced
* read that bypasses the option cache. Under the test bootstrap that returns the
* empty default, so the "currently locked" path (unlock) cannot be reached here
* and is left to the Docker end-to-end test.
*/
function lockout_csrf_define_probe(): void {
if (function_exists('lockout_csrf_probe')) {
return;
}
$src = file_get_contents(dirname(__DIR__, 4) . '/support.php');
if (preg_match('/function support_lockout\(\) : void \{.*?^\}/sm', $src, $m) !== 1) {
throw new RuntimeException('could not locate support_lockout() in support.php');
}
$body = $m[0];
$body = preg_replace('/^\s*header\([^;]*\);\s*$/m', '', $body);
$body = preg_replace('/^\s*cacti_log\([^;]*\);\s*$/m', '', $body);
$body = preg_replace('/\bexit\s*;/', 'return;', $body);
// The forced read of admin_user only feeds the message text via get_username().
// A forced read re-hits the database, which the test bootstrap answers with an
// empty value that also overwrites the seeded option cache, so drop the force
// here and let the admin identity come from the seeded cache instead. The
// admin comparison itself already uses an unforced read, so this does not
// change which branch runs.
$body = str_replace("read_config_option('admin_user', true)", "read_config_option('admin_user')", $body);
$body = preg_replace('/^function support_lockout\(\)/m', 'function lockout_csrf_probe()', $body);
eval($body);
}
lockout_csrf_define_probe();
beforeEach(function () {
global $no_http_headers, $config;
// Skip the session bootstrap inside raise_message so it writes straight to
// $_SESSION[SESS_MESSAGES] without starting a CLI session.
$no_http_headers = true;
$_SESSION = [];
$_REQUEST = [];
$config[OPTIONS_CLI]['admin_user'] = '1';
});
test('a non-POST lockout request is dropped before any state change', function () {
$_SERVER['REQUEST_METHOD'] = 'GET';
$_SESSION[SESS_USER_ID] = '1';
$_REQUEST['expected'] = 'unlocked';
lockout_csrf_probe();
// The guard returns before reaching the admin check, so no lockout message
// is raised at all.
expect($_SESSION[SESS_MESSAGES] ?? [])->toBe([]);
});
test('only the primary administrator may toggle the lockout', function () {
$_SERVER['REQUEST_METHOD'] = 'POST';
$_SESSION[SESS_USER_ID] = '2';
$_REQUEST['expected'] = 'unlocked';
lockout_csrf_probe();
expect($_SESSION[SESS_MESSAGES])->toHaveKey('lockout_user')
->and($_SESSION[SESS_MESSAGES]['lockout_user']['level'])->toBe(MESSAGE_LEVEL_ERROR);
});
test('a POST without a valid expected state is rejected', function () {
$_SERVER['REQUEST_METHOD'] = 'POST';
$_SESSION[SESS_USER_ID] = '1';
$_REQUEST['expected'] = 'garbage';
lockout_csrf_probe();
expect($_SESSION[SESS_MESSAGES])->toHaveKey('lockout')
->and($_SESSION[SESS_MESSAGES]['lockout']['level'])->toBe(MESSAGE_LEVEL_INFO);
});
test('a stale expected state does not flip the lockout', function () {
$_SERVER['REQUEST_METHOD'] = 'POST';
$_SESSION[SESS_USER_ID] = '1';
// The stored state is unlocked (empty default) but the page thought it was
// locked, so the compare-and-set must refuse to change anything.
$_REQUEST['expected'] = 'locked';
lockout_csrf_probe();
expect($_SESSION[SESS_MESSAGES])->toHaveKey('lockout')
->and($_SESSION[SESS_MESSAGES]['lockout']['level'])->toBe(MESSAGE_LEVEL_INFO);
});
test('a matching expected state locks Cacti', function () {
$_SERVER['REQUEST_METHOD'] = 'POST';
$_SESSION[SESS_USER_ID] = '1';
// Stored state is unlocked and the page agrees, so the lock is applied.
$_REQUEST['expected'] = 'unlocked';
lockout_csrf_probe();
expect($_SESSION[SESS_MESSAGES])->toHaveKey('lockout')
->and($_SESSION[SESS_MESSAGES]['lockout']['level'])->toBe(MESSAGE_LEVEL_WARN);
});
test('the process-list page offset is clamped against negative LIMIT offsets', function () {
$src = file_get_contents(dirname(__DIR__, 4) . '/support.php');
// Both process tables must clamp the page number to at least 1 so a page=0
// or negative page cannot produce a negative SQL LIMIT offset. Matched with
// tolerant whitespace so reformatting doesn't break this on exact spacing.
expect(preg_match_all('/max\(\s*1\s*,\s*\(int\)\s*grv\(\s*\'page\'\s*\)\s*\)/', $src))->toBe(2);
});