test(postgres): pin three guards no test caught when changed

A job whose own Backup exists skips the wait for another job's plugin
rollout, and the size probe keeps the strategy's Secret key names while
it takes the Secret from the record, adding a credentials block only
when the strategy has none. Each of these could be changed with the
suite still green: dropping the own-Backup check, or forcing the
missing-credentials branch either way. Cases for a job with a running
Backup next to a recent foreign attach, a strategy without credentials
and a strategy with custom key names now fail on each change.

Assisted-by: LLM
Signed-off-by: Alexey Artamonov <aleksei.artamonov@aenix.io>
This commit is contained in:
Alexey Artamonov committed 2026-11-12 17:02:40 +03:00
1 parent 1d22013646
commit 5c6fc10a23
2 files changed
+79

No files matched your search

@@ -514,3 +514,65 @@ func TestCreateCNPGBackupArtifact_SizeProbeSkipsARecordWithoutCredentials(t *tes
t.Errorf("Artifact = %#v, want no size", got.Status.Artifact)
}
}
// probeRecordedBackup runs createCNPGBackupArtifact for a backup recorded as
// written with credentials Secret recordedSecret, against rendered, and
// returns the size it measured and the connection it measured through.
func probeRecordedBackup(t *testing.T, rendered *strategyv1alpha1.CNPGTemplate, recordedSecret *corev1.Secret) (int64, s3Connection) {
t.Helper()
apiGroup := backupsv1alpha1.DefaultApplicationAPIGroup
j := &backupsv1alpha1.BackupJob{
ObjectMeta: metav1.ObjectMeta{Namespace: "tenant", Name: "bj-probe"},
Spec: backupsv1alpha1.BackupJobSpec{
ApplicationRef: corev1.TypedLocalObjectReference{APIGroup: &apiGroup, Kind: postgresAppKind, Name: "pg"},
},
}
cnpgBk := &cnpgtypes.Backup{ObjectMeta: metav1.ObjectMeta{Name: "cnpg-bk"}, Status: cnpgtypes.BackupStatus{BackupID: "20261021T100000"}}
secretName := recordedSecret.Name
written := cnpgDestination{DestinationPath: "s3://bkt/tenant/pg/", EndpointURL: "https://s3.example:8443", S3SecretRef: &secretName}
l := &fakeS3Lister{objects: []s3ObjectInfo{{Key: "tenant/pg/srv/base/20261021T100000/data.tar.gz", Size: 42}}}
r := reconcilerWithLister(t, l)
r.Client = newCNPGStrategyTestClient(t, recordedSecret)
got, err := r.createCNPGBackupArtifact(context.Background(), j, &ResolvedBackupConfig{}, cnpgBk, "postgres-pg", "srv", "postgresql", written, rendered, newPostgresApp("pg", "tenant"))
if err != nil {
t.Fatalf("createCNPGBackupArtifact: %v", err)
}
if got.Status.Artifact == nil {
t.Fatalf("no artifact")
}
return got.Status.Artifact.SizeBytes, l.conn
}
// A strategy that has since dropped its credentials still measures a backup
// recorded with a Secret, through that Secret and its default keys.
func TestCreateCNPGBackupArtifact_SizeProbeOfARecordedSecretUnderAStrategyWithoutCredentials(t *testing.T) {
store := newSizedBarmanObjectStore()
store.S3Credentials = nil
size, conn := probeRecordedBackup(t, &strategyv1alpha1.CNPGTemplate{BarmanObjectStore: *store}, s3CredsSecret("tenant", "creds-recorded"))
if size != 42 {
t.Errorf("SizeBytes = %d, want 42 measured through the recorded Secret", size)
}
if conn.AccessKey != "AKID" {
t.Errorf("probed with access key %q, want the recorded Secret's AKID", conn.AccessKey)
}
}
// The record names the Secret, not its keys: the strategy's key names stay,
// so a strategy with its own key names still reads the recorded Secret.
func TestCreateCNPGBackupArtifact_SizeProbeKeepsTheStrategysSecretKeys(t *testing.T) {
store := newSizedBarmanObjectStore()
store.S3Credentials.AccessKeyIDKey = "id"
store.S3Credentials.SecretAccessKeyKey = "key"
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{Namespace: "tenant", Name: "creds-recorded"},
Data: map[string][]byte{"id": []byte("CUSTOMID"), "key": []byte("custom-secret")},
}
size, conn := probeRecordedBackup(t, &strategyv1alpha1.CNPGTemplate{BarmanObjectStore: *store}, secret)
if size != 42 {
t.Errorf("SizeBytes = %d, want 42 measured with the strategy's key names", size)
}
if conn.AccessKey != "CUSTOMID" {
t.Errorf("probed with access key %q, want CUSTOMID read under the strategy's key name", conn.AccessKey)
}
}
@@ -3824,6 +3824,23 @@ func TestReconcileCNPG_JobWithoutLatchWaitsForAnotherJobsRollout(t *testing.T) {
}
}
// A job whose own Backup already exists is past every wait before it: it
// tracks that Backup even while another job's recent attach is still rolling
// the instances, since waiting would only hold the result of a Backup that
// runs regardless.
func TestReconcileCNPG_JobWithItsOwnBackupDoesNotWaitForAnotherJobsRollout(t *testing.T) {
cluster := newRolloutCluster(cnpgClusterHealthyPhase, buildBarmanPlugin(rolloutCluster, rolloutCluster))
cluster.Annotations = map[string]string{cnpgPluginAttachedAtAnnotation: time.Now().Add(-5 * time.Minute).UTC().Format(time.RFC3339)}
f := newCNPGRolloutFixture(t, newRolloutBackupJob(time.Now().Add(-time.Hour)), cluster,
newRolloutInstancePod(time.Now().Add(-10*time.Minute).Truncate(time.Second)))
f.seedCNPGBackup("bj-cnpg", "bj", rolloutCluster, "running")
j, _ := f.pass()
if ready := apimeta.FindStatusCondition(j.Status.Conditions, "Ready"); ready == nil || ready.Reason != "WaitingForCNPGBackup" {
t.Errorf("Ready = %+v, want WaitingForCNPGBackup tracking the job's own Backup", ready)
}
}
// A plugin attached by someone else after the latch, another backup job or
// the chart re-rendering a restored Cluster outside the platform flow,
// started the rollout before this job's write, which only finds it there: