mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-03 02:27:01 +09:00
docs(velero): correct the stale upgradeCRDs disable rationale
The comment justified upgradeCRDs: false by a kubectl-image-compatibility problem in the upgrade-crds Job. That rationale is obsolete in velero 12.x: the Job now runs the velero image natively, not a kubectl image. The real, current reason the Job stays disabled is that CRDs ship via the chart's crds/ directory, making the Job redundant. Correct both the values.yaml override comment and the helm-unittest comment to match. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
This commit is contained in:
2 files changed
+9
-5
No files matched your search
@@ -26,9 +26,11 @@ tests:
|
||||
path: spec.template.spec.initContainers[1].image
|
||||
value: quay.io/kubevirt/kubevirt-velero-plugin:v0.9.0
|
||||
|
||||
# Cozystack disables the upgrade-crds Job (upgradeCRDs: false) because the
|
||||
# job has kubectl-image compatibility issues; CRDs ship via the chart's
|
||||
# crds/ directory instead. Pin that invariant — it silently regressed once.
|
||||
# Cozystack disables the upgrade-crds Job (upgradeCRDs: false) because CRDs
|
||||
# ship via the chart's crds/ directory, making the Job redundant. (The old
|
||||
# kubectl-image-compatibility rationale is obsolete in velero 12.x, where the
|
||||
# Job now runs the velero image natively.) Pin that invariant — it silently
|
||||
# regressed once.
|
||||
- it: does not emit the upgrade-crds Job when upgradeCRDs is disabled
|
||||
template: charts/velero/templates/upgrade-crds/upgrade-crds.yaml
|
||||
asserts:
|
||||
|
||||
@@ -1,6 +1,8 @@
|
||||
velero:
|
||||
# Disable CRD upgrade job - CRDs are installed as part of helm chart
|
||||
# The upgrade job has issues with kubectl image compatibility
|
||||
# Disable the upgrade-crds Job: CRDs ship via the chart's crds/ directory, so
|
||||
# the Job is redundant. (The old kubectl-image-compatibility rationale is
|
||||
# obsolete in velero 12.x — the Job now runs the velero image natively, not a
|
||||
# kubectl one — but it stays disabled because cozystack manages CRDs via crds/.)
|
||||
upgradeCRDs: false
|
||||
initContainers:
|
||||
- name: velero-plugin-for-aws
|
||||
|
||||
Reference in new issue
Block a user