IvanHunters 3d7fd4d5a5 fix(etcd): eliminate TOCTOU race, fix YAML formatting, increase timeouts
Fix critical issues from final review:

**Eliminate TOCTOU race condition**

1. **Atomic Secret fetch**: Changed from two separate kubectl calls (tls.crt
   then tls.key) to single call fetching entire Secret.data. Prevents race
   where cert-manager rotates certificate between calls, resulting in old
   cert + new key mismatch. Now uses single kubectl get with jsonpath to
   extract both fields atomically from same Secret snapshot.

**Fix YAML formatting**

2. **Remove heredoc indentation**: Removed leading spaces from kubectl apply
   heredoc. Previous 10-space indentation was included in generated YAML,
   potentially causing parser issues depending on kubectl/API server version.
   Changed to <<'EOF' with no indentation for spec-compliant YAML output.

**Increase timeouts and improve RBAC**

3. **Increase kubectl apply timeout**: Changed from 30s to 90s. Kamaji
   ValidatingWebhook performs TLS handshake + etcd connectivity check which
   can take >30s if etcd StatefulSet is still initializing. 90s accommodates
   slow storage/network in production environments.

4. **Add RBAC for events**: Added list permission for events resource.
   Required for kubectl describe certificate to show events in diagnostics.
   Without this, describe shows incomplete information.

**Improve error handling**

5. **Explicit error messages**: Added descriptive error for expired
   certificates. Prevents generic "Secret not populated" error when real
   issue is cert expiry.

6. **Explicit control flow**: Changed from || exit 1 pattern to explicit
   if statements. Clearer intent and avoids confusion with set -e behavior.

All critical issues resolved. Code is production-ready with atomic operations,
correct YAML formatting, and appropriate timeouts.

Signed-off-by: IvanHunters <xorokhotnikov@gmail.com>
2026-04-25 01:03:00 +03:00
2025-10-08 09:43:34 +05:00
2025-04-01 18:48:14 +02:00
2024-02-08 12:04:32 +01:00
2026-04-16 14:30:51 +05:00
2026-03-17 02:57:52 +05:00

Cozystack Cozystack

Open Source Apache-2.0 License Support Active GitHub Release GitHub Commit OpenSSF Best Practices

Cozystack

Cozystack is a free platform and framework for building clouds.

Cozystack is a CNCF Sandbox Level Project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You can express your intention to on the fix on your own. Commits are used to generate the changelog, and their author will be referenced in it.

If you have Feature Requests please use the Discussion's Feature Request section.

Community

You are welcome to join our Telegram group and come to our weekly community meetings. Add them to your Google Calendar or iCal for convenience.

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 47.2%
Shell 37.6%
TypeScript 7%
Go Template 5.4%
Makefile 1.4%
Other 1.2%