Kvaps' review on #3178 called out three imprecisions in the
supporting comments. Fix them without touching runtime behaviour:
1. certificate.yaml previously emitted a secretTemplate whose
labels include \`app.kubernetes.io/managed-by: Helm\`. Helm
does NOT own the Secret written by cert-manager — the Certificate
resource does — and stamping that label on it misleads operators
reading the object with \`kubectl get secret -oyaml\`. Drop
secretTemplate; cert-manager labels its outputs unambiguously
(\`cert-manager.io/*\`, \`controller.cert-manager.io/*\`).
2. deployment.yaml comment on checksum/tls-cert claimed the lookup
\"resolves at every reconcile\". Not true. \`lookup\` runs only
on Helm actions (install / upgrade / rollback); helm-controller
does not re-render a deployed release on interval ticks. Under
cozystack's release cadence this is fine — any real chart bump,
values change, or manual \`flux reconcile hr\` triggers a
re-template within days — but at day ~350 renewal the pod
continues serving the certificate it loaded at startup until the
next Helm action. If no Helm action lands in the ~15 days
between renewal and expiry the webhook silently stops mutating.
The comment now spells that trade-off out so a future reader can
find it, and points at a small post-renewal Job as the follow-up
without re-introducing the ReplicaSet-churn amplifier the whole
PR retires.
3. values.yaml comment on certManagerEnabled did not warn that the
switch is effectively one-way. Once cert-manager has written the
Secret with \`type: kubernetes.io/tls\`, flipping the flag back
to false and rolling back to the legacy Opaque path fails —
\`Secret.type\` is immutable, so the legacy Secret template
cannot overwrite the cert-manager-owned one in place. The doc
now says operators must \`kubectl delete\` the Secret first if
they need to roll back.
Also refreshed patches/cert-manager-admission-tls.diff to reflect
these comment-only edits and re-verified end-to-end that
\`make update\`-style pull + patch produces a byte-identical tree
to what git tracks now.
15/15 helm-unittest cases still pass.
Signed-off-by: Ivan Okhotnikov <ivan.okhotnikov@aenix.io>