Files
cozystack/packages/system
Ivan Okhotnikov 79ce69a3b4 fix(vertical-pod-autoscaler): widen renewBefore + document selfSigned checksum, add existingSecret belt-and-suspenders assertion
Address the three non-blocking follow-ups on myasnikovdaniil's approval:

* renewBefore: 360h → 2160h (15d → 90d). With webhook `failurePolicy:
  Ignore`, an expired in-memory cert silently drops admission traffic
  until a Helm action rolls the ReplicaSet. helm-controller does not
  re-render on reconcile ticks after the release converges, only on
  install/upgrade/rollback — a 15-day window ties admission-webhook
  liveness to release cadence. 90 days survives realistic release
  schedules on customer clusters. Rotate-and-restart requirement is
  unchanged; the window is widened.
* Document on deployment.yaml why hashing only `tls.crt` is safe:
  the Issuer is `selfSigned`, so `ca.crt == tls.crt` and every rotation
  re-issues `tls.crt`. If a future refactor ever swaps the Issuer to a
  CA-backed one (external CA, ACME, Vault), the checksum MUST be
  extended to also cover `ca.crt` — otherwise a CA-only rotation would
  leave the self-registered MutatingWebhookConfiguration serving a stale
  caBundle until the next leaf rotation.
* Add a belt-and-suspenders helm-unittest assertion pinning that under
  `existingSecret` the admission-controller pod-template carries NEITHER
  `checksum/tls-secret` (legacy amplifier) NOR `checksum/tls-cert`
  (cert-manager runtime lookup). Templates are already structurally
  gated; this catches a future refactor that accidentally moves either
  checksum outside its `if` gate.

Regenerated patches/cert-manager-admission-tls.diff against upstream
via `make update` flow so the vendored chart edits stay in sync with
the patch file (avoids silent revert on the next update).

Verified: 16/16 helm-unittest cases pass, `helm lint` clean,
`helm template ... certManagerEnabled=true` renders `renewBefore: 2160h`,
and re-applying the regenerated patch onto a fresh upstream pull
produces a byte-identical chart tree.

Signed-off-by: Ivan Okhotnikov <ivan.okhotnikov@aenix.io>
2026-07-03 15:59:07 +03:00
..
2026-06-22 10:55:37 +00:00
2026-03-25 15:57:25 +05:00
2026-06-22 10:55:37 +00:00
2026-06-22 10:55:37 +00:00
2026-02-10 20:19:03 +01:00
2026-06-22 10:55:37 +00:00
2026-03-25 15:57:25 +05:00