Aleksei Sviridkin 925cb87af9 test: fix dead bats setup/teardown hooks under cozytest (#3134)
## What this PR does

cozytest.sh — the runner for every `*.bats` file in the repo (e2e via
`packages/core/testing/Makefile`, unit tests via `make bats-unit-tests`)
— is not real bats: it never invokes `setup()`/`teardown()`. Three such
hooks outside `etcd.bats` were therefore dead. Cleanup ran only via each
test's success-path inline delete, so a failing test leaked its
resources into the shared `tenant-test` namespace — and, for kuberture,
cluster-scoped RBAC that persists across sandbox re-runs.

This wires the cleanup to `cozy_cleanup()`, the hook cozytest does run
(once at suite exit and on the first failing test):

- **external-dns**: dead `teardown()` → `cozy_cleanup()` deleting all
ExternalDNS CRs. ExternalDNS is a stateless Deployment with the
`inmemory` provider, so a plain delete fully reclaims it — no drain
needed. The per-test inline deletes remain fail-loud on the success
path; `cozy_cleanup` is the failure-path net.
- **kuberture**: dead `teardown()` → `cozy_cleanup()` routed through the
existing `_cleanup()`, so the probe Pods, ServiceAccount, and
cluster-scoped ClusterRole/ClusterRoleBinding are reclaimed on the
failure path too. `_cleanup`'s per-delete `|| true` is also dropped
(keeping `--ignore-not-found`): the success-path inline call now fails
the test on a stuck teardown (e2e-testing.md §4), while the failure path
stays best-effort via the runner's `cozy_cleanup || true` wrap.
- **build-matrix_test**: the dead `setup()` only `cd`'d to the repo
root, which cozytest already runs from, so the relative
`hack/build-matrix.sh` calls resolve without it — removed.

### Release note

```release-note
NONE
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Improved end-to-end test cleanup for external-dns by switching to
suite-aligned cleanup that reliably removes ExternalDNS resources even
on failures or early aborts.
* Enhanced kuberture end-to-end cleanup to remove probe components and
related RBAC/package more safely, with errors handled consistently to
aid diagnosis.
* Updated test setup expectations for matrix builds so tests run
correctly from the repository root without relying on a custom directory
hook.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-06-30 21:18:17 +03:00
2025-10-08 09:43:34 +05:00
2025-04-01 18:48:14 +02:00
2024-02-08 12:04:32 +01:00

Cozystack Cozystack

Open Source Apache-2.0 License Support Active GitHub Release GitHub Commit OpenSSF Best Practices

Cozystack

Cozystack is a free platform and framework for building clouds.

Cozystack is a CNCF Sandbox Level Project that was originally built and sponsored by Ænix.

With Cozystack, you can transform a bunch of servers into an intelligent system with a simple REST API for spawning Kubernetes clusters, Database-as-a-Service, virtual machines, load balancers, HTTP caching services, and other services with ease.

Use Cozystack to build your own cloud or provide a cost-effective development environment.

Cozystack user interface

Use-Cases

Documentation

The documentation is located on the cozystack.io website.

Read the Getting Started section for a quick start.

If you encounter any difficulties, start with the troubleshooting guide and work your way through the process that we've outlined.

Versioning

Versioning adheres to the Semantic Versioning principles.
A full list of the available releases is available in the GitHub repository's Release section.

Contributions

Contributions are highly appreciated and very welcomed!

In case of bugs, please check if the issue has already been opened by checking the GitHub Issues section. If it isn't, you can open a new one. A detailed report will help us replicate it, assess it, and work on a fix.

You can express your intention to on the fix on your own. Commits are used to generate the changelog, and their author will be referenced in it.

If you have a concrete feature request, open an issue. For a cross-cutting or architectural change, open a design proposal in the community repo. For questions or early ideas, use GitHub Discussions. See CONTRIBUTING.md for the full routing.

Community

You are welcome to join our Telegram group and come to our weekly community meetings. Add them to your Google Calendar or iCal for convenience.

License

Cozystack is licensed under Apache 2.0.
The code is provided as-is with no warranties.

Commercial Support

A list of companies providing commercial support for this project can be found on official site.

Languages
Go 47.2%
Shell 37.6%
TypeScript 7%
Go Template 5.4%
Makefile 1.4%
Other 1.2%