After merging both qcow2 and shared TM_MADs the resulting driver
automatically identifies the image format and perform the snapshot
using the corresponding format. This enable the support to perform
live disk snapshots when using shared storage.
The "Hardware" profile of a network interface (NIC) of a VM can be of three types, now exposed in Sunstone:
- "Emulated" it includes the hardware model emulated by Qemu
- "PCI - Automatic" oned hw scheduler will pick the best PCI device for the NIC
- "PCI - Manual" user can specify the PCI device by its short-address as shown in host information
This commits also enables the attach/detach operations on PCI based NICs
*Note*: only for KVM VMs
Signed-off-by: Frederick Borges <fborges@opennebula.io>
(cherry picked from commit a3d5d61d4245a7936372e4a6c5dee4b6939f62f4)
Ensure that if the destination DS when cloning an image have a DRIVER set. The image is automatically converted during the cloning process for the fs driver.
(cherry picked from commit 69759b30cc)
Decided to format it as a patch than an entire rewrite of the probe script.
This could be rewritten to populate the models array with the supported only.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
(cherry picked from commit b23ad3a54c)
- SHORT_ADDRESS can be used to select specific devices (useful on
homogenous clusters or nic attach operations). This name has been
selected because of:
1. It is the attrbute shown host info
2. It does not collide with the reserved ADDRESS attribute
- New test and add functions that considers both allocation methods: by
name (VENDOR/CLASS/DEVICE) or address (SHORT_ADDRESS)
- Parameter check on VM creation
- revert and add method use the same pci_attribute function to add info
to the VM PCI attribute
- Remove well-known attributes when parsing PCI devices (ADDRESS,
PREV_ADDRES, BUS, FUNCTION, SLOT, NUMA_NODE, UUID)
- Support for attach and detach NIC with PCI attributes
* onevm_exec.rb looks for PCI devices for ATTACH=YES when attaching/detaching an interface
* script action are now written in Ruby
* KVM module with common actions (hostdev/interface device str)
* Minor changes in xmlparser and OpenNebulaVM classes
- PCI selection options to onevm nic-attach:
* pci short_address
* pci_device device ID
* pci_vendor vendor ID
* pci_class class ID
- VF can be configured by setting some parameters through IP link (e.g.
MAC or VLAN_ID). This commit includes a mixin to activate_vf.
* one_vmm_exec.rb looks for PCI VN_MAD drivers
* VM class (VNM) adds a @pcis array
* activate_vf should be called in the pre stage. The following drivers
acticate VFs (VLAN_ID is implemented as 802.1Q tag)
- 802.1Q
- bridge
- fw
- ovswitch
- Improve integration with Libvirt/QEMU:
* When attach, only activate the VF being attached
* Attach: Use <interface> and not <hostdev> for VF. There seems to be a race
condition between accessing the vfio device and permission setup.
* Attach: Remove address on attach as it may fail beacuse PCI controller
is not present, e.g.:
ATTACHNIC: Could not attach NIC to 28534240: error: Failed to attach device
from /dev/fd/63 error: XML error: Invalid PCI address 0000:01:01.0.
Only PCI buses up to 0 are available ExitCode: 1
* Detach: Detach always use <hostdev> as libvirt fails to identified the
device just by address when using <interface>
Related to commit M #-: Get rid of obsolete .vib files d019bd49a6
Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
(cherry picked from commit dcc9b57e26)
Regression introduced by68ce7dc0
With the addition to skipws, peek() will read the next whitespace in the buffer. The logic has been changed to use the extraction operator so ws are consumed. The peek - get is now changed by >> - unget calls
Daniel Boca