Thomas Vincent
0dd91c4602
Fixes compiler warnings across spine source files: adds missing void in function prototypes, marks internal functions static, removes unused variables, and fixes const-correctness on function signatures. **Note:** This PR also includes the following non-mechanical changes that should be reviewed carefully: - sql.c: db_column_exists now passes through the caller's type argument instead of hardcoding LOCAL (bug fix, changes runtime behavior for REMOTE callers) - poller.c: Removed write-only snmp_poller_items counter and its increment block (dead-code elimination) - util.c: getglobalvariable now returns a strdup'd copy instead of a pointer into opttable (fixes latent use-after-free on free()) - ping.c: Fixed strncopy(stack, hostname, strlen(stack)) to strlen(hostname) (old code was a no-op after memset) - util.c: Changed getsetting/getpsetting/getglobalvariable return type from const char * to char * to reflect caller ownership semantics ### Addressed performance and DRY issues: - Addresses #501 (Exponential Backoff) - Addresses #503 (Centralized Logging) - Addresses #504 (SNMP_FREE Macro) - Addresses #505 (O(1) Hash Table) ### Test plan - [ ] Verify spine compiles with both gcc and clang - [ ] Run spine against a test Cacti instance and verify polling works Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Spine: a poller for Cacti
Spine is a high speed poller replacement for cmd.php. It is almost 100%
compatible with the legacy cmd.php processor and provides much more flexibility,
speed and concurrency than cmd.php.
Make sure that you have the proper development environment to compile Spine. This includes compilers, header files and things such as libtool. If you have questions please consult the forums and/or online documentation.
Unix Installation
These instructions assume the default install location for spine of
/usr/local/spine. If you choose to use another prefix, make sure you update
the commands as required for that new path.
To compile and install Spine using MySQL versions 5.5 or higher please do the following:
./bootstrap
./configure
make
make install
chown root:root /usr/local/spine/bin/spine
chmod u+s /usr/local/spine/bin/spine
To compile and install Spine using MySQL versions previous to 5.5 please do the following:
./bootstrap
./configure --with-reentrant
make
make install
chown root:root /usr/local/spine/bin/spine
chmod +s /usr/local/spine/bin/spine
Windows Installation
CYGWIN Prerequisite
-
Download Cygwin for Window from https://www.cygwin.com/
-
Install Cygwin by executing the downloaded setup program
-
Select Install from Internet
-
Select Root Directory: C:\cygwin
-
Select a mirror which is close to your location
-
Once on the package selection section make sure to select the following (TIP: use the search!):
- autoconf
- automake
- dos2unix
- gcc-core
- gzip
- help2man
- inetutils-src
- libmysqlclient
- libmariadb-devel
- libssl-devel
- libtool
- m4
- make
- net-snmp-devel
- openssl-devel
- wget
-
Wait for installation to complete, coffee time!
-
Move the cygwin setup to the C:\cygwin\ folder for future usage.
Compile Spine
-
Open Cygwin shell prompt (C:\Cygwin\cygwin.bat) and brace yourself to use unix commands on Windows.
-
Download the Spine source to the current directory:
-
Extract Spine into C:\Cygwin\usr\src<spineversion>:
tar xzvf cacti-spine-*.tar.gz -
Change into the Spine directory:
cd /usr/src/cacti-spine-* -
Run bootstrap to prepare Spine for compilation:
./bootstrap -
Follow the instruction which bootstrap outputs.
-
Update the spine.conf file for your installation of Cacti. You can optionally move it to a better location if you choose to do so, make sure to copy the spine.conf as well.
-
Ensure that Spine runs well by running with
/usr/local/spine/spine -R -S -V 3 -
Update Cacti
PathsSetting to point to the Spine binary and update thePoller Typeto Spine. For the spine binary on Windows x64, and using default locations, that would beC:\cygwin64\usr\local\spine\bin\spine.exe -
If all is good Spine will be run from the poller in place of cmd.php.
Known Issues
-
On Windows, Microsoft does not support a TCP Socket send timeout. Therefore, if you are using TCP ping on Windows, spine will not perform a second or subsequent retries to connect and the host will be assumed down on the first failure.
If this is a problem it is suggested to use another Availability/Reachability method, or moving to Linux/UNIX.
-
Spine takes quite a few MySQL connections. The number of connections is calculated as follows: (1 for main poller + 1 per each thread + 1 per each script server)
Therefore, if you have 4 processes, with 10 threads each, and 5 script servers each your spine will take approximately:
total connections = 4 * ( 1 + 10 + 5 ) = 64 -
On older MySQL versions, different libraries had to be used to make MySQL thread safe. MySQL versions 5.0 and 5.1 require this flag. If you are using these version of MySQL, you must use the --with-reentrant configure flag.
Copyright (c) 2004-2026 - The Cacti Group, Inc.