test(Windows): stabilize tray notification CI test (#185)

.github/actions/configure-windows-tray-screenshots/action.yml

@@ -8,6 +8,23 @@ runs:
     - name: Configure Windows tray screenshots
       shell: pwsh
       run: |
+        echo "::group::Use dark Windows appearance"
+        $personalizeSettings = "HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Themes\Personalize"
+        New-Item -Path $personalizeSettings -Force | Out-Null
+        New-ItemProperty `
+          -Path $personalizeSettings `
+          -Name "AppsUseLightTheme" `
+          -PropertyType DWord `
+          -Value 0 `
+          -Force | Out-Null
+        New-ItemProperty `
+          -Path $personalizeSettings `
+          -Name "SystemUsesLightTheme" `
+          -PropertyType DWord `
+          -Value 0 `
+          -Force | Out-Null
+        echo "::endgroup::"
+
         echo "::group::Enable all tray icons"
         $trayIconScript = Join-Path $env:RUNNER_TEMP "Enable-AllTrayIcons.ps1"
         Invoke-WebRequest `

.github/workflows/ci.yml

@@ -59,7 +59,9 @@ jobs:
           - os: ubuntu-latest
             shell: "bash"
             qt_version: '6'
-          - os: windows-latest
+          # Windows Server 2022 renders QSystemTrayIcon notifications. The newer
+          # windows-latest image suppresses them in its interactive session.
+          - os: windows-2022
             shell: "msys2 {0}"
             qt_version: '6'
     steps:

tests/unit/test_tray.cpp

@@ -401,6 +401,9 @@ TEST_P(TrayNotificationIconTest, TestNotificationDisplay) {
   int initResult = tray_init(&testTray);
   trayRunning = (initResult == 0);
   ASSERT_EQ(initResult, 0);
+
+  // Let the desktop shell process the new icon before sending its notification.
+  WaitForTrayReady();
   dismissNativeNotifications();
 
   // Set notification properties