more pr fixes

packages/asset-uploader/src/index.ts

@@ -7,10 +7,12 @@ import {
 import { s3UploadHandler } from "./targets/s3/handler";
 import { uploadToS3 } from "./targets/s3/uploader";
 import { uploadToDisk } from "./targets/disk/upload";
+import { fsEnvVariables } from "./schema";
 
 const isS3Upload = Boolean(
   S3_ENV_KEYS.every((key) => Object.keys(process.env).includes(key))
 );
+const fsUploadVars = fsEnvVariables.parse(process.env);
 
 export const uploadAsset = async ({
   request,
@@ -24,8 +26,7 @@ export const uploadAsset = async ({
   dirname: string;
 }) => {
   const uploads = path.join(dirname, "../public");
-  const folderInPublic = process.env.FILE_UPLOAD_PATH || DEFAULT_UPLPOAD_PATH;
-  const directory = path.join(uploads, folderInPublic);
+  const directory = path.join(uploads, fsUploadVars.FILE_UPLOAD_PATH);
   const formData = await unstable_parseMultipartFormData(
     request,
     isS3Upload

packages/asset-uploader/src/schema.ts

@@ -1,5 +1,6 @@
 import { z } from "zod";
 import { NodeOnDiskFile } from "@remix-run/node";
+import { DEFAULT_UPLPOAD_PATH } from "./constants";
 
 const SingleImageInUpload = z.instanceof(NodeOnDiskFile);
 
@@ -21,3 +22,7 @@ export const s3EnvVariables = z.object({
   S3_BUCKET: z.string(),
   S3_ACL: z.string().optional(),
 });
+
+export const fsEnvVariables = z.object({
+  FILE_UPLOAD_PATH: z.string().optional().default(DEFAULT_UPLPOAD_PATH),
+});

packages/asset-uploader/src/targets/disk/upload.ts

@@ -1,6 +1,6 @@
 import path from "path";
 import sharp from "sharp";
-import { ImagesUpload } from "../../types";
+import { ImagesUpload } from "../../schema";
 
 export const uploadToDisk = async ({
   formData,

packages/asset-uploader/src/targets/s3/handler.ts

@@ -4,7 +4,7 @@ import { Upload } from "@aws-sdk/lib-storage";
 import ObjectID from "bson-objectid";
 
 import sharp from "sharp";
-import { ImagesUploadedSuccess, s3EnvVariables } from "../../types";
+import { ImagesUploadedSuccess, s3EnvVariables } from "../../schema";
 import {
   getArrayBufferFromIterable,
   getFilenameAndExtension,