mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 22:14:29 +09:00
fix: Items in combobox have zero height (#4737)
## Description  That's because LI items collapsed under Flex ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
This commit is contained in:
1 parent
b148e7b1bc
commit
b09f8694ef
1 file changed
+3
-6
@@ -39,6 +39,7 @@ import { Box } from "./box";
|
||||
import { Flex } from "./flex";
|
||||
import { NestedInputButton } from "./nested-input-button";
|
||||
import { InputField } from "./input-field";
|
||||
import { Grid } from "./grid";
|
||||
|
||||
export const ComboboxListbox = styled(
|
||||
"ul",
|
||||
@@ -62,13 +63,9 @@ export const ComboboxScrollArea = forwardRef(
|
||||
) => {
|
||||
return (
|
||||
<ScrollArea css={{ order: 1 }} {...props}>
|
||||
<Flex
|
||||
ref={forwardRef}
|
||||
direction="column"
|
||||
css={{ maxHeight: theme.spacing[34] }}
|
||||
>
|
||||
<Grid ref={forwardRef} css={{ maxHeight: theme.spacing[34] }}>
|
||||
{children}
|
||||
</Flex>
|
||||
</Grid>
|
||||
</ScrollArea>
|
||||
);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user