mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 22:14:29 +09:00
fix: scrub on CSS value input not working (#5611)
The scrub (drag to change value) feature was not working on CSS value
inputs when the initial value was a keyword like 'auto'.
This was a regression from b18315e570 which changed the early-return
checks to use valueRef.current.type but forgot to add value.type to the
useEffect dependency array, so the scrub control was never re-attached
when the value type changed.
This commit is contained in:
1 parent
1088d82ff7
commit
c2a36f18bb
1 file changed
+5
+5
@@ -259,12 +259,17 @@ const useScrub = ({
|
||||
},
|
||||
shouldHandleEvent,
|
||||
});
|
||||
// value.type and value.unit are intentionally in the dependency array
|
||||
// to re-setup scrub when the value type changes (e.g., from keyword to unit)
|
||||
}, [
|
||||
shouldHandleEvent,
|
||||
property,
|
||||
updateIntermediateValue,
|
||||
onAbortStable,
|
||||
defaultUnit,
|
||||
value.type,
|
||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||
"unit" in value ? value.unit : undefined,
|
||||
]);
|
||||
|
||||
return [scrubRef, inputRef];
|
||||
|
||||
Reference in new issue
Block a user