mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 05:26:24 +09:00
Oleg Isonen
014ef95e3e
Closes https://github.com/webstudio-is/webstudio/issues/5016 ## Description Since we are lazily initializing the player and using autoplay, players won't request full screen, so we need to request the fullscreen ourselves. 1. inline is now false by default 2. only for mobile/touch, custom logic checks if the device has touch or has resolution lower than 1024px ## Steps for reproduction 1. add vimeo component 2. put a video url, e.g. https://vimeo.com/1062544169 3. publish 4. play on a touch device or just a resolution smaller than 1024 5. see it goes full screen 6. repeaat the same with youtube ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.