webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 05:26:24 +09:00

T

Jaya Krishna Namburu 24efd92764 feat: add close button for popover element (#5205 )

fixes #3988 

## Description

This PR adds `PopoverClose` button to `Popover` element. Just exported
and added the component from `@radix-ui/popover`. Which is where all the
rest of the elements are being used.

Existing project on staging -
https://p-33460026-be01-4d80-8f4f-1d6677c38fe0-dot-pop-close.staging.webstudio.is
Deployed project on staging - https://jk-popover-close-1ph18.wstd.work


![popover-close](https://github.com/user-attachments/assets/7670dcc7-2afb-4edf-a638-2a32cb48a9e6)

## Steps for reproduction
- You can go to staging, and create a project with popover.
- Deploy the project and checked the rendered popover

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [x] made a self-review

## Before merging

- [x] tested locally and on preview environment (preview dev login:
0000)

2025-05-14 16:44:11 +05:30

.devcontainer

experimental: Animate UI (#4851 )

2025-02-24 14:27:50 +05:00

.github

refactor: upgrade remix and react-router (#5177 )

2025-05-02 00:35:20 +04:00

.storybook

refactor: upgrade vite for vitest and storybook (#5165 )

2025-04-29 14:17:42 +04:00

.vscode

build: Add devcontainer (#3429 )

2024-05-28 14:15:55 +03:00

@types

experimental: Fix chrome 134 regression bug (#5046 )

2025-03-26 16:27:10 +05:00

apps/builder

experimental: adapt tag control to html content model (#5208 )

2025-05-14 14:12:48 +03:00

codemod

chore: use console.info instead of console.log (#3049 )

2024-03-24 12:52:46 +01:00

fixtures

fix: default twitter og preview to use summary_large_image for bigger previews (#5188 )

2025-05-08 15:34:20 +05:30

https

experimental: Youtube animations (#5072 )

2025-04-06 14:47:16 +03:00

packages

feat: add close button for popover element (#5205 )

2025-05-14 16:44:11 +05:30

patches

experimental: Animation publishing (#4976 )

2025-03-11 11:19:01 +05:00

.gitignore

experimental: Animation publishing (#4976 )

2025-03-11 11:19:01 +05:00

.gitmodules

experimental: Proof of concept of the Animation component using ScrollTimeline (#4797 )

2025-02-01 14:57:36 +03:00

.nvmrc

chore: set node version to 20 in .nvmrc (#3423 )

2024-05-26 19:11:24 +03:00

.prettierignore

fix: Allow formatting d.ts files (#2558 )

2023-11-03 15:20:48 +02:00

CODE_OF_CONDUCT.md

Merge branch 'main' into feature-style-panel-flexChild-section

2022-11-12 11:36:44 +03:00

eslint.config.mjs

experimental: Animation publishing (#4976 )

2025-03-11 11:19:01 +05:00

LICENSE

Change license from MIT to AGPL V3 (#1980 )

2023-07-26 01:06:21 +02:00

lostpixel.config.js

refactor: merge all storybooks into one (#3441 )

2024-05-29 17:05:17 +03:00

package.json

refactor: upgrade remix and react-router (#5177 )

2025-05-02 00:35:20 +04:00

pnpm-lock.yaml

experimental: support paste html (#5185 )

2025-05-06 13:31:13 +04:00

pnpm-workspace.yaml

Add fixtures (#2254 )

2023-09-06 21:43:29 +03:00

README.md

docs: fix discord link in readme (#5091 )

2025-04-04 21:43:51 +07:00

release.sh

build: Automate release creation (#4910 )

2025-02-26 22:22:58 +01:00

submodules.sh

experimental: Proof of concept of the Animation component using ScrollTimeline (#4797 )

2025-02-01 14:57:36 +03:00

vercel.json

build: Test staging (Playground) (#3136 )

2024-04-12 11:03:45 +03:00

vite.sdk-components.config.ts

experimental: Animation publishing (#4976 )

2025-03-11 11:19:01 +05:00

vitest.config.ts

refactor: upgrade vite for vitest and storybook (#5165 )

2025-04-29 14:17:42 +04:00

README.md

Webstudio is an Open Source Visual Development Platform for developers, designers, and cross-functional teams. You own the data, components, and infrastructure. You can use the hosted version or roll out your own.

Learning Resources

Thanks

Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.

README.md

Learning Resources

Social Media

Thanks