mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 14:03:33 +09:00
27aa4ac70b11bcc8b4e419eeb204aea771999437
Based on feedback, its not clear that Local style is special: 1. can't be reordered 2. can't be reused To explain this visually better, we: 1. replaced Local with an icon 2. placed it after the input 3. added label in the menu 4. added hint in the menu <img width="248" alt="Screenshot 2024-03-10 at 15 32 20" src="https://github.com/webstudio-is/webstudio/assets/52824/f1040b38-93a9-4cc5-b185-1d8beb028aea"> <img width="248" alt="Screenshot 2024-03-10 at 15 32 09" src="https://github.com/webstudio-is/webstudio/assets/52824/a7beb70c-3c87-4966-a477-0b0f0373724a"> <img width="254" alt="Screenshot 2024-03-10 at 15 32 04" src="https://github.com/webstudio-is/webstudio/assets/52824/0705b8e0-16c2-4c64-a839-3f46aceb9fba"> <img width="246" alt="Screenshot 2024-03-10 at 15 31 53" src="https://github.com/webstudio-is/webstudio/assets/52824/948e46c7-811b-45e2-853f-9ec80705b457"> <img width="295" alt="image" src="https://github.com/webstudio-is/webstudio/assets/52824/df00b216-457e-4c33-9503-759576f2d733"> <img width="281" alt="image" src="https://github.com/webstudio-is/webstudio/assets/52824/e321d8e2-d65b-4db9-b64c-2aa82f694cf2"> ## Steps for reproduction 1. click button 5. expect xyz ## Code Review - [ ] hi @TrySound , I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.
Languages
TypeScript
98.9%
PLpgSQL
0.5%
CSS
0.3%
Shell
0.2%
JavaScript
0.1%
