webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-06 12:04:00 +09:00

T

Oleg Isonen 2d91ef4203 chore: don't fix boolean attributes to empty string values in html embed (#3251 )

## Description

When validating html embed, dom innerHTML always turns boolean
attributes into empty string, e.g. <div hidden></div> will always become
<div hidden=""></div> and this is not necessary, we can ignore those
mismatches.


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2024-04-29 13:51:47 +02:00

.github

build: Update action versions (#3241 )

2024-04-25 11:00:11 +03:00

.storybook

Migrate to storybook 7 (#1862 )

2023-06-27 10:02:58 +03:00

.vscode

use ts from workspace

2022-07-04 19:59:42 +02:00

@types

Replace @types/css-tree override with patch (#1783 )

2023-06-14 17:51:13 +03:00

apps/builder

chore: don't fix boolean attributes to empty string values in html embed (#3251 )

2024-04-29 13:51:47 +02:00

codemod

chore: use console.info instead of console.log (#3049 )

2024-03-24 12:52:46 +01:00

fixtures

refactor: reimplement atomic styles with nesting rules (#3248 )

2024-04-27 23:00:09 +04:00

packages

feat: Canvas drawing of xml element (#3245 )

2024-04-29 14:08:27 +03:00

patches

build: cloudflare cli template (#3157 )

2024-04-13 19:04:41 +03:00

scripts

Release 0.42.0 (#1165 )

2023-03-02 11:05:44 +01:00

.eslintrc.js

Moving cli from apps folder into packages folder (#2198 )

2023-08-28 09:55:08 +02:00

.gitignore

build: CLI container to use in webstudio builder publish process (#3163 )

2024-04-14 18:55:22 +03:00

.nvmrc

Migrate to node v18 (#1857 )

2023-06-27 18:17:48 +03:00

.prettierignore

fix: Allow formatting d.ts files (#2558 )

2023-11-03 15:20:48 +02:00

CODE_OF_CONDUCT.md

Merge branch 'main' into feature-style-panel-flexChild-section

2022-11-12 11:36:44 +03:00

LICENSE

Change license from MIT to AGPL V3 (#1980 )

2023-07-26 01:06:21 +02:00

package.json

build: upgrade to node v20 (#3217 )

2024-04-21 13:40:44 +07:00

pnpm-lock.yaml

build: Fix timeout error (#3222 )

2024-04-23 11:48:39 +03:00

pnpm-workspace.yaml

Add fixtures (#2254 )

2023-09-06 21:43:29 +03:00

README.md

docs: Update README.md (#2924 )

2024-02-18 11:36:30 +01:00

vercel.json

build: Test staging (Playground) (#3136 )

2024-04-12 11:03:45 +03:00

README.md

Webstudio is an Open Source Visual Development Platform for developers, designers, and cross-functional teams. You own the data, components, and infrastructure. You can use the hosted version or roll out your own.

Learning Resources

Thanks

Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.

README.md

Learning Resources

Social Media

Thanks