webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 05:26:24 +09:00

T

Oleg Isonen 2fb558bfd3 fix: Prevent duplicate token when renaming (#3873 )

Fixes https://github.com/webstudio-is/webstudio/issues/3776

## Description

During renaming of the token

- when token name is less than 1 character - show error state
- when token name already exists - show error state

Fixed a bunch of bugs with esc, error handling and switching to editing
another token while still editing the first one



https://github.com/user-attachments/assets/5833e611-235b-4c2c-a3ed-3ee521ac5fd1



## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file

2024-08-07 00:02:40 +02:00

.devcontainer

chore: Add Docker-in-Docker Support for Utilities like Supabase CLI (#3785 )

2024-07-25 20:50:52 +03:00

.github

chore: Use workflow_run completed event for fixtures (#3888 )

2024-08-06 22:54:10 +03:00

.storybook

refactor: merge all storybooks into one (#3441 )

2024-05-29 17:05:17 +03:00

.vscode

build: Add devcontainer (#3429 )

2024-05-28 14:15:55 +03:00

@types

fix: support multiline graphql in curl (#3342 )

2024-05-11 21:32:32 +03:00

apps/builder

fix: Prevent duplicate token when renaming (#3873 )

2024-08-07 00:02:40 +02:00

codemod

chore: use console.info instead of console.log (#3049 )

2024-03-24 12:52:46 +01:00

fixtures

fix: automatically add json content-type to webhook forms (#3889 )

2024-08-06 23:19:18 +02:00

packages

fix: Prevent duplicate token when renaming (#3873 )

2024-08-07 00:02:40 +02:00

patches

fix: Image Manager. Ensure picture click and delete functionality work consistently (#3514 )

2024-06-07 13:48:55 +03:00

.gitignore

build: Add devcontainer (#3429 )

2024-05-28 14:15:55 +03:00

.nvmrc

chore: set node version to 20 in .nvmrc (#3423 )

2024-05-26 19:11:24 +03:00

.prettierignore

fix: Allow formatting d.ts files (#2558 )

2023-11-03 15:20:48 +02:00

CODE_OF_CONDUCT.md

Merge branch 'main' into feature-style-panel-flexChild-section

2022-11-12 11:36:44 +03:00

eslint.config.mjs

build: switch to eslint 9 (#3877 )

2024-08-05 09:23:57 +02:00

LICENSE

Change license from MIT to AGPL V3 (#1980 )

2023-07-26 01:06:21 +02:00

lostpixel.config.js

refactor: merge all storybooks into one (#3441 )

2024-05-29 17:05:17 +03:00

package.json

build: switch to eslint 9 (#3877 )

2024-08-05 09:23:57 +02:00

pnpm-lock.yaml

refactor: switch authorization-token to postgrest (#3878 )

2024-08-06 16:55:54 +02:00

pnpm-workspace.yaml

Add fixtures (#2254 )

2023-09-06 21:43:29 +03:00

README.md

docs: Update README.md (#2924 )

2024-02-18 11:36:30 +01:00

vercel.json

build: Test staging (Playground) (#3136 )

2024-04-12 11:03:45 +03:00

README.md

Webstudio is an Open Source Visual Development Platform for developers, designers, and cross-functional teams. You own the data, components, and infrastructure. You can use the hosted version or roll out your own.

Learning Resources

Thanks

Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.

README.md

Learning Resources

Social Media

Thanks