mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 14:03:33 +09:00
Ivan Starkov
369e101eb8
## Description closes #3940 Removed logic with undefined replacement on paste as it doesn't look stable. Seems like `undefined` variables must be decorated or replaced on blur. Anyway now it has linter <img width="534" alt="image" src="https://github.com/user-attachments/assets/43518bbc-798d-4332-a89f-238ecd6986c4"> <img width="509" alt="image" src="https://github.com/user-attachments/assets/279b7895-9371-49bd-b5c8-5ce5c391acce"> ## Steps for reproduction In any expression editor enter 1. `'aaa' + system` see system is decorated (blue) cursor is after the system <img width="193" alt="image" src="https://github.com/user-attachments/assets/f180f401-b5b0-41c5-a548-6ee432d278ca"> 2. `'aaa' system` see system is not decorated <img width="249" alt="image" src="https://github.com/user-attachments/assets/4056a601-9374-487f-a934-f2e1c06bbb96"> then add `+` after 'aaa' see system now decorated, cursor is after `+` ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.