mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-08 21:15:18 +09:00
Oleg Isonen
3885b86f89
## Description I moved the fix to trpc layer to affect other calls as well. Turned out the hook is called many times - as many as there are items in dashboard, so I think relying on state dependency even though it works for completely unknown reasons is better from perf standpoint (I think ... who knows ...) ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Webstudio Builder
Open Source alternative to Webflow Designer
Contributing
Don't hesitate to reach out if you have questions around contributing to the project.