mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-08 13:05:08 +09:00
525e6e384db03e69eb8d0979f31a772981d04776
Closes https://github.com/webstudio-is/webstudio-designer/issues/994 ## Description Variable fonts were treated like normal fonts, so we were only showing one default font weight as available. Now we not only detect variable fonts, but we also save all the meta data we get from them, so we can add a variable font settings UI in the future, which is a huge deal for designers, because variable fonts offer very interesting styling options and animations ## Steps for reproduction 1. select instance 2. font family, upload variable versions fonts like Monrope, Inter or Roboto Flex 3. see you can choose any font weight 4. use any styles on the font e.g. italic etc ## Code Review - [ ] hi @TrySound , I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-designer/blob/main/apps/designer/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `designer/env-check.js` if mandatory
Webstudio Designer
Webstudio Designer is a NoCode Visual Tool inspired by Webflow. It is the place where you can build your site or app visually.
Contributing
Don't hesitate to reach out of you have questions around contributing to the project.
Community
Languages
TypeScript
98.9%
PLpgSQL
0.5%
CSS
0.3%
Shell
0.2%
JavaScript
0.1%