mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 05:26:24 +09:00
Ivan StarkovandOleg Isonen
6e41286635
## Description This <img width="856" alt="image" src="https://github.com/webstudio-is/webstudio/assets/5077042/f8894380-0dbb-45c7-a1a5-410dbcb01fc8"> To this <img width="1049" alt="image" src="https://github.com/webstudio-is/webstudio/assets/5077042/bf618095-08be-4c6f-850f-56354e74e738"> ## Known issues: ### All - w-nav-link preset colors do not match ### Mobile Mobile burger is not shown - w-nav-button does not have breakpoint style i.e. display: none->block for mobile - w-nav-menu does not have breakpoint related style i.e display: block -> none for mobile - we don't have widget icons like burger i.e. `"data": { "widget": { "type": "icon", "icon": "nav-menu" } }` _having breakpoint issues and that user in any case need to use Sheet on mobile this is ok_ ## Steps for reproduction Copypaste Navbar from webflow 2 webstudio ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file --------- Co-authored-by: Oleg Isonen <oleg008@gmail.com>
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.