0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 05:26:24 +09:00

T

Ivan Starkov 74f87ccada Fix flex children sections are showing on wrong elements (#1078 )

## Description

1. What is this PR about (link the issue and add a short description)

Fix flex children sections are showing on wrong elements
closes #685
most used functions are imported from style-info and all has tests
there.




## Steps for reproduction

Create a few Boxes, and see that the Flex Child section is not shown.
Set `display: flex` for some Box. See that Flex Child section is not
shown on the element. See that Flex Child section is shown on block
children.


## Code Review

- [ ] hi @kof , @TrySound I want you to look namings, too much we have
with styles Style, StyleDecl, StyleInfo etc.
I used useInstanceStyleData instead of useInstanceStyle because we
already have similar useInstanceStyles

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

2023-02-20 14:26:44 +03:00