mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-10 22:44:24 +09:00
Oleg Isonen
918da3fb86
https://discord.com/channels/955905230107738152/1217108594735190066 ## Description Images should either have an alt text or be decorative. By adding an empty alt by default, they are becoming decorative by default which seems logical, because if you can't explain what's in the picture to assistive tools, then they should be ignoring that picture https://www.w3.org/WAI/tutorials/images/decorative/ ## Steps for reproduction 1. by default see alt is empty (<img alt> is the same as. <img alt="">) 2. when set by the user its applied ## Code Review - [ ] hi @TrySound , I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.