mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 14:03:33 +09:00
98cb2ef576583881995d87c0e179ef02a811865d
Ref https://github.com/webstudio-is/webstudio/issues/3914 Closes https://github.com/webstudio-is/webstudio/issues/3800 ## Description This allows to see borders/outlines when changing ephimeral styles e.g. scrubbing border-outline width or color This is not 100% fixing the problem, as you still can't see the border/outline when you change non ephimeral value, but there is not much we can actually do, because outline has to be blue for clarity, making it look like the user color, would be potentially very confusing. ## Steps for reproduction 1. change any ephimeral styles like padding drag/drop or scrub any input 2. see outline is hidden during that change ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.
Languages
TypeScript
98.9%
PLpgSQL
0.5%
CSS
0.3%
Shell
0.2%
JavaScript
0.1%
