webstudio

0 Fork 0

mirror of https://github.com/webstudio-is/webstudio.git synced 2026-11-09 05:26:24 +09:00

T

Ivan Starkov 9d6773f382 fix: Incorrect style calculations (#3929 )

## Description

Closes #3807

Test cases are here 
-
[Failing](https://main.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
-
[Fixed](https://fix-styles.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)

They are fail on main and works in current PR

### Fixed

- [x] - Body display inline
- [x] - Switching between elements rendered styles for some period
incorrect
- [x] - Selecting display none in menu didn't work
- [x] - Html/Browser styles of invisible elements i.e. `display: none`
wasn't picked
- [x] - Unit sizes of invisible elements  wasn't picked

### New

Components with `display: contents` and only text nodes inside now have
outline (using range to get rect)
<img width="643" alt="image"
src="https://github.com/user-attachments/assets/4ee0eff2-66b5-405a-a88a-41191878bbbb">


## Steps for reproduction

-
[Failing](https://main.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
-
[Fixed](https://fix-styles.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file

2024-08-13 18:24:57 +03:00

.devcontainer

chore: Add Docker-in-Docker Support for Utilities like Supabase CLI (#3785 )

2024-07-25 20:50:52 +03:00

.github

chore: Load fixtures by build id, use current deplyment for sync (#3890 )

2024-08-07 01:29:05 +03:00

.storybook

build: upgrade storybook (#3915 )

2024-08-10 15:00:43 +02:00

.vscode

build: Add devcontainer (#3429 )

2024-05-28 14:15:55 +03:00

@types

fix: support multiline graphql in curl (#3342 )

2024-05-11 21:32:32 +03:00

apps/builder

fix: Incorrect style calculations (#3929 )

2024-08-13 18:24:57 +03:00

codemod

chore: use console.info instead of console.log (#3049 )

2024-03-24 12:52:46 +01:00

fixtures

experimental: Allow json in template literals (#3886 )

2024-08-11 11:50:18 +03:00

packages

feat: add shift/option modifiers to spacing and position input popovers (#3924 )

2024-08-12 22:23:06 +02:00

patches

fix: Image Manager. Ensure picture click and delete functionality work consistently (#3514 )

2024-06-07 13:48:55 +03:00

.gitignore

build: Add devcontainer (#3429 )

2024-05-28 14:15:55 +03:00

.nvmrc

chore: set node version to 20 in .nvmrc (#3423 )

2024-05-26 19:11:24 +03:00

.prettierignore

fix: Allow formatting d.ts files (#2558 )

2023-11-03 15:20:48 +02:00

CODE_OF_CONDUCT.md

Merge branch 'main' into feature-style-panel-flexChild-section

2022-11-12 11:36:44 +03:00

eslint.config.mjs

build: switch to eslint 9 (#3877 )

2024-08-05 09:23:57 +02:00

LICENSE

Change license from MIT to AGPL V3 (#1980 )

2023-07-26 01:06:21 +02:00

lostpixel.config.js

refactor: merge all storybooks into one (#3441 )

2024-05-29 17:05:17 +03:00

package.json

build: upgrade storybook (#3915 )

2024-08-10 15:00:43 +02:00

pnpm-lock.yaml

build: upgrade storybook (#3915 )

2024-08-10 15:00:43 +02:00

pnpm-workspace.yaml

Add fixtures (#2254 )

2023-09-06 21:43:29 +03:00

README.md

docs: Update README.md (#2924 )

2024-02-18 11:36:30 +01:00

vercel.json

build: Test staging (Playground) (#3136 )

2024-04-12 11:03:45 +03:00

README.md

Webstudio is an Open Source Visual Development Platform for developers, designers, and cross-functional teams. You own the data, components, and infrastructure. You can use the hosted version or roll out your own.

Learning Resources

Thanks

Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.

README.md

Learning Resources

Social Media

Thanks