mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-06 20:13:35 +09:00
b3b1792eaed83fca435d97c56af7701b9fa48fa3
## Description When on canvas inside builder we need to always eager load images to avoid this bug in latest chrome with cache turned off ## Steps for reproduction 1. turn off cache 2. add image component on canvas 3. see it renders as expected (loading lazy in settings is default, but on canvas it renders as loading eager) ## Code Review - [ ] hi @istarkov , I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory
Learning Resources
Social Media
Contributing
- Contributing Guide
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
- Design Assets and Docs
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.
Languages
TypeScript
98.9%
PLpgSQL
0.5%
CSS
0.3%
Shell
0.2%
JavaScript
0.1%
