mirror of
https://github.com/webstudio-is/webstudio.git
synced 2026-11-09 14:03:33 +09:00
Jaya Krishna Namburu
c1c43213c3
## Description fixes - when choosing an image after having a url, url is normally being reset, so you don't have both, now I managed to have both - Code area label should be Code Regarding the - jump when switching between image and gradient. This is a little tricky, to restrict from jumping. Thought about this while implementing itself. But there is too much negative spacing for gradients tab. We need to set `min-height`. Which is showing too much empty spacing for background gradients in my opinion. Let me know, if it's still fine and we can go ahead.  - shouldn't all properties land in the Code area? not just the url()? This, i am not sure if its possible. Because, in every code-editing areas. We are showing only the property value and not the key. In this case, of we want to show multiple properties. Then we need to show multiple key-value pairs. Like, `background-image: url, background-cli: border-box` etc. With some additional parsing of these values. ## Steps for reproduction 1. Set a remote url for a background image, now use a uploaded image for the same. The input-box need to be refreshed. ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [x] made a self-review ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6)
Learning Resources
- Blog
- Documentation
- Brand and Product Design
- Contributing Guide for Devs
- Github Discussions
- Wishlist
- Builder Issues Tracker
- Roadmap
Social Media
Thanks
Thanks to Lost Pixel for providing the visual testing platform that helps us review UI changes and catch visual regressions.